[jira] Commented: (VELOCITY-715) Leaked object in FileResourceLoader#templatePaths

2009-11-03 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12773349#action_12773349 ] Byron Foster commented on VELOCITY-715: --- The WeakHashMap will correctly drop the

[jira] Commented: (VELOCITY-739) Do not throw exception for quiet references in strict reference checking mode

2009-10-30 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12772172#action_12772172 ] Byron Foster commented on VELOCITY-739: --- My preference would be the current

[jira] Commented: (VELOCITY-731) Velocity 1.6 performance is degraded by introduced toString() calls

2009-08-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12745446#action_12745446 ] Byron Foster commented on VELOCITY-731: --- There was a discussion about this in

[jira] Commented: (VELOCITY-718) multi-thread merge causes 100% cpu

2009-05-24 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12712548#action_12712548 ] Byron Foster commented on VELOCITY-718: --- I tried to reproduce, but didn't have any

[jira] Commented: (VELOCITY-659) Remove throwing Exception from method signatures

2009-05-13 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12709126#action_12709126 ] Byron Foster commented on VELOCITY-659: --- I wonder why Gump has only recently

[jira] Commented: (VELOCITY-697) Add macro default parameters

2009-03-12 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681451#action_12681451 ] Byron Foster commented on VELOCITY-697: --- Sounds good, I was leaving it open for any

[jira] Closed: (VELOCITY-695) Add comments for directive parameters

2009-03-12 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-695. - Resolution: Fixed Better huu? :) Ok, looks like this is going in, so I'll close it. Change

[jira] Commented: (VELOCITY-698) If #stop is specified as #stop(template) then parsing only stops current template rendering

2009-03-12 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681456#action_12681456 ] Byron Foster commented on VELOCITY-698: --- yea, no need for this anymore. If #stop

[jira] Closed: (VELOCITY-711) Add a #scope directive for modifying scope behavior

2009-03-06 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-711. - Resolution: Invalid Add a #scope directive for modifying scope behavior

[jira] Commented: (VELOCITY-711) Add a #scope directive for modifying scope behavior

2009-03-06 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679813#action_12679813 ] Byron Foster commented on VELOCITY-711: --- I've played with dynamic scoping over

[jira] Commented: (VELOCITY-711) Add a #scope directive for modifying scope behavior

2009-03-05 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679491#action_12679491 ] Byron Foster commented on VELOCITY-711: --- Hmm, true, I was thinking the scoping

[jira] Created: (VELOCITY-709) String literal \\ parses incorrectly

2009-03-04 Thread Byron Foster (JIRA)
String literal \\ parses incorrectly -- Key: VELOCITY-709 URL: https://issues.apache.org/jira/browse/VELOCITY-709 Project: Velocity Issue Type: Bug Components: Engine Affects Versions: 1.7

[jira] Created: (VELOCITY-710) property velocimacro.library.autoreload = on does not affect new macro definitions

2009-03-04 Thread Byron Foster (JIRA)
property velocimacro.library.autoreload = on does not affect new macro definitions -- Key: VELOCITY-710 URL: https://issues.apache.org/jira/browse/VELOCITY-710 Project:

[jira] Created: (VELOCITY-711) Add a #scope directive for modifying scope behavior

2009-03-04 Thread Byron Foster (JIRA)
Add a #scope directive for modifying scope behavior --- Key: VELOCITY-711 URL: https://issues.apache.org/jira/browse/VELOCITY-711 Project: Velocity Issue Type: New Feature

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-03-04 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679027#action_12679027 ] Byron Foster commented on VELOCITY-704: --- I like your proposal Nathan, and I like

[jira] Commented: (VELOCITY-705) Dynamic VTL reference modification directive

2009-03-01 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677902#action_12677902 ] Byron Foster commented on VELOCITY-705: --- Yea, the writeReference method was really

[jira] Commented: (VELTOOLS-115) Improve exception and HTTP error management

2009-03-01 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677908#action_12677908 ] Byron Foster commented on VELTOOLS-115: --- Looking at this some more. I don't like

[jira] Commented: (VELTOOLS-115) Improve exception and HTTP error management

2009-02-28 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677738#action_12677738 ] Byron Foster commented on VELTOOLS-115: --- Thanks for the links. If you don't catch

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-02-28 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677789#action_12677789 ] Byron Foster commented on VELOCITY-704: --- You know I think these discussions get

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-02-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677534#action_12677534 ] Byron Foster commented on VELOCITY-704: --- I think having an independent $evaluate

[jira] Commented: (VELTOOLS-115) Improve exception and HTTP error management

2009-02-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677541#action_12677541 ] Byron Foster commented on VELTOOLS-115: --- It seems like the default behavior should

[jira] Commented: (VELOCITY-705) Dynamic VTL reference modification directive

2009-02-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677552#action_12677552 ] Byron Foster commented on VELOCITY-705: --- There is the notion of the Context event

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-02-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676092#action_12676092 ] Byron Foster commented on VELOCITY-704: --- On the pro side I think the approach of

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-02-21 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675587#action_12675587 ] Byron Foster commented on VELOCITY-704: --- I'll try it out. What about $global ?

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-02-19 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675184#action_12675184 ] Byron Foster commented on VELOCITY-680: --- How about the suggestion that Claude made,

[jira] Commented: (VELOCITY-704) VTL Simplicity - Control objects

2009-02-19 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675195#action_12675195 ] Byron Foster commented on VELOCITY-704: --- This is more then what I was thinking of

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-02-19 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675200#action_12675200 ] Byron Foster commented on VELOCITY-680: --- That's cool, I can go with:

[jira] Commented: (VELOCITY-695) Add comments for directive parameters

2009-02-19 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675204#action_12675204 ] Byron Foster commented on VELOCITY-695: --- Fair enough, does the balance change any

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-02-18 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674771#action_12674771 ] Byron Foster commented on VELOCITY-680: --- Yea, I've leaned away from the independent

[jira] Commented: (VELOCITY-703) VTL Simplicity - collapse #break, #stop and #return

2009-02-18 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674796#action_12674796 ] Byron Foster commented on VELOCITY-703: --- But I don't want to be free, I like

[jira] Commented: (VELOCITY-696) Add index parameter to #foreach directive to define an index variable

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674256#action_12674256 ] Byron Foster commented on VELOCITY-696: --- When the 'index' keyword is specified the

[jira] Commented: (VELOCITY-698) If #stop is specified as #stop(template) then parsing only stops current template rendering

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674412#action_12674412 ] Byron Foster commented on VELOCITY-698: --- I actually implemented this as

[jira] Commented: (VELOCITY-699) Add a #return directive for returning from a macro

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674433#action_12674433 ] Byron Foster commented on VELOCITY-699: --- Hmm, I didn't expect resistance on this

[jira] Resolved: (VELOCITY-696) Add index parameter to #foreach directive to define an index variable

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-696. --- Resolution: Fixed I've moved this functionality into a custom directive called #for which

[jira] Commented: (VELOCITY-699) Add a #return directive for returning from a macro

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674464#action_12674464 ] Byron Foster commented on VELOCITY-699: --- Ok, this is an optional directive now

[jira] Closed: (VELOCITY-699) Add a #return directive for returning from a macro

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-699. - Resolution: Won't Fix Fix Version/s: 2.0 Add a #return directive for returning from a

[jira] Closed: (VELOCITY-690) Do not require block directive to have parenthesis

2009-02-17 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-690. - Resolution: Fixed Do not require block directive to have parenthesis

[jira] Created: (VELOCITY-697) Add macro default parameters

2009-02-16 Thread Byron Foster (JIRA)
Add macro default parameters Key: VELOCITY-697 URL: https://issues.apache.org/jira/browse/VELOCITY-697 Project: Velocity Issue Type: New Feature Components: Engine Affects Versions: 2.0

[jira] Commented: (VELOCITY-695) Add comments for directive parameters

2009-02-16 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674072#action_12674072 ] Byron Foster commented on VELOCITY-695: --- You seem to be saying that you don't like

[jira] Created: (VELOCITY-698) If #stop is specified as #stop(template) then parsing only stops current template rendering

2009-02-16 Thread Byron Foster (JIRA)
If #stop is specified as #stop(template) then parsing only stops current template rendering --- Key: VELOCITY-698 URL: https://issues.apache.org/jira/browse/VELOCITY-698

[jira] Created: (VELOCITY-695) Add comments for directive parameters

2009-02-15 Thread Byron Foster (JIRA)
Add comments for directive parameters - Key: VELOCITY-695 URL: https://issues.apache.org/jira/browse/VELOCITY-695 Project: Velocity Issue Type: New Feature Components: Engine Affects

[jira] Created: (VELOCITY-696) Add index parameter to #foreach directive to define an index variable

2009-02-15 Thread Byron Foster (JIRA)
Add index parameter to #foreach directive to define an index variable - Key: VELOCITY-696 URL: https://issues.apache.org/jira/browse/VELOCITY-696 Project: Velocity Issue

[jira] Commented: (VELOCITY-692) have #if handle empty strings/arrays/collections/maps more conveniently

2009-02-14 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12673502#action_12673502 ] Byron Foster commented on VELOCITY-692: --- To clarify my original comment, yes, I

[jira] Created: (VELOCITY-691) Change context event handling for better efficiency.

2009-02-10 Thread Byron Foster (JIRA)
Change context event handling for better efficiency. Key: VELOCITY-691 URL: https://issues.apache.org/jira/browse/VELOCITY-691 Project: Velocity Issue Type: Improvement

[jira] Closed: (VELOCITY-691) Change context event handling for better efficiency.

2009-02-10 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-691. - Resolution: Won't Fix Hmm, looking at this more, There is more change I'd like to do, then I'm

[jira] Commented: (VELOCITY-688) ! preceding a reference in strict mode ignores a null exception

2009-02-10 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672312#action_12672312 ] Byron Foster commented on VELOCITY-688: --- Well, I figure rendering $foo as a blank

[jira] Commented: (VELOCITY-688) ! preceding a reference in strict mode ignores a null exception

2009-02-10 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672515#action_12672515 ] Byron Foster commented on VELOCITY-688: --- Nathan, the answer to your question is yes

[jira] Commented: (VELOCITY-692) have #if handle empty strings/arrays/collections/maps more conveniently

2009-02-10 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672521#action_12672521 ] Byron Foster commented on VELOCITY-692: --- This is probably a good opportunity to

[jira] Commented: (VELOCITY-688) ! preceding a reference in strict mode ignores a null exception

2009-02-09 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672158#action_12672158 ] Byron Foster commented on VELOCITY-688: --- Changed the orientation of this feature so

[jira] Created: (VELOCITY-690) Do not require block directive to have parenthesis

2009-02-08 Thread Byron Foster (JIRA)
Do not require block directive to have parenthesis -- Key: VELOCITY-690 URL: https://issues.apache.org/jira/browse/VELOCITY-690 Project: Velocity Issue Type: Improvement Components:

[jira] Commented: (VELOCITY-690) Do not require block directive to have parenthesis

2009-02-08 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671576#action_12671576 ] Byron Foster commented on VELOCITY-690: --- This change also allows block macros to

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-02-07 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671455#action_12671455 ] Byron Foster commented on VELOCITY-680: --- I've added Nathan's suggestion of making

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-02-05 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671002#action_12671002 ] Byron Foster commented on VELOCITY-680: --- I've added both the #global and #local

[jira] Commented: (VELOCITY-681) [regression] Changes on the macro parameters are not persisted outside the macro call

2009-02-03 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670087#action_12670087 ] Byron Foster commented on VELOCITY-681: --- I looked at this some more, and my vote is

[jira] Commented: (VELOCITY-687) Macro pass by value option

2009-01-30 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12669004#action_12669004 ] Byron Foster commented on VELOCITY-687: --- Ok, I would argue the viability of

[jira] Updated: (VELOCITY-687) Macro pass by value option

2009-01-30 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster updated VELOCITY-687: -- Affects Version/s: (was: 1.7) 2.0 Macro pass by value option

[jira] Created: (VELOCITY-688) ! preceding a reference in strict mode ignores a null exception

2009-01-30 Thread Byron Foster (JIRA)
! preceding a reference in strict mode ignores a null exception --- Key: VELOCITY-688 URL: https://issues.apache.org/jira/browse/VELOCITY-688 Project: Velocity Issue Type:

[jira] Resolved: (VELOCITY-688) ! preceding a reference in strict mode ignores a null exception

2009-01-30 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-688. --- Resolution: Fixed ! preceding a reference in strict mode ignores a null exception

[jira] Commented: (VELOCITY-681) [regression] Changes on the macro parameters are not persisted outside the macro call

2009-01-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667727#action_12667727 ] Byron Foster commented on VELOCITY-681: --- I applied this patch locally to 1.6.x and

[jira] Resolved: (VELOCITY-669) Concurrency bug introduced in 1.7-dev

2009-01-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-669. --- Resolution: Fixed Concurrency bug introduced in 1.7-dev

[jira] Updated: (VELOCITY-687) Macro pass by value option

2009-01-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster updated VELOCITY-687: -- Attachment: value.patch Macro pass by value option --

[jira] Commented: (VELOCITY-687) Macro pass by value option

2009-01-27 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667773#action_12667773 ] Byron Foster commented on VELOCITY-687: --- qoute it will add complexity to internal

[jira] Commented: (VELOCITY-669) Concurrency bug introduced in 1.7-dev

2009-01-26 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667294#action_12667294 ] Byron Foster commented on VELOCITY-669: --- Unless there is further input I'm going to

[jira] Created: (VELOCITY-687) Macro pass by value option

2009-01-26 Thread Byron Foster (JIRA)
Macro pass by value option -- Key: VELOCITY-687 URL: https://issues.apache.org/jira/browse/VELOCITY-687 Project: Velocity Issue Type: New Feature Components: Engine Affects Versions: 1.7

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-01-24 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666873#action_12666873 ] Byron Foster commented on VELOCITY-680: --- qoute Yes, that would throw an exception,

[jira] Commented: (VELOCITY-685) BlockMacros fail with strict number of macro arguments

2009-01-24 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666877#action_12666877 ] Byron Foster commented on VELOCITY-685: --- Thanks for getting these fixed quickly

[jira] Created: (VELOCITY-686) BlockMacro renders $bodyContent on #set

2009-01-24 Thread Byron Foster (JIRA)
BlockMacro renders $bodyContent on #set --- Key: VELOCITY-686 URL: https://issues.apache.org/jira/browse/VELOCITY-686 Project: Velocity Issue Type: Bug Components: Engine Reporter:

[jira] Resolved: (VELOCITY-673) Remove calling init method from the VelocityEngine non default constructors

2009-01-24 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-673. --- Resolution: Fixed This also fixes an initialization race condition when using the default

[jira] Commented: (VELOCITY-686) BlockMacro renders $bodyContent on #set

2009-01-24 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666972#action_12666972 ] Byron Foster commented on VELOCITY-686: --- Looking at the Define directive

[jira] Commented: (VELOCITY-682) #evaluate breaks macro processing

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666474#action_12666474 ] Byron Foster commented on VELOCITY-682: --- This is confirmed: the following simpler

[jira] Issue Comment Edited: (VELOCITY-682) #evaluate breaks macro processing

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666474#action_12666474 ] byronvf edited comment on VELOCITY-682 at 1/23/09 3:04 AM:

[jira] Resolved: (VELOCITY-454) clean up escaping to always escape \$ and \#

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-454. --- Resolution: Fixed I'm going to close this based on resolving VELOCITY-623. clean up

[jira] Closed: (VELOCITY-672) add '#for' as a synonym for '#foreach'

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-672. - Resolution: Won't Fix There doesn't seem to be much interest in this, closing... add

[jira] Commented: (VELOCITY-681) [regression] Changes on the macro parameters are not persisted outside the macro call

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666533#action_12666533 ] Byron Foster commented on VELOCITY-681: --- Sergiu is correct in that this is a pretty

[jira] Commented: (VELOCITY-684) Passing a map literal to a macro call forbids altering the map in any way, while maps bound to an actual parameter may be changed

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666547#action_12666547 ] Byron Foster commented on VELOCITY-684: --- This is correct pass by name behavior,

[jira] Created: (VELOCITY-685) BlockMacros fail with strict number of macro arguments

2009-01-23 Thread Byron Foster (JIRA)
BlockMacros fail with strict number of macro arguments -- Key: VELOCITY-685 URL: https://issues.apache.org/jira/browse/VELOCITY-685 Project: Velocity Issue Type: Bug Components:

[jira] Commented: (VELOCITY-684) Passing a map literal to a macro call forbids altering the map in any way, while maps bound to an actual parameter may be changed

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666596#action_12666596 ] Byron Foster commented on VELOCITY-684: --- I don't mean to sound technically rigid,

[jira] Commented: (VELOCITY-682) #evaluate breaks macro processing

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1204#action_1204 ] Byron Foster commented on VELOCITY-682: --- I've checked in a test case for this

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-01-23 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1225#action_1225 ] Byron Foster commented on VELOCITY-680: --- quote Defining that macro would make

[jira] Created: (VELOCITY-675) #@foo causes an NPE

2009-01-22 Thread Byron Foster (JIRA)
#...@foo causes an NPE --- Key: VELOCITY-675 URL: https://issues.apache.org/jira/browse/VELOCITY-675 Project: Velocity Issue Type: Bug Components: Engine Affects Versions: 1.7 Reporter: Byron Foster

[jira] Created: (VELOCITY-676) #[[##x]]# causes StringIndexOutOfBoundsException

2009-01-22 Thread Byron Foster (JIRA)
#[[##x]]# causes StringIndexOutOfBoundsException Key: VELOCITY-676 URL: https://issues.apache.org/jira/browse/VELOCITY-676 Project: Velocity Issue Type: Bug Components: Engine

[jira] Created: (VELOCITY-677) a '#' or '$' character at the end of VTL causes a ParseException

2009-01-22 Thread Byron Foster (JIRA)
a '#' or '$' character at the end of VTL causes a ParseException Key: VELOCITY-677 URL: https://issues.apache.org/jira/browse/VELOCITY-677 Project: Velocity Issue Type: Bug

[jira] Updated: (VELOCITY-677) a '#' or '$' character at the end of VTL causes a ParseException

2009-01-22 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster updated VELOCITY-677: -- Affects Version/s: 1.7 a '#' or '$' character at the end of VTL causes a ParseException

[jira] Created: (VELOCITY-679) Escaping #set(foo=bar)\\$$foo broken

2009-01-22 Thread Byron Foster (JIRA)
Escaping #set(foo=bar)\\$$foo broken -- Key: VELOCITY-679 URL: https://issues.apache.org/jira/browse/VELOCITY-679 Project: Velocity Issue Type: Bug Components: Engine Affects Versions:

[jira] Commented: (VELOCITY-677) a '#' or '$' character at the end of VTL causes a ParseException

2009-01-22 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666431#action_12666431 ] Byron Foster commented on VELOCITY-677: --- Agreed, I'm not motivated to dig into this

[jira] Updated: (VELOCITY-677) a '#' or '$' character at the end of VTL causes a ParseException

2009-01-22 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster updated VELOCITY-677: -- Description: If either the character '#' or '$' is the last character in VTL, then the

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-01-22 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666434#action_12666434 ] Byron Foster commented on VELOCITY-680: --- What are some thoughts on making this

[jira] Commented: (VELOCITY-680) RFC: New #local directive that behaves like #set but puts things into local context in macro rendering

2009-01-22 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12666437#action_12666437 ] Byron Foster commented on VELOCITY-680: --- Nathan, In strict mode #macro( foo

[jira] Resolved: (VELOCITY-670) Macro escaping inconsistent with forward references

2009-01-21 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-670. --- Resolution: Duplicate I'm going to make this a duplicate of VELOCITY-454 Macro escaping

[jira] Closed: (VELOCITY-671) Undefined macro in block form causes NPE

2009-01-21 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster closed VELOCITY-671. - Resolution: Fixed Verified, thanks Undefined macro in block form causes NPE

[jira] Commented: (VELOCITY-667) Regression: Specifying bad grammar no longer throws VelocityException

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12665363#action_12665363 ] Byron Foster commented on VELOCITY-667: --- I am able to reproduce the problem, I'm

[jira] Created: (VELOCITY-670) Macro escaping inconsistent with forward references

2009-01-20 Thread Byron Foster (JIRA)
Macro escaping inconsistent with forward references --- Key: VELOCITY-670 URL: https://issues.apache.org/jira/browse/VELOCITY-670 Project: Velocity Issue Type: Bug Components: Engine

[jira] Commented: (VELOCITY-669) Concurrency bug introduced in 1.7-dev

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12665431#action_12665431 ] Byron Foster commented on VELOCITY-669: --- This should work now, give it a shot. The

[jira] Updated: (VELOCITY-667) Regression: Specifying bad grammar no longer throws VelocityException

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster updated VELOCITY-667: -- Comment: was deleted Regression: Specifying bad grammar no longer throws VelocityException

[jira] Created: (VELOCITY-671) Undefined macro in block form causes NPE

2009-01-20 Thread Byron Foster (JIRA)
Undefined macro in block form causes NPE Key: VELOCITY-671 URL: https://issues.apache.org/jira/browse/VELOCITY-671 Project: Velocity Issue Type: Bug Components: Engine Affects Versions:

[jira] Created: (VELOCITY-672) add '#for' as a synonym for '#foreach'

2009-01-20 Thread Byron Foster (JIRA)
add '#for' as a synonym for '#foreach' -- Key: VELOCITY-672 URL: https://issues.apache.org/jira/browse/VELOCITY-672 Project: Velocity Issue Type: Improvement Components: Engine

[jira] Commented: (VELOCITY-669) Concurrency bug introduced in 1.7-dev

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12665565#action_12665565 ] Byron Foster commented on VELOCITY-669: --- qoute For instance in Parser.jjt you

[jira] Resolved: (VELOCITY-667) Regression: Specifying #macro without parenthesis no longer throws VelocityException

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Byron Foster resolved VELOCITY-667. --- Resolution: Fixed Looks like this will fly, changes have been merged over for inclusion

[jira] Created: (VELOCITY-673) Remove calling init method from the VelocityEngine non default constructors

2009-01-20 Thread Byron Foster (JIRA)
Remove calling init method from the VelocityEngine non default constructors --- Key: VELOCITY-673 URL: https://issues.apache.org/jira/browse/VELOCITY-673 Project: Velocity

[jira] Commented: (VELOCITY-671) Undefined macro in block form causes NPE

2009-01-20 Thread Byron Foster (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12665704#action_12665704 ] Byron Foster commented on VELOCITY-671: --- It seems to be a problem with BlockMacros

  1   2   3   >