Re: git commit: WICKET-4859 change component id counter to long, similar to RepeatingView

2012-11-08 Thread Igor Vaynberg
its not for convenience. without this autogenerated id the user would have to specify it and make sure it is unique across all toolbars in the datatable. when the datatable is created/configured via several methods this can be a headache. also, the ids do not matter because they are used in the rep

Re: [Vote] Release Apache Wicket 1.5.9

2012-11-08 Thread Igor Vaynberg
+1 -igor On Tue, Nov 6, 2012 at 1:34 AM, Martin Grigorov wrote: > This vote is to release Apache Wicket 1.5.9 > > Git repo > http://git-wip-us.apache.org/repos/asf/wicket.git > > Branch name > build/wicket-1.5.9 > > Archived and signed Git repo > http://people.apache.org/~mgrigorov/wicket-1.5.9

wicket pull request: Implementation for WICKET-4861.

2012-11-08 Thread costescuandrei
GitHub user costescuandrei opened a pull request: https://github.com/apache/wicket/pull/20 Implementation for WICKET-4861. Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it

wicket pull request: Implementation for WICKET-4861.

2012-11-08 Thread costescuandrei
GitHub user costescuandrei opened a pull request: https://github.com/apache/wicket/pull/20 Implementation for WICKET-4861. Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it

Re: git commit: WICKET-4859 change component id counter to long, similar to RepeatingView

2012-11-08 Thread Sven Meier
>Statics make me cringe Me too. I'm not sure about the need of an AtomicLong. I've just took the easy route and changed it to how RepeatingView works. > why does the counter have to be globally unique? See my last comment on the issue: It's just that toolbars have an auto generated id (for

Re: git commit: WICKET-4859 change component id counter to long, similar to RepeatingView

2012-11-08 Thread Martijn Dashorst
On Thu, Nov 8, 2012 at 11:24 AM, Martijn Dashorst wrote: > On Thu, Nov 8, 2012 at 10:02 AM, wrote: >> - private static int counter = 0; >> + /** Counter used for generating unique component ids. */ >> + private static long counter = 0; > > Should this be an AtomicLong instead?

Re: git commit: WICKET-4859 change component id counter to long, similar to RepeatingView

2012-11-08 Thread Martijn Dashorst
On Thu, Nov 8, 2012 at 10:02 AM, wrote: > - private static int counter = 0; > + /** Counter used for generating unique component ids. */ > + private static long counter = 0; Should this be an AtomicLong instead? Statics make me cringe in a multithreaded environment. Martijn