Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Tobias Soloschenko
Hi, well - a lot of manual steps to know before building wicket then. (Assuming Eclipse / JDK 8): 1. Install marketplace plugin for maven-eclipse-settings 2. Configure toolschain 3. Disable clirr plugin 4. Configure save actions, ... We have to update the contribution docs. kind regards Tobia

Re: wicket git commit: PackageResource#getResourceStream() removed and replaced by PackageResource#getCacheableResourceStream()

2015-06-09 Thread Tobias Soloschenko
Thanks from me, too! kind regards Tobias > Am 10.06.2015 um 08:21 schrieb Martin Grigorov : > > Hi Andrea, > >> On Tue, Jun 9, 2015 at 7:39 PM, wrote: >> >> Repository: wicket >> Updated Branches: >> refs/heads/WICKET-5906-7.x 5b30073a8 -> d64655987 >> >> >> PackageResource#getResourceStr

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Martin Grigorov
Hi, On Tue, Jun 9, 2015 at 6:32 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Ah I see - that's right. > > +1 for toolschain - but we need to ensure that the build keeps running on > jdk > 6 for wicket-6.x (unit tests, etc.) and that toolschain does not > abort the build nor

Re: wicket git commit: PackageResource#getResourceStream() removed and replaced by PackageResource#getCacheableResourceStream()

2015-06-09 Thread Martin Grigorov
Hi Andrea, On Tue, Jun 9, 2015 at 7:39 PM, wrote: > Repository: wicket > Updated Branches: > refs/heads/WICKET-5906-7.x 5b30073a8 -> d64655987 > > > PackageResource#getResourceStream() removed and replaced by > PackageResource#getCacheableResourceStream() > > > Project: http://git-wip-us.apach

Re: [VOTE] Release Apache Wicket 6.20.0

2015-06-09 Thread Maxim Solodovnik
+1 Tested with Apache Openmeetings On Tue, Jun 9, 2015 at 10:40 PM, Sebastien wrote: > [x] Yes, release Apache Wicket 6.20.0 > Tested over Wicket jQuery UI > > Thanks Martijn! > > On Tue, Jun 9, 2015 at 5:50 PM, Tobias Soloschenko < > tobiassolosche...@googlemail.com> wrote: > > > +10 ;-) > > >

Re: [VOTE] Release Apache Wicket 6.20.0

2015-06-09 Thread Sebastien
[x] Yes, release Apache Wicket 6.20.0 Tested over Wicket jQuery UI Thanks Martijn! On Tue, Jun 9, 2015 at 5:50 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > +10 ;-) > > kind regards > > Tobias > > > Am 09.06.2015 um 17:43 schrieb Martijn Dashorst < > martijn.dasho...@gmail.

Re: [VOTE] Release Apache Wicket 6.20.0

2015-06-09 Thread Tobias Soloschenko
+10 ;-) kind regards Tobias > Am 09.06.2015 um 17:43 schrieb Martijn Dashorst : > > This is a vote to release Apache Wicket 6.20.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote

[VOTE] Release Apache Wicket 6.20.0

2015-06-09 Thread Martijn Dashorst
This is a vote to release Apache Wicket 6.20.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 6.20.0 [ ] No, don't release Apache Wi

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Tobias Soloschenko
Ah I see - that's right. +1 for toolschain - but we need to ensure that the build keeps running on jdk > 6 for wicket-6.x (unit tests, etc.) and that toolschain does not abort the build nor requires jdk 6 I personally don't want to install several jdks :-/ to apply and test changes on wicket-

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Martijn Dashorst
> P.S.: I think most Wicket 6 users are already using jdk > 7. We can't set a new minimum JDK version for a minor release bump--it would violate the semver promise of our 6.x/7.x releases. Martijn

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Martijn Dashorst
No. String#isEmpty() for example is JDK 7 only. There are subtle API differences in the JDK between 6 and 7 (and 8) that warrant extreme caution trying to use a JDK N+1 for a JDK N compatible product. If this avenue fails, we can opt to use the animalsniffer plugin to detect wrong API usage, but t

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Tobias Soloschenko
Saw that it is already set - isn't this enought - is it? kind regards Tobias > Am 09.06.2015 um 15:24 schrieb Martijn Dashorst : > > All, > > I'm currently trying to build a release with Maven but ran into a snag > that Maven 3.3 doesn't support running on java 6 anymore. However I > like to e

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Tobias Soloschenko
What about to set the compile / source level to jdk 6? http://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html As long as we don't use jdbc or other integrations it should be fine. It's only a suggestion. kind regards Tobias P.S.: I think most Wicke

Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Martijn Dashorst
All, I'm currently trying to build a release with Maven but ran into a snag that Maven 3.3 doesn't support running on java 6 anymore. However I like to ensure our wicket 6.x releases are built with an actual Java 6 release, so I am in the process of using toolchains [1] for the release building.

Re: Releasing Wicket 6 & 7 using toolchains

2015-06-09 Thread Martijn Dashorst
[1] https://maven.apache.org/guides/mini/guide-using-toolchains.html On Tue, Jun 9, 2015 at 3:24 PM, Martijn Dashorst wrote: > All, > > I'm currently trying to build a release with Maven but ran into a snag > that Maven 3.3 doesn't support running on java 6 anymore. However I > like to ensure our