[GitHub] [wicket] andruhon commented on issue #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
andruhon commented on issue #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#issuecomment-511157387 Thanks @martin-g ! There's another PR for the same issue https://github.com/apache/wicket/pull/376 . Sven recommended to try different

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218028 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/AbstractNonceStrategy.java

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217930 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/INonceStrategy.java ## @@

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218087 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/CspUtils.java ## @@

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218202 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/nonce/PerSessionNonceStrategy.java

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303218212 ## File path: wicket-core/src/main/java/org/apache/wicket/settings/SecuritySettings.java ## @@

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217903 ## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ##

[GitHub] [wicket] martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
martin-g commented on a change in pull request #374: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/374#discussion_r303217943 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/INonceStrategy.java ## @@

Re: FYI

2019-07-13 Thread Martin Grigorov
Hi, I've committed a change to Wicket's Buildbot config that adds JAVA_HOME for the Java 11, 13 and 14 builds. Hopefully this will fix the problem! On Fri, Jul 12, 2019 at 5:01 PM Andrea Del Bene wrote: > Problem with javadoc-maven-plugin 3.1.x and CI: > >

[GitHub] [wicket] svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195834 ## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ##

[GitHub] [wicket] andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195348 ## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ##

[GitHub] [wicket] svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
svenmeier commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303195128 ## File path: wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java ##

[GitHub] [wicket] andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit

2019-07-13 Thread GitBox
andruhon commented on a change in pull request #376: WICKET-6682 add CSP nonce support: initial commit URL: https://github.com/apache/wicket/pull/376#discussion_r303193907 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/head/filter/CspNonceHeaderResponse.java