Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-29 Thread Igor Vaynberg
go for it On Fri, Jun 28, 2013 at 11:43 PM, martin.dilger wrote: > That sounds like a pretty good thing. Should I file a Ticket? > > > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/RestartResponseAtInterceptPageException-continueToOriginalDestination-tp4659907

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread martin.dilger
That sounds like a pretty good thing. Should I file a Ticket? -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/RestartResponseAtInterceptPageException-continueToOriginalDestination-tp4659907p4659920.html Sent from the Forum for Wicket Core developers mailing list arch

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
i think the middle ground is to add RequestCycle#continueToOriginalDestination(). that way its your job to make sure you actually have a valid wicket scope before attempting to call that method. -igor On Fri, Jun 28, 2013 at 11:49 AM, martin.dilger wrote: > Hi Igor, > > We dont talk about differ

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread martin.dilger
Hi Igor, We dont talk about different layers. Even if my class would be named SignInAction, it belongs to the UI-Layer and thats the only valid place, thats completely right. Could be a Spring Bean for example, that throws some use case specific authentication - exceptions (AuthenticationFailed, I

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
this does not seem cluttered to me: 1 add(new Button("login") { 2 onsubmit() { 3 if (authenticator.login(username, password)) { 4continueToOriginalDestination(); 5setResponsePage(UserHome.class); 6} else { 7 error("login failed"); 8 } 9 } do you expect to call set

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread martin.dilger
Maybe an addition, dont get me wrong, everything is possible the way it is. I´m just asking for convenience to declutter some of my components. -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/RestartResponseAtInterceptPageException-continueToOriginalDestination-tp465

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread martin.dilger
oh it is backed by wicket (what else?:)) but I dont want to clutter my components with all this stuff when it is propably reasonable to place it somewhere else. In my case, the virtual SignInAction would handle everything, not the component, the component is only the wrapper for ui etc. -- Vie

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Igor Vaynberg
if your form is not backed by wicket i do not think you should count on being within a wicket request cycle... -igor On Fri, Jun 28, 2013 at 7:43 AM, martin.dilger wrote: > Hi Martin, > > image the typical SignIn-Functionality. > > You have a SignInPanel which only shows the necessary Form Comp

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread martin.dilger
Hi Martin, image the typical SignIn-Functionality. You have a SignInPanel which only shows the necessary Form Components. Then you have some sort of Bean like SignInActionXYZ, which has in its perform method the typical flow: if(signInSuccesful()){ //well, check if there was some interceptio

Re: RestartResponseAtInterceptPageException#continueToOriginalDestination

2013-06-28 Thread Martin Grigorov
On Fri, Jun 28, 2013 at 5:17 PM, martin.dilger wrote: > Hi, > > just wondering, is there any Reason why > RestartResponseAtInterceptPageException#continueToOriginalDestination is > Package-Private and not public? > It is called in Component#continueToOriginalDestination which is itself > non-stat