Code inside PageWindowManager.
Hi, I was reading the patch proposed for issue 4572. I've found this line of code (line 461 for branch origin/wicket-1.5.x) inside PageWindowManager: while (result.size() count currentIndex != indexPointer); What is its purpose? Could it lead to a infinite loop?
Wicket 1.5.7 release this week ?
Hi, We've found a quite serious problem in DiskDataStore internals - https://issues.apache.org/jira/browse/WICKET-4572. In case the disk space per http session is exhausted it may lead to Wicket returning the wrong page instance when requested for a page with a specific id. This may lead to either ComponentNotFoundException (because the page instance is not the expected one and it doesn't have the component at all) or in the worst case it may lead to executing your business logic for the wrong data, e.g. deleting a wrong record when clicking a Link. Additionally https://issues.apache.org/jira/browse/WICKET-4561 caused problems for several users as well. So far we have 25 issues solved and 1.5.6 has been released at 27 April. So I suggest to release 1.5.7 this week. -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: Code inside PageWindowManager.
Sorry, I've just realized that the line of code is parto of do while statement :).. Hi, I was reading the patch proposed for issue 4572. I've found this line of code (line 461 for branch origin/wicket-1.5.x) inside PageWindowManager: while (result.size() count currentIndex != indexPointer); What is its purpose? Could it lead to a infinite loop?
Re: Wicket 1.5.7 release this week ?
+1 to release 1.5.7 Hi, We've found a quite serious problem in DiskDataStore internals - https://issues.apache.org/jira/browse/WICKET-4572. In case the disk space per http session is exhausted it may lead to Wicket returning the wrong page instance when requested for a page with a specific id. This may lead to either ComponentNotFoundException (because the page instance is not the expected one and it doesn't have the component at all) or in the worst case it may lead to executing your business logic for the wrong data, e.g. deleting a wrong record when clicking a Link. Additionally https://issues.apache.org/jira/browse/WICKET-4561 caused problems for several users as well. So far we have 25 issues solved and 1.5.6 has been released at 27 April. So I suggest to release 1.5.7 this week.
