Please file a ticket so I don't forget and I'll change it.
Or you do it :-)
On Wed, May 22, 2013 at 5:01 PM, Sven Meier wrote:
> Hi Martin,
>
> I'd say we should change it for 7.x only.
>
> For 6.x it's better to leave it STOP, since that corresponds to the
> behavior before "eventPropagation"
Hi Martin,
I'd say we should change it for 7.x only.
For 6.x it's better to leave it STOP, since that corresponds to the
behavior before "eventPropagation" was introduced.
Sven
On 05/22/2013 03:46 PM, Martin Grigorov wrote:
On Wed, May 22, 2013 at 4:41 PM, Sven Meier wrote:
With Wicket 7
On Wed, May 22, 2013 at 4:41 PM, Sven Meier wrote:
> With Wicket 7.0.0 we will follow the jquery convention with
> "preventDefault" initially set to false.
>
> @Martin:
> Shouldn't ARA#eventPropagation set to BUBBLE initially? That would be
> consistent with jquery too.
This is how it was in 6.
With Wicket 7.0.0 we will follow the jquery convention with
"preventDefault" initially set to false.
@Martin:
Shouldn't ARA#eventPropagation set to BUBBLE initially? That would be
consistent with jquery too.
Sven
On 05/22/2013 03:34 PM, Nick Pratt wrote:
Hi Martin
I didnt mean to imply tha
Hi Martin
I didnt mean to imply that we should change the functionality, just that I
think we should follow the convention of whatever jquery/JS do, except in
the cases where components need to alter this behavior for their correct
functionality. So if the JS/jquery default is to allow event propa
Hi Nick,
On Wed, May 22, 2013 at 3:30 PM, Nick Pratt wrote:
> With regards to the default setting of this value, I think we should follow
> whatever jquery / JS does by default (I dont know whether this is the case
> or not). I think events propagate by default, so any provided components
> tha
With regards to the default setting of this value, I think we should follow
whatever jquery / JS does by default (I dont know whether this is the case
or not). I think events propagate by default, so any provided components
that need to alter this behavior should explicitly set (false) for this
val
On Wed, May 22, 2013 at 1:46 PM, Sven Meier wrote:
> I still think we can change the default value for 'allowDefault' to true.
>> Can you think of a bad scenario when this will break ?
>>
>
> I'm not sure, but it will surely break somewhere.
>
> For 6.x I'd just restore AjaxFormValidatingBehavior
I still think we can change the default value for 'allowDefault' to true.
Can you think of a bad scenario when this will break ?
I'm not sure, but it will surely break somewhere.
For 6.x I'd just restore AjaxFormValidatingBehavior's functionality with
allowDefault=true iff a throttle is given.
After some experiments with the quickstart I think Sven is right. With
version 6.6.0 it's also impossible to insert an input. However with ver
6.7.0 is "almost" impossible, meaning that the behavior is a little
weird. Initially it's impossible, but if you move to the surname field
and then back
Ouch!
You are correct!
It is the same behavior in 6.7.0 and 6.6.0.
So, I agree that there is no need of 6.8.1.
I still think we can change the default value for 'allowDefault' to true.
Can you think of a bad scenario when this will break ?
Since there are no user complaints I'm not keen to do the
It's been that way ever since:
"keydown" with allowDefault=false -> not character input
Sven
On 05/22/2013 12:07 PM, Martin Grigorov wrote:
The quickstart in the ticket is very simple, there is no usage of
throttling.
It's just:
textField.add(new AjaxEventBehavior("keydown") {
@Override
pro
The quickstart in the ticket is very simple, there is no usage of
throttling.
It's just:
textField.add(new AjaxEventBehavior("keydown") {
@Override
protected void onEvent(AjaxRequestTarget target) {
System.err.println("event");
}
});
Without explicitly allowing the default behavior the user can
AFAICS this is a problem only for behaviors which are throttled.
AjaxFormValidatingBehavior is the only one in Wicket, we can simple set
allowDefault=true for that one. And I don't think this is so urgent to
require a 6.8.1 release.
Anyone else using ThrottlingSettings can easily set allowDefa
On Wed, May 22, 2013 at 10:04 AM, Martin Grigorov wrote:
> Hi,
>
> I think we need 6.8.1 because of the problem in
> https://issues.apache.org/jira/browse/WICKET-5194.
> The quickstart shows that textField.add(new AjaxEventBehavior("keydown"))
> doesn't work because the event' default behavior is
Hi,
I think we need 6.8.1 because of the problem in
https://issues.apache.org/jira/browse/WICKET-5194.
The quickstart shows that textField.add(new AjaxEventBehavior("keydown"))
doesn't work because the event' default behavior is prevented.
org.apache.wicket.ajax.attributes.AjaxRequestAttributes#a
16 matches
Mail list logo
