wicket pull request: Cdi 1.1 experimental 0.3-SNAPSHOT

2013-07-03 Thread jsarman
GitHub user jsarman opened a pull request: https://github.com/apache/wicket/pull/49 Cdi 1.1 experimental 0.3-SNAPSHOT Major changes to internals. Now supports @Conversational(auto,propagation) annotation to allow pages to override global configuration. Added WicketCdiFilter to all

Re: Thoughts on component ids

2013-07-03 Thread Jesse Long
On 03/07/2013 14:07, Martijn Dashorst wrote: On Wed, Jul 3, 2013 at 11:35 AM, Jesse Long wrote: First, requiring the component to know, at constructor time, the wicket:id of the tag it will be added to makes creating components difficult and clumsy. What is clumsy about it? What is difficult t

Re: Thoughts on component ids

2013-07-03 Thread Martijn Dashorst
On Wed, Jul 3, 2013 at 11:35 AM, Jesse Long wrote: > First, requiring the component to know, at constructor time, the wicket:id > of the tag it will be added to makes creating components difficult and > clumsy. What is clumsy about it? What is difficult to creating components currently? > What d

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Johan Compagner
Ah we are taking here about the removal of the deprecated api not the code for other browsers. That was 2.0 yes. Couldn't look it up that easy on vacation.. But then I guess we need to stick to 1.8.x On 3 Jul 2013 12:05, "Martijn Dashorst" wrote: > On Wed, Jul 3, 2013 at 11:47 AM, Johan Compagne

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martijn Dashorst
On Wed, Jul 3, 2013 at 11:47 AM, Johan Compagner wrote: > Why not just go to the latest 1.9.x? > I thought that was .10 but without all the removed api? 1.9 has removed the api. Martijn > On 3 Jul 2013 11:13, "Martijn Dashorst" wrote: > >> While I typically agree that using the latest stable v

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Johan Compagner
Why not just go to the latest 1.9.x? I thought that was .10 but without all the removed api? On 3 Jul 2013 11:13, "Martijn Dashorst" wrote: > While I typically agree that using the latest stable versions of > things is a good thing™, in this case the almighty gods that maintain > jquery have deci

AjaxFallbackDefaultDataTable/DataTable design

2013-07-03 Thread Vojtěch Krása
Hello, I implemented add/edit/remove on AjaxFallbackDefaultDataTable which updates only the affected row. The problem is that for adding a new row I need to call a method on DataGridView, which is not possible for two reasons: it is a protected method, and the datagrid is a private field in DataTa

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Andrea Del Bene
[x ] Release 6.9.1 with downgrade to jquery 1.8.3: and stay stick to 1.8.3 also for future versions of Wicket 6.x > While I typically agree that using the latest stable versions of > things is a good thing™, in this case the almighty gods that maintain > jquery have decided to move deprecated API

Thoughts on component ids

2013-07-03 Thread Jesse Long
Hi Wicket Developers, I have a few thoughts regarding component ids. First, requiring the component to know, at constructor time, the wicket:id of the tag it will be added to makes creating components difficult and clumsy. What do you think about changing this pattern: add(new MyComponent("t

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Cedric Gatay
[X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin We should use the time we have to check if the migration plugin does what is expected before releasing 6.10.0. 6.9.0 is a "bad" release for heavy JavaScript user. __ Cedric Gatay (@Cedric_Gatay

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martin Grigorov
On Wed, Jul 3, 2013 at 12:25 PM, Sven Meier wrote: > >MyApp#init() { > > getJavaScriptLibrarySettings()**.setJQueryReference(new > JavaScriptResourceReference(..**., > >**anyVersionThatWorksForMeUntilI**UpgradeMyAppAndPlugins)) > } > > Problem is when you're using libraries which are using > JQ

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martin Grigorov
On Wed, Jul 3, 2013 at 12:23 PM, Thomas Matthijs wrote: > > > As we are already considering 6.9.1, I think we should fix this issue > > > as well in 6.9.1. > > > > > > [ ] Release 6.9.1 with downgrade to jquery 1.8.3 > > > [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin > > > [ ]

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Sven Meier
>MyApp#init() { > getJavaScriptLibrarySettings().setJQueryReference(new JavaScriptResourceReference(..., >anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins)) } Problem is when you're using libraries which are using JQueryResourceReference.get() hard coded in #getDependencies() :/. Sven

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martin Grigorov
On Wed, Jul 3, 2013 at 12:20 PM, Emond Papegaaij wrote: > [X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery > 1.10.1 and migration plugin > > IMHO fixes in patch releases should be as small as possible and as clean > as possible. Reverting a change that broke things should

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Sven Meier
Upgrading to wicket 6.9 breaks all our applications Same here :/. With the removal of methods jQuery 1.9.x was a major change! [X] Release 6.9.1 with downgrade to jquery 1.8.3 Sven On 07/03/2013 11:12 AM, Martijn Dashorst wrote: While I typically agree that using the latest stable versions

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Michael Haitz
i would propose to upgrade jquery with wicket7, not before. [X] Release 6.9.1 with downgrade to jquery 1.8.3, 7.0.0 with jquery 1.10.1 and migration plugin cheers, Michael Am 03.07.2013 um 11:12 schrieb Martijn Dashorst : > [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery >

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Thomas Matthijs
> > As we are already considering 6.9.1, I think we should fix this issue > > as well in 6.9.1. > > > > [ ] Release 6.9.1 with downgrade to jquery 1.8.3 > > [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin > > [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery > >

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martin Grigorov
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > While I typically agree that using the latest stable versions of > things is a good thing™, in this case the almighty gods that maintain > jquery have decided to move deprecated APIs from versions prior to 1.9

Re: JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Emond Papegaaij
[X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin IMHO fixes in patch releases should be as small as possible and as clean as possible. Reverting a change that broke things should fix those things again. Using a different strategy (the migration

Re: WICKET-5226 breaks many wicket-cdi applications

2013-07-03 Thread Emond Papegaaij
On Wednesday 03 July 2013 12:07:07 Martin Grigorov wrote: > Here are the commits for WELD-1441: > > https://github.com/weld/core/commit/569c8efc5f0dd1dcc9c942fd3dd8c1f6 5a216b9e > https://github.com/weld/core/commit/9e248b5306b382f88f41cca1325178e d6fbe4306 > > What bothers me is > https://git

JQuery 1.10.1 dependency also breaks many applications

2013-07-03 Thread Martijn Dashorst
While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more acc

Re: WICKET-5226 breaks many wicket-cdi applications

2013-07-03 Thread Martin Grigorov
Here are the commits for WELD-1441: https://github.com/weld/core/commit/569c8efc5f0dd1dcc9c942fd3dd8c1f65a216b9e https://github.com/weld/core/commit/9e248b5306b382f88f41cca1325178ed6fbe4306 What bothers me is https://github.com/weld/core/commit/569c8efc5f0dd1dcc9c942fd3dd8c1f65a216b9e#L1R55 It th

Re: WICKET-5226 breaks many wicket-cdi applications

2013-07-03 Thread Emond Papegaaij
Here's my vote: [X] Yes, revert 5226 and release 6.9.1 Emond On Wednesday 03 July 2013 10:09:33 Emond Papegaaij wrote: > Hi all, > > The changes made for WICKET-5226 (no longer injecting anonymous inner > classes) breaks our applications badly, and I suspect we are not the only > one. The foll

Re: WICKET-5226 breaks many wicket-cdi applications

2013-07-03 Thread Martin Grigorov
On Wed, Jul 3, 2013 at 11:09 AM, Emond Papegaaij wrote: > Hi all, > > The changes made for WICKET-5226 (no longer injecting anonymous inner > classes) breaks our applications badly, and I suspect we are not the only > one. The following pattern is quite common: > > add(new Link("rest") { >

WICKET-5226 breaks many wicket-cdi applications

2013-07-03 Thread Emond Papegaaij
Hi all, The changes made for WICKET-5226 (no longer injecting anonymous inner classes) breaks our applications badly, and I suspect we are not the only one. The following pattern is quite common: add(new Link("rest") { @Inject private AccountRestResourceClient accountClient;