[GitHub] [wicket] martin-g commented on issue #394: Fix JavaDoc comment for PackageResource.getResourceStream()

2019-10-24 Thread GitBox
martin-g commented on issue #394: Fix JavaDoc comment for PackageResource.getResourceStream() URL: https://github.com/apache/wicket/pull/394#issuecomment-545781124 Why do you think it cannot be null ? `org.apache.wicket.core.util.resource.locator.IResourceStreamLocator#locate(java.lang

[GitHub] [wicket] vrozkovec opened a new pull request #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior

2019-10-24 Thread GitBox
vrozkovec opened a new pull request #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior URL: https://github.com/apache/wicket/pull/395 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [wicket] martin-g merged pull request #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior

2019-10-24 Thread GitBox
martin-g merged pull request #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior URL: https://github.com/apache/wicket/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [wicket] martin-g commented on issue #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior

2019-10-24 Thread GitBox
martin-g commented on issue #395: Fix javadoc: AjaxDownload > AjaxDownloadBehavior URL: https://github.com/apache/wicket/pull/395#issuecomment-545840528 Thank you, @vrozkovec ! This is an automated message from the Apache Git

[GitHub] [wicket] ursjoss commented on issue #394: Fix JavaDoc comment for PackageResource.getResourceStream()

2019-10-24 Thread GitBox
ursjoss commented on issue #394: Fix JavaDoc comment for PackageResource.getResourceStream() URL: https://github.com/apache/wicket/pull/394#issuecomment-545974273 @martin-g Yes, you're completely right of course. Sorry for the noise... --

[GitHub] [wicket] ursjoss closed pull request #394: Fix JavaDoc comment for PackageResource.getResourceStream()

2019-10-24 Thread GitBox
ursjoss closed pull request #394: Fix JavaDoc comment for PackageResource.getResourceStream() URL: https://github.com/apache/wicket/pull/394 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [wicket] solomax opened a new pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
solomax opened a new pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340442504 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/pages/wicket-browser-info.js ## @@ -58,6 +58,8 @@

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340442050 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340441484 ## File path: wicket-core/src/main/java/org/apache/wicket/markup/html/pages/wicket-browser-info.js ## @@ -58,6 +58,8 @@

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340442004 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340441902 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] solomax commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
solomax commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340448427 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] solomax commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-29 Thread GitBox
solomax commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340449582 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] martin-g commented on a change in pull request #396: Wicket 6712 js time zone

2019-10-30 Thread GitBox
martin-g commented on a change in pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#discussion_r340458270 ## File path: wicket-core/src/test/java/org/apache/wicket/protocol/http/ClientPropertiesTest.java ## @@ -149,4 +149,32 @@ void

[GitHub] [wicket] svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-30 Thread GitBox
svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-548122574 IMHO I've found a better solution, see https://github.com/apache/wicket/commits/WICKET-6703-replace-eval-with-domEval

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-30 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-548195495 @svenmeier I had a look at the code. It all makes sense. I'll test it soon. --

[GitHub] [wicket] solomax merged pull request #396: Wicket 6712 js time zone

2019-10-31 Thread GitBox
solomax merged pull request #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [wicket] solomax commented on issue #396: Wicket 6712 js time zone

2019-10-31 Thread GitBox
solomax commented on issue #396: Wicket 6712 js time zone URL: https://github.com/apache/wicket/pull/396#issuecomment-548308369 Thanks for the review! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [wicket] svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-31 Thread GitBox
svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-548335147 Actually your data-wicket-evaluation=after made me wonder whether we could just make the ordering relevant. It's just

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613 `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, Wicket.Ajax.suspendCall());", c3.getMarkupId(

[GitHub] [wicket] andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox
andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613 Hi @svenmeier ! `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, Wicket.Ajax.suspend

[GitHub] [wicket] andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox
andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613 Hi @svenmeier ! `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, Wicket.Ajax.suspend

[GitHub] [wicket] andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox
andruhon edited a comment on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613 Hi @svenmeier ! `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, Wicket.Ajax.suspend

[GitHub] [wicket] svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-06 Thread GitBox
svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550315849 @andruhon I've seen that you preferred to put this into a separate js file. Personally I'd rather have this concise a

[GitHub] [wicket] dependabot[bot] opened a new pull request #397: Bump jackson-databind from 2.9.9 to 2.9.10.1

2019-11-12 Thread GitBox
dependabot[bot] opened a new pull request #397: Bump jackson-databind from 2.9.9 to 2.9.10.1 URL: https://github.com/apache/wicket/pull/397 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9 to 2.9.10.1. Commits - See full diff in [compare view](https:

[GitHub] [wicket] martin-g merged pull request #397: Bump jackson-databind from 2.9.9 to 2.9.10.1

2019-11-12 Thread GitBox
martin-g merged pull request #397: Bump jackson-databind from 2.9.9 to 2.9.10.1 URL: https://github.com/apache/wicket/pull/397 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [wicket] martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-14 Thread GitBox
martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-554242643 > Regarding multiple locks - I don't know when/why this would actually be useful. Do we (want to) support it ?

[GitHub] [wicket] svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-20 Thread GitBox
svenmeier commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-556947694 Many thanks Andrew, we've got this enhancement into master. Please close this pull request. --

[GitHub] [wicket] andruhon closed pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-21 Thread GitBox
andruhon closed pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-21 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-557256075 🎉 🎉 🎉 Thank you everyone! Have a great weekend! T

[GitHub] [wicket] andruhon commented on issue #375: WICKET-6666 modal dialog

2019-11-21 Thread GitBox
andruhon commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-557295536 It seems like this popup does what's needed and is simple enough. > That's just AjaxNewWindowNotifyingBehavior creating a new page instance when it detects

[GitHub] [wicket] andruhon commented on a change in pull request #375: WICKET-6666 modal dialog

2019-11-21 Thread GitBox
andruhon commented on a change in pull request #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#discussion_r349346748 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/trap-focus.js ## @@ -0,0 +1,

[GitHub] [wicket] andruhon commented on a change in pull request #375: WICKET-6666 modal dialog

2019-11-21 Thread GitBox
andruhon commented on a change in pull request #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#discussion_r349345828 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/theme/DefaultTheme.java ## @

[GitHub] [wicket] svenmeier commented on issue #375: WICKET-6666 modal dialog

2019-11-29 Thread GitBox
svenmeier commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-559769246 >If I open dialog with a Link in a new tab, it just blinks and disappears immediately (tested in FF, Chrome and Edge). > This is a really annoying behavior. I

[GitHub] [wicket] svenmeier commented on a change in pull request #375: WICKET-6666 modal dialog

2019-11-29 Thread GitBox
svenmeier commented on a change in pull request #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#discussion_r352105624 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/theme/DefaultTheme.java ##

[GitHub] [wicket] bitstorm commented on issue #375: WICKET-6666 modal dialog

2019-12-07 Thread GitBox
bitstorm commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-562881531 Hi! I've tested the new ModlDialog and it looks cool! I've found just a minor UI issue under Firefox opening different nested dialogs: the resizable right border

[GitHub] [wicket] svenmeier commented on issue #375: WICKET-6666 modal dialog

2019-12-07 Thread GitBox
svenmeier commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-562893250 Thanks Andrea for given the implementation a test! I'm aware of the issue with the resize handle. It seems to be a bug in Firefox with nested resizable contai

[GitHub] [wicket] bitstorm commented on issue #375: WICKET-6666 modal dialog

2019-12-08 Thread GitBox
bitstorm commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-562981994 @svenmeier Great! Give me a call when you are done, so we can proceed merging this PR. This is a

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-12-09 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-563339765 @ivaynberg any objections against continuing the new modal dialog implementation on #375 ? If not, could you please close this pull req

[GitHub] [wicket] ivaynberg closed pull request #361: WICKET-6666 initial checkin of new ModalDialog

2019-12-09 Thread GitBox
ivaynberg closed pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [wicket] ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-12-09 Thread GitBox
ivaynberg commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-563455636 no objections This is an automated message from the Apache Git Service. T

[GitHub] [wicket] asfgit closed pull request #273: WICKET-6321 Support Integrity and Crossorigin attributes

2019-12-12 Thread GitBox
asfgit closed pull request #273: WICKET-6321 Support Integrity and Crossorigin attributes URL: https://github.com/apache/wicket/pull/273 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [wicket] chrisco484 commented on issue #375: WICKET-6666 modal dialog

2019-12-28 Thread GitBox
chrisco484 commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-569463952 > This is my take on a new modal dialog/window for Wicket. > > I've taken Igor's work as a base but changed a lot of things, so I thought a separate pull

[GitHub] [wicket] chrisco484 edited a comment on issue #375: WICKET-6666 modal dialog

2019-12-28 Thread GitBox
chrisco484 edited a comment on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-569463952 > This is my take on a new modal dialog/window for Wicket. Hi @svenmeier Have you had a chance to check out the way Modals work in the Wick

[GitHub] [wicket] svenmeier commented on issue #375: WICKET-6666 modal dialog

2019-12-30 Thread GitBox
svenmeier commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-569816088 Hi @chrisco484, thanks for chiming in. Yes, I have used ModalX before. I like that you can show arbitrary dialogs without the need to keep them in the com

[GitHub] [wicket] JoachimRohde opened a new pull request #398: Added warning regarding the limitations of the -tag

2020-01-02 Thread GitBox
JoachimRohde opened a new pull request #398: Added warning regarding the limitations of the -tag URL: https://github.com/apache/wicket/pull/398 A small update of the user guide pointing out the limitations of the wicket:enclosure-tag by just copying the JavaDoc of the EnclosureContainer.

[GitHub] [wicket] svenmeier closed pull request #375: WICKET-6666 modal dialog

2020-01-03 Thread GitBox
svenmeier closed pull request #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [wicket] svenmeier commented on issue #375: WICKET-6666 modal dialog

2020-01-03 Thread GitBox
svenmeier commented on issue #375: WICKET- modal dialog URL: https://github.com/apache/wicket/pull/375#issuecomment-570616496 Thanks, I've merge the implementation into master. This is an automated message from the Apache

[GitHub] [wicket] martin-g merged pull request #398: Added warning regarding the limitations of the -tag

2020-01-03 Thread GitBox
martin-g merged pull request #398: Added warning regarding the limitations of the -tag URL: https://github.com/apache/wicket/pull/398 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [wicket] martin-g commented on issue #398: Added warning regarding the limitations of the -tag

2020-01-03 Thread GitBox
martin-g commented on issue #398: Added warning regarding the limitations of the -tag URL: https://github.com/apache/wicket/pull/398#issuecomment-570764416 Thank you, @JoachimRohde ! This is an automated message from the Apac

[GitHub] [wicket] papegaaij opened a new pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-17 Thread GitBox
papegaaij opened a new pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399 I'm opening this PR to get some feedback on the suggested changes. The structure of the code is what I have in mind for this. I do know the documentat

[GitHub] [wicket] solomax commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-17 Thread GitBox
solomax commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368205286 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,191 @@ +

[GitHub] [wicket] solomax commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-17 Thread GitBox
solomax commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368205168 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,191 @@ +

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-17 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-575870332 @papegaaij we are currently adding CSP header using following conditions: ``` if (resp instanceof WebResponse && !(resp instanceof W

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-18 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-575882339 That won't work because that class is not on the classpath. Also I don't like checking on subclasses to exclude them. What if another s

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-18 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-575895355 `canSetHeader` ? This is an automated message from the Apache Git Servic

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-19 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-576048302 I've resolved the issues with `setHeader`, updated the documentation and fixed some minor issues. I've whitelisted some resources in th

[GitHub] [wicket] andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-19 Thread GitBox
andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368319326 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,191 @@

[GitHub] [wicket] andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-19 Thread GitBox
andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368318269 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,191 @@

[GitHub] [wicket] andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-19 Thread GitBox
andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368322723 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPRenderable.java ## @@ -0,0 +1,42 @@

[GitHub] [wicket] andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-19 Thread GitBox
andruhon commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368318770 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,191 @@

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-20 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-576300948 API looks good to me I'm trying to add CSP support from this branch to out main wicket app The biggest problem so far: first request

[GitHub] [wicket] papegaaij opened a new pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
papegaaij opened a new pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400 This PR replaces inline display: none with a CSS class and a stylesheet. The stylesheet is managed by Wicket and added automatically. You can change or

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368901056 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPRenderable.java ## @@ -0,0 +1,42 @@

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368909863 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368907006 ## File path: wicket-core/src/test/java/org/apache/wicket/csp/CSPSettingRequestCycleListenerTest.java ###

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368904046 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/FixedCSPDirective.java ## @@ -0,0 +1,5

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368908158 ## File path: wicket-core/src/test/java/org/apache/wicket/csp/CSPSettingRequestCycleListenerTest.java ###

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368902798 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicyEnforcer.java ##

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368908845 ## File path: wicket-core/src/test/java/org/apache/wicket/csp/CSPSettingRequestCycleListenerTest.java ###

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368903438 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicyEnforcer.java ##

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r368895838 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,208 @@

[GitHub] [wicket] martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368947706 ## File path: wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java ## @@ -770,4

[GitHub] [wicket] martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368948446 ## File path: wicket-core/src/test/java/org/apache/wicket/markup/html/basic/RedirectPage-expected1.html ###

[GitHub] [wicket] martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368947117 ## File path: wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java ## @@ -758

[GitHub] [wicket] papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368974578 ## File path: wicket-core/src/test/java/org/apache/wicket/markup/html/basic/RedirectPage-expected1.html ##

[GitHub] [wicket] martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368975915 ## File path: wicket-core/src/test/java/org/apache/wicket/markup/html/basic/RedirectPage-expected1.html ###

[GitHub] [wicket] papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368978477 ## File path: wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java ## @@ -770,4

[GitHub] [wicket] papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r368979027 ## File path: wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java ## @@ -75

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369205446 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java ###

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-576848537 > API looks good to me > I'm trying to add CSP support from this branch to out main wicket app > The biggest problem so far: first

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369208682 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java ## @@ -0,0 +1,208 @@

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369209407 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/CSPRenderable.java ## @@ -0,0 +1,42 @@

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369209780 ## File path: wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicyEnforcer.java ##

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369210183 ## File path: wicket-core/src/test/java/org/apache/wicket/csp/CSPSettingRequestCycleListenerTest.java ##

[GitHub] [wicket] andruhon commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
andruhon commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r369246875 ## File path: wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java ## @@ -71,5 +71,7

[GitHub] [wicket] andruhon commented on issue #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
andruhon commented on issue #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#issuecomment-576885516 The change looks good to me This is an automated message from the Apache

[GitHub] [wicket] martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#discussion_r369382673 ## File path: wicket-core/src/main/java/org/apache/wicket/mock/MockApplication.java ## @@ -71,5 +71,7

[GitHub] [wicket] martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
martin-g commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369383970 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-21 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577026973 @papegaaij I'm still investigating (suspectingthis might be caused by lots of `nonce`s need to be generated, and/or lot's of inline st

[GitHub] [wicket] solomax commented on issue #400: WICKET-6725: replace display: none by css class

2020-01-21 Thread GitBox
solomax commented on issue #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#issuecomment-577028408 Maybe changes required for `WICKET-6726` can also be added to `wicket-core.css`? --

[GitHub] [wicket] papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-22 Thread GitBox
papegaaij commented on a change in pull request #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#discussion_r369416763 ## File path: wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java ###

[GitHub] [wicket] papegaaij commented on issue #400: WICKET-6725: replace display: none by css class

2020-01-22 Thread GitBox
papegaaij commented on issue #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#issuecomment-577062703 @solomax that's the idea, but I haven't started on that ticket yet :) Th

[GitHub] [wicket] papegaaij closed pull request #400: WICKET-6725: replace display: none by css class

2020-01-22 Thread GitBox
papegaaij closed pull request #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [wicket] papegaaij commented on issue #400: WICKET-6725: replace display: none by css class

2020-01-22 Thread GitBox
papegaaij commented on issue #400: WICKET-6725: replace display: none by css class URL: https://github.com/apache/wicket/pull/400#issuecomment-577063274 This PR is merged into master manually This is an automated message from

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-22 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577199827 @papegaaij, All I was able to find the reason of slow down in my application `SecureRandom.getInstanceStrong()` creates `NativePRNGB

[GitHub] [wicket] martin-g commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-22 Thread GitBox
martin-g commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577206590 @solomax Is it better with `-Djava.security.egd=file:/dev/./urandom` ?

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-22 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577212144 just tried to start Tomcat with `JAVA_OPTS="-Djava.security.egd=file:/dev/./urandom" ./bin/catalina.sh run` it is slow :( ---

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-22 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577292623 Good random data with a reliable entropy source always is a problem. On my system (kubuntu), I've got haveged running to increase the a

<    1   2   3   4   5   6   7   8   9   10   >