Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
On Mon, Jun 1, 2020 at 3:40 PM Thomas Heigl wrote: > > > > Now I checked the GitHub Actions docs ( > > > https://help.github.com/en/actions/reference/events-that-trigger-workflows > > ) > > and added support for Pull Requests. > > Since we have .github/workflows only in master branch it won't tri

Re: Questions regarding development workflow

2020-06-01 Thread Thomas Heigl
> > Now I checked the GitHub Actions docs ( > https://help.github.com/en/actions/reference/events-that-trigger-workflows > ) > and added support for Pull Requests. > Since we have .github/workflows only in master branch it won't trigger any > builds for 8.x, 7.x, ... If we want this then we have to

Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
On Mon, Jun 1, 2020 at 1:10 PM Thomas Heigl wrote: > Thanks for the infos Andrea and Martin! I think that answers all my > questions. > > The official CI tool is BuildBot but since recently we also added GitHub > > Actions since it comes for free (i.e. any maintenance from us). > > At the moment

Re: Questions regarding development workflow

2020-06-01 Thread Thomas Heigl
Thanks for the infos Andrea and Martin! I think that answers all my questions. The official CI tool is BuildBot but since recently we also added GitHub > Actions since it comes for free (i.e. any maintenance from us). > At the moment it builds only master branch but we can remove this > restrictio

Re: Questions regarding development workflow

2020-06-01 Thread Martin Grigorov
Hi, On Sun, May 31, 2020 at 2:17 PM Andrea Del Bene wrote: > Hi Thomas! > > On 30/05/20 18:52, Thomas Heigl wrote: > > Hi all, > > > > Do we have any guidelines regarding the development workflow? E.g. > > > > - How many approvals do I need for merging a PR? > PR approvals on GitHub is a relativ

Re: Questions regarding development workflow

2020-05-31 Thread Andrea Del Bene
Hi Thomas! On 30/05/20 18:52, Thomas Heigl wrote: Hi all, Do we have any guidelines regarding the development workflow? E.g. - How many approvals do I need for merging a PR? PR approvals on GitHub is a relatively new thing and there is no strict rule about it. As empiric rule we try to get th

Questions regarding development workflow

2020-05-30 Thread Thomas Heigl
Hi all, Do we have any guidelines regarding the development workflow? E.g. - How many approvals do I need for merging a PR? - Who manages the changelog? Should a changelog entry be part of every PR? - How do we decide what PRs to backport to older versions? And are there CI builds for PRs? I wou