Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-14 Thread Colm O hEigeartaigh
For RequiredPartsBuilder, the String in question is returned from getAttributeNS which returns an empty String if there is no Attribute Namespace. That being said I did find one place in the code where a null check makes sense. Colm. On Sun, Nov 14, 2021 at 4:19 AM Rob Leland wrote: > > This is

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-12 Thread Colm O hEigeartaigh
What change are you referring to, can you point me to a line of code? Colm. On Tue, Nov 9, 2021 at 9:50 PM Rob Leland wrote: > > Was the change from "".equals(var) to var.length evaluated for NPE errors? > The previous method NPE were avoided. > > On Tue, Nov 9, 2021, 09:33 Colm O hEigeartaigh

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-09 Thread Rob Leland
Was the change from "".equals(var) to var.length evaluated for NPE errors? The previous method NPE were avoided. On Tue, Nov 9, 2021, 09:33 Colm O hEigeartaigh wrote: > Thanks everyone, the vote passes with 6 +1 votes, at least 3 of them > binding. > > Colm. > > On Mon, Nov 8, 2021 at 11:26 PM

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-09 Thread Colm O hEigeartaigh
Thanks everyone, the vote passes with 6 +1 votes, at least 3 of them binding. Colm. On Mon, Nov 8, 2021 at 11:26 PM Sagara Gunathunga wrote: > > +1 > > Thanks! > > On Tuesday, November 2, 2021, Colm O hEigeartaigh wrote: >> >> This is a vote to release Apache WSS4J 2.4.0. Even though this is a

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-08 Thread Sagara Gunathunga
+1 Thanks! On Tuesday, November 2, 2021, Colm O hEigeartaigh wrote: > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > new major release, the changes are somewhat minimal - the main purpose > of the release is to pick up a new major version of Apache Santuario > (2.3.0). >

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-08 Thread Alessio Soldano
+1 Thanks! On Mon, Nov 1, 2021 at 1:01 PM Colm O hEigeartaigh wrote: > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > new major release, the changes are somewhat minimal - the main purpose > of the release is to pick up a new major version of Apache Santuario > (2.3.0). >

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-08 Thread ant
+1 too if that wasn't obvious. ...ant On Mon, Nov 8, 2021 at 2:30 PM ant wrote: > > LGTM > >...ant > > On Mon, Nov 1, 2021 at 11:54 AM Colm O hEigeartaigh > wrote: > > > > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > > new major release, the changes are

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-08 Thread ant
LGTM ...ant On Mon, Nov 1, 2021 at 11:54 AM Colm O hEigeartaigh wrote: > > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > new major release, the changes are somewhat minimal - the main purpose > of the release is to pick up a new major version of Apache Santuario >

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-01 Thread Freeman Fang
+1(non-binding) Thanks! Freeman On Mon, Nov 1, 2021 at 7:54 AM Colm O hEigeartaigh wrote: > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > new major release, the changes are somewhat minimal - the main purpose > of the release is to pick up a new major version of Apache

Re: [VOTE] - Release Apache WSS4J 2.4.0

2021-11-01 Thread Daniel Kulp
+1 Dan > On Nov 1, 2021, at 7:54 AM, Colm O hEigeartaigh wrote: > > This is a vote to release Apache WSS4J 2.4.0. Even though this is a > new major release, the changes are somewhat minimal - the main purpose > of the release is to pick up a new major version of Apache Santuario > (2.3.0). >

[VOTE] - Release Apache WSS4J 2.4.0

2021-11-01 Thread Colm O hEigeartaigh
This is a vote to release Apache WSS4J 2.4.0. Even though this is a new major release, the changes are somewhat minimal - the main purpose of the release is to pick up a new major version of Apache Santuario (2.3.0). Git tag: https://github.com/apache/ws-wss4j/releases/tag/wss4j-2.4.0 Artifacts: