Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-07 Thread Imesh Gunaratne
Better not to use python-dev, see below post: http://stackoverflow.com/questions/21341423/should-python-dev-be-required-to-install-pip On Mon, Sep 7, 2015 at 11:27 AM, Akila Ravihansa Perera wrote: > All package installations should have a check whether package is already >

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-06 Thread Gayan Gunarathne
Hi, On Mon, Sep 7, 2015 at 10:38 AM, Reka Thirunavukkarasu wrote: > Hi > > When we include python in PCA and configurator, won't it get installed by > both the modules where i might give errors as it is already installed by > the other module. Otherwise, we will need to add a

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-06 Thread Anuruddha Liyanarachchi
Hi When we include python in PCA and configurator, won't it get installed by > both the modules where i might give errors as it is already installed by > the other module. Otherwise, we will need to add a check for whether the > relevant library exists already or not. > In order to overcome

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-06 Thread Akila Ravihansa Perera
All package installations should have a check whether package is already installed. IMO, enforcing a module order to overcome this is not the proper way to solve it. ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-06 Thread Reka Thirunavukkarasu
Hi When we include python in PCA and configurator, won't it get installed by both the modules where i might give errors as it is already installed by the other module. Otherwise, we will need to add a check for whether the relevant library exists already or not. In order to overcome this, what

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-06 Thread Imesh Gunaratne
On Sun, Sep 6, 2015 at 11:27 AM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi, > > IMO we can define 'python-dev', 'python-pip' libraries in stratos base > since they are required by configurator which is a mandatory module. > Why do we use "python-dev" instead of "python"? It

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Anuruddha Liyanarachchi
Hi Raj, Thanks for pointing this out. I have now added the jinja2 dependency to configurator module and removed from PCA. [1] [1] https://github.com/wso2/product-private-paas/blob/master/cartridges/vm/puppet/modules/configurator/manifests/init.pp#L32 On Sat, Sep 5, 2015 at 3:14 PM, Rajkumar

[Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Rajkumar Rajaratnam
Hi, I think python-pip & jinja2 should be installed by configurator puppet module, not by python agent. I am using vagrant, puppet and configurator to setup my development environment, but I am not using python agent. Since $subject is not done, I had to modify configurator puppet module. It

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Akila Ravihansa Perera
Hi Raj, I think we should not remove python-pip from PCA module since those dependencies should be installed for PCA to function. @Anuruddha: I still see that jinja2 is packed from PCA module [1]. Shall we move this to configurator module? [1]

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Akila Ravihansa Perera
Hi Raj, Yes, I meant python-pip should not be removed from PCA module but should be installed for configurator as well. I think it should be redefined for configurator module since python-pip is not a compulsory package. We can use Java agent without it. Thanks. On Sun, Sep 6, 2015 at 6:17 AM,

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Rajkumar Rajaratnam
On Sun, Sep 6, 2015 at 7:45 AM, Akila Ravihansa Perera wrote: > Hi Raj, > > I think we should not remove python-pip from PCA module since those > dependencies should be installed for PCA to function. > ​In the very similar way, python-pip should be installed for configurator

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Gayan Gunarathne
It is ok to redefined the python-pip module in configurator module since currently it is used in PCA and configurator only. But this might be a issue with other python libraries as well if that commonly used among the python modules.Also if there is several python modules exists we need to

Re: [Dev] [Private PaaS] python-pip & jinja2 should be installed by configurator puppet module

2015-09-05 Thread Anuruddha Liyanarachchi
Hi, IMO we can define 'python-dev', 'python-pip' libraries in stratos base since they are required by configurator which is a mandatory module. Therefore, In configurator module we can inlcude jinja2; In PCA module we can include PCA related python dependencies