[Dev] Review and merge PR

Hi All, Can you please review and merge following PR[1]. [1] https://github.com/wso2/carbon-business-messaging/pull/660 Thanks and Regards -- Rukshan Chathuranga. WSO2, Inc. +94711822074 ___ Dev mailing list Dev@wso2.org

[Dev] Review and merge following PRs

Hi All, Can you please review and merge the following PRs. Which contain 3rd party dependency upgrade fixes including solr and lucence. [1] https://github.com/wso2/carbon-registry/pull/292 [2] https://github.com/wso2/carbon-governance/pull/315 Thanks and Regards -- Rukshan Chathuranga. WSO2,

Re: [Dev] Review and merge PR for reading conf folder path by carbon

PR is merged. Fix will be available in carbon-analytics v1.3.22 version. Thanks. On Tue, Mar 13, 2018 at 7:56 PM, Lasantha Dharmakeerthi wrote: > Hi all, > > Spark Analytics Executor read the conf folder path as following way. Since > IoT server has changed the folder

[Dev] Review and merge PR for reading conf folder path by carbon

Hi all, Spark Analytics Executor read the conf folder path as following way. Since IoT server has changed the folder structure it is causing an issue. carbonConfDir = carbonHome + File.separator + "repository" + File.separator + "conf"; Therefore I think the correct way is to get the path as

Re: [Dev] Review and merge PR for logs required for message roundtrip analysis

Hi Dushani, Added some comments to the carbon-apimgt PR. Please fix those. Thanks & Regards, Mushthaq On Fri, Mar 9, 2018 at 6:57 PM, Dushani Wellappili wrote: > Hi APIM team and IS team, > > Highly appreciate if you can review the two PRs [1] and [2] which include > the

[Dev] Review and merge PR for logs required for message roundtrip analysis

Hi APIM team and IS team, Highly appreciate if you can review the two PRs [1] and [2] which include the newly added logs which are used to identify the message hops and their latencies in each node during an API invocation in WSO2 APIM. Please refer [3] for documentation and mail thread [4] for

Re: [Dev] Review and Merge PR

Merged. Pls re-upload the connector. On Fri, Aug 14, 2015 at 4:20 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Hi Malaka, Find the pull request for Flicker below.. which is changed according to the test failure. https://github.com/wso2/esb-connectors/pull/268 Thanks. -- Regards

[Dev] Review and Merge PR

Hi Malaka, Find the pull request for Flicker below.. which is changed according to the test failure. https://github.com/wso2/esb-connectors/pull/268 Thanks. -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list

[Dev] Review and Merge the PR

Hi, $subject please for [1]. [1] https://github.com/wso2/carbon-identity/pull/749/ Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com http://wso2.com/ ___ Dev mailing list

[Dev] Review and Merge the PR

Hi, $subject please for [1] which fixes public jira [2]. [1]https://github.com/wso2/carbon-identity/pull/739 [2]https://wso2.org/jira/browse/IDENTITY-3422 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com

Re: [Dev] Review and Merge PR for ESB Jira 3619

Merged please resolve the jira On Tue, Jul 28, 2015 at 6:20 PM, Sriashalya Srivathsan asha...@wso2.com wrote: $subject for following https://github.com/wso2/wso2-synapse/pull/292 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware -- Best Regards, Malaka Silva

[Dev] Review and Merge PR for ESB Jira 3619

$subject for following https://github.com/wso2/wso2-synapse/pull/292 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and Merge the PR

Hi, Please review and merge the PR [1] for public jira [2]. [1] https://github.com/wso2/carbon-identity/pull/623 [2] https://wso2.org/jira/browse/IDENTITY-3253 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com

[Dev] Review and Merge the PR

Hi, Please review and merge the fix [1] for public jira [2]. [1]https://github.com/wso2/product-is/pull/146 [2]https://wso2.org/jira/browse/IDENTITY-3220 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com

Re: [Dev] Review and Merge PR

Hi, Please find the PR below https://github.com/wso2/product-esb/pull/210 On Tue, Jul 7, 2015 at 12:18 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Please $ subject for synapse_sample 907 Thank you. -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware -- Regards

Re: [Dev] Review and Merge PR

Merged On Tue, Jul 7, 2015 at 1:53 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Hi Malaka, As we discussed in the review the mandatory parameters like host name,port and client Id are added in the axis2.xml. topic name and other optional parameters added in the proxy. thank you. On

Re: [Dev] Review and Merge PR

Hi Sriashalya, In the given sample only mqtt.connection.factory is specified. What about the other mandatory parameters? Also what is the doc link for this sample? On Tue, Jul 7, 2015 at 12:20 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Hi, Please find the PR below

Re: [Dev] Review and Merge PR

Sorry got the sample link. It's Sample 907 right? I think we can can have number 272 since 9xx is for inbound. On Tue, Jul 7, 2015 at 1:18 PM, Malaka Silva mal...@wso2.com wrote: Hi Sriashalya, In the given sample only mqtt.connection.factory is specified. What about the other mandatory

Re: [Dev] Review and Merge PR

Hi Malaka, I changed the sample number in the Doc and Pull request. On Tue, Jul 7, 2015 at 1:20 PM, Malaka Silva mal...@wso2.com wrote: Sorry got the sample link. It's Sample 907 right? I think we can can have number 272 since 9xx is for inbound. On Tue, Jul 7, 2015 at 1:18 PM, Malaka

Re: [Dev] Review and Merge PR

Hi Malaka, As we discussed in the review the mandatory parameters like host name,port and client Id are added in the axis2.xml. topic name and other optional parameters added in the proxy. thank you. On Tue, Jul 7, 2015 at 1:37 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Hi Malaka, I

[Dev] Review and Merge PR

Please $ subject for synapse_sample 907 Thank you. -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and Merge the PR

Please review and merge the fix [1] for public jira [2]. [1] https://github.com/wso2/product-is/pull/142 [2] https://wso2.org/jira/browse/IDENTITY-2541 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com http://wso2.com/

[Dev] Review and Merge PR

Please $Subject the fix [1] for Public Jira [2]. Tested and verified with shared subscriptions as well. Created Doc JIRA at [3] to update the documentation. [1] https://github.com/wso2/carbon-apimgt/pull/803 [2] https://wso2.org/jira/browse/APIMANAGER-3945 [3]

[Dev] Review and merge the PR

Hi Malaka, $subject for Googlecalendar connector. Please find the PR[1]. [1]- https://github.com/wso2/esb-connectors/pull/211 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#218, Stanley Road, Jaffna, Sri Lanka Email: naashe...@wso2.com lean . enterprise . middleware

Re: [Dev] Review and merge the PR

Merged On Sat, Jun 27, 2015 at 2:46 PM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, $subject for Googlecalendar connector. Please find the PR[1]. [1]- https://github.com/wso2/esb-connectors/pull/211 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#218,

[Dev] Review and merge the PR

Hi Malaka, $subject for verticalresponse connector. Please find the PR[1]. [1]- https://github.com/wso2/esb-connectors/pull/202 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com

[Dev] Review and Merge the PR

Hi , This is the fix [1] for Public JIRA issue [2]. $subject please. [1] https://github.com/wso2/carbon-identity/pull/475 [2] https://wso2.org/jira/browse/IDENTITY-3364 https://wso2.org/jira/browse/IDENTITY-3358 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com

Re: [Dev] Review and Merge the PR

Correcting the web address: [2] https://wso2.org/jira/browse/IDENTITY-3364 Thanks Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com nirosh...@wso2.com M :0718407133| http://wso2.com http://wso2.com/ On Wed, Jun 24, 2015 at 5:38 PM, Hasanthi Purnima Dissanayake

Re: [Dev] Review and Merge PR

Merged On Fri, Jun 19, 2015 at 7:22 PM, Shakila Sivagnanarajah shak...@wso2.com wrote: Hi Malaka, Please find the PR https://github.com/wso2/esb-connectors/pull/177 Thank you -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 shak...@wso2.com --

[Dev] Review and merge the PR

Hi Malaka, $Subject for Youtube connector. Please find the PR below[1]. This connector has folder change and usual pom change. I've tested manually for some methods randomly. [1]- https://github.com/wso2/esb-connectors/pull/172 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2,

Re: [Dev] Review and merge the PR

thx Merged On Fri, Jun 19, 2015 at 11:57 AM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, Previous folder structure was : {esb-connectors}/googlecalendar/src/main.. After the folder structure changed(like common folder structure of connector) the structure is :

[Dev] Review and Merge PR

Hi Malaka, Please $subject for nest. https://github.com/wso2/esb-connectors/pull/174 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Review and Merge PR

Can we also move the folders to a proper structure with the same. On Fri, Jun 19, 2015 at 1:45 PM, Sriashalya Srivathsan asha...@wso2.com wrote: Hi Malaka, Please $subject for nest. https://github.com/wso2/esb-connectors/pull/174 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise .

[Dev] Review and Merge PR

Hi Malaka, Please find the PR https://github.com/wso2/esb-connectors/pull/177 Thank you -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 shak...@wso2.com ___ Dev mailing list Dev@wso2.org

Re: [Dev] Review and merge PR

Hi Malaka, The connector has been uploaded to store please merge the PR Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 3:36 PM, Malaka Silva mal...@wso2.com wrote: Once you upload

Re: [Dev] Review and merge PR

Done On Fri, Jun 19, 2015 at 5:29 PM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, The connector has been uploaded to store please merge the PR Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com

Re: [Dev] Review and merge PR

Tests ran after the structural change? Is the new connector is uploaded to store? On Fri, Jun 19, 2015 at 11:16 AM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, Yes, since the folder structure is not properly set and I've tested some methods randomly it works. Regards, --

Re: [Dev] Review and merge the PR

Hi Malaka, Previous folder structure was : {esb-connectors}/googlecalendar/src/main.. After the folder structure changed(like common folder structure of connector) the structure is :

Re: [Dev] Review and merge the PR

What exactly is the folder change. Please provide some details. On Fri, Jun 19, 2015 at 11:19 AM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka. Yes. there is a folder structure change and I tested manually it works. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc

[Dev] Review and merge the PR

Hi Malaka, $Subject for Twitter connector. Please find PR below[1]. Tested manually for some random methods. [1]- https://github.com/wso2/esb-connectors/pull/175 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email:

Re: [Dev] Review and merge PR

Once you upload I'll merge https://github.com/wso2/esb-connectors/pull/167 On Fri, Jun 19, 2015 at 3:29 PM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, I tested after the folder change it works. I'll update to store. Regards, -- *Naasheer Ali* | Associate Software Engineer

[Dev] Review and Merge PR

Hi Malaka, Please review and merge the PR for eventbrite and yammer. https://github.com/wso2/esb-connectors/pull/173 Thank you. https://github.com/wso2/esb-connectors/pull/173 -- *S.Elilmatha* Associate Software Engineer, WSO2 Inc.; http://wso2.com lean.enterprise.middleware Mobile

Re: [Dev] Review and merge PR

Hi Malaka, I tested after the folder change it works. I'll update to store. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:35 AM, Malaka Silva mal...@wso2.com wrote: Tests ran

Re: [Dev] Review and Merge PR

Merged On Fri, Jun 19, 2015 at 2:15 PM, Elilmatha Sivanesan elilma...@wso2.com wrote: Hi Malaka, Please review and merge the PR for eventbrite and yammer. https://github.com/wso2/esb-connectors/pull/173 Thank you. https://github.com/wso2/esb-connectors/pull/173 -- *S.Elilmatha*

[Dev] Review and merge PR

Hi Malaka, $Subject for Google Calendar connector. Please find the PR below[1]. [1]- https://github.com/wso2/esb-connectors/pull/167 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com

[Dev] Review and merge the PR

Hi Malaka, $Subject for Jira connector. Please fine the PR below[1]. [1] - https://github.com/wso2/esb-connectors/pull/168 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com

Re: [Dev] Review and merge the PR for Shippo connector

Please remove the certificate, Keystore and Truststore On Thu, Jun 18, 2015 at 11:56 AM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, Please find the PR for shippo connector[1]. [1]- https://github.com/wso2/esb-connectors/pull/162 Regards, -- *Naasheer Ali* | Associate Software

Re: [Dev] Review and merge the PR for Shippo connector

Hi Malaka, I have removed the certificate and added the default Keystore and Truststore since those were empty. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Thu, Jun 18, 2015 at 4:51 PM, Malaka Silva

Re: [Dev] Review and merge the PR

Hi Malaka. Yes. there is a folder structure change and I tested manually it works. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:14 AM, Malaka Silva mal...@wso2.com wrote: Why

Re: [Dev] Review and merge PR

Did you change the folder structure? On Thu, Jun 18, 2015 at 5:35 PM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, $Subject for Google Calendar connector. Please find the PR below[1]. [1]- https://github.com/wso2/esb-connectors/pull/167 Regards, -- *Naasheer Ali* | Associate

Re: [Dev] Review and merge the PR

Why there is a folder structure change? On Thu, Jun 18, 2015 at 6:18 PM, Naasheer Ali naashe...@wso2.com wrote: Hi Malaka, $Subject for Jira connector. Please fine the PR below[1]. [1] - https://github.com/wso2/esb-connectors/pull/168 Regards, -- *Naasheer Ali* | Associate Software

Re: [Dev] Review and merge PR

Hi Malaka, Yes, since the folder structure is not properly set and I've tested some methods randomly it works. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:13 AM, Malaka Silva

[Dev] Review and merge the PR for Shippo connector

Hi Malaka, Please find the PR for shippo connector[1]. [1]- https://github.com/wso2/esb-connectors/pull/162 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com ___

[Dev] Review and merge PR

Hi Malaka, Please find the following PR for Redmine https://github.com/wso2/esb-connectors/pull/164 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Review and merge for ESBJAVA-3766 and ESBJAVA-3733

Correction : ESBJAVA-3766 and ESBJAVA-3773 Maheeka Jayasuriya Software Engineer Mobile : +9450661 On Fri, Jun 12, 2015 at 4:51 PM, Maheeka Jayasuriya mahe...@wso2.com wrote: Hi, $subject please. [2] also contains serialization tests. [1]

[Dev] Review and merge for ESBJAVA-3766 and ESBJAVA-3733

Hi, $subject please. [2] also contains serialization tests. [1] https://github.com/wso2/carbon-mediation/pull/214 [2] https://github.com/wso2/wso2-synapse/pull/228 Thanks, Maheeka Jayasuriya Software Engineer Mobile : +9450661 ___ Dev mailing

[Dev] Review and merge PR for integration test

Hi ESB team, Please review and merge the integration test [1] for [2]. [1] https://github.com/wso2/product-esb/pull/181 [2] https://wso2.org/jira/browse/CARBON-15119 -- Best Regards, Kalpa Welivitigoda Software Engineer, WSO2 Inc. http://wso2.com Email: kal...@wso2.com Mobile: +94776509215

Re: [Dev] Review and merge PR for integration test

Merged On Mon, Jun 8, 2015 at 1:59 PM, Kalpa Welivitigoda kal...@wso2.com wrote: Hi ESB team, Please review and merge the integration test [1] for [2]. [1] https://github.com/wso2/product-esb/pull/181 [2] https://wso2.org/jira/browse/CARBON-15119 -- Best Regards, Kalpa Welivitigoda

Re: [Dev] Review and merge PR for integration test

Thanks Malaka. On Mon, Jun 8, 2015 at 3:55 PM, Malaka Silva mal...@wso2.com wrote: Merged On Mon, Jun 8, 2015 at 1:59 PM, Kalpa Welivitigoda kal...@wso2.com wrote: Hi ESB team, Please review and merge the integration test [1] for [2]. [1] https://github.com/wso2/product-esb/pull/181

Re: [Dev] Review and merge JSON Parser in Jaggery

Done. /Ruchira On Mon, Jun 8, 2015 at 4:41 PM, Charitha Goonetilleke charit...@wso2.com wrote: Hi, Please review and merge fix[1] for integer parsing issue in Jaggery HTTP client. [1]https://github.com/wso2/jaggery/pull/123 Thanks, /charithag -- *Charitha Goonetilleke* Software

[Dev] Review and merge PR for APIMANAGER-3663

Hi, Please review and merge PR [1] for Jira [2] [1] https://github.com/wso2/carbon-apimgt/pull/529 [2] https://wso2.org/jira/browse/APIMANAGER-3663 Regards. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter https://twitter.com/KaluMallii | Google+

[Dev] Review and Merge PR

Hi, Please review and merge PR[1] for JIRA[2]. [1] - https://github.com/wso2/carbon-business-process/pull/58 [2] - https://wso2.org/jira/browse/BPS-656 Thank you. Regards, -- Shiva Balachandran Software Engineer WSO2 Inc. Mobile - +94 774445788 Blog -

Re: [Dev] Review and Merge PR

On Wed, May 27, 2015 at 5:10 PM, Shiva Balachandran sh...@wso2.com wrote: Hi, Please review and merge PR[1] for JIRA[2]. [1] - https://github.com/wso2/carbon-business-process/pull/58 [2] - https://wso2.org/jira/browse/BPS-656 Thank you. Regards, -- Shiva Balachandran Software

[Dev] Review and Merge the PRs

Hi, The JIRA issue [1] is fixed. The PRs for carbon-apimgt and product-apim are in [2] and [3] respectively. Please $Subject. [1]https://wso2.org/jira/browse/APIMANAGER-2854 [2] https://github.com/wso2/carbon-apimgt/pull/445 [3] https://github.com/wso2/product-apim/pull/175 -- Thanks

Re: [Dev] Review and merge PR APIMANAGER-3550

OK, What if ON_HOLD subscription was blocked through API Publisher before it get approved via admin-workflow? Even it's blocked, I guess, admin can approve or reject the subscription. That will be the staus of the subscription. Depends on the order of execution whether admin-workflow or API

Re: [Dev] Review and merge PR APIMANAGER-3550

Then fine. I haven't tested this. On Tue, May 19, 2015 at 12:19 PM, Kasun Gunasekara kas...@wso2.com wrote: Block is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be

Re: [Dev] Review and merge PR APIMANAGER-3550

Block is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be disappeared from the publisher. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Abimaran, I noticed that earlier. But ON_HOLD status is already handled in API Publisher using a tip saying that the subscription is pending for approval. Does it still has to be removed? If yes I will do the necessary changes. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Kasun, Following are status' of API subscription public static class SubscriptionStatus { public static final String BLOCKED = BLOCKED; public static final String PROD_ONLY_BLOCKED = PROD_ONLY_BLOCKED; public static final String UNBLOCKED = UNBLOCKED; public static final

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Kasun, What is the status of this issue? On Wed, May 13, 2015 at 4:55 PM, Kasun Gunasekara kas...@wso2.com wrote: Hi Abimaran, I checked on this and found out that API Provider's Subscriptions page uses getAllAPIUsageByProvider() to load subscriptions and I have only changed

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Abimaran, I had some misunderstanding about the issue and the earlier PR was for the API Store. Did revert the earlier commit and updated the PR with relevant changes to the API Publisher. Please review and merge PR[1] [1] https://github.com/wso2/carbon-apimgt/pull/383 Kasun Gunasekara

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Kasun, In the Subscription page of the API Publisher, We have to show, BLOCKED, UNBLOCKED API Subscription. But, with this pull request, you made changes to list on the UNBLOCKED API Subscription. It we don't show the BLOCKED API Subscription, we won't be able to unblock them through the

[Dev] Review and merge PR APIMANAGER-3550

Hi, Please review and merge PR [1] for jira [2]. [1] https://github.com/wso2/carbon-apimgt/pull/383 [2] https://wso2.org/jira/browse/APIMANAGER-3550 Regards. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter https://twitter.com/KaluMallii | Google+

Re: [Dev] Review and merge PR APIMANAGER-3550

Hi Abimaran, I checked on this and found out that API Provider's Subscriptions page uses getAllAPIUsageByProvider() to load subscriptions and I have only changed getPaginatedSubscribedAPIs() which is used by API Store. This change doesn't affect API Provider as far as I understand. Kasun

[Dev] Review and merge the pull request

Hi, Please $subject [1] for the Jira [2]. [1] - https://github.com/wso2/carbon-business-process/pull/41 [2] - https://wso2.org/jira/browse/BPS-470 -- Vinod Kavinda Software Engineer, *WSO2, Inc http://www.wso2.com.* Mobile : +94 (0) 712 415544 vi...@wso2.com

[Dev] Review and merge

Hi, A fix for https://wso2.org/jira/browse/IDENTITY-3105 is available at https://github.com/wso2/carbon-commons/pull/81. Please review and merge the request. -- *-Damith Senanayake-* +94712205272 ___ Dev mailing list Dev@wso2.org

[Dev] Review and merge

Hi Please review and merge the PR[1] [1] https://github.com/wso2/carbon-identity/pull/203 Thanks Godwin -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D http://lnkd.in/KUum6D*

[Dev] Review and merge

Hi Abimaran, Please $subject for the PR[1] for the issue[2] [1] - https://github.com/wso2/carbon-apimgt/pull/54/ [2] - https://wso2.org/jira/browse/APIMANAGER-3281 ​Thanks,​ -- *Madusanka Premaratne* | Associate Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove,

Re: [Dev] Review and merge

Hi Madusanka, It's merged. On Mon, Mar 9, 2015 at 9:57 AM, Madusanka Premaratne madusan...@wso2.com wrote: Hi Abimaran, Please $subject for the PR[1] for the issue[2] [1] - https://github.com/wso2/carbon-apimgt/pull/54/ [2] - https://wso2.org/jira/browse/APIMANAGER-3281 ​Thanks,​ --

Re: [Dev] Review and merge the PR for WSAS-1907

Merged the PR. thanks, On Thu, Mar 5, 2015 at 12:26 PM, Shashika Karunatilaka shashi...@wso2.com wrote: Hi Supun Updated the PR[1] accordingly [1] https://github.com/wso2/product-as/pull/49 On Wed, Mar 4, 2015 at 8:02 PM, Supun Malinga sup...@wso2.com wrote: Hi Shashika, Let's add

Re: [Dev] Review and merge the PR for WSAS-1907

Hi Supun Updated the PR[1] accordingly [1] https://github.com/wso2/product-as/pull/49 On Wed, Mar 4, 2015 at 8:02 PM, Supun Malinga sup...@wso2.com wrote: Hi Shashika, Let's add the features into default and worker profile as well.. thanks, On Wed, Mar 4, 2015 at 5:03 PM, Shashika

Re: [Dev] Review and merge the PR for WSAS-1907

Hi Shashika, Let's add the features into default and worker profile as well.. thanks, On Wed, Mar 4, 2015 at 5:03 PM, Shashika Karunatilaka shashi...@wso2.com wrote: Hi, Please review and merge the PR [1] for [2]. [1] https://github.com/wso2/product-as/pull/49 [2]

[Dev] - Review and merge the pull request - Removed duplicated dependencies in product -greg 5.0.0-SNAPSHOT pom file

Hi, Please merge the pull request [1]. JIRA - https://wso2.org/jira/browse/REGISTRY-2376 [1] - https://github.com/wso2-dev/product-greg/pull/61 Thanks -- Prasanna Dangalla Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware cell: +94 777 55 80 30 | +94 718 11 27 51

[Dev] Review and merge the pull request - Changed 4.3.0 management console documentation link from 4.2.0 to 4.3.0

Hi Carbon team, Please merge the pull request [1]. JIRA - https://wso2.org/jira/browse/CARBON-15120 [1] - https://github.com/wso2/carbon4-kernel/pull/126 Thanks -- Prasanna Dangalla Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware cell: +94 777 55 80 30 | +94 718

Re: [Dev] Review and merge carbon business process #21

Hi Firzhan, Isn't it a good idea to completely delete the lines you have commented out in 'components/bpmn/org.wso2.carbon.bpmn/src/main/java/org/wso2/carbon/bpmn/core/db/Database.java' file if they are not necessary? Or else I think it's better to add a comment why you have commented out those,

Re: [Dev] Review and merge carbon business process #21

Hi Akalanka, I have updated the pull request with your suggestions. Regards, Firzhan On Tue, Nov 11, 2014 at 8:33 AM, Akalanka Pagoda Arachchi darsha...@wso2.com wrote: Hi Firzhan, Isn't it a good idea to completely delete the lines you have commented out in

[Dev] Review and merge orbit #17

Hi Nandika, Can you please merge pull request[1].This contains the orbit bundles for Activiti Engine and Activiti Rest API. [1] https://github.com/wso2/orbit/pull/17 Thanks Waruna -- Regards, Waruna Lakshitha Jayaweera Software Engineer WSO2 Inc; http://wso2.com phone: +94713255198

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

adding Prabath On Wed, Jun 4, 2014 at 3:30 PM, Rajith Vitharana raji...@wso2.com wrote: H, Although repo maintainers receive email when ever pull request is sent, I think it would be great if we can maintain a document for this. Thanks, On Wed, Jun 4, 2014 at 11:30 AM, Kasun Gajasinghe

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

On Wed, Jun 4, 2014 at 8:56 AM, Rajith Vitharana raji...@wso2.com wrote: Hi Kasun, Sorry for the inconvenience. Is there any document stating the relevant repo maintainers for each Git repo? Not as I know of. But we should create one. Whenever you send a pull request, the repo maintainers

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

H, Although repo maintainers receive email when ever pull request is sent, I think it would be great if we can maintain a document for this. Thanks, On Wed, Jun 4, 2014 at 11:30 AM, Kasun Gajasinghe kas...@wso2.com wrote: On Wed, Jun 4, 2014 at 8:56 AM, Rajith Vitharana raji...@wso2.com

[Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

Hi, Please do $subject for [1] and [2] [1] https://github.com/wso2-dev/carbon-utils/pull/1 [2] https://github.com/wso2-dev/carbon-storage-management/pull/1 Thanks -- Rajith Vitharana Software Engineer, WSO2 Inc. : wso2.com Mobile : +94715883223 Blog : http://lankavitharana.blogspot.com/

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

Hi Rajith, I cannot merge changes to carbon-storage-management. Please contact the relevant repo maintainers. Can you explain the reason for your PR [1]? Thanks, KasunG On Tue, Jun 3, 2014 at 6:37 PM, Rajith Vitharana raji...@wso2.com wrote: Hi, Please do $subject for [1] and [2] [1]

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

Hi Kasun, Sorry for the inconvenience. Is there any document stating the relevant repo maintainers for each Git repo? The PR [1] is there because org.wso2.carbon.reporting.feature is needed in BAM. Thanks, On Tue, Jun 3, 2014 at 7:24 PM, Kasun Gajasinghe kas...@wso2.com wrote: Hi Rajith,