Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-26 Thread Sriskandarajah Suhothayan
Sent a pull request with the changes Thanks Suho On Tue, Mar 25, 2014 at 1:59 PM, Kasun Gajasinghe kas...@wso2.com wrote: Hi Suho, Created main and team repos for wso2-wsdl4j. Please send the PR to team repo at [1] [1] https://github.com/wso2/wso2-wsdl4j On Tue, Mar 25, 2014 at

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-26 Thread Kasun Gajasinghe
Merged the changes. On Wed, Mar 26, 2014 at 12:04 PM, Sriskandarajah Suhothayan s...@wso2.comwrote: Sent a pull request with the changes Thanks Suho On Tue, Mar 25, 2014 at 1:59 PM, Kasun Gajasinghe kas...@wso2.com wrote: Hi Suho, Created main and team repos for wso2-wsdl4j. Please

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-25 Thread Kasun Gajasinghe
Hi Suho, Created main and team repos for wso2-wsdl4j. Please send the PR to team repo at [1] [1] https://github.com/wso2/wso2-wsdl4j On Tue, Mar 25, 2014 at 10:46 AM, Sriskandarajah Suhothayan s...@wso2.comwrote: Hi Sagara/Geeth/KasunG, Can one of you create the wso2-wsdl4j repo please.

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Sagara Gunathunga
Hi Suho, I'm sorry to point out this issue at this stage but I think you need to provide two separate patches as follows. 1. First patch with original source code without any modification just to bring WSDL4J code under our source repo. 2. Separate patch only with your modification. If we

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Manoj Kumara
Hi, I commented out that because it was referring to older version pom file. Corrected the version and added the fix with 198916. Sorry about the trouble. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Sun, Mar

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Sriskandarajah Suhothayan
Thanks for pointing it out. I'll also add those patches to the Jira. So it will be helpful. Suho On Mon, Mar 24, 2014 at 6:06 PM, Sagara Gunathunga sag...@wso2.com wrote: Hi Suho, I'm sorry to point out this issue at this stage but I think you need to provide two separate patches as

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Sriskandarajah Suhothayan
Attached the wsdl4j 1.6.3 source and the custom patch over the wsdl4j 1.6.3 source. Thanks Suho On Mon, Mar 24, 2014 at 7:24 PM, Sriskandarajah Suhothayan s...@wso2.comwrote: Thanks for pointing it out. I'll also add those patches to the Jira. So it will be helpful. Suho On Mon, Mar

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Manoj Kumara
Hi, Added the new version upgrade under r198956 and merged the changes under r198957. Thanks for pointing out. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Mon, Mar 24, 2014 at 8:28 PM, Sriskandarajah

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Manoj Kumara
Hi Suho, Please add the changes to the relevant git wso2-dev repo. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Tue, Mar 25, 2014 at 9:52 AM, Manoj Kumara ma...@wso2.com wrote: Hi, Added the new version

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-24 Thread Sriskandarajah Suhothayan
Hi Sagara/Geeth/KasunG, Can one of you create the wso2-wsdl4j repo please. So that I can send the pull request. Thanks Suho On Tue, Mar 25, 2014 at 9:54 AM, Manoj Kumara ma...@wso2.com wrote: Hi Suho, Please add the changes to the relevant git wso2-dev repo. Thanks, Manoj *Manoj

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-23 Thread Manoj Kumara
Reverting this with r198904 due to build unstable on service stubs. Please have a look. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, Mar 21, 2014 at 5:14 PM, Sriskandarajah Suhothayan s...@wso2.comwrote:

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-23 Thread Sriskandarajah Suhothayan
I found the patch was not properly applied, where due to some reason the parent element of the wsdl4j orbit has been commented out. carbon/kernel/branches/4.2.0/patches/patch0006/dependencies/orbit/wsdl4j/1.6.2.wso2v4/pom.xml +!--parent-- +!--groupIdorg.wso2.carbon/groupId-- +

[Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Sriskandarajah Suhothayan
Please commit the path to resolve $Subject[1] Thanks Suho [1]https://wso2.org/jira/browse/CARBON-14742 -- *S. Suhothayan* Associate Technical Lead, *WSO2 Inc. *http://wso2.com * http://wso2.com/* lean . enterprise . middleware *cell: (+94) 779 756 757 | blog:

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Manoj Kumara
Hi Suho, Can you please attach only the diff relevant to your change plus changes on bin.xml. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, Mar 21, 2014 at 12:50 PM, Sriskandarajah Suhothayan

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Manoj Kumara
Hi Suho, Since this is an dependency version upgrade there can be API changes on the new version. Since the patch need to be compatible with all the 4.2.0 released products can you please check for any possible case. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Sriskandarajah Suhothayan
There are no API changes from wsdl4j 1.6.2 to 1.6.3. Hence there wont be any compatibility issues Suho On Fri, Mar 21, 2014 at 3:04 PM, Manoj Kumara ma...@wso2.com wrote: Hi Suho, Since this is an dependency version upgrade there can be API changes on the new version. Since the patch need

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Manoj Kumara
Hi, Added to committed to patch0006 with r198836. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, Mar 21, 2014 at 4:39 PM, Sriskandarajah Suhothayan s...@wso2.comwrote: There are no API changes from wsdl4j

Re: [Dev] Fixing kernel to properly read WSDL namespaces

2014-03-21 Thread Sriskandarajah Suhothayan
Thanks Suho On Fri, Mar 21, 2014 at 5:06 PM, Manoj Kumara ma...@wso2.com wrote: Hi, Added to committed to patch0006 with r198836. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/ *lean.enterprise.middleware* Mobile: +94713448188 On Fri, Mar 21, 2014 at