Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-19 Thread Abimaran Kugathasan
OK, What if ON_HOLD subscription was blocked through API Publisher before it get approved via admin-workflow? Even it's blocked, I guess, admin can approve or reject the subscription. That will be the staus of the subscription. Depends on the order of execution whether admin-workflow or API

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-19 Thread Abimaran Kugathasan
Then fine. I haven't tested this. On Tue, May 19, 2015 at 12:19 PM, Kasun Gunasekara kas...@wso2.com wrote: Block is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-19 Thread Kasun Gunasekara
Block is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be disappeared from the publisher. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Kasun Gunasekara
Hi Abimaran, I noticed that earlier. But ON_HOLD status is already handled in API Publisher using a tip saying that the subscription is pending for approval. Does it still has to be removed? If yes I will do the necessary changes. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Abimaran Kugathasan
Hi Kasun, Following are status' of API subscription public static class SubscriptionStatus { public static final String BLOCKED = BLOCKED; public static final String PROD_ONLY_BLOCKED = PROD_ONLY_BLOCKED; public static final String UNBLOCKED = UNBLOCKED; public static final

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-15 Thread Abimaran Kugathasan
Hi Kasun, What is the status of this issue? On Wed, May 13, 2015 at 4:55 PM, Kasun Gunasekara kas...@wso2.com wrote: Hi Abimaran, I checked on this and found out that API Provider's Subscriptions page uses getAllAPIUsageByProvider() to load subscriptions and I have only changed

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-15 Thread Kasun Gunasekara
Hi Abimaran, I had some misunderstanding about the issue and the earlier PR was for the API Store. Did revert the earlier commit and updated the PR with relevant changes to the API Publisher. Please review and merge PR[1] [1] https://github.com/wso2/carbon-apimgt/pull/383 Kasun Gunasekara

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Abimaran Kugathasan
Hi Kasun, In the Subscription page of the API Publisher, We have to show, BLOCKED, UNBLOCKED API Subscription. But, with this pull request, you made changes to list on the UNBLOCKED API Subscription. It we don't show the BLOCKED API Subscription, we won't be able to unblock them through the

[Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Kasun Gunasekara
Hi, Please review and merge PR [1] for jira [2]. [1] https://github.com/wso2/carbon-apimgt/pull/383 [2] https://wso2.org/jira/browse/APIMANAGER-3550 Regards. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter https://twitter.com/KaluMallii | Google+

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Kasun Gunasekara
Hi Abimaran, I checked on this and found out that API Provider's Subscriptions page uses getAllAPIUsageByProvider() to load subscriptions and I have only changed getPaginatedSubscribedAPIs() which is used by API Store. This change doesn't affect API Provider as far as I understand. Kasun