Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Created new pull request with necessary changes[1]. please review and merge. [1]https://github.com/wso2/carbon-messaging/pull/41 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *Link

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, I modified the Carbon-Messaging according to the requirements. Please review and merge. https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Mi

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi, Fixed the issues mentioned. Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/ir

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi Senduran, Yes. We can use a general control message type instead of ping and pong messages. So I removed ping and pong carbon message types from Carbon-Messaging and added new message type ". Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc.

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Can you please review and merge the PR? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mob

[Dev] Fixed the Issue with Testng Configurations

Hi all, There was a problem with testng is not aware of the test classes configured in the testng.xml. Please find the following PR fixing the problem. Please review and merge. https://github.com/wso2/carbon-transports/pull/226 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc

[Dev] Test Cases for WebSocket in Carbon-Transport

Hi all, Please review the PR and give feedback. https://github.com/wso2/carbon-transports/pull/223 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/ir

Re: [Dev] WSO2 Committers += Nisala Nanayakkara

Congratulations Nisala *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middlew

Re: [Dev] WSO2 Committers += Shan Mahanama

Congratulations Shan!!! Best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunikaw <https://lk.linkedin.com/in/irunikaw>* *Mobile : +94712403314*

Re: [Dev] WSO2 Committers += Malintha Fernando

Congratulations Malintha!!! Best Regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunikaw <https://lk.linkedin.com/in/irunikaw>* *Mobile : +

[Dev] Carbon-Messaging for WebSocket Protocol

. So with the existing implementation is it necessary to call Callback.done() method? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://

Re: [Dev] Carbon-Messaging for WebSocket Protocol

K thanks. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* O

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, I did necessary changes after the review. Please review and merge https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Mi

[Dev] PR of Client Connector for WebSocket

Hi all, Please review and comment on the $subject. https://github.com/wso2/carbon-transports/pull/260 Thanks and best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.

[Dev] PR - WebSocket Server Connector Support for Ballerina

Hi, Please review the PR and comment. https://github.com/ballerinalang/ballerina/pull/2210 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://

Re: [Dev] MSF4J Websocket security token transmit

Hi Godwin, IMHO the best way to do it using HTTP header. Are you using netty directly? If that so there is a way to add necessary headers for the initial handshake and we can check them in the server side. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.

Re: [Dev] MSF4J Websocket security token transmit

;>> Hi >>> What would be solution if we are to initiate the connection from the >>> browser itself, AFAIK websocket library for browsers does not support >>> adding headers. >>> >>> Thanks, >>> >>> *Ayyoob Hamza* >>> *Sen

[Dev] Changes for carbon-transport release-4.3.0-m1

nch and do a milestone release for now? WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +947

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Thanks Vidura. Will check. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Mi

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* O

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* O

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

Hi all, Please review the new changes did and comment. https://github.com/wso2/msf4j/pull/364 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/ir

Re: [Dev] Modifying Carbon-Messaging Client Connector

someone needs a return object user can cast it and use. eg: Object init(CarbonMessage cMsg, Map<String, Object> properties); WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *Link

Re: [Dev] Should we refactor CarbonMessage

override the methods in default carbon message if in order to work with default scenarios. WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/ir

Re: [Dev] Modifying Carbon-Messaging Client Connector

Adding Amjadh and Arshardh *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Mi

[Dev] Modifying Carbon-Messaging Client Connector

for client connector and also it is better to return an object in "send methods" other than a boolean so it will reduce the complications for other protocol basis work. WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun..

Re: [Dev] Changes for carbon-transport release-4.3.0-m1

e continue this way. Can we please discuss on how we should proceed further since some work seems stuck with this issue? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin

[Dev] Please Review and Merge (WebSocket Client Connector)

Hi, Please review and merge this PR. https://github.com/wso2/carbon-transports/pull/287 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://

Re: [Dev] Setup the WebSocket security in msf4j WebSocket server

Hi Sivaramya, In MSF4J HTTPS working. Since HTTP and WS use the same server connector configuration for WS too. Which means if HTTPS is configured when running MSF4J then WSS also working. @Danesh can please you provide the specifics? :) Thanks, Irunika *Irunika Weeraratne* *Software Engineer