Re: [Dev] MSS helloworld sample can't build in clean repo

Hi Azeez, Please review and merge the fix for the above issue [1]. [1]. https://github.com/wso2/product-mss/pull/60 Regards, Aruna On Fri, Nov 13, 2015 at 12:00 PM, Aruna Karunarathna wrote: > > > On Fri, Nov 13, 2015 at 11:55 AM, Kalpa Welivitigoda > wrote:

Re: [Dev] MSS helloworld sample can't build in clean repo

On Fri, Nov 13, 2015 at 11:55 AM, Kalpa Welivitigoda wrote: > Hi Aruna, > > On Fri, Nov 13, 2015 at 11:48 AM, Aruna Karunarathna > wrote: > >> So to overcome this issue, we will follow the following approach. >> >> Create a separate module called mss-parent and

Re: [Dev] MSS helloworld sample can't build in clean repo

So to overcome this issue, we will follow the following approach. Create a separate module called mss-parent and move all the dependencies and plugins management to that mss-parent's pom.xml from the product-mss's root pom.xml. Keep only the build plugins in the product-mss's root pom.xml. Refer

Re: [Dev] MSS helloworld sample can't build in clean repo

Hi Aruna, On Fri, Nov 13, 2015 at 11:48 AM, Aruna Karunarathna wrote: > So to overcome this issue, we will follow the following approach. > > Create a separate module called mss-parent and move all the dependencies > and plugins management to that mss-parent's pom.xml from the

Re: [Dev] MSS helloworld sample can't build in clean repo

On Wed, Nov 11, 2015 at 7:01 PM, Afkham Azeez wrote: > > On Wed, Nov 11, 2015 at 1:46 AM, Nirmal Fernando wrote: > >> Do sample poms need a parent at all (if everything is in the maven >> central)? IMO they should be self contained. >> > > +1 . Kernel team can

Re: [Dev] MSS helloworld sample can't build in clean repo

BTW, AS sample having a sample parent pom is wrong. Samples are there to guide the user how to write his own stuff. The user will not extend a sample parent pom from AS, so IMO it is wrong to have it in that manner in AS. On Wed, Nov 11, 2015 at 12:49 AM, Aruna Karunarathna

Re: [Dev] MSS helloworld sample can't build in clean repo

Do sample poms need a parent at all (if everything is in the maven central)? IMO they should be self contained. On a related note; License year is missing https://github.com/wso2/product-mss/blob/release-1.0.0-alpha/samples/helloworld/pom.xml#L3 On Wed, Nov 11, 2015 at 3:07 PM, Afkham Azeez

Re: [Dev] MSS helloworld sample can't build in clean repo

On Wed, Nov 11, 2015 at 1:10 PM, Afkham Azeez wrote: > Can we push that pom to Maven central? > Will that solve the problem?. AFAIU pushing mss-service-parent pom to maven central won't solve the problem, as per the inheritance tree we have to push the org.wso2.carbon.mss.parent

Re: [Dev] MSS helloworld sample can't build in clean repo

Then, can we add the repository to the mss-service-parent and push it to the Maven central? On Wed, Nov 11, 2015 at 2:19 PM, Aruna Karunarathna wrote: > > > On Wed, Nov 11, 2015 at 1:10 PM, Afkham Azeez wrote: > >> Can we push that pom to Maven central? >> > >

Re: [Dev] MSS helloworld sample can't build in clean repo

On Wed, Nov 11, 2015 at 1:46 AM, Nirmal Fernando wrote: > Do sample poms need a parent at all (if everything is in the maven > central)? IMO they should be self contained. > +1 . Kernel team can you please push the released POMs to Maven central? > > On a related note; License

Re: [Dev] MSS helloworld sample can't build in clean repo

In the samples, we are showing the user how to write their own microservice. We can't show them a sample pom that extends a sample parent. Then we are asking users to write microservices one way and we are writing them another way. Push all the relevant poms to maven central. 2 objectives, 1.

Re: [Dev] MSS helloworld sample can't build in clean repo

+1 for pushing the pom to Maven central. That will provide transparent access to all required artifacts and make the MSS project building very easy. On Wed, Nov 11, 2015 at 1:10 PM, Afkham Azeez wrote: > Can we push that pom to Maven central? > > On Tue, Nov 10, 2015 at 11:31

[Dev] MSS helloworld sample can't build in clean repo

Without building the product-mss repo, can't build the helloworld sample. [1] After adding the wso2-nexus repo was able to build. I think we need to mention in the docs for alpha release and fix this properly in next release. Following changes required to build in clean repo. 1. Remove the

Re: [Dev] MSS helloworld sample can't build in clean repo

Since we are extending from the wso2 pom, don't we automatically inherit the repo? On Tue, Nov 10, 2015 at 11:06 PM, Aruna Karunarathna wrote: > Without building the product-mss repo, can't build the helloworld sample. > [1] > > After adding the wso2-nexus repo was able to

Re: [Dev] MSS helloworld sample can't build in clean repo

On Wed, Nov 11, 2015 at 12:40 PM, Afkham Azeez wrote: > Since we are extending from the wso2 pom, don't we automatically inherit > the repo? > Yes, for the git repository it does. But the sample inside the distribution there is no inheritance. > On Tue, Nov 10, 2015 at 11:06

Re: [Dev] MSS helloworld sample can't build in clean repo

sample pom --> mss-service-parent-pom --> mss-parent-pom -> wso2-pom So, sample pom should inherit the WSO2 repo right? On Tue, Nov 10, 2015 at 11:13 PM, Aruna Karunarathna wrote: > > > On Wed, Nov 11, 2015 at 12:40 PM, Afkham Azeez wrote: > >> Since we are

Re: [Dev] MSS helloworld sample can't build in clean repo

On Wed, Nov 11, 2015 at 12:46 PM, Afkham Azeez wrote: > sample pom --> mss-service-parent-pom --> mss-parent-pom -> wso2-pom > > So, sample pom should inherit the WSO2 repo right? > Yes. the above inheritance is correct. But when building the sample, AFAIU the following

Re: [Dev] MSS helloworld sample can't build in clean repo

Can we push that pom to Maven central? On Tue, Nov 10, 2015 at 11:31 PM, Aruna Karunarathna wrote: > > > On Wed, Nov 11, 2015 at 12:46 PM, Afkham Azeez wrote: > >> sample pom --> mss-service-parent-pom --> mss-parent-pom -> wso2-pom >> >> So, sample pom should