zjffdu commented on pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#issuecomment-782992021
Thanks for the contribution @Kimahriman Is doc here needs to be updated ?
http://zeppelin.apache.org/docs/0.9.0/setup/security/shiro_authentication.html#knox-sso
asfgit closed pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826989
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##
@@ -247,6 +248,9 @@ public boolean
Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826864
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##
@@ -138,8 +139,8 @@ private String
Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826741
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealm.java
##
@@ -241,7 +228,6 @@ protected AuthorizationInfo
Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826676
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/realm/jwt/KnoxJwtRealm.java
##
@@ -83,14 +78,6 @@
@Override
protected void
Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826527
##
File path: conf/shiro.ini.template
##
@@ -66,8 +66,6 @@ user3 = password4, role2
#knoxJwtRealm.cookieName = hadoop-jwt
Kimahriman opened a new pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059
### What is this PR for?
This PR aims to add support for Knox groups in
ShiroAuthenticationService.getAssociatedRoles. This allows Knox realm groups
(which uses hadoop groups under the hood)
Adam Binford created ZEPPELIN-5258:
--
Summary: Add Knox realm support to
ShiroAuthenticationService.getAssociatedRoles
Key: ZEPPELIN-5258
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5258
zjffdu opened a new pull request #4058:
URL: https://github.com/apache/zeppelin/pull/4058
### What is this PR for?
This PR is to refactoring ExecutionContext: move its creation to `Note`,
because most of fields of ExecutionContext is from Note. Moving it to `Note`
10 matches
Mail list logo