[GitHub] [zeppelin] asfgit closed pull request #4055: [ZEPPELIN-5078] Make it possible to cancel "run all paragraphs" operation

2021-02-22 Thread GitBox
asfgit closed pull request #4055: URL: https://github.com/apache/zeppelin/pull/4055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (ZEPPELIN-5260) nNotebook functionalities(like run paragraphs, add a new paragraph, reset interpreters) become unusable, when code completion is used

2021-02-22 Thread jahira ibrahim (Jira)
jahira ibrahim created ZEPPELIN-5260: Summary: nNotebook functionalities(like run paragraphs, add a new paragraph, reset interpreters) become unusable, when code completion is used Key: ZEPPELIN-5260 URL:

[GitHub] [zeppelin] smiklosovic commented on pull request #4057: [ZEPPELIN-4843] - Fix search in Elasticsearch interpreter

2021-02-22 Thread GitBox
smiklosovic commented on pull request #4057: URL: https://github.com/apache/zeppelin/pull/4057#issuecomment-783599619 hi @zjffdu , I have fixed my errors, it was about Javadoc being longer tha 120 chars (something like that). I do not know how to influence other modules. It seems that

[GitHub] [zeppelin] Reamer opened a new pull request #4060: [ZEPPELIN-5259] Use RemoteInterpreterManagedProcess for K8sRemoteInterpreterProcess

2021-02-22 Thread GitBox
Reamer opened a new pull request #4060: URL: https://github.com/apache/zeppelin/pull/4060 ### What is this PR for? This PR changes the parent class for K8sRemoteInterpreterProcess to RemoteInterpreterManagedProcess. It also contains some bug fixes. I removed the static method

[jira] [Created] (ZEPPELIN-5259) Use RemoteInterpreterManagedProcess for K8sRemoteInterpreterProcess

2021-02-22 Thread Philipp Dallig (Jira)
Philipp Dallig created ZEPPELIN-5259: Summary: Use RemoteInterpreterManagedProcess for K8sRemoteInterpreterProcess Key: ZEPPELIN-5259 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5259

[GitHub] [zeppelin] Reamer commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

2021-02-22 Thread GitBox
Reamer commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r580367427 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ## @@ -247,6 +248,9 @@ public boolean

[GitHub] [zeppelin] zjffdu commented on pull request #4057: [ZEPPELIN-4843] - Fix search in Elasticsearch interpreter

2021-02-22 Thread GitBox
zjffdu commented on pull request #4057: URL: https://github.com/apache/zeppelin/pull/4057#issuecomment-783450290 @smiklosovic CI is failed This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] zjffdu commented on pull request #4058: [ZEPPELIN-5257] Refactoring of ExecutionContext

2021-02-22 Thread GitBox
zjffdu commented on pull request #4058: URL: https://github.com/apache/zeppelin/pull/4058#issuecomment-783412736 @Reamer The reason of moving `ExecutionContext` to `Note` is that `Note` is the only place to create `ExecutionContext`, and it makes sense because `ExecutionContext` should

[GitHub] [zeppelin] smiklosovic commented on pull request #4057: [ZEPPELIN-4843] - Fix search in Elasticsearch interpreter

2021-02-22 Thread GitBox
smiklosovic commented on pull request #4057: URL: https://github.com/apache/zeppelin/pull/4057#issuecomment-783315201 @zjffdu I have added javadoc and squashed the changes into 1 commit. Please review and eventually merge.

[GitHub] [zeppelin] Kimahriman commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

2021-02-22 Thread GitBox
Kimahriman commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r580175872 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ## @@ -247,6 +248,9 @@ public boolean

[GitHub] [zeppelin] Kimahriman commented on pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

2021-02-22 Thread GitBox
Kimahriman commented on pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#issuecomment-783305421 > Thanks for the contribution @Kimahriman Is doc here needs to be updated ? http://zeppelin.apache.org/docs/0.9.0/setup/security/shiro_authentication.html#knox-sso

[GitHub] [zeppelin] smiklosovic commented on pull request #4057: [ZEPPELIN-4843] - Fix search in Elasticsearch interpreter

2021-02-22 Thread GitBox
smiklosovic commented on pull request #4057: URL: https://github.com/apache/zeppelin/pull/4057#issuecomment-783299690 @Reamer btw, the transport client is becoming obsolete these days, if you check e.g. spring data for elasticsearch they are already marking it as obsolete, maybe a ticket

[GitHub] [zeppelin] Reamer commented on a change in pull request #4059: [ZEPPELIN-5258] Add Knox realm group lookup to shiro auth service

2021-02-22 Thread GitBox
Reamer commented on a change in pull request #4059: URL: https://github.com/apache/zeppelin/pull/4059#discussion_r580088979 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ## @@ -247,6 +248,9 @@ public boolean

[GitHub] [zeppelin] Reamer commented on pull request #4058: [ZEPPELIN-5257] Refactoring of ExecutionContext

2021-02-22 Thread GitBox
Reamer commented on pull request #4058: URL: https://github.com/apache/zeppelin/pull/4058#issuecomment-783221407 In general, I like the builder pattern for `ExecutionContext` and also final as a keyword for attributes in `ExecutionContext`. I also think that binding the

[GitHub] [zeppelin] Reamer commented on pull request #4057: [ZEPPELIN-4843] - Fix search in Elasticsearch interpreter

2021-02-22 Thread GitBox
Reamer commented on pull request #4057: URL: https://github.com/apache/zeppelin/pull/4057#issuecomment-783202465 Maybe it's time to update our Elasticsearch library. We are currently using [2.4.3](https://github.com/apache/zeppelin/blob/master/elasticsearch/pom.xml#L37), which was