[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 Thanks for the contribution @wishwisdom. It's unclear in the screenshots because you used the old version of zeppelin for the `before` screenshot. Could you update it? --- If your

[GitHub] zeppelin issue #2541: [ZEPPELIN-2865] upgrade Beam interpreter to latest ver...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2541 Thanks for the contribution. Could you check the failed job? - https://travis-ci.org/XuMingmin/zeppelin/jobs/264931044 --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 I didn't mean both. Just gave an opinion. Personally, I don't believe that reviewer only can reply `LGTM` or `NO`. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2526 I saw that people were asking there is this kind of permission. - https://stackoverflow.com/questions/43971836/how-do-i-set-permissions-to-a-zeppelin-note-to-be-able-to-execute

[GitHub] zeppelin issue #2528: ZEPPELIN-2834 Show Interpreter list as expand collapse...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2528 Thanks for the contribution. Really nice and useful feature. I guess you introduced new property `isExpanded` in setting. It would be nice to include newly added the property in existing

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 @tinkoff-dwh Thanks for the update. In feature and code level, it's good. But personally, I hope we can get improved UI. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 1. Let's expose the config using REST API we already have. - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/rest_api/configuration.html#configuration-rest-api-list 2. Check

[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 Hi @agura I guess you didn't setup travis CI for the forked repository. - https://builds.apache.org/job/zeppelin-pull-request/2647/console ![image](https://user

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Then, I think we need to hide when cookie manager is disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2512 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm Merged to master. Thanks for the contribution again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 @agura Hi, you don't need to setup CI on your laptop. 1. Signup travis-ci.org 2. Change your repository incubator-zeppelin to `zeppelin`: https://github.com/agura?tab=repositories

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2416 @bhavintandel I haven't checked this can be merged into the 0.7 branch. But if there is no problem to merge, and we can include this PR in 0.7.3 - even if there's conflict, we can create

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2416 @yu74n Could you resolve conflict and check my last comment? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2512 I missed the notification for a while. Sorry for the late response. Let me check and reply ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2478 This is a new feature that makes utilizing graph type easily. Any other opinions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2517: Zeppelin-2835 add ssl doco

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2517 LGTM, merge if no more discussion. I refered https://github.com/apache/zeppelin/pull/2238/files --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 CI passed https://travis-ci.org/nokia/zeppelin/builds/256876805 merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 LGTM merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 Great! LGTM, let's merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2510: [ZEPPELIN-2756] Support ansi escape code for colorizin...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2510 @zjffdu is right. This is based on #2474 as described in the PR description. Please review last 2 commits except for @zjffdu's commits. - 80ecfba - dd97d00 --- If your project

[GitHub] zeppelin issue #2510: [ZEPPELIN-2756] Support ansi escape code for colorizin...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2510 CI failed, but irrelevant. The error is related with Ipython which is going on #2510 - https://api.travis-ci.org/jobs/259230939/log.txt?deansi=true ``` Results

[GitHub] zeppelin pull request #2510: [ZEPPELIN-2756] Support ansi escape code for co...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2510 [ZEPPELIN-2756] Support ansi escape code for colorizing output in browser ### What is this PR for? Support ANSI escape code for colorizing output in browser using [ansi-up](https

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh It's the default binding in emacs mode. ## in default modes https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts ![image](https://user

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409 , Could you check https://github.com/apache/zeppelin/pull/2505? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Thanks. I updated the previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 I don't have a preference, but in my experience, many web apps rely on the browser provided remember-me feature. Here is an example of Github sign-in page - https://github.com/login

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 I see. thanks for the answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm cursor is still thick. Should I missing something? or.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh 1. I realized that `CTRL+F` is bound to `Moving cursor` in paragraphs. Can we use `CTRL + OPT + F` (`ALT` in case of windows OS) or another key what you think better

[GitHub] zeppelin issue #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs from bo...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2469 Will be handled later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs ...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh Thank you for the update. 1. Can we add the shortcut into ![image](https://user-images.githubusercontent.com/4968473/28510157-a6b31092-7081-11e7-99e9-1ad9894d9b75

[GitHub] zeppelin issue #2497: [ZEPPELIN-2779] Unit test for job module (zeppelin-web...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2497 Thanks for the review @sravan-s Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 @yanboliang Sorry for the late response. Thx for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 Deployed - https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/security/shiro_authentication.html#ldap --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2497 [ZEPPELIN-2779] Unit test for job module (zeppelin-web) ### What is this PR for? Added few test cases for the `job` module under `zeppelin-web/` Additionally

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2497: [ZEPPELIN-2779] Unit test for job module (zeppelin-web...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2497 @sravan-s I updated the PR, now websocket (un)subscription is handled in this way (https://github.com/apache/zeppelin/pull/2497/commits/2e12c21197d916b864e3c29c627d929992ee89a2

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Is this enough place to describe build options? What do you think of? - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/basics/how_to_build.html#build-command-examples --- If your

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 @sohaibiftikhar Thanks for the contribution! Travis CI is not set, but this is not relevant with CI. LGTM. merge if no more discussion. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Can we write docs to let the user know they can set these options using maven profile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2496: [HOTFIX] fix 'checkbox' type for create iterpreter for...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2496 @tinkoff-dwh Thanks for the contribution. Tested locally and works well. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2493: [ZEPPELIN-2778] Unit test for credential module (zeppe...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2493 Thanks for the review @sravan-s Merge if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2497: [ZEPPELIN-2779] Unit test for job module (zeppelin-web...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2497 @sravan-s Please help review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2491: [ZEPPELIN-2777] Unit test for configuration module (ze...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2491 Thanks for the reiview @sravan-s @tinkoff-dwh Merge if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 It was a long trip. Thanks for the update and fix. checked locally and it works well. Merge if no more discussion. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 It says `Looks like travis-ci is not configured for your fork.` If you set already travis CI for your fork, could you provide the link? i can help u. --- If your project is set up

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2497 [ZEPPELIN-2779] Unit test for job module (zeppelin-web) ### What is this PR for? Added few test cases for the `job` module under `zeppelin-web/` Additionally, - removed

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto Then could you close and reopen this PR to retrigger jenkins again? https://builds.apache.org/job/zeppelin-pull-request/2363/console --- If your project is set up for it, you

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 Thanks for implementing such a great feature! 1. Could you rebase against the current master? Since filenames were changes, it would be easier to review after rebasing 2. Regarding UX

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 Hi, @malayhm Could you take a look the comment I left? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2474 Let create a PR to fix the ASCII issue, we can test this PR based on the ASCII PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2478 Thanks for the great feature! since this is a big change, I guess it takes a time to review and requires multiple reviewers. Let me take a look. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta Tested locally and it works well. Could you rebase using the current master? since the base branch looks quite old. LGTM except for it. --- If your project is set up

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Left a comment, except for it, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 CI is green, I think jenkins was restarted somehow. - https://travis-ci.org/ebuildy/zeppelin/builds/253975556 LGTM merge if no more discussion. --- If your project is set up

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto thanks for the contribution. 1. Could you create a JIRA ticket? 2. files under `/thrift` are auto-generated, so we can't modify. 3. You need to the forked repository

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 Rebased to clean commit messages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 rebased to fix some commit message which can't be handled in the merge script. (`*`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally, I

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally, I

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy I left a comment. Could u check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Thanks for the contribution @yanboliang. I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy Thanks for the contribution. Tested and works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2473: [fix] Check runtimeInfos is not null

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2473 Hi, Thanks for the contribution. 1. Could you make the failed job be green? - https://travis-ci.org/ebuildy/zeppelin/jobs/251686246 2. Please make a JIRA ticket for this issue

[GitHub] zeppelin issue #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUserList....

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2487 LGTM merge if no more discussion. referred https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet#Defense_Option_1:_Prepared_Statements_.28with_Parameterized_Queries.29

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 @soralee Thanks for the review. We need to keep the zeppelin-web module clean. :) Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2374 @khalidhuseynov Thanks for the update. 1. Could you describe the reason why we need to have separated setting tabs? I mean, what note persistence setting should be under `Global Settings

[GitHub] zeppelin issue #2477: [ZEPPELIN-2342] Improving Test Environment for zeppeli...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2477 Thanks for the review. @soralee. It enables us to write integration tests easily. I will add some integration tests into zeppelin-web later based on this. Merge if no more discussion

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2448 well abstracted and tested PR. LGTM except for - Currently, it seems that converting the note names only when creating / renaming. Is it right? I so, can we rename them initially as you

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 and works well in mobile (iphone 6s chrome, sarari) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 Deployed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch` command

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage, ..) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta I just built PR 2446 and remove `/conf/helium.json` and then installed 2 packages and reorder the icons, 1. But it takes longer than before. IMO, we just need to save

[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2437 Deployed - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/interpreter/interpreter_binding_mode.html --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2437 Sure, users can easily access the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2449 I have a suggestion. - Place `Recent` before `Notebook` (more upper side) - Limit the maximum number of recent notebooks. That's because users are accessing recent notebook

[GitHub] zeppelin issue #2429: [ZEPPELIN-2675] Distributing Jars when using an extern...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2429 Thanks for the quick reply. There are 2 failed jobs. We can restart or need to fix them. https://travis-ci.org/radicalbit/zeppelin/builds/250680464 --- If your project is set up

[GitHub] zeppelin issue #2469: [ZEPPELIN-2726] Move angular related pkgs from bower t...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2469 Thanks for the review. @soralee @sravan-s we are using annotation for angular, but two angular conflicts. (bower side required by angular-websocket) Thus, I will change this PR

[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2437 @cacti77 it's provided as of 0.8.0-SNAPSHOT. - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/interpreter/interpreter_binding_mode.html here are the background

[GitHub] zeppelin pull request #2469: [ZEPPELIN-2725] Move angular related pkgs from ...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2469: [ZEPPELIN-2725] Move angular related pkgs from ...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2469 [ZEPPELIN-2725] Move angular related pkgs from bower to npm (zeppelin-web) ### What is this PR for? Move angular related packages from bower to npm. Because bower team recommends using

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 checked that works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2469: [ZEPPELIN-2725] Move angular related pkgs from ...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2469 [ZEPPELIN-2725] Move angular related pkgs from bower to npm (zeppelin-web) ### What is this PR for? Move angular related packages from bower to npm. Because bower team recommends using

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 Yeah, I guess it happens when browser size is small, probably related to the change brought from 92f41bf --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2437 it was an honor to make more correct, concise documentation with your help. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2429: [ZEPPELIN-2675] Distributing Jars when using an extern...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2429 Hi! Thanks for the contribution. @marcotagliabue. It looks like useful! 1. Please fix the failed CI 2. Would be nice to rebase to update the outdated base branch

[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2437 Please let me know if we need to add / improve / modify something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   5   6   7   8   9   10   >