[GitHub] zeppelin pull request #1991: [ZEPPELIN-2081] Prettify input, textarea in int...

2017-02-08 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1991 [ZEPPELIN-2081] Prettify input, textarea in interpreter setting page ### What is this PR for? Fix small details in interpreter setting page about inputboxes, textareas - Set

[GitHub] zeppelin pull request #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-08 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-08 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1982 [ZEPPELIN-2069] Helium Package Configuration ### What is this PR for? Supporting helium package configurations. I attached screenshots. Implementation details

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1952 Sorry for late reply. I was taking a look also recent resource related commit to understand fully. 1. This PR is well abstracted and shipped with enough unit test. 2. And easy

[GitHub] zeppelin pull request #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-07 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1982 [ZEPPELIN-2069] Helium Package Configuration ### What is this PR for? Supporting helium package configurations. I attached screenshots. Implementation details

[GitHub] zeppelin pull request #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-07 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 @AhyoungRyu I totally agree! Now we have basic things, thus we need docs for it. I will work it on https://issues.apache.org/jira/browse/ZEPPELIN-2070 --- If your project is set up for it, you

[GitHub] zeppelin pull request #1982: [ZEPPELIN-2069] Helium Package Configuration

2017-02-06 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1982 [ZEPPELIN-2069] Helium Package Configuration ### What is this PR for? Supporting helium package configurations. I attached screenshots. Implementation details

[GitHub] zeppelin issue #1975: [ZEPPELIN-2046] The final output is a little inconsist...

2017-02-05 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1975 I think we can use only 1 `div` element instead of appending `div` for streaming output by replacing it's contents (`html()`). --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode

2017-02-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1892 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1935: [gh-pages][ZEPPELIN-1973] List all available Helium pa...

2017-02-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1935 Tested and works well :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1952 @Leemoonsoo Nice to have abstracted table structure inside zeppelin. It enable us many things even i just glanced at. I will take look deeply and comment soon. --- If your project

[GitHub] zeppelin issue #1935: [gh-pages][ZEPPELIN-1973] List all available Helium pa...

2017-02-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1935 @AhyoungRyu Thanks for great contribution. This PR increase the number of helium package users significantly. I would like to comment about the design of `helium.json`. Basically, It's

[GitHub] zeppelin issue #1935: [gh-pages][ZEPPELIN-1973] List all available Helium pa...

2017-01-31 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1935 @AhyoungRyu You are welcome. I will review soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode

2017-01-31 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1892 Sorry for late reply. I will review and comment ASAP @soralee --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-29 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1940 finally, CI is green. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-29 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-29 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1955 [ZEPPELIN-2025] Cleanup R Tutorial ### What is this PR for? 1. Remove useless paragraphs in R tutorial 2. Prettify layout I attached screenshots for comparison. See

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-29 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-29 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1955 [ZEPPELIN-2025] Cleanup R Tutorial ### What is this PR for? 1. Remove useless paragraphs in R tutorial 2. Prettify layout I attached screenshots for comparison. See

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1955 [ZEPPELIN-2025] Cleanup R Tutorial ### What is this PR for? 1. Remove useless paragraphs in R tutorial 2. Prettify layout I attached screenshots for comparison. See

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1955 @minahlee Thanks for review! I updated notebook layout and it looks like ## Large Size ![full-size](https://cloud.githubusercontent.com/assets/4968473/22398815/cd2d003c

[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-27 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1955 [ZEPPELIN-2025] Cleanup R Tutorial ### What is this PR for? 1. Remove useless paragraphs in R tutorial 2. Prettify layout I attached screenshots for comparison. See

[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 Works well as described. - tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only) - code looks nice. well abstracted client classes is shipped with some tests

[GitHub] zeppelin pull request #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0

2017-01-26 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0

2017-01-26 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 @jaspinderdineout Hi :) Zeppelin doesn't support es 5.0 currently as i know. I will close this PR. This issue can be easily handled after #1902. --- If your project is set up

[GitHub] zeppelin pull request #1940: [ZEPPELIN-2008] Introduce Spell

2017-01-24 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1940 [ZEPPELIN-2008] Introduce Spell ### What is this PR for? Implemented **Spell** to Helium categories. *Technically, it's the frontend interpreter* runs on browser not backend

[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @bbonnin 👍 @jongyoul I will take a look more deeply :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1905: [ZEPPELIN-1974] Remove extension from webpack config f...

2017-01-17 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1905 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1900: [ZEPPELIN-1969] Can not change visualization package v...

2017-01-14 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1900 I hit the same issue! Thanks for fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1875 @felixcheung I think it's ok since all LICENSEs will be merged into a single file - https://github.com/apache/zeppelin/blob/master/dev/create_release.sh#L93-#L96 --- If your

[GitHub] zeppelin pull request #1887: [ZEPPELIN-1940] most of eslint rules are NOT ap...

2017-01-11 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1887 [ZEPPELIN-1940] most of eslint rules are NOT applied at all ### What is this PR for? **Most fixes are about applying lint rules. It's automatically fixed using `eslint --fix` command

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 **For reviewers** Fixed to use `spark.jars` instead of `classpath`. - classpath doesn't include submitted jars at this moment (i could get 7 days ago, but not now

[GitHub] zeppelin issue #1868: [ZEPPELIN-1917] Improve python.conda interpreter

2017-01-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1868 @Leemoonsoo now `python.conda` support other `env *` commands :) https://cloud.githubusercontent.com/assets/4968473/21827211/0130cd40-d7ce-11e6-8925-4757c6a2d6fc.png;> --- If y

[GitHub] zeppelin issue #1761: [ZEPPELIN-1711] Create Docker Images for Released Zepp...

2017-01-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1761 @felixcheung Thanks for review. Previously, we discussed about separating images in [ZEPPEILN-1711](https://issues.apache.org/jira/browse/ZEPPELIN-1711) IMO, having 1 image which

[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1842 Let me review this PR. I wil comment again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1875 @Leemoonsoo I moved all font-related licenses from `bin_license` to `/LICENSE` Aldo remove rat exclusion in `zeppeiln-web/pom.xml` for `google-fonts.css` because it is managed by us now

[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...

2017-01-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1877 I faced the same problem too. Thanks for fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1868: [ZEPPELIN-1917] Improve python.conda interpreter

2017-01-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1868 @Leemoonsoo Thanks for review! If https://github.com/apache/zeppelin/pull/1874 is merged soon, I can rewrite the whole `conda env *` commands based on #1874 since current

[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1875 @Leemoonsoo Thanks for detailed explanation. I will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1876: [ZEPPELIN-1927] Remove useless function wrappin...

2017-01-08 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1876 [ZEPPELIN-1927] Remove useless function wrapping in all js files ### What is this PR for? Removed useless function wrappings to move toward `import`, `export` syntax. This PR

[GitHub] zeppelin pull request #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-08 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1875 [ZEPPELIN-1926] Remove grunt googlefonts task ### What is this PR for? There is no reason to download fonts files whenever we build. - Google font doesn't change frequently

[GitHub] zeppelin pull request #1874: [ZEPPELIN-1914] Preserve spaces, newlines in te...

2017-01-08 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1874 [ZEPPELIN-1914] Preserve spaces, newlines in text output (BUG) ### What is this PR for? Fixed to preserve spaces, newlines in text output. ![image](https

[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev cause it does ...

2017-01-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1869 Thanks for comment @AhyoungRyu :) Also, CI failed but irrelevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1869: [MINOR] fix: DON'T clean in npm run dev since useless

2017-01-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1869 \cc @Leemoonsoo for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1869: [MINOR] fix: DON'T clean in npm run dev since u...

2017-01-07 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1869 [MINOR] fix: DON'T clean in npm run dev since useless ### What is this PR for? Removed clean task in npm run dev because webpack-dev-server uses in-memory build :) This was annoying

[GitHub] zeppelin pull request #1868: [ZEPPELIN-1917] Improve python.conda interprete...

2017-01-07 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1868 [ZEPPELIN-1917] Improve python.conda interpreter ### What is this PR for? Add missing commands to the `python.conda` interpreter - `conda info` - `conda list` - `conda

[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...

2017-01-06 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1857 ``` ZeppelinSparkClusterTest.sparkRTest:186 expected:<[[1] 3]> but was:<[ ``` The above test is failing. I will take a look into. --- If your project is set up for it

[GitHub] zeppelin pull request #1857: [ZEPPELIN-1874] fix: sparkR doens't render outp...

2017-01-06 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1857 [ZEPPELIN-1874] fix: sparkR doens't render output properly ### What is this PR for? Zeppelin sparkr only shows first element of all outputs due to invalid implementation

[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...

2017-01-05 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1812 @Leemoonsoo :) - Now user doens't need to care about `yarn.lock` and can use npm commands. - CI failure is irrelevant --- If your project is set up

[GitHub] zeppelin pull request #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode ...

2017-01-05 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1854 [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip text ### What is this PR for? Currently the tooltip for personalized mode is quite confusing. Since - tooltip text

[GitHub] zeppelin pull request #1852: [ZEPPELIN-1910] fix: Multiple dialog when don't...

2017-01-05 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1852 [ZEPPELIN-1910] fix: Multiple dialog when don't have permission for run all para ### What is this PR for? See multiple same dialog when user doesn't have permission for **Run all

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 1. I read and replied before. > Q. README shows that user can use --py-files > A. Users cannot benefit from --packages. They need to download, find location of all transitiv

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 @zjffdu > since it doesn't resolve the yarn-client mode 1. PySpark also doens't support extending PYTHONPATH in yarn-client. 2. You are saying this is not right

[GitHub] zeppelin issue #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't wo...

2017-01-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1843 @jongyoul Thanks for opinion :) It works well. I tested like 1. enable shiro 2. add permission per user into a note to check other users can execute clear all or not ![1905

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doe...

2017-01-04 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1843 [ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't work in a note ### What is this PR for? Fixed **Clear all paragraphs** button in a note (I attached a screenshot)

[GitHub] zeppelin pull request #1841: [ZEPPELIN-1850] fix: DON'T run npm clean in mav...

2017-01-04 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1841 [ZEPPELIN-1850] fix: DON'T run npm clean in maven clean phase (CI related) ### What is this PR for? maven clean executes `npm run clean` after #1824. but running npm commands requires

[GitHub] zeppelin pull request #1835: [MINOR][DOCS] Add troubleshooting section to sp...

2017-01-03 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1835 [MINOR][DOCS] Add troubleshooting section to spark_cluster_mode.md ### What is this PR for? I faced problems while executing docker image for spark on mesos described in [Spark on Mesos

[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...

2017-01-03 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1812 @Leemoonsoo 1. `yarn remove` and `yarn add` will update package.json as well. 2. But some people might not know how to use yarn, so it would be better to - remove

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 @zjffdu I'v just created gist to show `--packages` option download pyspark-cassandra. https://gist.github.com/1ambda/5caf92753ea2f95ada11b1c13945d261 ``` downloading https

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 @zjffdu Thanks for review :) Then, How can I load [pyspark-cassandra](https://github.com/TargetHolding/pyspark-cassandra#with-spark-packages) for pyspark? --- If your project is set up

[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...

2017-01-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1831 @astroshim Thanks for review! It's the expected behavior. If spark submit doens't be properly loaded, spark interpreter will die without errors. --- If your project is set up for it, you

[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

2017-01-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1824 @Leemoonsoo Thanks for review! Now `mvn clean` will execute `npm run clean` (8baaea2) ``` $ zeppelin-web git:(ZEPPELIN-1850/remove-grunt-clean) mvn clean Java HotSpot(TM

[GitHub] zeppelin pull request #1831: [ZEPPELIN-1883] Can't import spark submitted pa...

2017-01-01 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1831 [ZEPPELIN-1883] Can't import spark submitted packages in PySpark ### What is this PR for? Fixed importing packages in pyspack requested by `SPARK_SUBMIT_OPTION` ### What type

[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...

2016-12-29 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1824 [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt) ### What is this PR for? Replaced `grunt-contrib-clean` to [rimraf](https://github.com/isaacs/rimraf) - to remove

[GitHub] zeppelin pull request #1812: [ZEPPELIN-1850] Use yarn instead of npm to redu...

2016-12-28 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1812 [ZEPPELIN-1850] Use yarn instead of npm to reduce build time ### What is this PR for? This PR is about using [yarn](https://yarnpkg.com/) which is ultra fast than npm. As you

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov Thanks for reply! > yeah that's good point, do you have something in mind regarding it? i was thinking whether it should be more of a mode switch (say different mode ad

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @Leemoonsoo ### Remove `console.log` in dist I missed it. Previously, grunt stripped all `console.log` using this config ``` uglify

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-26 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @AhyoungRyu I didn't know about ZEPPELIN-1805 but good to hear that it is solved by this PR. Also, docs was updated to include `npm run dev` command in 8442eba :) --- If your project

[GitHub] zeppelin pull request #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-25 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1805 [ZEPPELIN-1850] Introduce Webpack (front) ### What is this PR for? The purpose of this PR is introducing webpack to zeppelin-web - It supports super-fast javascript compilation

[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-25 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1791 @felizbear 1. I thought webpack-dev-server can serve only one diretory using `contentBase` but they supports multiple dirs. So now it doesn't matter :) 2. It's typo. I updated

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-23 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1803 [MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js ### What is this PR for? Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-23 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-23 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1803 [MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js ### What is this PR for? Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-23 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun great! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...

2016-12-23 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1803 [MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js ### What is this PR for? Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can

[GitHub] zeppelin pull request #1802: [MINOR] Validate before setting focus to paragr...

2016-12-23 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1802 [MINOR] Validate before setting focus to paragraphs ### What is this PR for? Fixed fragile code in notebook.controller.js. This code causes loading errors as u can see the screenshot

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-23 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 Works well as described. Here are few things to consider. - It would be great if there is a signal (whatever) so let user know that this is committed version of note. It's confusing

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 FYI - you can install 2.11.0 using brew. @khalidhuseynov is right, that should be handled in the separate issue. Let's talk about it on ZEPPELIN-1737. --- If your project is set up

[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1791 Did simple test for applying webpack. Let me share result in short. - (**IMPORTANT**) It is impossible to handle in a single PR. It requires changing directory structure and this causes

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 Hi @tae-jun It's good idea to introduce limitation when notes are in trash. Let me comment (1) what you mentioned is about restricting modification of archived notes (i mean

[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1791 one more question. Can we boost dev mode build using webpack and its useful plugins? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1789: [MINOR] Optimize watchers of paragraph results

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1789 Hard to figure out what is different at first. See border of the icons. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1791 \cc @cloverhearts @felizbear for review. Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...

2016-12-22 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1791 [ZEPPELIN-1847] fix: Copy only html when html file changed ### What is this PR for? Reduce build time by avoiding to copy non-related files. Approx 3~4 secs as you can see below

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 For other reviewers - If you are using git 2.10+, Notebook revision feature will not work. Checkout [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) --- If your

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Those are other flaky tests already reported. You can search JIRA [here](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20and%20text%20~%20

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Could you file CI links? :) also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-19 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 Glad to help reviewing this PR :) Let me check and then give you feedbacks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

2016-12-19 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Thanks for fixing a flaky test :) It would be great if you accumulate CI multiple results like #1667 for review. Just closing and re-opening will also works instead of pushing

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It works well as described and here are two things to consider. 1. Trash is represented in `~Trash` in the Navbar. https://cloud.githubusercontent.com/assets

[GitHub] zeppelin pull request #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI ...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, This PR looks like unbacked from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 Hi all, This PR looks like unpopular from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 Hi all, This PR looks like unpopular from the point of view design. I will close this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

<    5   6   7   8   9   10   11   12   13   >