Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1816
@soralee Thanks for testing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1825
@anthonycorbacho As a creator of this operations, could you please help
review this PR? :D
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1825
[DOCS][ZEPPELIN-1586] Add 'Security' section under notebook restapi docs
### What is this PR for?
After #1567 merged we can get/set note permission information for a certain
note
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1757
@felixcheung Yes. So I can handle it later if you don't mind. I think it'll
be faster. Shall we merge then? :)
---
If your project is set up for it, you can reply to this email and have your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1813
Yeah it makes sense. Tested and it's working well ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1811
@cuspymd I tried to make the browser width narrower and tried to change the
paragraph width itself , but still couldn't reproduce.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1804
@soralee There is a conflict file now. Could you resolve it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1811
Thanks for your contribution. I added clipboard in #1750 but, can't
reproduce the text overflow like you attached screenshot. I tested latest
master in Chrome / Firefox / Safari
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1816
[MINOR] Fix broken CSS for plain text paragraph result
### What is this PR for?
After #1711 merged, plain text paragraph result CSS is broken now.
Originally the text result like below
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1773
Looks good! Thanks @zjffdu
Merge into master if there are no more comments on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@vinayshukla I think what @Leemoonsoo suggested was having only one
documentation about this info.
And IMO having detailed information to describe about "Authentication in
Zep
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1792
Merge into master if there are no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@tae-jun Thanks for your great work! Merge if there are no more discussions
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1806
@soralee CI is green now. Thanks for the quick fix!
Merge into master as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1791
Merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
Will merge this into master if there are no more comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1773
@zjffdu Do you have any chances to look into the last comment by
@felixcheung ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1798
Docs change has no test so, CI failure is not related with this change.
Will merge this if there are no more comments.
---
If your project is set up for it, you can reply to this email
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1801
@agura Thanks. CI failure looks irrelevant with this change.
Will merge this into master if there are no more discussions.
---
If your project is set up for it, you can reply
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
@prabhjyotsingh Thanks! :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1798
Looks good ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1805
@1ambda To quickly test this branch, I tried to change some css components
and html, js files. It's working really nicely(and super fast). Great work
indeed! Seems it solved
[ZEPPELIN-1805
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1798
@zjffdu Thanks! Then we can remove `Upgrade` section since we don't need to
have both of them :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1804
@soralee Thanks for fixing this. And docs update ð I tested and it
mostly works well. Personally
```
println(
"""%angular
""")
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1786
@khalidhuseynov yup, hopefully it can be :)
Will merge this into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
Can someone review this one? ð
ð¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@1ambda Tested this branch and it's faster than master as you described.
Nice improvement indeed!
- before
https://cloud.githubusercontent.com/assets/10060731/21472036/01d7b58a
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1030
@neil4dong This PR is not for bug fix but for adding new credential Apis.
Could you elaborate more about your problem? You can also create new
[Jira](https://issues.apache.org/jira/issues/?jql
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1730
Finally CI is green now! LGTM ð
ð¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1786
@khalidhuseynov Thanks for fixing. I test this on
[ZeppelinHub](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#storage-in-zeppelinhub),
seems it's synced well when I ran
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1753
@jongyoul @cloverhearts Didn't saw the last commit. Please ignore my last
comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1753
@jongyoul @cloverhearts Did you have any chance to check [my
comment](https://github.com/apache/zeppelin/pull/1753#pullrequestreview-13267973)?
---
If your project is set up for it, you can
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1780
Nice! Then will merge into master if there are no more comments :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
CI is all green now! Ready to review.
Here are some brief summaries what I did.
Since from this PR `anonymous`(non authenticated) user can't set note
permission, related test
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1759
As I posted the reason of CI failure in the above, it's not relevant. So
will merge into master if there are no more comments. Thanks @DrIgor!
---
If your project is set up for it, you can
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1757
@lresende Thanks! Looks nice. BTW the [Build from
Source](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#building-from-source)
section went to too down side. How about
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1758
@AlexanderShoshin Right that would be better. So sorry about that ã
_ã
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1721
@cloverhearts Looks good ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@tae-jun Thanks for your precise explanation. Yeah it makes sense. And
tested again and it looks good for what we talked about :)
It'll be nice to be merged after addressing @1ambda's
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1738
@bitchelov Did you have a chance to look into [this
comment](https://issues.apache.org/jira/browse/ZEPPELIN-1839?focusedCommentId=15761118
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1783
@PetroKostyuk Thanks for your contribution! It's really useful feature
indeed.
For the quick review, it would be better to edit PR title to sth like
"[ZEPPELIN-727] Enable to
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
@prabhjyotsingh @cloverhearts @astroshim Sorry for my late response.
I added checking anonymous user \w notebook rest api. So if anonymous users
try to click lock icon / `GET` note
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1757
Sorry for my late blocking, but actually I even didn't know that there is
`README.md` under `conf/`. Maybe many ppl are same with me I guess. Seems there
is already some duplicated information
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1694
[ZEPPELIN-1718] Prevent anonymous user to set note permission
### What is this PR for?
Currently anonymous user can open the notebook permission page and type sth
in `Owner`/ `Reader
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/1694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
@prabhjyotsingh @cloverhearts @astroshim Sorry for my late response.
I added checking anonymous user by using websocket and updated PR
description \w new UI screenshot image. Please take
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1750
Will merge into master if there are no more comments then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1750
@felixcheung Yeah that's my plan :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1780
@astroshim I checked again and it's working well. Sorry for any confusions,
it was my bad.
So LGTM ð
---
If your project is set up for it, you can reply to this email and have your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1758
@AlexanderShoshin Actually it was my bad. I checked again and [this
commit](https://github.com/apache/zeppelin/pull/1758/commits/fe2a39ec38ad2aed4b65e37c96e7b1dfd3f3489b)
is perfectly working
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1773
@zjffdu All CI build jobs are red now. Could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1758
Thanks for your quick update!
Since #1780 is trying to update the all tutorial notes' format to the
latest one, having older format of note can't be best solution I think. Not
sure
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1777
CI has been failed only in [Selenium
test](https://travis-ci.org/apache/zeppelin/jobs/184584526) like below.
```
[36mTests: succeeded 17, failed 1, canceled 0, ignored 0, pending 0[0m
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1780
I imported (using url) this new format of notes to my Zeppelin, but seems
they don't show the result by default like below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm @soralee Thanks for your review!
CI failed only in Selenium test like below and it's not related with this
docs change.
```
Results :
Tests in error
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1766
@zjffdu @Leemoonsoo Thanks for your review!
Will merge into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1756
At last! Tested and it works well. LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm No worries. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm Since you added this section, it'll be appreciated if you can
review this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1768
[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter
overview page
### What is this PR for?
After #1470 merged, "(Experimental) Interpreter Execution
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1766
[MINOR] Set default interpreter \w first intp
### What is this PR for?
Currently we can select default interpreter when we create a new note like
below.
 Tested again to check the time stamp, it makes sense.
Then how about attaching the time stamp
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1717
Will merge this into master if there are no more comments.
@cloverhearts Thanks for your effort to keep maintaining job management :)
---
If your project is set up for it, you can reply
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1760
2 CI build job failed with below errors and looks irrelevant with this
change
```
Results :
Tests in error:
InterpreterRestApiTest.testRestartInterpreterPerNote:303
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1759
@DrIgor Thanks for your contribution!
Currently 1 test profile failed like below, but it looks irrelevant with
this change/
```
Results :
Failed tests
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1760
@fred777 Thanks for your contribution. Nice catch! Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1735
LGTM ð
Merge if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1730
@tae-jun Nice feature indeed!
Most of cases are working like a charm.
But as @marchpig said above,
 is broken in here:
http://zeppelin.apache.org
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1750
@felixcheung
I just tested this patch only in dev mode(`npm run start`). But after I
checked at `localhost:8080` and found
```
404
http://localhost:8080/bower_components
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1752
[HOT FIX] Fix broken display_formula.png by using relative path
### What is this PR for?
Currently `display_formula.png` (added by #1606) is broken in here:
http://zeppelin.apache.org
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1734
Thanks @1ambda. Seems it much better! Let me test again.
So true. Currently the CI test result makes us more confused and really
hard to find what the problem is :(
---
If your project
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1750
[ZEPPELIN-1796] Add 'copy to clipboard' next to the paragraph id
### What is this PR for?
There are lots of use cases that need to know each `Paragraph Id` in
Zeppelin.
e.g. [run
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1735
@astroshim Thanks for your prompt update. Tested and it works well!
But sadly 3 of CI tests are failed likw below and looks relevant with this
change. Could you take a look this again
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1743
Merge into master if there are no more comments :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1735
@astroshim Good catch! Tested and it was working well as expected.
AFAIK there are 3 way to run a paragraph in Zeppelin note like below
1. \w keyboard shortcut `Shift + Enter
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1734
@1ambda Great initiative for improving interpreter binding page UI! I also
agree that current binding page is getting longer (thanks to the Zeppelin
contributors :D) and getting hard to find
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Tested and it's working nicely! LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1725
I've tested this patch and finally it works now. Tested both whole build
`mvn clean package -DskipTests` and `npm run build` under `zeppelin-web`.
Thanks for the quick fix!
---
If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@soralee What a nice suggestion! @tae-jun I think it's cool!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1686
@soralee I just merged this into master branch. Could you update PR
description with latest change? Maybe one day, someone wants to refer this PR
to add another keyboard shortcut I think
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1703
@khalidhuseynov Thanks!
CI had been failed during downloading Spark
https://cloud.githubusercontent.com/assets/10060731/20750140/b0186c98-b738-11e6-8687-6697ced72a1e.png
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1690
Merge into gh-pages branch if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1686
Merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1703
@khalidhuseynov Could you check this one? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1703
[DOCS] Update Shiro conf file with new package names in docs accordingly
### What is this PR for?
Based on #1700,
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
@prabhjyotsingh @cloverhearts Didn't think about that way. It makes sense.
Thanks for your suggestion. Let me update then :)
---
If your project is set up for it, you can reply to this email
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1690
@1ambda Sounds great thanks! LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
401 - 500 of 866 matches
Mail list logo
