[GitHub] zeppelin issue #1754: [ZEPPELIN-1800] Update scio doc - fix type $ should be...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1754 LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1746: Collection.isEmpty() should be used to test for emptin...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1746 @bitchelov Thanks for the contribution. Do you mind update description of the PR? PR description will be part of commit message when merged. So we expect some meaningful description

[GitHub] zeppelin issue #1737: ZEPPELIN-1769. Support cancel job in SparkRInterperete...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1737 @zjffdu Thanks! LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1752: [HOT FIX] Fix broken display_formula.png by using rela...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1752 LGTM. Merge it as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1733: [ZEPPELIN-1753] Fix blank notename issue

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1733 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun thanks for the great contribution! LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 LGTM and merge to master if there're no further discussions. @khalidhuseynov Great work! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1722: [ZEPPELIN-1776] substitute null check for the refactor...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1722 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1612: ZEPPELIN-1607. Refactor Livy Interpreter to adapt scop...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1612 LGTM and merge to master if there're no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1739: Branch 0.5.6 al

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1739 @andreistankevich could you close this PR if you accidentally created? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1728 LGTM and merge to master if there're no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda that looks more make sense to me. fyi, a related PR https://github.com/apache/zeppelin/pull/423 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda for working on UX improvement. Personally, i'd prefer keep items in 1 column. Because it displays interpreter names (e.g. %spark, %pyspark, etc) at predictable location

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1727 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 LGTM and merge to master if there're no more discussions. Great work @cloverhearts ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #:

Github user Leemoonsoo commented on the pull request: https://github.com/apache/zeppelin/commit/cb0b45080251b224f44abe8719865b756290a397#commitcomment-20082316 I made mistake on backporting this commit. Our merge tool couldn't handle this case so i manually cherrypicked and resolved

[GitHub] zeppelin issue #1725: [MINOR] Resolve bower dependency conflict, hang (zeppe...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1725 @soralee reported that branch-0.6 is also failing with this problem. And i confirmed branch-0.6 build fails with the same problem and this fixes the problem. So i'm going to back

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1723 Thanks @cuspymd for providing review. LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1724 @prabhjyotsingh Thanks. Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 Tried but still no luck .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1724 Thanks @prabhjyotsingh for the review. I think other charts doesn't have these options. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 Tried but no button is displayed. Maybe i'm missing something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1713: [ZEPPELIN-1530] Update common scripts for Linux and Wi...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1713 LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1724: [ZEPPELIN-1674] save barchart, areachart option

GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/1724 [ZEPPELIN-1674] save barchart, areachart option ### What is this PR for? Persist - bar graph options (grouped, stacked) - area graph option: (stacked, stream, expanded

[GitHub] zeppelin pull request #1724: [ZEPPELIN-1674] save barchart, areachart option

Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/1724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 Tested and LGTM. Thanks @cloverhearts for the fix! Could you resolve the conflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1725: [MINOR] Resolve bower dependency conflict, hang (zeppe...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1725 Thanks for the fix. Confirmed it fixes build problem if i remove node_modules bower_components directories. LGTM. While the bug breaks build, merge this patch to master

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1630 Merge to master if there're no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1723 Thanks @marchpig for the fix. Thanks @tae-jun for the review. LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #1724: [ZEPPELIN-1674] save barchart, areachart type

GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1724 [ZEPPELIN-1674] save barchart, areachart type ### What is this PR for? Persist - bar graph options (grouped, stacked) - area graph option: (stacked, stream, expanded

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Could you let me know you apache JIRA id? so i can assign you in this https://issues.apache.org/jira/browse/ZEPPELIN-1637 issue and resolve. --- If your project is set up

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1630 Great work @tae-jun. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1711: [ZEPPELIN-1721] Let each visualization define 'setting...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1711 Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 @khalidhuseynov sounds good. Let's wait for CI becomes green. Other than that, Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 Tested and it works well. Great work @khalidhuseynov. But when i visit revision, shouldn't it be immutable? i can still edit and run. --- If your project is set up for it, you can

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 @krskoondra Thanks for the nice feature. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1714 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1715 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1630 Tested and working really nicely. Looks awesome to me! Thanks @tae-jun for the great contribution! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 CI test failed with ``` Results : Tests in error: ParagraphActionsIT.testRemoveButton:155->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisi

[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1715 Thanks @soralee for the nice improvement. Tested and LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1711: [ZEPPELIN-1721] Let each visualization define 'setting...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1711 I think test failures are irrelevant to this change. Ready to review. ``` AngularElem - should able to be created from implicit conversion Run completed in 1 second, 632

[GitHub] zeppelin issue #1712: [ZEPPELIN-1742] send error info to popup when commit f...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1712 Tested and LGTM. Thanks @khalidhuseynov for the update. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 If i assume your remote name for Zeppelin repository is `apache-github` (you can check it by running `git remote -v`), First, fetch Zeppelin repo (to get latest master) with `git

[GitHub] zeppelin issue #1708: [ZEPPELIN-1728] Add an example configuring classpath f...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1708 Thanks @Tagar @astroshim for the review. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1711: [ZEPPELIN-1721] Let each visualization define '...

GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1711 [ZEPPELIN-1721] Let each visualization define 'setting'. ### What is this PR for? ZEPPELIN-1003 made an abstraction layer for visualization and now visualizations are moved to [zeppelin

[GitHub] zeppelin issue #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in partic...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1702 Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1707: Add PythonDockerInterpreter to interpreter group

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1707 Merge to master if there're no further comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1709: [HOTFIX] Make Spark download stable on CI

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1709 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1658 @agoodm merged master and addressed tests added from #1632. CI failure is not related. Merge to master. ![image](https://cloud.githubusercontent.com/assets/1540981/20757762

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1441 @cloverhearts Thanks for the explanation. Keeping search with real time job monitoring make sense. LGTM and merge to master. if there're no further discussions. --- If your project

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 Thanks @krskoondra for the contribution. LGTM. merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1706: [HOTFIX] Exclude org/apache/zeppelin/scio/avro/* once ...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1706 LGTM and merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1707: Add PythonDockerInterpreter to interpreter group

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1707 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1708: [ZEPPELIN-1728] Add an example configuring clas...

GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1708 [ZEPPELIN-1728] Add an example configuring classpath for hive-site.xml ### What is this PR for? hive-site.xml is required to configure HiveContext in SparkInterpreter. So it'll

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1677 Merge to master if there're no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1566: [ZEPPELIN-1587] (WIP) Add impersonation routine in Spa...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1566 Using --proxy-user instead of doAs would work? https://issues.apache.org/jira/browse/ZEPPELIN-1730 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1699: [ZEPPELIN-1724] conda run command removed in 4.1.0

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1699 Tested and LGTM. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in partic...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1702 Tested and it works well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1691: ZEPPELIN-1716. Error of interpreter not found is not p...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1691 Tested and LGTM. Thanks @zjffdu for the fix! Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1672 https://github.com/apache/zeppelin/pull/1704 changes the filename processenduser.md to userimpersonation.md. Could you resolve conflict? --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1704: [HOT FIX] Fix broken link to userimpersonation.html

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1704 Merge to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1704: [HOT FIX] Fix broken link

GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1704 [HOT FIX] Fix broken link ### What is this PR for? https://github.com/apache/zeppelin/pull/1554 added a `processenduser.md`, but the navigation menu different name on it's link

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1679 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1617: ZEPPELIN-1645: JDBC Interpreter does not commit update...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1617 @matthewLiem Maybe, some jdbc driver may support some parameters like `?autocommit=true` in it's connection url. But it depends on driver implementation whether they have such feature

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1658 Thanks @agoodm @khalidhuseynov for the review! Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul I think key requirement of personalized mode is two or more different user want to keep their own dynamic form input and the output of paragraph. How can this be done without let

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 @cloverhearts Thanks for the great contribution. LGTM and merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1685 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1647: [ZEPPELIN-1013] Don't run paragraph on selectbox chang...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1647 Although it changes user experience, it is more consistent behavior considering other type of dynamic form behavior (input, checkbox). Regarding the test, while other types of dynamic

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1688 Top right corner of each paragraph was pretty crowded in early days of Zeppelin. Run, Move up, Move down, Delete, Show title, Show codes, Hides output, and so on. Because

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 I still can see some unnecessary changes on the import code block in many files. Could you manage them unchanged? I have listed files in previous comment. --- If your project is set up

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1686 Ctrl+Alt+L sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1686 Thanks @soralee for the contribution. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1683: Fix Travis build error with ls command

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1683 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1612: ZEPPELIN-1607. Refactor Livy Interpreter to adapt scop...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1612 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1658 I think this PR is ready to be reviewed. While this PR includes quite a lot of changes i'm highlighting some key changes. 1. Display multiple types of output in a single paragraph

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1673 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1593: ZEPPELIN-1613. PerUser scoped mode doesn't work

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1593 @zjffdu Looks great to me! Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1339 In case of 1) Don't have plan to use spark interpreter, just want to use other interpreters like python, big query. 2) Set SPARK_HOME in interpreter property instead of conf

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1637 Could you keep following files unchanged and resolve conflict with master? bigquery/src/main/java/org/apache/zeppelin/bigquery/BigQueryInterpreter.java cassandra/src/main/java/org

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1677 @m30m Awesome! LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1656: Fix Yarn configuration of Spark2.0

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1656 LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1613 Make sense. @karup1990 what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1654: [ZEPPELIN-1683] Run python process in docker container

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1654 Thanks @felixcheung for the review. Merge to mater if there is no more comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1613 @zjffdu Right. Isolated mode can create multiple spark applications. @karup1990 @zjffdu how can we handle multiple spark applications? --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1670: [ZEPPELIN-1700] ConnectException between ZeppelinServe...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1670 @astroshim Thanks for the contribution. Could you edit default value from [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf

[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1539 Tested and LGTM. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1669: HOT FIX: Fix NPE while getting default interpreter set...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1669 LGTM and merge to master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1654: [ZEPPELIN-1683] Run python process in docker container

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1654 CI Green now. please review this. Once it's merged, i'd like to add some tutorials that leverage this feature. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1660 @jongyoul Could you describe more about the personalized mode? I don't think current implementation is anywhere close to personalized mode discussed in https://issues.apache.org/jira/browse

[GitHub] zeppelin issue #1656: Fix Yarn configuration of Spark2.0

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1656 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1656: Fix Yarn configuration of Spark2.0

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1656 Thanks @astroshim for the fix. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1664: [ZEPPELIN-1693] doesn't work folder feature on navbar.

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1664 Thanks @cloverhearts for taking care. LGTM and merge to master as a Hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1624: ZEPPELIN-1653: Make UI responsive

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1624 Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1657: [ZEPPELIN-1623] Fix flaky test - ParagraphActionsIT.te...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1657 Re-triggered CI and failure is irrelevant to this change. Merge if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1652: [MINOR] Move tutorial notes under one folder

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1652 Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1645: [ZEPPELIN-1671] Conda interpreter

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1645 Merge if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

<    5   6   7   8   9   10   11   12   13   14   >