[GitHub] zeppelin issue #1971: When gear icon is clicked, scroll the page to the top ...

2017-02-04 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1971 I checked the CI failure, it does not look relevant to this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1971: When gear icon is clicked, scroll the page to t...

2017-02-03 Thread beriaanirudh
GitHub user beriaanirudh opened a pull request: https://github.com/apache/zeppelin/pull/1971 When gear icon is clicked, scroll the page to the top to show the interpreter bindings ### What is this PR for? When someone is browsing a notebook and they click the *gear

[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...

2017-01-24 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1914 Thanks for the review @jongyoul . I looked at the CI failure and it looks irrelevant to this change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1914: [ZEPPELIN-1983] Feedback about success/failure ...

2017-01-19 Thread beriaanirudh
GitHub user beriaanirudh opened a pull request: https://github.com/apache/zeppelin/pull/1914 [ZEPPELIN-1983] Feedback about success/failure when interpreter is re… ### What is this PR for? When a interpreter is restarted, there is no feedback to user whether the action

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-09-01 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @corneadoug @Leemoonsoo please let me know if any action-item on my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-29 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 Hey, I had done the testing on streaming cases for shell and spark earlier while raising this PR, and they did work then. I just did the testing on top

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-25 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @corneadoug @bzz this is ready for review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-23 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @jongyoul done. Used diamond operator at all places except for 1 where compiler wouldn't allow (AppendOutputRunner.java:78) --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-22 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @corneadoug @jongyoul @bzz this is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-16 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @corneadoug thanks for verifying. @jongyoul Got it fixed now. I had mis-understood previously. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-10 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @jongyoul @corneadoug I have incorporated all feedback, and added comments on queries. This PR is ready for review. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-09 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 My tests needed some fixes to work with other tests. I have fixed them. But the build still has some errors I think not related to my change. https://travis-ci.org/apache/zeppelin/builds

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-06 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 @jongyoul: I have incorported all feedback: 1. Using ScheduledExecutorService for ensuring AppendOutputRunner is up, instead of doing so inside the while loop. 2. Synchronizing

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

2016-08-05 Thread beriaanirudh
Github user beriaanirudh commented on the issue: https://github.com/apache/zeppelin/pull/1283 It is easier to handle the twice output on the javascript side, so I have added the check in file `paragraph.controller.js`. The browser would not let results to be appended if the paragraph

[GitHub] zeppelin pull request #1283: Buffer append output results + fix extra incorr...

2016-08-04 Thread beriaanirudh
GitHub user beriaanirudh opened a pull request: https://github.com/apache/zeppelin/pull/1283 Buffer append output results + fix extra incorrect results ### What is this PR for? On a paragraph run, for every line of output, there is a broadcast of the new line from zeppelin