Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1600
Thank you @aspen01, @placeybordeaux
In order to be merged, this branch have to be rebased on top of the master,
which itself already includes CI fixes, i.e 1c7d8fb.
This branch
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1775
@khalidhuseynov Is it WIP?
Then please feel free to add WIP in PR title and ping back, when it's ready
for reviews.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1767
Great improvement, thank you @vinayshukla !
But indeed, it would be really nice to have documentation available on the
website as well, as @Leemoonsoo suggests.
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1776
Thank you @pmccaffrey6 , it looks great to me, modulo few things noted
above.
Could you just double check that all feedback from reviews was addressed?
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1779
Looks good to me.
Just FYI - there already is #1598 from @1ambda but AFAIK it is stuck and
need a hand.
That would be awesome, if we could come up with a plan to merge that one as
well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1780
Looks great to me.
CI fails here though. I know it's annoying but @astroshim, as PR author,
could you please post failure build logs here, so we can see if it is something
that already have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1758
Is there any other feedback, or was everything addressed and we shall merge
it now?
Saw @zjffdu 's
> How about refer this note in flink.md ?
@AlexanderShoshin do you think i
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Only the last CI profile fails on very strange curcumstances:
```
16/12/19 04:54:08 INFO ApplicationMaster: Deleting staging directory
.sparkStaging/application_1482123134765_0003
16/12/19
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
Thank you very much @cuspymd for fix and @zjffdu for double-checking!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1600
I see! This looks like something failing on the TravisCI side though.
Could you please rebase this branch on latest master and force-push it here
again? This will trigger CI \w latest code\fixes
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
@cuspymd please let me know you ASF JIRA user or email and I'll be happy to
assign [ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) so
attribution is keept for release notes
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
Looks great to me. Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1774
merging as HOTFIX as CI is green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1774
Merging as a HOTFIX, as CI passes \wo packaeg installation error, as per
https://travis-ci.org/1ambda/zeppelin/builds/184455104
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1716
@cloverhearts can you please rebase it on latest master - `git rebase
master` and force push it? This will trigger CI with latest fixes and help to
see if there are any relevant failures here
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
\cc @corneadoug @felizbear for reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1477
Thank you @yiming187 !
CI failures looks not relevant to the changes
```
Results :
Failed tests:
HeliumApplicationFactoryTest.testLoadRunUnloadApplication:160
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Thanks for explanation, makes sense to me
On CI failures - from my experience, if the reason of failure is posted
here - there speeds up the merge dramatically.
I have update
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1603
2 weeks ping @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
First and second failing CI profile hit
[ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797)
Spark 1.5 had another troubles \w `DepInterpreterTest`
```
16/12/13
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Looks great to me, thank you @1ambda @mfelgamal
Let's wait for CI results and merge to master, if nothing comes up and
there is no further discussion!
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Iâm a bit confused though - this PR seems not to have separate checkstyle
CI profile, right?
Didnât we want to have `CHECKSTLYLE=1 â¦` profile for all projects, and
then skip
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1734
Guys, if I may, I would suggest keep the discussion in PR focused on the
subject of the PR and move general topics of project's CI stability to the
public dev@ mailing list and appropriate JIRA
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
I'm sorry for a confusion - as soon as this issue is not about CI, but
about `Update checkstyle rule file, plugin`.
Let's move the CI discussion to the dev@ mailing list so all people
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Interesting, that is the first time I see it! AFAIK `spark-csv` has been
included in Spark since 2.0
The failing profile is Spark 1.6 with **Scala 2.11**, but it fails on
fetching `spark
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1744
Looks great to me, modulo minor issue above.
Also, in my experience if CI failure reason is summarised and posted here
by PR author - it makes merging/reviewing process much faster
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Thank you @felizbear !
Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal could you please explain, why do you think one more script is
needed - `start-zeppelin.sh` and why `CMD["/bin/zeppelin.sh"]` can not be used
as entrypoint for the image?
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1716
@cloverhearts thank you for contribution! In my experience, if PR author or
one of reviewers post the reason for CI failure - that speeds up the
review\merge process dramatically.
CI
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1731
ð Idea sounds great to me. It looks like
https://github.com/optimalisatie/grunt-goog-webfont-dl is not maintained but
https://github.com/Mika-/grunt-google-fonts had changes this year.
I
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1727
Looks great to me, thank you @1ambda for valuable build improvements!
Merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal that sounds awesome job, thank you very much.
Please let me test it tomorrow and get back to you here, but otherwise I
think it's ready to be merged!
---
If your project is set
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1561
@meenakshisekar thank you for contribution! Could you rebase on the latest
master please?
Also, please do not hesitate to let us know in case you need any help with
this one, in order to get
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1477
@yiming187 thank you for improvement, looks good to me, ð for having
tests!
Could you please rebase it on the latest master, before merging it in?
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1661
Sounds awesome, thank you!
Let's merge then, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Looks great to me!
@felizbear In my experience, if the contribution author followup on CI
failure - that speeds up the merge time tremendously.
It looks like at least CI is failing
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1718
Looks great to me, thank you @minahlee !
Merging as a hotfix, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Looks great to me, thank you @felizbear for frontend code improvements!
Let's wait for CI, meanwhile, would you mind creating a JIRA issue please?
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
I see what you mean, for profile not included in build roster by default we
would need to update the CI profile. Well, it's 12s * 10 (number of profile we
have no), which looks like 2min time, but we
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Sounds great! What is rationale for having checkstyle running everywhere +
a separate profile?
Would it make sense to measure the CI build time with\without separate
profile and see
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
With number of PRs we have I'm a bit lost, which one will introduce a
separate checkstyle CI profile and skip it in all the rest?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1661
@minahlee Looks great to me!
Could you please rebase on latest master?
I assume that for testing, it should be enough to build `mvn clean package
-Pbuild-distr -DskipTests` and make
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1695
@PetroKostyuk thank you for improvement!
It looks like your work need to be rebased on the latest master in order to
resolve conflicts, before merging.
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
2 Scala 2.11 profiles failed on IgniteSQL tests - a flaky test tracked
under [ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738l)
```
Tests run: 2, Failures: 1, Errors: 0
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Waiting for CI to finish on https://travis-ci.org/1ambda/zeppelin/
Will merge to master right after that, if there is no further discussion.
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
Looks great to me, thank you @felixcheung let's merge if there is no
further discussion!
CI failure of tests in `zeppelin-zengine` on 1 profile looks not relevant
and will be taken care
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Go it, that sounds great.
Then shall we finish and merge this guy first, and then get back to #1668
merge it?
---
If your project is set up for it, you can reply to this email and have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1500
Looks great to me and CI is green.
Thank you @Peilin-Yang for prompt responce and @felizbear for reviews!
Merging to master, if there is no further discussion.
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Looks like it need a final re-base here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1709
CI is green, merging to master as a HOTFIX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1696
rebasing on #1709 should solve the CI issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@1ambda I have created a HOTFIX for CI Spark download in #1709 so after
merging it, let's rebase and see if that fixed the issue.
I'm a bit confused, do you want to continue working here
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
@felixcheung I think after #1709 there might be no need for `mvn -q` option
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1709
[HOTFIX] Make Spark download stable on CI
### What is this PR for?
There has been issues with downloading\caching Spark, esp in #1689 #1696
This is hotfix for Spark download on CI
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Will you also add `plugin.download.version` to
[spark-dependencies/pom.xml](https://github.com/apache/zeppelin/pull/1668/files#diff-457fb4186c9640eac4e0808bbd0d849e)
?
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
There is really strange test failure in `markdown` tests on first CI
profile (flaky-test?)
```
Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 101.166
sec <<<
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
That makes sense, let's try!
@1ambda and me are already working on downoad Spark src stability if not
cached and going to nail it in #1696 and #1689
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1682
Great update @felixcheung !
On the `--quite` switch - before fixing the symptoms I would rather prefer
fixing the reason, if possible. Do you have any idea why does it start to bite
us only
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
I think we are already on the path of multiple PRs, wich sounds great to me!
@jongyoul shall we close this guy then?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1391
Having a `PortProvider` as injectable dependency, that incapsulates all the
logic about picking the port numbers sounds great!
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@mfelgamal yes, exactly. Do you think this is possible? I wonder if the
image size would go down, if we remove those guys after getting `knitr`.
The goal would be to have a _minimal_ image
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1603
ping @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Thank you @1ambda !
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1674
Sounds good, let's take care of small parts first, and then rebase and
merge this guys in a bulk!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1696
I have asked ASF on another side as well
[INFRA-12996](https://issues.apache.org/jira/browse/INFRA-12996)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Here are more detailed logs
```
[WARNING] Retrying (4 more)
Downloading:
http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1701
Looks good to me.
Usually, it's better to have JIRA issue to keep author\attribution
information for the release.
Merging to master if there is no further discussion
---
If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Prev plugin version seems to have same behavior
```
[ERROR] Failed to execute goal
com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget
(download-pyspark-files
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1698
CI failure seems like a candidate for JIRA issue with `flaky-test` label
```
Failed tests:
ZeppelinSparkClusterTest.zRunTest:346 expected: but was:
```
Seems un
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
thanks a lot, @1ambda !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Sounds reasonable. CI is green, merging to master then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1700
Looks good to me, merging to master as a hotfix based on user feedback in
[this thread](http://markmail.org/message/4z6hxxf3eem2wgp2), if there is no
further discussion.
---
If your project is set
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1696
Spark 2.0 profile fails with very stragne
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check
(checkstyle-fail-build) on project zeppelin
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1679
Looks good to me.
CI is green now, so will merge it to master if there is no further
discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1693
Looks great to me, thank you @1ambda
Merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Looks great to me, thank you @1ambda !
May be, as soon as CI is green let's try to squash some commits, before
merging it in - 37 may be a bit too much to be useful in merge commit message
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1632
I think it is mostly the test output that pollutes the CI logs...
So, if I read TravisCI logs right - with 2 new profiles `Elapsed time 31
min`, and on `master` i.e
[yesterday](https
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Thank you @1ambda !
I think it's a great idea to have checkstyle off the most of profiles, but
add a new one with just checkstyle.
After CI finishes, let's post the CI time statistics
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1690
Looks great to me, thank you for taking care of both, Eclipse and IDEA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thank you @Leemoonsoo ! Merging to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1632
Thank you for CI failure assessment @agoodm !
How do you think, how crucial are those tests? May be just documenting on
how to run them manually could be an option?
Generally, we
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thank you for review @felizbear !
> it increases npm test time since it tries to install phantom every time
but it reduces `npm install` time, and as soon as on CI we only do
inst
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
to recap - theare are two final things, that would be very nice to have in
this image:
- find a way to reduce base image size from ~500mb i.e by installing R
without `build-base make gcc g
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
> if we want to make dockerfile to the latest version from zeppelin which
haven't a binary version
This better be handled under a separate JIRA issue as this one is about
`[ZEPPELIN-1
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@agoodm as CI is failing - could you please rebase on latest master, it has
some CI improvements and then open\close the PR to trigger a new CI here again?
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thanks for review @1ambda ! Not sure about version number, so kept it blank
for now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
@1ambda it looks like rebase is needed after few other `pom.xml`
modifications got merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Looks great to me and CI is green now.
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Great, CI is green now!
Merging to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
\cc @afsanjar @felizbaer for reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Awesome, ð for tests and a great commit\history structure that allows
just to skip one and preserve all the work!
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1662
Thanks!
Looks great to me, will merge to master as soon as CI is green, if there is
no further discussion.
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Thank you for double-checking and explanations. Looks like CI is failing
right now though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts looks like CI is failing. Do you know the reason? If you try
open\close the PR, can it be reproduced?
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Great job @mfelgamal !
The idea was to try to avoid building separate artefacts for Docker and use
official convenience binaries from Apache release.
Am I mimssing something
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Thank you @AhyoungRyu for great job and taking care in addressing the [user
experience
concerns](https://github.com/apache/zeppelin/pull/1339#issuecomment-259683752)!
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
CI is green now.
Looks great to me, merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1662
@1ambda thank you for great effort! It's a bit hard to review as
re-formatting is mixed with pom.xml modifications.
How hard would be to have 2 separate PRs - one with improvements
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1600
@aspen01 thank you for contribution!
Could you please double-check that all new files, as any other file in
Apache Zeppelin, have [ASF's Apache 2.0 license
header](http://www.apache.org
1 - 100 of 535 matches
Mail list logo
