Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1124
CI is green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1129
CI is green now! :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1044
RIght, in you fork you need to pull the master from apache git and then
rebase this branch on top of it, resolving the conflicts.
---
If your project is set up for it, you can reply to this email
Github user bzz closed the pull request at:
https://github.com/apache/zeppelin/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bzz reopened a pull request:
https://github.com/apache/zeppelin/pull/1124
ZEPPELIN-1105: Python - add paragraph ERROR status
### What is this PR for?
Implement paragraph ERROR status for Python interpreter in case of Error or
Exception in the output
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1124
Thank you @minahlee for prompt review and notice on CI fix, I really
appreciate!
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1126
Thank you for improvement!
Looks great, I think same question as in #1125 apply here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1123
Looks good to me,
as for CI failure - did you check JIRA issues, esp with flack-test label?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1125
Looks great, ð for tests if it's possible.
\cc @jongyoul as person who recently worked most on JDBC interpreters for a
review
---
If your project is set up for it, you can reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1124
reabsed on latest master
ping @khalidhuseynov @minahlee @jongyoul for a review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1128
Looks good to me, let's merge asap as HOTFIX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1129
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1124
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz closed the pull request at:
https://github.com/apache/zeppelin/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1124
Ready to merge, \cc @minahlee @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1124
ZEPPELIN-1105: Python - add paragraph ERROR status on Error or Exception
### What is this PR for?
Implement paragraph ERROR status for Python interpreter in case of Error or
Exception
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1104
So you think `resultRefreshed ` condition is not useful check any more?
\cc @felizbear @corneadoug for review
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov one thing: as soon as this changes the URL - you might
want to double-check and make sure that URLs to each separate paragraph
(+IFrame ones) and a Search work with new URL
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/957
@jongyoul how do you think, shall we close this one for now and re-open it
later or do you still work on it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1030
@astroshim Merged, next time please check JIRA issue - it should be
assigned to somebody (you, in this case) and has a "Fix Version" set.
This simplified life of the release man
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
### CI failure debug approach
First thing to do in order to debug such issues:
- link all raw build logs
- extact and systematize failure resaons from logs (usulaly it's last
'exited
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1064
Thank you!
Looks good to me, mering if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1094
CI failure is not related and handled under
[ZEPPELIN-1073](https://issues.apache.org/jira/browse/ZEPPELIN-1073)
Merging if there is no further disucssion
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1090
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1092
CI passes now, and changes looks great to me.
Let's merge if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1094
Ready to be merged, \cc @minahlee @prabhjyotsingh for review.
CI failure is being taken care of under #1092
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1091
@prabhjyotsingh on closing the JIRA issues, please do not forget to set
correct `fix version` field.
It's 0.7.0 now if changes were merged only to master, I have updated 1065
---
If your
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1094
ZEPPELIN-1063: fix flaky python interpreter test
### What is this PR for?
fix flaky python interpreter test
### What type of PR is it?
Bug Fix
### Todos
* [ ] cleanup
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1090
Looks great to me, thank you for fixing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1030
There are multiple CI failures
- JSON parsing failure somewhere in websocket communication
```
Running
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1075
Thank you guys for fast catching this one and HotFixing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
done in 97f25e2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
cherry-picking to branch-0.6 fails with merge conflicts as master and
branch-0.6 diverged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1063
Looks awesome to me, thank you!
I think it's ready to merge, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
Thank you guys for the prompt reviews!
@Leemoonsoo agree on API change and I'm glad to have it merged in 0.6,
updated JIRA
@minahlee review addressed in 3b1ad36
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1067
It is ready to be merged now.
TODOs will be addressed in different PR, after #1063 is merged
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1067
ZEPPELIN-1048: Pandas support for python interpreter
### What is this PR for?
### What type of PR is it?
Feature
### Todos
* [x] fix NPE in logs on empty paragraph
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1063
BTW while we are here, how do you think shall we also set
`zeppelin.python.maxResult` to 1000?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1063
Looks great to me, thank you @minahlee !
Will merge, if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1042
Both suggestions are nice addition, and there is also a refactoring on
TODOs so I guess it's WIP now.
ð for making it part of the release, as discussed dev@z.a.o
---
If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Thank you very much @onkarshedge ! I will go though it and let you know
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1013
Ok, thanks for explanation, this was not a strong opinion, just a question.
Sounds good to me.
@minahlee what do you think?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
That sounds great @rawkintrevo on licenses !
Sorry, in preparation to 0.6 release people get quite busy..
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/919
To be able to change indention is very reasonable option, esp. as soon as
you start working with Python.
@astroshim It could be hard to implement per-interpreter as @Leemoonsoo
suggests
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/994
Got it, thank for reminding! Let's merge this guy then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1033
CI failed due to networking issues
```
INFO: I/O exception (java.net.SocketException) caught when processing
request to {s}->https://repo.maven.apache.org:443: Connection reset
Jun
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1034
Sounds great! Shall we merge this guy then, and handle this nasty click in
`ParagraphActionIT.testCreateNewButton` in separate pr?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1043
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/994
Looks awesome to me, thank you @minahlee !
2 minor things are a bit confusing:
- the purpose of `dev/publish_release.sh.hehe` file
- some artifacts (namely, integration for Geode
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1034
Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1032
Makes perfect sense to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1033
Python: fix for 'run all' paragraphs
### What is this PR for?
Switch to FIFO scheduler as in current implementation `.interpret()` is not
thread-safe and so in parallel one 'Run All' fails some
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1032
I'm planning to add at least one more tutorial notebook of using python,
something similar to what we have for Apache Spark but with pandas and
matplotlib etc.
Do you guys think advanced one
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1032
ZEPPELIN-1027: Python - add basic matplotlib example notebook
### What is this PR for?
It adds basic matplotlib example notebook.
### What type of PR is it?
Improvement
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1028
@prabhjyotsingh if we could point what is the reason of failure and link to
either PR or existing JIRA issue that handles it - that could help improve our
infrastructure a lot
Looks good
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1024
Now this PR contains some commits that do not belong here, and it either
needs to be re-created from a separate branch as @corneadoug points out, or
interactively rebased with keeping only good
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
Great work, @rawkintrevo ! It looks like a rebase on the latest master is
needed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1023
Looks great to me, thank you @AhyoungRyu @felixcheung !
Let's merge if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1010
Looks great to me, thank you @AhyoungRyu
Will merge to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1018
Sounds great, thank you for explanation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/966
Yes.. and this method does not work if the default interpreter is set to
Python for the notebook
 output
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1007
Good point, if asked, I would say that having `NotebookRepoSync implements
NotebookRepo` is not an elegant design either - NotebookRepoSync is not a
NoteboksRepo! :)
It's up to you after all
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
@corneadoug as a first step, how about re-open the PR to trigger CI and
see, which ones are reproducible by posting same report for new CI build
results?
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1015
Two CI failures here
1. **Python test failure**
[logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137725472/log.txt)
AFAIK never seen before (might be related to #1009
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1017
@davidtzoor great to see new visualization! Could you rebase on top of the
latest master please?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/994
Thank you for the feedback @echarles !
I think it should be fine to add missing bits, as soon as they are
identified and there is somebody with actual use case for it later on. Would
you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge I understand that it's WIP, just wanted to remind that
eventually your `NotebookRepo` implementation should user
`NotebookRepoVersioned`, see Git one as an example.
Could you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/933
@swakrish do you think it's ready to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1010
@AhyoungRyu great job! Let me take another pass on it plz.
BTW is removal of `conf/shiro.ini` a part of the quickstart?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1000
Last commit needs to be removed by using git interactive rebase, as it's
been taken care of under #1009
It would also be great to have more descriptive PR title like `Fix typo in
bin
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1007
Thank you for addressing feedback promptly.
Well, in my oppinion, if by "encourage more versioned implementation" you
mean having this code duplicated 5 times around the code base
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1002
Looks great to me and CI passes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1009
Thank you for the prompt responce!
CI passes now and fix solves the issue and looks great to me.
Merging if there is no further discussion.
---
If your project is set up
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1012
Thank you @jongyoul, ð for having tests!
Improving this further by generalizing to other interpreters after a
release sounds like a very good plan.
Looks great to me.
---
If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1005
Looks great, thank you for prompt update!
@jongyoul is there a reason to make it configurable from another PR instead
of this one? Just curious
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1007
Great improvement!
Could you please explain the rationale behind removing
`NotebookRepoVersioned` and making a lot of boilerplate methods returning
`null` in all other notebook storages
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1009
@OutOfBedlam thank you for catching this and contributing the improvement!
Before merging, could you please check that your code follows [project code
style
guide](https://github.com/apache
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1011
Thanks for catching it, looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/908
@cloverhearts exciting changes! This would help us to make convenience
binary for a release smaller as well
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/994
Looks great, I think there are just few things left:
- rebased on latest master
- check that code conforms the [conventions from our style
guide](https://github.com/apache/zeppelin/blob
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1002
@jongyoul the CI failure I can see does not seem to be part of any existing
open sub-task in
[ZEPPELIN-878](https://issues.apache.org/jira/browse/ZEPPELIN-878)
```
09:02:21,815 ERROR
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/984
@AhyoungRyu there are 2 different test failures on CI here:
**Integration test** fails
https://s3.amazonaws.com/archive.travis-ci.org/jobs/137185986/log.txt
```
Tests in error
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/978
@ravicodder thank you for improvement!
\cc @felizbear as original author of search frontend for a review
---
If your project is set up for it, you can reply to this email and have
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/974
Great work @jongyoul !
Looks good to me except minor things listed above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
Looks great to me, let's merge as a short term solution.
And yes, as @felixcheung mentioned - in a mid\long term, it would be great
for interpreter to encapsulate this knowledge
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/977
Looks great to me, @rerngvit thank you for contribution!
Have update JIRA issues assignment.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/968
That is a great suggesting, @lresende ! There already were discussions
about if I recall.
Let's do so in separate PR though, so we could narrow the scope of
discussion
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/960
Looks great to me, @cloverhearts thank you for catching it.
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
401 - 500 of 535 matches
Mail list logo
