[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 @astroshim Merged, next time please check JIRA issue - it should be assigned to somebody (you, in this case) and has a "Fix Version" set. This simplified life of the release man

[GitHub] zeppelin issue #928: [ZEPPELIN-116] Add Mahout Support for Spark Interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/928 ### CI failure debug approach First thing to do in order to debug such issues: - link all raw build logs - extact and systematize failure resaons from logs (usulaly it's last &#

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 Merging if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1100 Looks good to me, \cc @corneadoug @felizbear for review of the frontend part --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1064: BugFix-blocking of blank values insertion on the Crede...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1064 Thank you! Looks good to me, mering if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1094: ZEPPELIN-1063: fix flaky python interpreter test

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1094 CI failure is not related and handled under [ZEPPELIN-1073](https://issues.apache.org/jira/browse/ZEPPELIN-1073) Merging if there is no further disucssion --- If your project is set up for it

[GitHub] zeppelin issue #1094: ZEPPELIN-1063: fix flaky python interpreter test

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1094 CI fails on Integration tests, and failure looks different from #1091 and #1092 ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 143.455 sec - in

[GitHub] zeppelin issue #1090: [MINOR] Blocking the minus cursor value.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1090 Merging if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 Looks great to me! Let's create a JIRA issue for current failure with label `flaky-tests` and merge this! --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1094: ZEPPELIN-1063: fix flaky python interpreter test

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1094 Rebased on latest master, after #1092 got merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1092: [ZEPPELIN-1064] Flaky Test - ParagraphActionsIT.testTi...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1092 CI passes now, and changes looks great to me. Let's merge if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] zeppelin issue #1094: ZEPPELIN-1063: fix flaky python interpreter test

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1094 Ready to be merged, \cc @minahlee @prabhjyotsingh for review. CI failure is being taken care of under #1092 --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1091: [ZEPPELIN-1065] Flaky Test - ParagraphActionsIT.testRe...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1091 @prabhjyotsingh on closing the JIRA issues, please do not forget to set correct `fix version` field. It's 0.7.0 now if changes were merged only to master, I have updated 1065 --- If

[GitHub] zeppelin pull request #1094: ZEPPELIN-1063: fix flaky python interpreter tes...

GitHub user bzz opened a pull request: https://github.com/apache/zeppelin/pull/1094 ZEPPELIN-1063: fix flaky python interpreter test ### What is this PR for? fix flaky python interpreter test ### What type of PR is it? Bug Fix ### Todos * [ ] cleanup

[GitHub] zeppelin issue #1091: [ZEPPELIN-1065] Flaky Test - ParagraphActionsIT.testRe...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1091 Sounds good, and this PR looks great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1091: [ZEPPELIN-1065] Flaky Test - ParagraphActionsIT.testRe...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1091 Thank you for pointing out [ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063) - have updated it's description. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1091: [ZEPPELIN-1065] Flaky Test - ParagraphActionsIT.testRe...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1091 @prabhjyotsingh thank you for fixing this one! What do you think, if would it make sense to reduce total wait time and get this test more stable with a wait polling implementation to locate

[GitHub] zeppelin issue #1090: [MINOR] Blocking the minus cursor value.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1090 Looks great to me, thank you for fixing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1041: Get note revision of note - git repo

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1041 Looks awesome to me, CI failure tacked under [ZEPPELIN-862](https://issues.apache.org/jira/browse/ZEPPELIN-862) ``` 23:25:52,963 INFO org.apache.zeppelin.socket.NotebookServer:1193 - Job

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 There are multiple CI failures - JSON parsing failure somewhere in websocket communication ``` Running

[GitHub] zeppelin issue #928: [ZEPPELIN-116] Add Mahout Support for Spark Interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/928 Thank you for your patience! Could you rebase your work on latest master please and I'll be happy to look into the CI build failures again? --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #836: [ZEPPELIN-732] Helium Application

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/836 Looks great, do you plan to rebase on master as well? I think there was also @anish18sun using it under [ZEPPELIN-684](https://issues.apache.org/jira/browse/ZEPPELIN-684) so \cc @anish18sun

[GitHub] zeppelin issue #1075: [HOTFXI] Fix python test case and resolve rat license ...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1075 Thank you guys for fast catching this one and HotFixing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1067 done in 97f25e2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1067 cherry-picking to branch-0.6 fails with merge conflicts as master and branch-0.6 diverged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1063: [ZEPPELIN-1045] Apply new mechanism to PythonInterpret...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1063 Looks awesome to me, thank you! I think it's ready to merge, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1067 Thank you guys for the prompt reviews! @Leemoonsoo agree on API change and I'm glad to have it merged in 0.6, updated JIRA @minahlee review addressed in 3b1ad36 If there

[GitHub] zeppelin issue #1067: ZEPPELIN-1048: Pandas support for python interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1067 It is ready to be merged now. TODOs will be addressed in different PR, after #1063 is merged --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin pull request #1067: ZEPPELIN-1048: Pandas support for python interp...

GitHub user bzz opened a pull request: https://github.com/apache/zeppelin/pull/1067 ZEPPELIN-1048: Pandas support for python interpreter ### What is this PR for? ### What type of PR is it? Feature ### Todos * [x] fix NPE in logs on empty paragraph

[GitHub] zeppelin issue #1063: [ZEPPELIN-1045] Apply new mechanism to PythonInterpret...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1063 BTW while we are here, how do you think shall we also set `zeppelin.python.maxResult` to 1000? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1065: FIX merge mistake on Branch 0.6

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1065 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1063: [ZEPPELIN-1045] Apply new mechanism to PythonInterpret...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1063 Looks great to me, thank you @minahlee ! Will merge, if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1042: [WIP] bin/install-interpreter.sh for netinst package

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1042 Both suggestions are nice addition, and there is also a refactoring on TODOs so I guess it's WIP now. 👍 for making it part of the release, as discussed dev@z.a.o --- If your proje

[GitHub] zeppelin issue #989: Added ipfsnotebookrepo [ Zeppelin-683 WIP ]

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/989 Thank you very much @onkarshedge ! I will go though it and let you know --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1013 Ok, thanks for explanation, this was not a strong opinion, just a question. Sounds good to me. @minahlee what do you think? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #928: [ZEPPELIN-116] Add Mahout Support for Spark Interpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/928 That sounds great @rawkintrevo on licenses ! Sorry, in preparation to 0.6 release people get quite busy.. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1055: [ZEPPELIN-1028] Fix exported notebook importing error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1055 Looks good to me, let's test and merge right after #1043 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1030: [ZEPPELIN-1023] Add more credential apis.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1030 👍 for having tests! Two things: 1. Code Instead of locking on the map (`synchronized(credentialsMap){...}`), would it make sense to rather replace `credentialsMap` with

[GitHub] zeppelin issue #919: support changing tabsize of paragraph

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/919 To be able to change indention is very reasonable option, esp. as soon as you start working with Python. @astroshim It could be hard to implement per-interpreter as @Leemoonsoo suggests for

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 Got it, thank for reminding! Let's merge this guy then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1043: [ZEPPELIN-905] Fix import notebook with error result

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1043 I think we should merge it ASAP as per [ZEPPELIN-889](https://issues.apache.org/jira/browse/ZEPPELIN-889) this blocks us from makeing a release. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1041: Get note revision of note - git repo

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1041 Looks great to me, sans rebased on master and a minor javadoc issue above. I think it's good to merge as soon as those are addressed. --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #1032: ZEPPELIN-1027: Python - add basic matplotlib example n...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1032 Thank you for prompt reviews! Merging fi there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1033: Python: fix for 'run all' paragraphs

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1033 CI failed due to networking issues ``` INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset Jun

[GitHub] zeppelin issue #1034: [ZEPPELIN-1009] [HOTFIX] Fix Selenium test error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1034 Sounds great! Shall we merge this guy then, and handle this nasty click in `ParagraphActionIT.testCreateNewButton` in separate pr? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1013 Now we have 3 drop-down menus :) Are you guys sure that we can not get away with just 2 of them i.e 'logout' instead of 'about' in under the gear icon? Also, for the

[GitHub] zeppelin issue #989: Added ipfsnotebookrepo [ Zeppelin-683 WIP ]

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/989 Hi @onkarshedge, as mid-term evaluation starts soon, I think it's crucial to get answers on 2 previous questions now. >Could you also point to some document with high-level descriptio

[GitHub] zeppelin issue #1043: [ZEPPELIN-905] Fix import notebook with error result

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1043 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 Looks awesome to me, thank you @minahlee ! 2 minor things are a bit confusing: - the purpose of `dev/publish_release.sh.hehe` file - some artifacts (namely, integration for Geode and

[GitHub] zeppelin issue #1034: [ZEPPELIN-1009] [HOTFIX] Fix Selenium test error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1034 Looks great to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1032: ZEPPELIN-1027: Python - add basic matplotlib example n...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1032 Makes perfect sense to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1033: Python: fix for 'run all' paragraphs

GitHub user bzz opened a pull request: https://github.com/apache/zeppelin/pull/1033 Python: fix for 'run all' paragraphs ### What is this PR for? Switch to FIFO scheduler as in current implementation `.interpret()` is not thread-safe and so in parallel one 'Run

[GitHub] zeppelin issue #1032: ZEPPELIN-1027: Python - add basic matplotlib example n...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1032 I'm planning to add at least one more tutorial notebook of using python, something similar to what we have for Apache Spark but with pandas and matplotlib etc. Do you guys think advance

[GitHub] zeppelin pull request #1032: ZEPPELIN-1027: Python - add basic matplotlib ex...

GitHub user bzz opened a pull request: https://github.com/apache/zeppelin/pull/1032 ZEPPELIN-1027: Python - add basic matplotlib example notebook ### What is this PR for? It adds basic matplotlib example notebook. ### What type of PR is it? Improvement

[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1028 @prabhjyotsingh if we could point what is the reason of failure and link to either PR or existing JIRA issue that handles it - that could help improve our infrastructure a lot Looks good to

[GitHub] zeppelin issue #1024: Add force layout visualization in paragraphs for SQL q...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1024 Now this PR contains some commits that do not belong here, and it either needs to be re-created from a separate branch as @corneadoug points out, or interactively rebased with keeping only good

[GitHub] zeppelin issue #928: [ZEPPELIN-116][WIP] Add Mahout Support for Spark Interp...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/928 Great work, @rawkintrevo ! It looks like a rebase on the latest master is needed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1015 @corneadoug sounds good! Screenshot is in the logs in base64. Could you post current CI failure in the same way as I did above? Then we could iterate faster on it --- If your project is set up

[GitHub] zeppelin issue #1023: [gh-pages][ZEPPELIN-996] Update first page of Zeppelin...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1023 Looks great to me, thank you @AhyoungRyu @felixcheung ! Let's merge if there is no further discussion --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1010: [ZEPPELIN-998][WIP] Extend install.md -> Quick Start

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1010 Looks great to me, thank you @AhyoungRyu Will merge to master, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1018: Blocking the zeppelin-web build error.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1018 Sounds great, thank you for explanation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1015 on #1021 in [logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137973583/log.txt) I can see **ParagraphActionsIT.testRemoveButton

[GitHub] zeppelin issue #966: [ZEPPELIN-958] Support syntax highlight for python and ...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/966 Yes.. and this method does not work if the default interpreter is set to Python for the notebook ![screen shot 2016-06-17 at 01 03 50](https://cloud.githubusercontent.com/assets/5582506/16123862

[GitHub] zeppelin issue #1021: Python interpreter and doc cleanup

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1021 Thank you for prompt reviews! Merging if there is no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1013 @corneadoug thanks for posting screen! It looks reasonable > and put every items under this single button? > Either way, i think it's better than now. True, as soon as

[GitHub] zeppelin issue #933: [ZEPPELIN-905] fix failed notebook import bug

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/933 @swkimme ping on the status of this patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 @minahlee Great! I think it should be ready to merge as soon as issues highlighted above a. failing networking `curl` b. build configuration duplication are

[GitHub] zeppelin issue #1021: Python interpreter and doc cleanup

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1021 CI failure is not related and is taken care of under #1015 ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.3 sec - in

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1013 > @bzz actually, last time I tested, the about dropdown was doing great on mobile Have you already tested 2 proposed dropdowns on mobile? If possible, plz share the screenshots --- If y

[GitHub] zeppelin issue #1014: Remove Incubator and fix typos in README

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1014 Let's merge the guy if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1016: Bump up version to 0.7.0-SNAPSHOT

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1016 @minahlee looks great, let's merge it @darionyaphet all release-related question are discussed on dev@ mailing list and tracked under [ZEPPELIN-889](https://issues.apache.org/jira/b

[GitHub] zeppelin issue #1018: Blocking the zeppelin-web build error.

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1018 Is it a build WARNING or an actual error? Asking as have not seen CI build failure due to this error before --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #1021: Python interpreter and doc cleanup

GitHub user bzz opened a pull request: https://github.com/apache/zeppelin/pull/1021 Python interpreter and doc cleanup ### What is this PR for? This is first step improving current Python interpreter implementation. It has just a cleanup, style and docs improvements

[GitHub] zeppelin issue #1020: [HOTFIX][DOC] Fix image path

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1020 👍 looks great, let's merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] zeppelin issue #836: [ZEPPELIN-732] Helium Application

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/836 @khalidhuseynov Just FYI, this PR adds 4 new messages websocket protocol: ``` APP_APPEND_OUTPUT, // [s-c] append output APP_UPDATE_OUTPUT, // [s-c] update (replace) output

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1013 Just FYI - please mind that second menu should play nice with mobile layout. As first one is collapsed on mobile, even right now with just a search search - it sometimes is not enough space

[GitHub] zeppelin issue #836: [ZEPPELIN-732] Helium Application

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/836 Great stuff!! It's going to take some time to review. @Leemoonsoo @minahlee Please help me understand, do you think this should be included in 0.6.0 release? As I do not see [ZEPPELI

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1007 Good point, if asked, I would say that having `NotebookRepoSync implements NotebookRepo` is not an elegant design either - NotebookRepoSync is not a NoteboksRepo! :) It's up to you afte

[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1015 @corneadoug as a first step, how about re-open the PR to trigger CI and see, which ones are reproducible by posting same report for new CI build results? --- If your project is set up for it, you

[GitHub] zeppelin issue #1015: [ZEPPPELIN-1009] Trying to Fix selenium modal error

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1015 Two CI failures here 1. **Python test failure** [logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/137725472/log.txt) AFAIK never seen before (might be related to #1009

[GitHub] zeppelin issue #1017: Add force layout visualization in paragraphs for SQL q...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1017 @davidtzoor great to see new visualization! Could you rebase on top of the latest master please? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 Thank you for the feedback @echarles ! I think it should be fine to add missing bits, as soon as they are identified and there is somebody with actual use case for it later on. Would you be

[GitHub] zeppelin issue #976: ZEPPLIN-976 ] HotFix - zeppelin server does not restart...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/976 @cloverhearts thank you for adding tests! Looks great to me, merging if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 Great, I think if checking error conditions could be added to network-related commands - it would be even more awesome, as this is quite common failure pattern. Other then that, looks great

[GitHub] zeppelin issue #989: Added ipfsnotebookrepo [ Zeppelin-683 WIP ]

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/989 @onkarshedge I understand that it's WIP, just wanted to remind that eventually your `NotebookRepo` implementation should user `NotebookRepoVersioned`, see Git one as an example. Coul

[GitHub] zeppelin issue #933: [ZEPPELIN-905] fix failed notebook import bug

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/933 @swakrish do you think it's ready to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1010: [ZEPPELIN-998] Extend install.md -> Quick Start

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1010 Thanks for prompt response! Your documentation update looks great to me, modulo few minor suggestions above. Please feel free to use them at your will, otherwise I think it's rea

[GitHub] zeppelin issue #1010: [ZEPPELIN-998] Extend install.md -> Quick Start

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1010 @AhyoungRyu great job! Let me take another pass on it plz. BTW is removal of `conf/shiro.ini` a part of the quickstart? --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1000: typo

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1000 Last commit needs to be removed by using git interactive rebase, as it's been taken care of under #1009 It would also be great to have more descriptive PR title like `Fix typo in

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1007 Thank you for addressing feedback promptly. Well, in my oppinion, if by "encourage more versioned implementation" you mean having this code duplicated 5 times around the code base

[GitHub] zeppelin issue #1002: ZEPPELIN-992 Move some tests from InterpreterFactoryTe...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1002 Looks great to me and CI passes now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1009: Prevent NullPointerException if "gatewayServer" does n...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1009 Thank you for the prompt responce! CI passes now and fix solves the issue and looks great to me. Merging if there is no further discussion. --- If your project is set up for it

[GitHub] zeppelin issue #1012: ZEPPELIN-999 Support alias for JDBC properties

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1012 Thank you @jongyoul, 👍 for having tests! Improving this further by generalizing to other interpreters after a release sounds like a very good plan. Looks great to me. --- If your

[GitHub] zeppelin issue #1005: ZEPPELIN-995 Change scheduler for JDBC interpreter to ...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1005 Looks great, thank you for prompt update! @jongyoul is there a reason to make it configurable from another PR instead of this one? Just curious --- If your project is set up for it, you

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1007 Great improvement! Could you please explain the rationale behind removing `NotebookRepoVersioned` and making a lot of boilerplate methods returning `null` in all other notebook storages

[GitHub] zeppelin issue #1009: Prevent NullPointerException if "gatewayServer" does n...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1009 @OutOfBedlam thank you for catching this and contributing the improvement! Before merging, could you please check that your code follows [project code style guide](https://github.com/apache

[GitHub] zeppelin issue #1011: Update licenses

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1011 Thanks for catching it, looks great to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #908: ZEPPELIN-598 ] Dynamic loading for Interpreter and API

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/908 @cloverhearts exciting changes! This would help us to make convenience binary for a release smaller as well --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/994 Looks great, I think there are just few things left: - rebased on latest master - check that code conforms the [conventions from our style guide](https://github.com/apache/zeppelin/blob

[GitHub] zeppelin issue #976: ZEPPLIN-976 ] HotFix - zeppelin server does not restart...

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/976 @cloverhearts yes, if that is not very hard to do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

<    1   2   3   4   5   6   7   >