[GitHub] zeppelin pull request #1101: [ZEPPELIN-1072] Saving Interpreter Setting dose...

2016-06-28 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1101 [ZEPPELIN-1072] Saving Interpreter Setting dosen't notify when its finished ### What is this PR for? When user tries to save Interpreter Setting, it does not notify user when its done

[GitHub] zeppelin issue #1086: [Zeppelin 1042] Extra space is present as part of user...

2016-06-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1086 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1091: [ZEPPELIN-1065] Flaky Test - ParagraphActionsIT.testRe...

2016-06-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1091 @bzz fair point; - have refactored all AbstractZeppelinIT's sleep calls into ZeppelinITUtils. - added another function clickAndWait, which will click and wait for 1s

[GitHub] zeppelin pull request #1091: [ZEPPELIN-1065] add delay after deleting paragr...

2016-06-27 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1091 [ZEPPELIN-1065] add delay after deleting paragraph. ### What is this PR for? This is for fixing flaky CI failing test ``` testRemoveButton

[GitHub] zeppelin issue #1052: ZEPPELIN-1037 Enable Kerberos support in Livy Interpre...

2016-06-27 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1052 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1080: [ZEPPELIN-1060] validate user before saving

2016-06-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1080 Ready for review CI fails for #5326.1, Which is unrelated. ``` --- T E S T S

[GitHub] zeppelin issue #1052: ZEPPELIN-1037 Enable Kerberos support in Livy Interpre...

2016-06-26 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1052 Have tested it, it works on a Kerberos enabled system. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1060: [MINOR] [ZEPPELIN-1043] Blocked in inaccessible notebo...

2016-06-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1060 Going back i.e. `history.back()`wouldn't for if someone has shared a link (for example) over chat/email on which you don't have access to. Hence, I would recommend

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

2016-06-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1079 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1084: [HOTFIX] Fix flaky AuthenticationIT

2016-06-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1084 @minahlee @bzz @Leemoonsoo After merging this CI is now failing (Build #5323.1) with ``` --- T E S T S

[GitHub] zeppelin pull request #1080: [ZEPPELIN-1060] validate user before saving

2016-06-24 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1080 [ZEPPELIN-1060] validate user before saving ### What is this PR for? Zeppelin notebook permissions change has an issue while reconfiguring permissions by clearing textbox

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

2016-06-24 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1079 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1071: [ZEPPELIN-1052] Application does not logout user when ...

2016-06-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1071 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1071: [ZEPPELIN-1052] Application does not logout use...

2016-06-23 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1071 [ZEPPELIN-1052] Application does not logout user when authcBasic is used ### What is this PR for? This PR is WRT to [this](http://apache-zeppelin-users-incubating-mailing-list.75479

[GitHub] zeppelin issue #1070: [HOTFIX] Fix compile error caused by merging #1043

2016-06-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1070 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1051: increase more logs, and return appropriate error to fr...

2016-06-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1051 CI fails for #5104.1 ``` Results : Failed tests: ZeppelinSparkClusterTest.sparkRTest:104 expected: but was: ``` #5104.7

[GitHub] zeppelin issue #1051: increase more logs, and return appropriate error to fr...

2016-06-20 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1051 @jongyoul Thank you for the review, have made relevant change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1051: increase more logs, and return appropriate erro...

2016-06-20 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1051 increase more logs, and return appropriate error to front-end ### What is this PR for? In the current implementation JDBC interpret only catches SQLException

[GitHub] zeppelin issue #1042: [WIP] bin/install-interpreter.sh for netinst package

2016-06-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1042 One more feature request for this, with downloading an interpreter, creation/insertion of relevant entry in `conf/interpreter.json` --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click

2016-06-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1027 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter

2016-06-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1028 Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1032: ZEPPELIN-1027: Python - add basic matplotlib example n...

2016-06-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1032 Good one, we should have it. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1036: [MINOR] Add .Rhistory in .gitignore

2016-06-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1036 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click

2016-06-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1027 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1028: [Zeppelin-1022] Apply new mechanism to LivyInterpreter

2016-06-17 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1028 @bzz I was referring to https://github.com/apache/zeppelin/pull/1034, ZEPPELIN-1009. ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.524 sec

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 I think we should as this is to do with AD auth. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1029: [ZEPPELIN-698] #756 Added new shortcuts but didn't rem...

2016-06-16 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1029 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1028: [Zeppelin-1022] Apply new mechanism to LivyInte...

2016-06-16 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/1028 [Zeppelin-1022] Apply new mechanism to LivyInterpreter ### What is this PR for? Apply new mechanism to LivyInterpreter ### What type of PR is it? [Improvement

[GitHub] zeppelin issue #993: [ZEPPELIN-987] Enable user to secure interpreter settin...

2016-06-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/993 @AhyoungRyu is this still a work in progress ? Is there a way in which we can go away with seeing all of these three munu i.e. Interpreter setting, Credentials and Configurations

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 @rja1 have made some changes, hope this(188ac170c7a0921044f301ae703bf580a71b2cdf) solves for "activeDirectoryRealm.principalSuffix isn't honoured" --- If your project

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 Hi @rja1, I see two issues in your request; 1. Your AD require you to pass @domainName; I understand in some of the cases, depending on how you have configured AD

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 @vinayshukla, Yes, this fix is for both Active Directory and LDAP. Have tested this with configuring Active Directory running on Windows Server 2008, and on an open LDAP running

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 @Leemoonsoo thank you for taking a look at it. Have added a selenium test case for the same. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...

2016-06-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/996 Sure, I think we can merge this as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

2016-06-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/986 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...

2016-06-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/996 One more suggestion not sure if that is relevant to this PR should we have `5` near https://github.com/apache/zeppelin/blob/master/spark-dependencies/pom.xml#L827 and https

[GitHub] zeppelin pull request #992: [ZEPPELIN-980] missing "incubation-" references

2016-06-10 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/992 [ZEPPELIN-980] missing "incubation-" references ### What is this PR for? This is extension to https://github.com/apache/zeppelin/pull/983, with missing references of

[GitHub] zeppelin pull request #986: [Zeppelin 946] [WIP] Permissions not honoring gr...

2016-06-10 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/986 [Zeppelin 946] [WIP] Permissions not honoring group ### What is this PR for? Error: Insufficient privileges to write notebook. Allowed users or roles: [admin, zeppelinWrite

[GitHub] incubator-zeppelin issue #944: [ZEPPELIN-935] Adding more configurations to ...

2016-06-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/944 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin issue #951: Move zeppelin version from home page to about...

2016-06-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/951 Thanks for the explanation. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin issue #956: [ZEPPELIN-923] Apply new mechanism to ShellIn...

2016-06-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/956 @AhyoungRyu have made a fix #4492.7 failed #958. Can you rebase with master, and re-trigger ? And yes other is `[INFO] Rat check: Summary of files. Unapproved: 1 unknown

[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...

2016-06-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/959 Hi @minahlee, This CI failure is fixed with #958. Can you rebase with master and re-trigger ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-zeppelin issue #960: ZEPPELIN-953 ] Jquery.floatThead delete the i...

2016-06-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/960 This CI failure was fixed with https://github.com/apache/incubator-zeppelin/pull/958. Can you rebase with master and re-trigger ? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin issue #958: [Hot Fix] Fix flaky ZeppelinIT build

2016-06-03 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/958 Tried it 4 different times - https://travis-ci.org/apache/incubator-zeppelin/builds/135110386 - https://travis-ci.org/apache/incubator-zeppelin/builds/135119542

[GitHub] incubator-zeppelin pull request #958: [Hot Fix] Fix flaky ZeppelinIT build

2016-06-03 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/958 [Hot Fix] Fix flaky ZeppelinIT build ### What is this PR for? Master is failing for ZeppelinIT at testSparkInterpreterDependencyLoading:243, as the previous line's

[GitHub] incubator-zeppelin issue #937: Auto-suggestion feature for notebook permissi...

2016-06-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/incubator-zeppelin/pull/937 Tested it, works well. Auto complete was one of the missing feature. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-zeppelin pull request #951: Move zeppelin version from home page t...

2016-06-02 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/951 Move zeppelin version from home page to about section ### What is this PR for? Move zeppelin version that is shown home page to new about section. ### What type

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...

2016-05-31 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/933#issuecomment-222641325 @swkimme I think this is failing because you are trying to get paragraph result i.e. `p.getResult()` or `p2.getResult()` without running any

[GitHub] incubator-zeppelin pull request: Change website menu caret color

2016-05-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/915#issuecomment-221483256 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: Change the placement of 'Reposito...

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/901#issuecomment-221169107 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-zeppelin pull request: Update/shiro docs

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/907#issuecomment-221167326 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220962020 Or that is also broken for `$locationChangeSuccess`, its not cleaning up. Can you fix this as well ? --- If your project is set up for it, you can

[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...

2016-05-23 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220959983 If we use `$scope.search = function(searchTerm)` then we can [this](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src

<    4   5   6   7   8   9