[GitHub] [zeppelin-site] jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web

2023-09-10 Thread via GitHub
jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin-site] jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web

2023-09-10 Thread via GitHub
jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/zeppelin-site/pull/2 Bumps [jszip](https://github.com/Stuk/jszip) from 3.1.5 to 3.10.1. Changelog Sourced from https://github.com/Stuk/jszip/blob/main/CHANGES.md;>jszip's changelog. v3.10.1

[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/zeppelin-site/pull/1 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from

[GitHub] [zeppelin] jongyoul merged pull request #4626: [MINOR] Change notification emails

2023-06-29 Thread via GitHub
jongyoul merged PR #4626: URL: https://github.com/apache/zeppelin/pull/4626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4626: [MINOR] Change notification emails

2023-06-29 Thread via GitHub
jongyoul commented on PR #4626: URL: https://github.com/apache/zeppelin/pull/4626#issuecomment-1612729433 @zjffdu @Reamer @huage1994 Could you please review this PR? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] jongyoul commented on pull request #4625: [ZEPPELIN-5935] Update jsoup version

2023-06-29 Thread via GitHub
jongyoul commented on PR #4625: URL: https://github.com/apache/zeppelin/pull/4625#issuecomment-1612606501 BTW, why don't we update the latest version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] jongyoul commented on pull request #4615: Bump guava from 24.1.1-jre to 32.0.0-jre in /shell

2023-06-29 Thread via GitHub
jongyoul commented on PR #4615: URL: https://github.com/apache/zeppelin/pull/4615#issuecomment-1612550228 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on pull request #4619: Bump snappy-java from 1.1.8.4 to 1.1.10.1 in /cassandra

2023-06-29 Thread via GitHub
jongyoul commented on PR #4619: URL: https://github.com/apache/zeppelin/pull/4619#issuecomment-1612549882 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul merged pull request #4623: [HOTFIX] Change the location of bank.csv to fix the integration tests

2023-06-29 Thread via GitHub
jongyoul merged PR #4623: URL: https://github.com/apache/zeppelin/pull/4623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4625: [ZEPPELIN-5935] Update jsoup version

2023-06-28 Thread via GitHub
Reamer commented on PR #4625: URL: https://github.com/apache/zeppelin/pull/4625#issuecomment-1610990075 Based on https://mvnrepository.com/artifact/org.jsoup/jsoup do you see a way to patch in the other vulnerability as well? -- This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-28 Thread via GitHub
Reamer commented on code in PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244808864 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java: ## @@ -376,7 +381,7 @@ private NoteNode getNoteNode(String notePath) throws

[GitHub] [zeppelin] jongyoul commented on pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-27 Thread via GitHub
jongyoul commented on PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1610385548 BTW, there are no tests for the features. Could you please add tests for your feature? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-27 Thread via GitHub
jongyoul commented on code in PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244500227 ## zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java: ## @@ -1497,4 +1530,78 @@ private boolean checkPermission(String noteId,

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-27 Thread via GitHub
jongyoul commented on code in PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244498036 ## zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java: ## @@ -1192,24 +1203,38 @@ public void moveFolderToTrash(String folderPath,

[GitHub] [zeppelin] idzikovsky commented on pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-27 Thread via GitHub
idzikovsky commented on PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1609093390 Issues in my last comment were resolved in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] Reamer merged pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-27 Thread via GitHub
Reamer merged PR #4621: URL: https://github.com/apache/zeppelin/pull/4621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-27 Thread via GitHub
Reamer commented on PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#issuecomment-1608925309 > is `web.xml` needed? I think so. I don't think the context is currently being used anywhere. ``` configuration deployment ``` but the

[GitHub] [zeppelin] shefali163 opened a new pull request, #4625: [ZEPPELIN-5935] Update jsoup version

2023-06-26 Thread via GitHub
shefali163 opened a new pull request, #4625: URL: https://github.com/apache/zeppelin/pull/4625 ### What is this PR for? Bump jsoup version for fixing CVE-2021-37714 ### What type of PR is it? Improvement ### What is the Jira issue?

[GitHub] [zeppelin] idzikovsky commented on pull request #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-23 Thread via GitHub
idzikovsky commented on PR #4624: URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1605038003 Sorry, I made this PR on top of 0.10.1 version, and it seems like something has been changed in this filed in master branch since then. Now I have local fix of this issue for

[GitHub] [zeppelin] idzikovsky opened a new pull request, #4624: [ZEPPELIN-5934] Check notebook folder permissions before allowing to rename, remove or restore it

2023-06-22 Thread via GitHub
idzikovsky opened a new pull request, #4624: URL: https://github.com/apache/zeppelin/pull/4624 ### What is this PR for? Users who are able to see notes in some directory can rename, move to trash and remove from trash that directory without being owner or having write permissions for

[GitHub] [zeppelin] jongyoul commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2023-06-21 Thread via GitHub
jongyoul commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1600948242 I like it. I totally believe that we should support JDK 11 even though we lose some old versioned compatibility. Let me try to see it eagerly. -- This is an automated message from

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r123709 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] jongyoul opened a new pull request, #4623: [HOTFIX] Change the location of bank.csv to fix the integration tests

2023-06-21 Thread via GitHub
jongyoul opened a new pull request, #4623: URL: https://github.com/apache/zeppelin/pull/4623 ### What is this PR for? Changing the location of `bank.csv` which is being used in integration tests ### What type of PR is it? Hot Fix ### Todos * [x] - Change the

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236475777 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-21 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236422121 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] LeapYear closed pull request #3947: [ZEPPELIN-5066] Notebook creation fails in Zeppelin 0.9 with namespace collision

2023-06-20 Thread via GitHub
LeapYear closed pull request #3947: [ZEPPELIN-5066] Notebook creation fails in Zeppelin 0.9 with namespace collision URL: https://github.com/apache/zeppelin/pull/3947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-20 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235968470 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-20 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-20 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-20 Thread via GitHub
Reamer commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [zeppelin] dependabot[bot] closed pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-20 Thread via GitHub
dependabot[bot] closed pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent URL: https://github.com/apache/zeppelin/pull/4508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-20 Thread via GitHub
dependabot[bot] commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598894737 Looks like org.apache.ivy:ivy is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-20 Thread via GitHub
Reamer commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598894158 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-20 Thread via GitHub
jongyoul commented on code in PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235074369 ## zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [zeppelin] jongyoul merged pull request #4622: Remove ivy and oro as flink dependency

2023-06-20 Thread via GitHub
jongyoul merged PR #4622: URL: https://github.com/apache/zeppelin/pull/4622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer opened a new pull request, #4622: Remove ivy and oro as flink dependency

2023-06-20 Thread via GitHub
Reamer opened a new pull request, #4622: URL: https://github.com/apache/zeppelin/pull/4622 ### What is this PR for? Currently no longer in use, so the dependency is removed. See: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598025256 ### What type of PR is it?

[GitHub] [zeppelin] zjffdu commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-19 Thread via GitHub
zjffdu commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598025256 I think it is not used any more, can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zeppelin] Reamer commented on pull request #4621: [ZEPPELIN-5933] Polish jetty

2023-06-19 Thread via GitHub
Reamer commented on PR #4621: URL: https://github.com/apache/zeppelin/pull/4621#issuecomment-1597553878 Hi @joakime I hope you are still active in the Jetty project and wanted to take this opportunity to thank you for your detailed

[GitHub] [zeppelin] Reamer opened a new pull request, #4621: [ZEPPELIN-5933] Polish jetty

2023-06-19 Thread via GitHub
Reamer opened a new pull request, #4621: URL: https://github.com/apache/zeppelin/pull/4621 ### What is this PR for? This PR addresses all comments from the following comment. https://github.com/eclipse/jetty.project/issues/6592#issuecomment-897877018 The comments were very helpful

[GitHub] [zeppelin] Reamer commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-18 Thread via GitHub
Reamer commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1596530412 > Are the CI failures related to this change? If not, can this be reviewed? I do not think so. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] Reamer commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-18 Thread via GitHub
Reamer commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1596526453 @zjffdu Do you know why ivy is included here as a dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] Reamer merged pull request #4617: [HOTFIX] Add bank.csv for integration test

2023-06-18 Thread via GitHub
Reamer merged PR #4617: URL: https://github.com/apache/zeppelin/pull/4617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4617: [HOTFIX] Add bank.csv for integration test

2023-06-18 Thread via GitHub
jongyoul commented on PR #4617: URL: https://github.com/apache/zeppelin/pull/4617#issuecomment-1596371748 @Reamer @zjffdu @huage1994 Could you please approve this PR? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] jongyoul merged pull request #4618: [ZEPPELIN-5932] Upgraded h2 version in jdbc

2023-06-18 Thread via GitHub
jongyoul merged PR #4618: URL: https://github.com/apache/zeppelin/pull/4618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
Reamer commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596241260 Thank you, I can reproduce the issue. Can you change the Goal `package` to `verify` in the following line? Then the CI system should run checkstyle. Unfortunately the phase `package`

[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
Reamer commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596191919 I am surprised that there are no errors in the CI. Do you see errors in the CI system? Maybe we should adjust the default build. -- This is an automated message from the Apache Git

[GitHub] [zeppelin] zinal commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
zinal commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187342 > I see. Which Maven command did you run? mvn clean package -DskipTests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
Reamer commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187009 I see. Which Maven command did you run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] zinal commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
zinal commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596182691 > I think it would be good if with this fix the checkstyle plugin is enabled. It seems to be enabled, at least it was complaining without the fixes when I followed the general build

[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
Reamer commented on PR #4620: URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596181619 I think it would be good if with this fix the checkstyle plugin is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] zinal opened a new pull request, #4620: Fixed minor formatting issues preventing the full build

2023-06-18 Thread via GitHub
zinal opened a new pull request, #4620: URL: https://github.com/apache/zeppelin/pull/4620 ### What is this PR for? Fixed minor issues in Java files formatting to make maven-checkstyle-plugin happy ### What type of PR is it? Improvement ### Todos ### What is

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4619: Bump snappy-java from 1.1.8.4 to 1.1.10.1 in /cassandra

2023-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #4619: URL: https://github.com/apache/zeppelin/pull/4619 Bumps [snappy-java](https://github.com/xerial/snappy-java) from 1.1.8.4 to 1.1.10.1. Release notes Sourced from https://github.com/xerial/snappy-java/releases;>snappy-java's

[GitHub] [zeppelin] jongyoul opened a new pull request, #4617: [HOTFIX] Add bank.csv for integration test

2023-06-15 Thread via GitHub
jongyoul opened a new pull request, #4617: URL: https://github.com/apache/zeppelin/pull/4617 ### What is this PR for? Fixing errors for integration test. The file was being served as s3 endpoint but it's not accessible for now ### What type of PR is it? Hot Fix ###

[GitHub] [zeppelin] shefali163 commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
shefali163 commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1592384540 Are the CI failures related to this change? If not, can this be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] jongyoul merged pull request #4133: [ZEPPELIN-5403] Update kubernetes client to 5.4.1 and fix unit tests

2023-06-14 Thread via GitHub
jongyoul merged PR #4133: URL: https://github.com/apache/zeppelin/pull/4133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4616: Bump guava from 31.0.1-jre to 32.0.0-jre in /alluxio

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4616: URL: https://github.com/apache/zeppelin/pull/4616 Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 32.0.0

[GitHub] [zeppelin] dependabot[bot] closed pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] closed pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell URL: https://github.com/apache/zeppelin/pull/4473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4473: Bump guava from 24.1.1-jre to 29.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] commented on PR #4473: URL: https://github.com/apache/zeppelin/pull/4473#issuecomment-1592067168 Superseded by #4615. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4615: Bump guava from 24.1.1-jre to 32.0.0-jre in /shell

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4615: URL: https://github.com/apache/zeppelin/pull/4615 Bumps [guava](https://github.com/google/guava) from 24.1.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 32.0.0

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4614: Bump guava from 24.1.1-jre to 32.0.0-jre in /bigquery

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #4614: URL: https://github.com/apache/zeppelin/pull/4614 Bumps [guava](https://github.com/google/guava) from 24.1.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases. 32.0.0

[GitHub] [zeppelin] dependabot[bot] closed pull request #4471: Bump guava from 24.1.1-jre to 29.0-jre in /bigquery

2023-06-14 Thread via GitHub
dependabot[bot] closed pull request #4471: Bump guava from 24.1.1-jre to 29.0-jre in /bigquery URL: https://github.com/apache/zeppelin/pull/4471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4471: Bump guava from 24.1.1-jre to 29.0-jre in /bigquery

2023-06-14 Thread via GitHub
dependabot[bot] commented on PR #4471: URL: https://github.com/apache/zeppelin/pull/4471#issuecomment-1592067020 Superseded by #4614. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] Reamer commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-14 Thread via GitHub
Reamer commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1591104853 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] Reamer commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
Reamer commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1591103950 > Hi, Can this PR be reviewed? Let's see what the CI results are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [zeppelin] Reamer commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
Reamer commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1591100262 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [zeppelin] shefali163 commented on pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2023-06-14 Thread via GitHub
shefali163 commented on PR #4508: URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1590585554 Hi, Can this PR be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] shefali163 commented on pull request #4481: Bump shiro-core from 1.9.1 to 1.10.0

2023-06-14 Thread via GitHub
shefali163 commented on PR #4481: URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1590584477 Hi, Can this PR be reviewed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] jongyoul commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

2023-06-13 Thread via GitHub
jongyoul commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1590269638 @zhugezifang Hello, sorry for the late reply. I glance at your PR and suggest you make a child interpreter like `jdbc.debug` instead of adding a menu. The debug paragraph is currently

[GitHub] [zeppelin] Reamer merged pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-12 Thread via GitHub
Reamer merged PR #4612: URL: https://github.com/apache/zeppelin/pull/4612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] realknorke commented on pull request #4586: [ZEPPELIN-5902] Support Spark 3.4

2023-06-12 Thread via GitHub
realknorke commented on PR #4586: URL: https://github.com/apache/zeppelin/pull/4586#issuecomment-1586909509 This seems like a reasonable change request and easy to fix. @zjffdu is it possible for you to fix that? Thanks a lot! :) -- This is an automated message from the Apache Git

[GitHub] [zeppelin] jongyoul merged pull request #4613: [ZEPPELIN-5927]Solve the concurrency calls to `saveNoteAuth`.

2023-06-12 Thread via GitHub
jongyoul merged PR #4613: URL: https://github.com/apache/zeppelin/pull/4613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1584017096 > > and the data cache is really for hive like this large data database (not for mysql), as we know , hive sql will tranlate to mapreduce job, complex hive sql have shuffle and

[GitHub] [zeppelin] jongyoul commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
jongyoul commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582577943 > and the data cache is really for hive like this large data database (not for mysql), as we know , hive sql will tranlate to mapreduce job, complex hive sql have shuffle and reducer

[GitHub] [zeppelin] jongyoul commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
jongyoul commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582561003 Sorry for the late and short comment but how about making debug paragraph as a new interpreter? I mean, for instance, `%jdbc.debug`. Debugging jdbc paragraph itself is reasonable but

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582337500 Thanks for your reply. I understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582193016 I don't think so, because this function is used by all save operations. e.g. when note files are created. These would then block each other. -- This is an automated message from the

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582091105 > A few thoughts about your work: > > * All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. > * It seems

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582067198 > A few thoughts about your work: > > * All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. > * It seems

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582065412 @Reamer hi,firstly thanks for your advice "All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there" it

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582052448 Mybe a synchronized at the `org.apache.zeppelin.util.FileUtils#atomicWriteToFile(java.lang.String, java.io.File, java.util.Set)` is a better option. -- This is an automated

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582001696 Feel free to prepare a PullRequest with JIRA ticket. Your StackTrace should be included in the JIRA ticket. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [zeppelin] Reamer commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-08 Thread via GitHub
Reamer commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-158298 A few thoughts about your work: - All functionality is located in the JDBC interpreter. All new dependencies and classes should also be located there. - It seems that in case of a

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-08 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581997675 Yes, i also think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581919786 A `synchronized` at the `saveNoteAuth` method should fix the problem. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581779073 Thanks for your reply. This pull request migrates solve the concurrency problem caused by multiple concurrent calls to

[GitHub] [zeppelin] zhugezifang commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
zhugezifang commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1222353767 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
jongyoul commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221824271 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
Reamer commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221819108 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4612: [ZEPPELIN-5926] Remove map entries if Collection is empty

2023-06-07 Thread via GitHub
jongyoul commented on code in PR #4612: URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221525956 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java: ## @@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {

[GitHub] [zeppelin] Reamer commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580598263 Are you sure it is because of this change? I think you have another concurrency problem. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078356 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException:

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078089 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException:

[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note

2023-06-07 Thread via GitHub
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580071482 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException:

[GitHub] [zeppelin] Reamer merged pull request #4610: [ZEPPELIN-5921] Fix sync with remote repository

2023-06-02 Thread via GitHub
Reamer merged PR #4610: URL: https://github.com/apache/zeppelin/pull/4610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zhugezifang commented on pull request #4611: [ZEPPELIN-5915]improve query efficiency

2023-06-02 Thread via GitHub
zhugezifang commented on PR #4611: URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1573214026 hi @Reamer @jongyoul @huage1994 ,could you help me to review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] Reamer merged pull request #4608: fix conjars repository url

2023-06-01 Thread via GitHub
Reamer merged PR #4608: URL: https://github.com/apache/zeppelin/pull/4608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer merged pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings

2023-05-31 Thread via GitHub
Reamer merged PR #4609: URL: https://github.com/apache/zeppelin/pull/4609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   >