AyWa opened a new pull request #3336: [ZEPPELIN-4078] Fix concurrent 
autocomplete and execute for Ipython
URL: https://github.com/apache/zeppelin/pull/3336
 
 
   ### What is this PR for?
   
   The pr is to fix a bug that will make the **ipython** `execute_interactive` 
hang forever if a auto `complete` call is make at the same time. (see unit test 
for example that is failing on master).
   
   For now the fix is to synchronize those method : `execute` / `complete`. It 
will not bring regression because anyway, the kernel does not support 
concurrent execute and auto complete (see 
https://github.com/jupyter/notebook/issues/3763)
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - unit test failing in master / succeed on this branch
   * [x] - fix with lock
   
   ### What is the Jira issue?
   It is one part of the jira issue. Other fix will come soon
   https://issues.apache.org/jira/browse/ZEPPELIN-4078
   
   ### How should this be tested?
   * First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? no
   * Is there breaking changes for older versions? no
   * Does this needs documentation? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to