Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Only the last CI profile fails on very strange curcumstances:
```
16/12/19 04:54:08 INFO ApplicationMaster: Deleting staging directory
.sparkStaging/application_1482123134765_0003
16/12/19
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Hi all, This PR looks like unpopular from the point of view design. I will
close this issue. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz Thanks for the quick reply.
1. I will post CI logs :)
2. I'v just created an issue for the livy intergration test failure:
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Thanks for explanation, makes sense to me
On CI failures - from my experience, if the reason of failure is posted
here - there speeds up the merge dramatically.
I have update
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz Sorry for confusing. Let me explain more details.
- without `-Ploose-checkstyle`, maven will print all WARNINGs. So people
will see these warnings while developing (**default**)
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Iâm a bit confused though - this PR seems not to have separate checkstyle
CI profile, right?
Didnât we want to have `CHECKSTLYLE=1 â¦` profile for all projects, and
then skip
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
I'm sorry for a confusion - as soon as this issue is not about CI, but
about `Update checkstyle rule file, plugin`.
Let's move the CI discussion to the dev@ mailing list so all people in the
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
\cc @zjffdu regarding to the `spark-csv` dependency issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Interesting, that is the first time I see it! AFAIK `spark-csv` has been
included in Spark since 2.0
The failing profile is Spark 1.6 with **Scala 2.11**, but it fails on
fetching
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz
A test failed but it is irrelevant with this PR
```
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.156 sec
<<< FAILURE! - in
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz Let me know if there is anything to do before merging this :) thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz
CI failed but it's due to Flaky pyspark test. I think this can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
I see what you mean, for profile not included in build roster by default we
would need to update the CI profile. Well, it's 12s * 10 (number of profile we
have no), which looks like 2min time, but we
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz
Recently, i found that checkstyle doesn't need too much time. It takes
apprx 12 seconds in my labtop.
So i believe it is such a big problem of executing checkstyle plugin in all
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Sounds great! What is rationale for having checkstyle running everywhere +
a separate profile?
Would it make sense to measure the CI build time with\without separate
profile and see if there
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz
https://github.com/apache/zeppelin/pull/1689/commits/56dfa5232ef3cc58c147f8512cd37d4d3d6e8c4f
This commit added the `CHECKSTYLE=1` profile which printing all WARN.
And
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
With number of PRs we have I'm a bit lost, which one will introduce a
separate checkstyle CI profile and skip it in all the rest?
---
If your project is set up for it, you can reply to this email
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz I'v just rebased
I will add some commits enumerated above and then mention you when ready.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Go it, that sounds great.
Then shall we finish and merge this guy first, and then get back to #1668
merge it?
---
If your project is set up for it, you can reply to this email and have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@bzz I will work on here and add some small details from #1696 later
(e.g adding profile for checkstyle not to skip checkstyle in all other
profiles)
---
If your project is set up for it,
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
@1ambda I have created a HOTFIX for CI Spark download in #1709 so after
merging it, let's rebase and see if that fixed the issue.
I'm a bit confused, do you want to continue working here or
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Here are more detailed logs
```
[WARNING] Retrying (4 more)
Downloading:
http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Prev plugin version seems to have same behavior
```
[ERROR] Failed to execute goal
com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget
(download-pyspark-files) on
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Looks great to me, thank you @1ambda !
May be, as soon as CI is green let's try to squash some commits, before
merging it in - 37 may be a bit too much to be useful in merge commit message
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Thank you @1ambda !
I think it's a great idea to have checkstyle off the most of profiles, but
add a new one with just checkstyle.
After CI finishes, let's post the CI time statistics in
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Failed due to log size limitation of travis CI
```
The log length has exceeded the limit of 4 MB (this usually means that the
test suite is raising the same exception over and over).
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1689
\cc @bzz for review thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
27 matches
Mail list logo
