Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
Tested and LGTM. Sorry for the late reply. I'll merge it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/932
Tested and LGTM.
Merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user FRosner commented on the issue:
https://github.com/apache/zeppelin/pull/932
Hi all,
tested it and it works. I understood that
https://github.com/apache/zeppelin/pull/2182 is on hold because this one is
also going to fix it but in a better way? Can we move forward
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
@sohaibiftikhar Sure, I didn't test it yet as I had a talk in ApacheCon
last Wednesday. I'll handle it soon.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/932
@jongyoul I wish to open a dependent pull request for review. Is it
possible to merge this branch if everything is working fine.
---
If your project is set up for it, you can reply to this
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
@sohaibiftikhar Thanks for verifying it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/932
So I figured out what was happening. The problem was with my shiro.ini as I
had not assigned a session manager.
`securityManager.sessionManager = $sessionManager`
After assigning
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/932
@jongyoul Should I raise this as a separate issue because this seems
unrelated to this PR? Apparently the ticket is not held when using LdapRealm
while with LdapGroupRealm it is fine.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
Actually, I'm not sure I didn't dig into it. My current assumption is to
support anonymous and authorized one
---
If your project is set up for it, you can reply to this email and have your
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/932
@jongyoul I'd be happy to look into it but would be better for me if you
can provide a starting point to start looking at.
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
I also had a similar problem. We need to handle it.
On Mon, May 8, 2017 at 11:31 PM, Sohaib Iftikhar
wrote:
> @echarles
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles I tested with both simple and LdapGroupRealm and it was working.
It is only with LdapRealm that I am facing an issue. I will post a sample
`shiro.ini` for your reference. As I
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
It is working here with shiro-enabled (simple username password in
shiro,ini, not the ldaprealm).
I would need to test with ldaprealm...
@sohaibiftikhar is it working for your with the
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles Any comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles Sorry, I haven't checked it correctly. Thanks for checking it
again. I'll test it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
Jenkins build is now green. @jongyoul @bzz Any other inputs/questions on
this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
In general, including Zeppelin, most of reviewers feel uncomfortable to
upgrade some libraries even it's too old because no one guarantee all existing
functions work perfectly - eg. Kafka had
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles Hi, I saw your commit and looks better for me. At the first time,
I don't understand what it is. Can you enable your travis to pass CI?
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles I'm terribly sorry for for such a huge communication delay in my
side :\
Would you be willing to re-base it on the latest master so we could merge
it?
---
If your project is set
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
@bzz pushed my local merge. Anything else that should be done before you
merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
Thank you for addressing licensing issues!
Let me look into that again and then merge to master, if there is no
further discussion.
---
If your project is set up for it, you can reply to
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
Merged with latest master.
@bzz I don't know where I found CDDL 2.0 (sounded indeed strange when I was
writing this some time ago). jax-rs is now CDDL 1.0, beanvalidation is now ASL2
and
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
After the licenses clarification, I think we should be good to merge - I
love the idea of having Jersey2.
\cc @Leemoonsoo @jongyoul for review as well
---
If your project is set up for it,
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
Sorry, been a busy week. I think it needs to be rebased on latest master.
Few things on licensing:
There are two same **CDDL 1.1** texts now
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
@bzz are we ok now with the license information?
Travis is red for 3 on the 9 profiles, but this comes from a timeout trying
to launch/access spark
```16/08/17 15:36:04 INFO
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
@bzz I have moved `LICENSE-jersery-2` to
`zeppelin-distribution/src/bin_license`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
Thank you for your patience, @echarles
AFAIK CDDL 1.1 that jersey2 is distributed under belongs to ASF [Category B
license list](http://www.apache.org/legal/resolved.html#category-b) so it
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles thank you for taking care!
Please give me some time to try it out and make another pass on it and I'll
get back to you here.
---
If your project is set up for it, you can reply to this
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
@bzz I have updated the PR descrption (first comment) with the need to
update license and adding a note on how easy it is with jersey to map a full
json to a pojo being passed as method
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
A quick search over JIRA suggests that the failure you reffer was taked
care of in [ZEPPELIN-1264](https://issues.apache.org/jira/browse/ZEPPELIN-1264)
and is resolved in latest master, please rebase.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
Failing with
org.apache.zeppelin.interpreter.InterpreterException:
org.apache.thrift.TApplicationException: Internal error processing
createInterpreter
at
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/932
@Leemoonsoo Just pushed the asked changes regarding licenses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/932
Thanks for the contribution.
Could you take care of zeppelin-distribution/src/bin_license/LICENSE for
dependency change?
I have summarized cxf and jersey related dependencies
33 matches
Mail list logo