[GitHub] zeppelin issue #2039: [MINOR] Use standard java API to interrupt thread

2017-03-02 Thread DrIgor
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/2039 Ping-ping) Do you have other questions? Do you think it's better to proper synchronize `terminate` flag instead? I reviewed code to understand how zeppelin core works and found

[GitHub] zeppelin pull request #2089: [ZEPPELIN-791] Build infra: move all RAT to roo...

2017-03-02 Thread DmytroShkvyra
GitHub user DmytroShkvyra opened a pull request: https://github.com/apache/zeppelin/pull/2089 [ZEPPELIN-791] Build infra: move all RAT to root pom.xml What is this PR for? It is better have a single place where we manage project-wise RAT exclusions for a contributions under

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2051 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2075: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...

2017-03-02 Thread DmytroShkvyra
Github user DmytroShkvyra commented on the issue: https://github.com/apache/zeppelin/pull/2075 add wildcard --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2039: [MINOR] Use standard java API to interrupt thread

2017-03-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2039 From my understanding, setting a flag to let the thread gracefully runs to end, seems safer than calling `interrupt` on it --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...

2017-03-02 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2045 Ping! @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2054 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...

2017-03-02 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2073 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port

2017-03-02 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2073 CI is [green](https://travis-ci.org/soralee/zeppelin/builds/206890162) but Jenkins is failed. So I reopen this PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...

2017-03-02 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2073 [ZEPPELIN-2130][Doc]Do not use web development port ### What is this PR for? If user uses web application development port such like 9000 which is default value, Zeppelin is not working

[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-02 Thread andrykrp
Github user andrykrp commented on the issue: https://github.com/apache/zeppelin/pull/2085 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #2089: [ZEPPELIN-791] Build infra: move all RAT to roo...

2017-03-02 Thread DmytroShkvyra
GitHub user DmytroShkvyra reopened a pull request: https://github.com/apache/zeppelin/pull/2089 [ZEPPELIN-791] Build infra: move all RAT to root pom.xml What is this PR for? It is better have a single place where we manage project-wise RAT exclusions for a contributions under

[GitHub] zeppelin issue #2089: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...

2017-03-02 Thread DmytroShkvyra
Github user DmytroShkvyra commented on the issue: https://github.com/apache/zeppelin/pull/2089 @felixcheung Could you review my PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2039: [MINOR] Use standard java API to interrupt thread

2017-03-02 Thread DrIgor
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/2039 `interrupt` just sets `Thread.isInterrupted` flag and does not immediately stop the thread. Then thread can check this flag and decide if it needs to stop. So in fact, termination logic remains

[GitHub] zeppelin pull request #2089: [ZEPPELIN-791] Build infra: move all RAT to roo...

2017-03-02 Thread DmytroShkvyra
Github user DmytroShkvyra closed the pull request at: https://github.com/apache/zeppelin/pull/2089 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-03-02 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
GitHub user vipul1409 opened a pull request: https://github.com/apache/zeppelin/pull/2090 ZEPPELIN-2199: Fix lapply issue in sparkR ### What is this PR for? Function createRDDFromArray used for creating R RDD expects a JavaSparkContext object instead of spark context. This PR

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2074 @1ambda did you get time to review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-03-02 Thread FireArrow
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1985 Terribly sorry for late answer! Not sure why I didn't get any notifications about your answers :confused: @zjffdu I haven't looked into who actually sends the signal, but if it is as you

[jira] [Created] (ZEPPELIN-2204) Logout redirect "/" not context-path

2017-03-02 Thread Emanuel Damian Paz (JIRA)
Emanuel Damian Paz created ZEPPELIN-2204: Summary: Logout redirect "/" not context-path Key: ZEPPELIN-2204 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2204 Project: Zeppelin

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at: https://github.com/apache/zeppelin/pull/2086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2086: [ZEPPELIN-2167] User with insufficient privileg...

2017-03-02 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request: https://github.com/apache/zeppelin/pull/2086 [ZEPPELIN-2167] User with insufficient privileges can still restore files by renaming files in/out of Trash ### What is this PR for? User with insufficient privileges can still

[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter

2017-03-02 Thread Malian
Github user Malian commented on the issue: https://github.com/apache/zeppelin/pull/1545 @zjffdu What's the status of this pull request ? Can we expect it will be merged soon ? Thank you ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2062: ZEPPELIN-2161 Nested Group Support in LdapRealm for AD

2017-03-02 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2062 Rebased and green now. Thanks for your help. Would you mind merging that into branch-0.7 as well? Regarding docu: The LDAP Realm section in the docu

[jira] [Created] (ZEPPELIN-2205) pages are emtpy, can't open a notebook

2017-03-02 Thread Mathieu D (JIRA)
Mathieu D created ZEPPELIN-2205: --- Summary: pages are emtpy, can't open a notebook Key: ZEPPELIN-2205 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2205 Project: Zeppelin Issue Type: Bug

[GitHub] zeppelin pull request #2084: [HOTFIX][ZEPPELIN-2178] Prevent from cleaning o...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1545: ZEPPELIN-1571. Support pig udf interpreter

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1545 @zjffdu Sadly there are some conflicts now. Could you resolve them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #2091: Env variable to configure maven central repo

2017-03-02 Thread andreaTP
GitHub user andreaTP opened a pull request: https://github.com/apache/zeppelin/pull/2091 Env variable to configure maven central repo ### What is this PR for? When deploying Zeppelin in private Cloud or within closed networks, it happens that Maven Central isn't directly

[GitHub] zeppelin pull request #2092: [ZEPPELIN-2148] On creation of Bar graph zeppel...

2017-03-02 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2092 [ZEPPELIN-2148] On creation of Bar graph zeppelin UI shows it as minigraph - 2 ### What is this PR for? This is based on

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2074 Sure, I'll merge this soon, and have created a new PR https://github.com/apache/zeppelin/pull/2092 as this has merge conflict with master. Please feel free to review that as well. ---

[GitHub] zeppelin issue #2086: [ZEPPELIN-2167] User with insufficient privileges can ...

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2086 Merging this to master and branch-0.7 if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2082: [ZEPPELIN-2123] [branch-0.7] backport travis_check.py ...

2017-03-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2082 Merge to branch-0.7 if no further comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...

2017-03-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2074 @prabhjyotsingh sorry for late reply :sob: - Tested and works well as described. - `ng-if` is great implementation!, since they will re-draw - It would be nice if we apply this

[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...

2017-03-02 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2037 Tested and works as described. - LGTM except https://github.com/apache/zeppelin/pull/2037#pullrequestreview-24893904 --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2090 Can anyone help me understand the build error it looks unrelated to my change, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2080 Merge into branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2077: [ZEPPELIN-2191] Helium package should be able to impor...

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2077 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2042 Merge into master and branch-0.7 if there are no more comments on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't transfile im...

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2071 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...

2017-03-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2037 @1ambda Thanks for the review. Sadly there some conflicts. Let me updated again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
Github user vipul1409 closed the pull request at: https://github.com/apache/zeppelin/pull/2090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread vipul1409
GitHub user vipul1409 reopened a pull request: https://github.com/apache/zeppelin/pull/2090 ZEPPELIN-2199: Fix lapply issue in sparkR ### What is this PR for? Function createRDDFromArray used for creating R RDD expects a JavaSparkContext object instead of spark context. This PR

[GitHub] zeppelin issue #2091: Env variable to configure maven central repo

2017-03-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2091 try close and reopen this PR to trigger Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2079: ZEPPELIN-2195. Use PYSPARK_PYTHON and PYSPARK_D...

2017-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2091: Env variable to configure maven central repo

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2091 Did you switch on 'zeppelin' repository from https://travis-ci.org/profile (https://zeppelin.apache.org/contribution/contributions.html#continuous-integration) ? Also after

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-02 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2090 Did you switch on 'zeppelin' repository from https://travis-ci.org/profile (https://zeppelin.apache.org/contribution/contributions.html#continuous-integration) ? Also after