[GitHub] zeppelin pull request #1176: [Zeppelin 1165 : improve] Paragraph dynamic rel...

2016-12-22 Thread cloverhearts
Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1176


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1176: [Zeppelin 1165 : improve] Paragraph dynamic relationsh...

2016-12-22 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1176
  
https://github.com/apache/zeppelin/pull/1799

I was create new pr.

and re-implementation codebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1799: [ZEPPELIN-1165 : WIP] Code-based job workflow

2016-12-22 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1799

[ZEPPELIN-1165 : WIP] Code-based job workflow

### What is this PR for?

Code based workflow (**work in progress**)

Re-implementation on this pr
https://github.com/apache/zeppelin/pull/1176



Workflow process feature.
(To ensure the success of each paragraph, it is possible to run 
consecutively.)
 Case 1

Through a dynamic form, you can execute the order in paragraph.
There is a difference with traditional methods.
Please check the following flowchart.

![workflowdynamicformcontrol](https://cloud.githubusercontent.com/assets/10525473/16791726/a4b96ff0-48fc-11e6-8e23-9ec577066bb7.png)
 Case 2

In general, when run a plurality of Paragraph, it performs Note entire run.
This is a good way to run a lot of Paragraph contained in the Note.
However, the problem occurs if the Interpreter of Paragraph different.

![notebook_example](https://cloud.githubusercontent.com/assets/10525473/16803203/175ad01a-4940-11e6-8949-72d0c49bdf9e.png)
For Paragraph each using a different type of one of the Interpreter Note 
but run in sequence, the end is all different.

![normal notebook 
run](https://cloud.githubusercontent.com/assets/10525473/16803193/069c4d94-4940-11e6-9293-888b6c6288a0.png)
For example, Markdown is a very fast Interpreter.
The process is completed very quickly.
This is a problem in the sequential execution Paragraph.

![worklfow 
run](https://cloud.githubusercontent.com/assets/10525473/16803192/06998122-4940-11e6-8f01-43cdf64f2eef.png)
This feature ensures a certain execution order Notebook with each 
Interpreter.
# Case 3

For concurrent job in the workflow ...


![job_repl](https://cloud.githubusercontent.com/assets/10525473/16828860/96e601b8-49ce-11e6-87d0-6f7fc30ce751.png)

If the current functional design is supposed to run at the same time, as 
follows 
It is to share the results of the job.
But if the situation need to run the job at the same time, subject to their 
execution flow.

*\* The results will have to succeed, the following paragraph will be 
executed. **
### What type of PR is it?

Improvement
### jira
https://issues.apache.org/jira/browse/ZEPPELIN-1165

![cap 2016-07-14 15-11-07-036]
### Questions:
- Does the licenses files need update? no
- Is there breaking changes for older versions? no
- Does this needs documentation? yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-workflow

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1799


commit 84daa37f132a968ca381c3d86b6f74e834256e26
Author: cloverhearts 
Date:   2016-12-23T07:31:10Z

added remote work job status class and get method on interface




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1447
  
@purechoc Do you want to rebase it and continue work on it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread felizbear
Github user felizbear commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
@1ambda thank you for the research. A couple of questions:
1. Why do you think it requires changing dir structure?
2. What do you mean by: "we need index.html first."?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1798: ZEPPELIN-1853. Add README for livy interpreter

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1798
  
+1 for having more doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1797: [ZEPPELIN-1854] make Per User mode in interpreter sett...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1797
  
@jongyoul can you help review this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1798: ZEPPELIN-1853. Add README for livy interpreter

2016-12-22 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1798

ZEPPELIN-1853. Add README for livy interpreter

### What is this PR for?
Add `README` file for developer, besides update the `livy.md` for the 
recent changes on livy interpreter. 


### What type of PR is it?
[Documentation]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1853

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1853

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1798.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1798


commit 72f40c73f45fd9254b783a5520d5c6f34b32cbf0
Author: Jeff Zhang 
Date:   2016-12-23T06:39:29Z

ZEPPELIN-1853. Add README for livy interpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1798: ZEPPELIN-1853. Add README for livy interpreter

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1798
  
@AhyoungRyu Please help review it. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1792: Change gitignore for font files

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1792
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1797: [ZEPPELIN-1854] make Per User mode in interpret...

2016-12-22 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/1797

[ZEPPELIN-1854] make Per User mode in interpreter setting visible even if 
there is no role assigned to a user

### What is this PR for?
There can be a case where user may have enabled shiro authentication, but 
may not have configured role based mapping.
In such a scenarios "Per User" mode in interpreter setting should be 
visible even if there are no role assigned to a user.

### What type of PR is it?
[Bug Fix]


### What is the Jira issue?
* [ZEPPELIN-1854](https://issues.apache.org/jira/browse/ZEPPELIN-1854)

### How should this be tested?
Enable authentication via shiro.ini, and in that remove "[roles]" block, 
now after restarting zeppelin server "Per User" should be visible when user 
edits any interpreter setting.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1797


commit d199c5eab2a8f45851bd8f17726d991d9e802d62
Author: Prabhjyot Singh 
Date:   2016-12-23T06:30:16Z

make per user mode visible




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1854) "Per User" mode in interpreter setting should be visible even if there is no role assigned to a user

2016-12-22 Thread Prabhjyot Singh (JIRA)
Prabhjyot Singh created ZEPPELIN-1854:
-

 Summary: "Per User" mode in interpreter setting should be visible 
even if there is no role assigned to a user
 Key: ZEPPELIN-1854
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1854
 Project: Zeppelin
  Issue Type: Bug
Reporter: Prabhjyot Singh


There can be a case where user may have enabled shiro authentication, but may 
not have configured role based mapping.

In such a scenarios "Per User" mode in interpreter setting should be visible 
even if there are no role assigned to a user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1792: Change gitignore for font files

2016-12-22 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1792
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1721: [ZEPPELIN-969] order by note name in job menu

2016-12-22 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1721
  
@anthonycorbacho change finished.


![asc](https://cloud.githubusercontent.com/assets/10525473/21448241/a177ac24-c923-11e6-91ce-abef42bb0ea8.png)

![desc](https://cloud.githubusercontent.com/assets/10525473/21448242/a17b2e08-c923-11e6-8144-bfb96d768385.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1785
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1777
  
@marchpig can you resolve conflicting file ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
FYI - you can install 2.11.0 using brew. 

@khalidhuseynov is right, that should be handled in the separate issue. 
Let's talk about it on ZEPPELIN-1737.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1853) Add README for livy interpreter

2016-12-22 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1853:


 Summary: Add README for livy interpreter
 Key: ZEPPELIN-1853
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1853
 Project: Zeppelin
  Issue Type: Improvement
  Components: livy-interpreter
Affects Versions: 0.7.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2016-12-22 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1775

[ZEPPELIN-1745] View revisions in non-editable mode

### What is this PR for?
This is to make view of revisions non-editable

### What type of PR is it?
Improvement

### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys

### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)

### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to 
modify note

### Screenshots (if appropriate)

![revision_view](https://cloud.githubusercontent.com/assets/1642088/21340828/53131054-c6cc-11e6-960b-abf5db905194.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/revision-view

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov 
Date:   2016-12-16T04:20:22Z

change var name revisionDisabled -> revisionView

commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov 
Date:   2016-12-16T08:10:26Z

disable run all

commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov 
Date:   2016-12-16T08:12:09Z

disable clear output

commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov 
Date:   2016-12-16T08:18:02Z

disable clone note

commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov 
Date:   2016-12-16T08:19:21Z

disable export note

commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov 
Date:   2016-12-16T08:22:14Z

disable revision commit

commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov 
Date:   2016-12-16T08:24:16Z

disable remove note

commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov 
Date:   2016-12-16T08:25:42Z

disable scheduler

commit ee87a53805f9af9c657db24938e47ea409cfa258
Author: Khalid Huseynov 
Date:   2016-12-19T04:21:51Z

disable + new paragraph

commit 9d73be4f8447596600b6f9723922d521f66d337f
Author: Khalid Huseynov 
Date:   2016-12-19T04:26:37Z

don't show paragraph settings menu

commit 2cf28dce40b14bed547fe5727850093ef490a258
Author: Khalid Huseynov 
Date:   2016-12-19T05:09:27Z

don't show run/cancel on paragraph

commit 45a11cf45e0531e3159eb399e0b3d07a305ccbc4
Author: Khalid Huseynov 
Date:   2016-12-19T08:00:39Z

make paragraph title non-editable

commit e61e049efdf53b8c386f60f6a11be3e43518
Author: Khalid Huseynov 
Date:   2016-12-20T05:20:07Z

disable editor editing

normally it should be done on change of .revisionView however at that time 
editor isn't loaded yet

commit e78599cc82fc22e253ba4f52dcdd7482133bf6f1
Author: Khalid Huseynov 
Date:   2016-12-20T06:11:50Z

disable hotkeys

commit 464d19f3b3cef37def095f8dd30e35c208041e6e
Author: Khalid Huseynov 
Date:   2016-12-20T06:32:15Z

disable editing note name

commit 4c71b6def9164f0675b2f9483a88fa01a7a26483
Author: Khalid Huseynov 
Date:   2016-12-20T06:41:34Z

disable show/hide code in note action-bar

commit ebf2d2fd55a2042d65579ae0149a98a6de07b944
Author: Khalid Huseynov 
Date:   2016-12-20T06:43:20Z

disable show/hide output in note action bar

commit 9b42e0ef9a503e8eebb3ca0fa9673ea10097e61e
Author: Khalid Huseynov 
Date:   2016-12-20T06:47:25Z

don't show paragraph level hide editor button

commit 6963abae404e4aadae6445c8990e23ba52d44183
Author: Khalid Huseynov 
Date:   2016-12-20T06:48:13Z

don't show paragraph level hide output buttton




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes 

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2016-12-22 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@1ambda actually i've tried to reproduce 
[ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) and even 
with git 2.11.0 wasn't able to do it. also from documentation 
[here](https://github.com/git/git/tree/master/Documentation/RelNotes) only from 
2.11.0 `--allow-empty` commits was introduced, meaning only git versions 2.11+ 
could be a problem which is the most recent version and can be built from the 
source only for now. So I think reviewing this PR wouldn't much depend on git 
version, and 
[ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) will be 
addressed separately. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1729
  
@purechoc Thanks for the quick update. Could you add test in 
`LivyInterpreterIT` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1780: [BugFix] Tutorial note json format.

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1780


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1796: [WIP] ZEPPELIN-1852. Use multiple InterpreterRe...

2016-12-22 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1796

[WIP] ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo

### What is this PR for?
Refactor the livy interpreter to use multiple `InterpreterResult` for 
displaying appInfo. 


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1852

### How should this be tested?
Add integration test and also test it manually

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/21446563/9e3c9e78-c902-11e6-8bf6-84788d1dfb51.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1852

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1796


commit e800932d9070e9c82b96802592ae4a6a0cfe
Author: Jeff Zhang 
Date:   2016-12-23T03:14:32Z

ZEPPELIN-1851. LazyOpenInterpreter would open interpreter multiple times 
when open fails

commit e34e4f52d3510fc2a6233a580f7d21cda6a98476
Author: Jeff Zhang 
Date:   2016-12-23T03:24:27Z

ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1852) Use multiple InterpreterResult for displaying appInfo

2016-12-22 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1852:


 Summary: Use multiple InterpreterResult for displaying appInfo
 Key: ZEPPELIN-1852
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1852
 Project: Zeppelin
  Issue Type: Sub-task
  Components: livy-interpreter
Affects Versions: 0.7.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1795: ZEPPELIN-1851. LazyOpenInterpreter would open interpre...

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1795
  
@Leemoonsoo @jongyoul  Please help review it. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1795: ZEPPELIN-1851. LazyOpenInterpreter would open i...

2016-12-22 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1795

ZEPPELIN-1851. LazyOpenInterpreter would open interpreter multiple times 
when open fails


### What is this PR for?
Change `opened` to be `volatile` as it would be accessed by multiple 
threads. And check `opened` in `getProgress` rather than call `open()`


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1851

### How should this be tested?
Tested manually on livy interpreter (change the livy configuration to make 
livy fails to create session).

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1851

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1795


commit e800932d9070e9c82b96802592ae4a6a0cfe
Author: Jeff Zhang 
Date:   2016-12-23T03:14:32Z

ZEPPELIN-1851. LazyOpenInterpreter would open interpreter multiple times 
when open fails




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1851) LazyOpenInterpreter would open interpreter multiple times when open fails

2016-12-22 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1851:


 Summary: LazyOpenInterpreter would open interpreter multiple times 
when open fails
 Key: ZEPPELIN-1851
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1851
 Project: Zeppelin
  Issue Type: Bug
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1729
  
@purechoc refactoring LivyHelper has been done. You can continue this PR. I 
think the right place for you is 
https://github.com/apache/zeppelin/blob/master/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java#L231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1503: NPE LivySparkSQLInterpreter thrown with %livy.sql inte...

2016-12-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1503
  
@gss2002 Livy interpreter has been refactored, this issue has been fixed. 
Mind to close it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-22 Thread tae-jun
GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin issue #1793: [WIP][MINOR] Refactoring Job and Paragraph

2016-12-22 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1793
  
```
Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:
```

This test passed in my local


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread tae-jun
Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
@1ambda Thanks for your prompt response!
I see what you mean now. Thanks for the explanation :)

Now, only `remove permanently` and `restore` buttons are shown.
https://cloud.githubusercontent.com/assets/8201019/21433976/7c735306-c8b5-11e6-92a2-8f09ab84e823.png;
 width=200>
https://cloud.githubusercontent.com/assets/8201019/21433985/8334b02c-c8b5-11e6-87bf-ada0f978d69b.png;
 width=200>

How does it look? 😄 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1850) Improve frontend build structure, tools

2016-12-22 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-1850:
---

 Summary: Improve frontend build structure, tools
 Key: ZEPPELIN-1850
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1850
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Hoon Park


Currently, we are using grunt + native js. But it would be productive if we can 
make use of babel, webpack and other recent tools. (e.g fast compilation, 
recent syntax, and so on)

I did simple tests for applying webpack. Let me share the result in short.

- (IMPORTANT) It is impossible to handle in a single PR. It requires changing 
directory structure and this causes sooo many rebase. It would be painful 
if it is not merged quickly.
- angular is more tricky to use webpack. (e.g how to handle ng-include? - 
https://github.com/shanhaichik/webpack-require-loader/)
- we need index.html first.
- webpack configuration is not hard as expected. we have many references for it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
Did simple test for applying webpack. Let me share result in short.

- (**IMPORTANT**) It is impossible to handle in a single PR. It requires 
changing directory structure and this causes sooo many rebase. It would be 
painful if it is not merged quickly.
- angular is more tricky to use webpack. (e.g how to handle ng-include? - 
[webpack-require-loader])
- we need index.html first. 
- webpack configuration is not hard as expected. [we have many 
references](https://github.com/preboot/angular-webpack/blob/master/webpack.config.js)
 for it



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1751


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
Hi @tae-jun 

It's good idea to introduce limitation when notes are in trash. Let me 
comment

(1) what you mentioned is about restricting modification of archived notes 
(i mean, notes are in trash)
(2) Removing `rename` and `clear output` **does not** mean disabling those 
functionality. It's just about hiding the menus. We can rename and clear output 
in the trashed notes. It's not about (1)

So I I think removing `rename` and `clear output` can be handled in this 
PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1789: [MINOR] Optimize watchers of paragraph results

2016-12-22 Thread cuspymd
Github user cuspymd commented on the issue:

https://github.com/apache/zeppelin/pull/1789
  
In the process of modifying the above issue, I divided the buttons of the 
chart selector into two groups.
The role of the two button groups seems to be slightly different.

- First group: Chart selection buttons
- Second group: App selection buttons


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1790: [ZEPPELIN-1845] InterpreterFactory.createOrGetInterpre...

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1790
  
CI Green, ready for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1849) Web interface does not render information properly

2016-12-22 Thread Sergey_Sokur (JIRA)
Sergey_Sokur created ZEPPELIN-1849:
--

 Summary: Web interface does not render information properly
 Key: ZEPPELIN-1849
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1849
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.7.0
Reporter: Sergey_Sokur
 Fix For: 0.7.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1759: [ZEPPELIN-922] New interpreter registration mec...

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1759


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...

2016-12-22 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1561
  
@meenakshisekar Could you rebase this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-22 Thread tae-jun
Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
@AhyoungRyu Always thanks for the review :) Also thanks for your 
understanding.

@1ambda  Thanks for the review! I appreciate it and sorry for my late 
response.
That was a really nice point. I fixed it as you see below:

https://cloud.githubusercontent.com/assets/8201019/21429799/b678e794-c8a3-11e6-851f-04d1ad55998e.png;
 alt="image" width=200>
I tested on Chrome and Firefox. Please check!


As to the second point that you mentioned, I thought a lot of about it as 
well :)
My opinion is same with you, but I think maybe other users can feel limited.
So I would like to make it configurable as three levels on other PR:
1. super strict: not even open note
2. read only: only can open note and read it
3. unlimited access: able to rename, read, write, and run note

Would you mind if I do that? Please let me know 😄
Thanks for the review again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1848) ZEPPELIN_NOTEBOOK_S3_KMS_KEY_ID defaults to search keys in us-east-1

2016-12-22 Thread Mikhail (JIRA)
Mikhail created ZEPPELIN-1848:
-

 Summary: ZEPPELIN_NOTEBOOK_S3_KMS_KEY_ID defaults to search keys 
in us-east-1
 Key: ZEPPELIN-1848
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1848
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-zengine
Affects Versions: 0.6.2
 Environment: EMR
Reporter: Mikhail
Priority: Minor


Hi,

I am trying to setup Zeppelin to store encrypted notebooks in S3 with KMS in 
us-west-2. I have KMS key in us-west-2 as well.
However when I tried to add {{ZEPPELIN_NOTEBOOK_S3_KMS_KEY_ID}} pointing to 
that key, I got the following error in logs
{noformat}
 WARN [2016-12-22 11:48:53,275] ({main} NotebookRepoSync.java[]:95) - 
Failed to sync with secondary storage on start {}
java.io.IOException: Unable to store note in S3: 
com.amazonaws.services.kms.model.NotFoundException: Key 
'arn:aws:kms:us-east-1:174485552022:key/a0d06e55-efdd-4f5a-aec6-03a64b08278b' 
does not exist (Service: AWSKMS; Status Code: 400; Error Code: 
NotFoundException; Request ID: 9c919bac-c83c-11e6-9b8a-250e451234bf)
at 
org.apache.zeppelin.notebook.repo.S3NotebookRepo.save(S3NotebookRepo.java:223)
at 
org.apache.zeppelin.notebook.repo.NotebookRepoSync.pushNotes(NotebookRepoSync.java:215)
at 
org.apache.zeppelin.notebook.repo.NotebookRepoSync.sync(NotebookRepoSync.java:200)
at 
org.apache.zeppelin.notebook.repo.NotebookRepoSync.(NotebookRepoSync.java:93)
at 
org.apache.zeppelin.server.ZeppelinServer.(ZeppelinServer.java:83)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
... truncated
{noformat}
Notice that it tries to look up key in us-east-1 (default region) instead of 
us-west-2.
I believe it is about that code 
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java#L100
 and the patch will look more or less like here 
http://stackoverflow.com/a/27173676/484050
I think this can be solved by introducing additional environment variable like 
{{ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION}}.
Sorry, can't fix that myself.

Thanks,
Mikhail



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread felizbear
Github user felizbear commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
We totally can but it requires some effort, i.e. migrating code to es6 
modules 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
one more question. Can we boost dev mode build using webpack and its useful 
plugins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread felizbear
Github user felizbear commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
GOOD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
@1ambda 
Thank you for your good fix. 
Sure, I will :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1789: [MINOR] Optimize watchers of paragraph results

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1789
  
Hard to figure out what is different at first. See border of the icons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...

2016-12-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1791
  
\cc @cloverhearts @felizbear for review. Thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...

2016-12-22 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1791

[ZEPPELIN-1847] fix: Copy only html when html file changed

### What is this PR for?

Reduce build time by avoiding to copy non-related files. Approx 3~4 secs as 
you can see below.

### What type of PR is it?
[Improvement]

### Todos

Nothing

### What is the Jira issue?

[ZEPPELIN-1847](https://issues.apache.org/jira/browse/ZEPPELIN-1847)

### How should this be tested?

1. `cd zeppelin-web`
2. `npm install` && `npm run start`
3. change any html file in `src/` and see log. 
4. compare the result with master branch's

### Screenshots (if appropriate)


```
Running "watch" task
Waiting...
>> File "src/app/home/home.html" changed.


## before

Execution Time (2016-12-22 08:13:35 UTC)
loading tasks   130ms  ▇▇▇ 3%
htmlhint:src 84ms  ▇▇ 2%
newer:copy:dev   3.6s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
 93%
Total 3.9s
Completed in 5.953s at Thu Dec 22 2016 17:13:39 GMT+0900 (KST) - Waiting…

## after

Execution Time (2016-12-22 08:14:27 UTC)
loading tasks   137ms  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
 52%
newer:htmlhint3ms  ▇ 1%
newer:htmlhint:src   25ms  ▇▇▇▇▇▇▇ 10%
htmlhint:src 89ms  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 34%
newer:copy:html   5ms  ▇▇ 2%
Total 261ms

Completed in 2.447s at Thu Dec 22 2016 17:14:27 GMT+0900 (KST) - Waiting…
```

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin fix/DONT-copy-all-files-grunt

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1791


commit 03e95f778ddd2d6a13c279a85ff14aa3616b8f05
Author: 1ambda <1am...@gmail.com>
Date:   2016-12-22T08:29:30Z

fix: Copy only html when html file changed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1789: [MINOR] Optimize watchers of paragraph results

2016-12-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1789
  
Thanks for the contribution, one minor issue:

Before:
https://cloud.githubusercontent.com/assets/674497/21419733/7b477450-c84f-11e6-9f06-9623585b6402.png;>

After:
https://cloud.githubusercontent.com/assets/674497/21419732/7b455ee0-c84f-11e6-8a9f-4c4e31dfe36e.png;>


Rest LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1847) Reduce zeppelin-web build time for html files in dev

2016-12-22 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-1847:
---

 Summary: Reduce zeppelin-web build time for html files in dev
 Key: ZEPPELIN-1847
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1847
 Project: Zeppelin
  Issue Type: Bug
  Components: build, front-end
Reporter: Hoon Park


Changing html files cause copying all files ({{copy:dev}} task in Gruntfile.js
We can improve our productivity by fixing this. 

{code}
  html: {
files: [
  '<%= yeoman.app %>/**/*.html'
],
tasks: ['newer:htmlhint', 'newer:copy:dev']
  },
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)