Re: Submitting code

2019-03-30 Thread Jeff Zhang
Making a new branch make sense to me, if no objection, I will create a branch for you. Jongyoul Lee 于2019年3月31日周日 下午12:29写道: > Hi, > > Basically, all PRs should be merged separately in a master branch. By the > same rule, if you have a big task which has several small tasks, all sub > tasks

Re: Submitting code

2019-03-30 Thread Jongyoul Lee
Hi, Basically, all PRs should be merged separately in a master branch. By the same rule, if you have a big task which has several small tasks, all sub tasks should be reviewed and merged separately with a complete small function, even if it changes some behaviors. Making branches help sometimes

[GitHub] [zeppelin] sgloutnikov edited a comment on issue #3092: [ZEPPELIN-3653] - New Java interpreter

2019-03-30 Thread GitBox
sgloutnikov edited a comment on issue #3092: [ZEPPELIN-3653] - New Java interpreter URL: https://github.com/apache/zeppelin/pull/3092#issuecomment-478302263 @selvinsource thank you! Saved me a good amount of time investigating why I couldn't build with Scala 2.11. Was able to build fine

[GitHub] [zeppelin] sgloutnikov commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter

2019-03-30 Thread GitBox
sgloutnikov commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter URL: https://github.com/apache/zeppelin/pull/3092#issuecomment-478302263 @selvinsource thank. you! Saved me a good amount of time investigating why I couldn't build with Scala 2.11. Was able to build fine with

[GitHub] [zeppelin] AyWa commented on issue #3338: ZEPPELIN-4081. when the python process is killed, the task state is still running

2019-03-30 Thread GitBox
AyWa commented on issue #3338: ZEPPELIN-4081. when the python process is killed,the task state is still running URL: https://github.com/apache/zeppelin/pull/3338#issuecomment-478249008 Hey, you mean https://github.com/apache/zeppelin/pull/3339 ? No worries should I looks to something ?

[GitHub] [zeppelin] zjffdu commented on issue #3338: ZEPPELIN-4081. when the python process is killed, the task state is still running

2019-03-30 Thread GitBox
zjffdu commented on issue #3338: ZEPPELIN-4081. when the python process is killed,the task state is still running URL: https://github.com/apache/zeppelin/pull/3338#issuecomment-478244940 Sorry @AyWa I just reverted this PR, because I found it may cause travis CI failed.