Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1952
@Leemoonsoo Nice to have abstracted table structure inside zeppelin. It
enable us many things even i just glanced at.
I will take look deeply and comment soon.
---
If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
@AhyoungRyu Thanks for great contribution. This PR increase the number of
helium package users significantly.
I would like to comment about the design of `helium.json`. Basically, It's
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1892
Sorry for late reply. I will review and comment ASAP @soralee
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
@AhyoungRyu You are welcome. I will review soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep
simple. There is no reason to use angular
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1935
Tested and works well :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1892
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1952
Sorry for late reply. I was taking a look also recent resource related
commit to understand fully.
1. This PR is well abstracted and shipped with enough unit test.
2. And easy
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
@AhyoungRyu I totally agree! Now we have basic things, thus we need docs
for it. I will work it on https://issues.apache.org/jira/browse/ZEPPELIN-2070
---
If your project is set up for it, you
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1989
Hi @qinchaofeng. I think you pushed different branch. Could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1975
I think we can use only 1 `div` element instead of appending `div` for
streaming output by replacing it's contents (`html()`).
---
If your project is set up for it, you can reply to this email
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1902
@bbonnin ð
@jongyoul I will take a look more deeply :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1940
[ZEPPELIN-2008] Introduce Spell
### What is this PR for?
Implemented **Spell** to Helium categories. *Technically, it's the frontend
interpreter* runs on browser not backend
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1902
Works well as described.
- tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only)
- code looks nice. well abstracted client classes is shipped with some
tests
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1955
[ZEPPELIN-2025] Cleanup R Tutorial
### What is this PR for?
1. Remove useless paragraphs in R tutorial
2. Prettify layout
I attached screenshots for comparison. See
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1955
@minahlee Thanks for review!
I updated notebook layout and it looks like
## Large Size
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1598
@jaspinderdineout Hi :)
Zeppelin doesn't support es 5.0 currently as i know.
I will close this PR. This issue can be easily handled after #1902.
---
If your project is set up
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1955
[ZEPPELIN-2025] Cleanup R Tutorial
### What is this PR for?
1. Remove useless paragraphs in R tutorial
2. Prettify layout
I attached screenshots for comparison. See
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1955
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1982
[ZEPPELIN-2069] Helium Package Configuration
### What is this PR for?
Supporting helium package configurations. I attached screenshots.
Implementation details
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2016
Hope to merge into 0.7.0 branch as well to help 0.7.1+ users
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
@Leemoonsoo
I'v just updated this PR.
- Using `artifact` as config -
https://github.com/apache/zeppelin/pull/1982/commits/6e91b78880777ace0e780c746e376a8e0c88b520
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
But current implementation is really inefficient in terms of API calls. I
will refactor it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1995
@AhyoungRyu Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2054
I will review and comment soon. Thanks for fixing bug @soralee!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2053
I will review and give you feedback soon. Thanks for fixing bug @astroshim!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
@Leemoonsoo Thanks for review.
- Then we need to close the configuration panel after saving. I will update
it.
- You have to use echo spell provided by zeppelin (`examples
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2016
@prabhjyotsingh
- tested and it works well.
- I'v changed implementation of this PR according to your suggestion.
---
If your project is set up for it, you can reply to this email
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
@Leemoonsoo cause I added config before to test :(
https://github.com/1ambda/zeppelin-echo-spell/blob/master/package.json#L13-#L18
---
If your project is set up for it, you can reply
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1995
Thanks @AhyoungRyu. This definitely help to write and check test easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2060
Thanks for improvement! I will review and comment soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2015
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1982
just rebased to apply new CI system.
### Newly added commits
- Close config panel after saving:
https://github.com/apache/zeppelin/pull/1982/commits
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortable
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortable
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages to distinguish
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2006
[ZEPPELIN-2099] Add NPM link for helium pkgs published in npm
### What is this PR for?
Add NPM link for helium pkgs published in npm while coloring grey for local
packages
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1998
CI failed, but irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2016
@felixcheung
Yes, build time increase 40 secs ~ 1 min approximately per build profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2016
[ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build
failure (BUG)
### What is this PR for?
yarn installed by frontend-maven-plugin causes build failure **when
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1998
@AhyoungRyu Thanks for review. I'v just addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
Or are there other ways to figure out local package? instead of `return
pkg.artifact && !pkg.artifact.includes('@');`
---
If your project is set up for it, you can reply to this email
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1995
[ZEPPELIN-2086] Move zeppelin-web related test files into src/ for
efficiency
### What is this PR for?
Since we are using a separated test directory,
- it's uncomfortable
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@AhyoungRyu Thanks for review. I'v changed the condition for checking local
package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2016
[ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build
failure (BUG)
### What is this PR for?
yarn installed by frontend-maven-plugin causes build failure **when
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
FYI - https://github.com/eirslett/frontend-maven-plugin/issues/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2000
Hi @soralee :)
I would like to suggest using `'ngInject'l` instead of `$inject =
['$location'];` as like https://github.com/apache/zeppelin/pull/1994
>
http://zeppelin.apache.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@AhyoungRyu thanks for review. CI failed but irrelavent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1991
[ZEPPELIN-2081] Prettify input, textarea in interpreter setting page
### What is this PR for?
Fix small details in interpreter setting page about inputboxes, textareas
- Set
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1997
Tested and works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2000
Looks nice :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1998
Resolved @soralee's comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra
If you want to use node modules in terminal, you have to install them
globally. (e.g `$ yarn install`)
But in case of grunt (and karma so on..), we don't need
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1991
@felixcheung Fixed. (`font-size: 12`)
---
If your project is set up
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra That's cool. You are trying to modify something without
understanding. Anyway, We have 2 problems.
1. local development
- you must install yarn if you want to use
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra Please read and try #2016
### Details
- yarn installed by frontend-maven-plugin can't run commands described in
scripts tag (package.json)
- but npm is able
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2006
@Leemoonsoo Someday
- what about black?
- we might use labels such as `local` and `online` for helium packages.
---
If your project is set up for it, you can reply to this email
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2016
[ZEPPELIN-2105] yarn installed by frontend-maven-plugin causes build
failure (BUG)
### What is this PR for?
yarn installed by frontend-maven-plugin causes build failure **when
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra Really sorry if you feel like that.
But IMO
- you didn't try almost all possible alternatives
- you didn't try to understand my comments at all. I repeatedly
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
Regrading to **max call stack size** what @DmytroShkvyra mentioned in above
comment (for other people)
- https://github.com/npm/npm/issues/9953
- https://github.com/npm/npm/issues
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra
I think the log you'v just posted is quite different. It's not for build.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra Should we support build env such as windows on vm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
So, what you want to solve is **building zeppelin in vms which can't have
enough symlinks**? right?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2002
@DmytroShkvyra
- I think we don't need to worry about **max call stack size** since it
occurs in unusual env like windows, *linux on vm*.
- Zeppelin is not the thing like JDK
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1994
[MINOR] Replace angular inject with ngInject
### What is this PR for?
Replaced angular inject with ngInject to reduce duplication and keep
simple. There is no reason to use angular
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2015
I will review this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1998
[ZEPPELIN-2070][DOCS] Create Docs for Spell
### What is this PR for?
Docs for Spell which was added by #1940
### What type of PR is it?
[Documentation]
### Todos
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2016
@prabhjyotsingh Sure. I will test and give you feedback soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1 - 100 of 1201 matches
Mail list logo
