[GitHub] zeppelin pull request #2177: [ZEPPELIN-2301] DON'T overwrite editor text whe...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2125 It's just my opinion. Thus, it's ok to use d3 if you think it's reasonable 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2212 Tested and works as describe. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2125 UI can be improved in the following PRs. So it's ok not to resolve the whole things in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2199 @markito I mean, this PR not the JIRA ticket :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2210: [ZEPPELIN-2088] Evaluate helium bundle one by o...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2210 [ZEPPELIN-2088] Evaluate helium bundle one by one ### What is this PR for? Evaluate helium bundle one by one. Because - Bundling them in one file is not good idea because

[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2252 [ZEPPELIN-1940] lint rule set is NOT applied at all. ### What is this PR for? eslint ruleset is NOT applied at all due to invalid `.eslintrc`. This PR includes - fixes

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 @AhyoungRyu Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2251: [ZEPPELIN-2403] added interpreter property types

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2251 One suggestion. What about calling them as 'widget' or something instead of 'type'? cause we might add actual type like 'number', 'string',... as @leemoonsu mentioned. --- If your project is set

[GitHub] zeppelin issue #2256: [ZEPPELIN-2315] (bug) new note.json is overwritten by ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2256 Old version zeppelins will not render converted note.json. On the other hand, if we keep 'result', they can render last version of old format. Is it ok? --- If your project is set up for it, you

[GitHub] zeppelin issue #1761: [ZEPPELIN-1711] Create Docker Images for Released Zepp...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1761 Let me create new PR which including only 1 OS (ubuntu) based on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2260 @soralee Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2225 Submitted #2261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2260: [ZEPPELIN-2408] Should use $uibTooltip instead ...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2260 [ZEPPELIN-2408] Should use $uibTooltip instead of $tooltip (master) ### What is this PR for? Since we are using angular-bootstrap 2.5+, we should use `$uibTooltip` instead of `$tooltip

[GitHub] zeppelin pull request #2261: [ZEPPELIN-2420] Slow notebook listing in navbar

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2261 [ZEPPELIN-2420] Slow notebook listing in navbar ### What is this PR for? Notebook listing is slow as you can see in the screenshot below. The problem was, - angular

[GitHub] zeppelin issue #2259: Prevent NPE on delete local module cache

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2253 @jongyoul ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2261: [ZEPPELIN-2420] Slow notebook listing in navbar

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2261 @tinkoff-dwh Please help review this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 rebased to resolve conflict with #2133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 It makes sense displaying last execution time instead of creation time of the notebook in the job page. Tested and works well LGTM. Let's merge it to master and branch-0.7

[GitHub] zeppelin issue #2541: [ZEPPELIN-2865] upgrade Beam interpreter to latest ver...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2541 Thanks for the contribution. Could you check the failed job? - https://travis-ci.org/XuMingmin/zeppelin/jobs/264931044 --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2536: [ZEPPELIN-2861] Use OpenJDK in docker image.

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2536 Can we apply this patch into branch-0.7 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 I didn't mean both. Just gave an opinion. Personally, I don't believe that reviewer only can reply `LGTM` or `NO`. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2539: [ZEPPELIN-2863] change notebook-authorization.json and...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2539 Hi, Thanks for the contribution. @sadhen I think you can manually move `interpreter*.json` inside the docker container. Isn't it? --- If your project is set up for it, you can

[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 @byung-u I missed the CI status/ Could you make sure CI is green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 For me, it's up to you. - keep current implementation - try and propose few different UIs --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-11

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2527 Thanks for the contribution @byamthev I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 Thanks for the contribution @wishwisdom. It's unclear in the screenshots because you used the old version of zeppelin for the `before` screenshot. Could you update it? --- If your

[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 It's weird. https://github.com/apache/zeppelin/pull/2541 passed CI and we modified https://github.com/apache/zeppelin/blob/master/.travis.yml 21 days ago. I guess - the package

[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 Hi, what is your base branch? Could you rebase using current master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 @soralee Thanks for posting the image. LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2540: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2540 Some PRs made yesterday passed CI. Could you rebase using current master? I am not sure what base branch you are using. ![image](https://user-images.githubusercontent.com/4968473/29358997

[GitHub] zeppelin issue #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-11

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2527 LGTM. merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2538: [ZEPPELIN-2862] misalign text and icon in notebook dro...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2538 LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1151: Fonted download chinese garbled fix

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1151 Closed. Thanks for the reporting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 1. Let's expose the config using REST API we already have. - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/rest_api/configuration.html#configuration-rest-api-list 2. Check

[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2506 @tinkoff-dwh Thanks for the update. In feature and code level, it's good. But personally, I hope we can get improved UI. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2526 I saw that people were asking there is this kind of permission. - https://stackoverflow.com/questions/43971836/how-do-i-set-permissions-to-a-zeppelin-note-to-be-able-to-execute

[GitHub] zeppelin issue #2528: ZEPPELIN-2834 Show Interpreter list as expand collapse...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2528 Thanks for the contribution. Really nice and useful feature. I guess you introduced new property `isExpanded` in setting. It would be nice to include newly added the property in existing

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Then, I think we need to hide when cookie manager is disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 Hi @agura I guess you didn't setup travis CI for the forked repository. - https://builds.apache.org/job/zeppelin-pull-request/2647/console ![image](https://user

[GitHub] zeppelin issue #2445: ZEPPELIN-2674 Ignite version upgraded up to 2.0

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2445 LGTM, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2543 I think now CI works properly. Please restart the failed test since it looks like the flaky test - https://travis-ci.org/byung-u/zeppelin/jobs/265423163 --- If your project

[GitHub] zeppelin issue #2543: [ZEPPELIN-2860] Invalid last job execution time

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2543 Checked that CI is green. Merge if no more discussion. https://travis-ci.org/byung-u/zeppelin/builds/265423161 --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2541: [ZEPPELIN-2865] upgrade Beam interpreter to latest ver...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2541 LGTM. Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm Merged to master. Thanks for the contribution again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2512: [ZEPPELIN-2823] Notebook saved status is wrong if ther...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2512 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 Deployed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2460 and works well in mobile (iphone 6s chrome, sarari) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 @soralee Thanks for the review. We need to keep the zeppelin-web module clean. :) Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy Thanks for the contribution. Tested and works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUserList....

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2487 LGTM merge if no more discussion. referred https://www.owasp.org/index.php/SQL_Injection_Prevention_Cheat_Sheet#Defense_Option_1:_Prepared_Statements_.28with_Parameterized_Queries.29

[GitHub] zeppelin issue #2473: [fix] Check runtimeInfos is not null

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2473 Hi, Thanks for the contribution. 1. Could you make the failed job be green? - https://travis-ci.org/ebuildy/zeppelin/jobs/251686246 2. Please make a JIRA ticket for this issue

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Thanks for the contribution @yanboliang. I left a comment. Could you check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch` command

[GitHub] zeppelin pull request #2477: [ZEPPELIN-2342] Improving Test Environment for ...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2477 [ZEPPELIN-2342] Improving Test Environment for zeppelin-web (e2e, coverage, ..) ### What is this PR for? Improved testing environment for zeppelin-web - added `test:watch

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2472: [ZEPPELIN-2749] Use scalable file structure for...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2472 [ZEPPELIN-2749] Use scalable file structure for zeppelin web ### What is this PR for? We have improved zeppelin-web, but some parts are still messy. As part of keeping zeppelin-web

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta I just built PR 2446 and remove `/conf/helium.json` and then installed 2 packages and reorder the icons, 1. But it takes longer than before. IMO, we just need to save

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 Rebased to clean commit messages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally, I

[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2472 rebased to fix some commit message which can't be handled in the merge script. (`*`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2493: [ZEPPELIN-2778] Unit test for credential module...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2493 [ZEPPELIN-2778] Unit test for credential module (zeppelin-web) ### What is this PR for? Added few test cases for the credential module under `zeppelin-web/` Additionally

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto thanks for the contribution. 1. Could you create a JIRA ticket? 2. files under `/thrift` are auto-generated, so we can't modify. 3. You need to the forked repository

[GitHub] zeppelin pull request #2491: [ZEPPELIN-2777] Unit test for configuration mod...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2491 [ZEPPELIN-2777] Unit test for configuration module (zeppelin-web) ### What is this PR for? Added few test cases for the configuration module under `zeppelin-web/` Additionally, I

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy I left a comment. Could u check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 Left a comment, except for it, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2446 @necosta Tested locally and it works well. Could you rebase using the current master? since the base branch looks quite old. LGTM except for it. --- If your project is set up

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2478 Thanks for the great feature! since this is a big change, I guess it takes a time to review and requires multiple reviewers. Let me take a look. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2474 Let create a PR to fix the ASCII issue, we can test this PR based on the ASCII PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 Hi, @malayhm Could you take a look the comment I left? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 Thanks for implementing such a great feature! 1. Could you rebase against the current master? Since filenames were changes, it would be easier to review after rebasing 2. Regarding UX

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 CI is green, I think jenkins was restarted somehow. - https://travis-ci.org/ebuildy/zeppelin/builds/253975556 LGTM merge if no more discussion. --- If your project is set up

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 @desmorto Then could you close and reopen this PR to retrigger jenkins again? https://builds.apache.org/job/zeppelin-pull-request/2363/console --- If your project is set up for it, you

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 @sohaibiftikhar Thanks for the contribution! Travis CI is not set, but this is not relevant with CI. LGTM. merge if no more discussion. --- If your project is set up for it, you can

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Can we write docs to let the user know they can set these options using maven profile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2497 [ZEPPELIN-2779] Unit test for job module (zeppelin-web) ### What is this PR for? Added few test cases for the `job` module under `zeppelin-web/` Additionally

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 I don't have a preference, but in my experience, many web apps rely on the browser provided remember-me feature. Here is an example of Github sign-in page - https://github.com/login

[GitHub] zeppelin issue #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs from bo...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2469 Will be handled later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #2469: [WIP][ZEPPELIN-2726] Move angular related pkgs ...

Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 Deployed - https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/security/shiro_authentication.html#ldap --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2475 @yanboliang Sorry for the late response. Thx for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2497: [ZEPPELIN-2779] Unit test for job module (zeppelin-web...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2497 Thanks for the review @sravan-s Merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh Thank you for the update. 1. Can we add the shortcut into ![image](https://user-images.githubusercontent.com/4968473/28510157-a6b31092-7081-11e7-99e9-1ad9894d9b75

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409 , Could you check https://github.com/apache/zeppelin/pull/2505? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh It's the default binding in emacs mode. ## in default modes https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts ![image](https://user

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2503 Thanks. I updated the previous comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2490: [Zeppelin-2718] Find and replace code in note

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2490 @tinkoff-dwh 1. I realized that `CTRL+F` is bound to `Moving cursor` in paragraphs. Can we use `CTRL + OPT + F` (`ALT` in case of windows OS) or another key what you think better

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2462 @malayhm cursor is still thick. Should I missing something? or.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2500: [ZEPPELIN-2804] Fix shiro_authentication documentation

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2500 I see. thanks for the answer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2497: [ZEPPELIN-2779] Unit test for job module (zeppe...

GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2497 [ZEPPELIN-2779] Unit test for job module (zeppelin-web) ### What is this PR for? Added few test cases for the `job` module under `zeppelin-web/` Additionally, - removed

[GitHub] zeppelin issue #2489: [Refactoring] some opportunities to use diamond operat...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2489 It says `Looks like travis-ci is not configured for your fork.` If you set already travis CI for your fork, could you provide the link? i can help u. --- If your project is set up

<    2   3   4   5   6   7   8   9   10   11   >