[GitHub] [zeppelin] zjffdu commented on pull request #4122: [ZEPPELIN-5379] LIST_CONFIGURATIONS command cannot return the default…

2021-06-04 Thread GitBox
zjffdu commented on pull request #4122: URL: https://github.com/apache/zeppelin/pull/4122#issuecomment-853596439 LGTM, will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] zjffdu closed pull request #4120: [ZEPPELIN-5374] Don't update paragraph config when latest checkpoint of flink is unchanged

2021-06-04 Thread GitBox
zjffdu closed pull request #4120: URL: https://github.com/apache/zeppelin/pull/4120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] Reamer commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-06-04 Thread GitBox
Reamer commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-853941348 I think an empty delimiter is wrong, possibly something like "--conf" would be better. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] zjffdu commented on pull request #4128: [ZEPPELIN-5339] Support scala 2.12 for flink

2021-06-04 Thread GitBox
zjffdu commented on pull request #4128: URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-853621487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [zeppelin] Reamer commented on pull request #4126: [ZEPPELIN-5393] Polish rest, socket package of zeppelin-server

2021-06-04 Thread GitBox
Reamer commented on pull request #4126: URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-853938757 @zjffdu I have created PR #4129. Hopefully this will fix the flapping test. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zeppelin] asfgit closed pull request #4122: [ZEPPELIN-5379] LIST_CONFIGURATIONS command cannot return the default…

2021-06-04 Thread GitBox
asfgit closed pull request #4122: URL: https://github.com/apache/zeppelin/pull/4122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu commented on pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-04 Thread GitBox
zjffdu commented on pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-854380073 CI is fixed now, ready for review @Reamer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zeppelin] zjffdu commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-04 Thread GitBox
zjffdu commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-854371460 Thanks @Reamer It is better to run the tests several times to make sure the flaky test is fixed. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-04 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-854478859 The first CI run was successful. I am now restarting the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [zeppelin] EricGao888 opened a new pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-04 Thread GitBox
EricGao888 opened a new pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130 ### What is this PR for? * Enable extension of flexmark in markdown interpreter ### What type of PR is it? Improvement ### Todos * [ ] - Make emoji auto-scale according to

[GitHub] [zeppelin] Reamer commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-04 Thread GitBox
Reamer commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-854612660 Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository. -- This is an automated message fr

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-04 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-854619053 The second CI run failed... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-04 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-854643077 I updated to newest K8s client version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] zjffdu commented on pull request #4121: [ZEPPELIN-5376] Polish server and service package codes of zeppelin-server

2021-06-05 Thread GitBox
zjffdu commented on pull request #4121: URL: https://github.com/apache/zeppelin/pull/4121#issuecomment-855250956 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] asfgit closed pull request #4128: [ZEPPELIN-5339] Support scala 2.12 for flink

2021-06-05 Thread GitBox
asfgit closed pull request #4128: URL: https://github.com/apache/zeppelin/pull/4128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-06 Thread GitBox
EricGao888 commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-855535278 > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository. Good suggestion, may I a

[GitHub] [zeppelin] zjffdu commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-06 Thread GitBox
zjffdu commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-855538308 @EricGao888 You can use `download-maven-plugin` to download these images and put them in the zeppelin-web module. See the example here https://github.com/apache/zeppelin/blo

[GitHub] [zeppelin] Reamer commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-06 Thread GitBox
Reamer commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r646271563 ## File path: zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/JupyterKernelInterpreter.java ## @@ -216,6 +259,23 @@ private void l

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-07 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-855743541 CI was successful, restart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-07 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-855877968 The second CI run was successful. I squashed a few commits. Next CI run :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [zeppelin] Reamer commented on pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-07 Thread GitBox
Reamer commented on pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-855958400 Third CI run fails again. I add an ignore and open issue in fabric8/kubernetes-client. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer opened a new pull request #4131: Remove joda-time, because its included in jdk8

2021-06-07 Thread GitBox
Reamer opened a new pull request #4131: URL: https://github.com/apache/zeppelin/pull/4131 ### What is this PR for? This PR removes joda-time, which is not necessary with JDK8+ ### What type of PR is it? - Improvement ### What is the Jira issue? * https://issues.apache

[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-07 Thread GitBox
EricGao888 commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856405185 > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository. I found that unicode can

[GitHub] [zeppelin] Sangrho opened a new pull request #4132: [ZEPPELIN-5406] Add detailed explanation for Impersonate on LDAP & Kerberized environments

2021-06-07 Thread GitBox
Sangrho opened a new pull request #4132: URL: https://github.com/apache/zeppelin/pull/4132 ### What is this PR for? For detailed explanation for how to impersonate on LDAP & Kerberized environments. ### What type of PR is it? [Documentation] ### Todos * [ ] - Task

[GitHub] [zeppelin] Reamer commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-07 Thread GitBox
Reamer commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856470547 > > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository. > > I found that unicode c

[GitHub] [zeppelin] asfgit closed pull request #4129: [ZEPPELIN-5400] Polish K8s launcher

2021-06-07 Thread GitBox
asfgit closed pull request #4129: URL: https://github.com/apache/zeppelin/pull/4129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] Reamer opened a new pull request #4133: [ZEPPELIN-5403] Update kubernetes client to 5.4.1 and fix unit tests

2021-06-07 Thread GitBox
Reamer opened a new pull request #4133: URL: https://github.com/apache/zeppelin/pull/4133 ### What is this PR for? This PR re-enables the unit tests in K8's launcher. ### What type of PR is it? - Bug Fix ### What is the Jira issue? * https://issues.apache.org/jira/bro

[GitHub] [zeppelin] Reamer commented on pull request #4118: [ZEPPELIN-5370] Polish pom.xml files

2021-06-07 Thread GitBox
Reamer commented on pull request #4118: URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-856506555 @cuspymd Please rebase to current master to fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] EricGao888 commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-08 Thread GitBox
EricGao888 commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856538713 > > > Where did you find the emoji images? I think it's better to download the emojis during the build and not put them all in our git repository. > > > > > > I fo

[GitHub] [zeppelin] jongyoul commented on pull request #4132: [ZEPPELIN-5406] Add detailed explanation for Impersonate on LDAP & Kerberized environments

2021-06-08 Thread GitBox
jongyoul commented on pull request #4132: URL: https://github.com/apache/zeppelin/pull/4132#issuecomment-856581471 This PR changed documentation only so I'll merge it regardless of the result of CI. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [zeppelin] jongyoul closed pull request #4132: [ZEPPELIN-5406] Add detailed explanation for Impersonate on LDAP & Kerberized environments

2021-06-08 Thread GitBox
jongyoul closed pull request #4132: URL: https://github.com/apache/zeppelin/pull/4132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-09 Thread GitBox
zjffdu commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-857666057 @PrarthiJain Could you check the failed test ? AFAIK, `frontend / test-selenium-with-spark-module-for-spark-2-3` and `core / jdbcIntegrationTest-and-unit-test-of-Spark-2-4-with-

[GitHub] [zeppelin] Reamer commented on pull request #4131: [ZEPPELIN-5404] Remove joda-time

2021-06-10 Thread GitBox
Reamer commented on pull request #4131: URL: https://github.com/apache/zeppelin/pull/4131#issuecomment-858405006 I will merge this PR into master and branch-0.9 on Monday (14.06.2021) if no further comments are received. -- This is an automated message from the Apache Git Service. To res

[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-10 Thread GitBox
PrarthiJain commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-858489147 It seems the Alluxio Interpreter Test is failing, should be fixed with- #2900. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [zeppelin] zjffdu commented on pull request #4131: [ZEPPELIN-5404] Remove joda-time

2021-06-14 Thread GitBox
zjffdu commented on pull request #4131: URL: https://github.com/apache/zeppelin/pull/4131#issuecomment-859231502 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] zjffdu commented on pull request #4118: [ZEPPELIN-5370] Polish pom.xml files

2021-06-14 Thread GitBox
zjffdu commented on pull request #4118: URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-859234456 @cuspymd Could you check the failed spark integration test ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-14 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r649650890 ## File path: zeppelin-plugins/launcher/yarn/src/test/java/org/apache/zeppelin/interpreter/launcher/YarnLauncherUtilTest.java ## @@ -0,0 +1,41 @@ +/* + *

[GitHub] [zeppelin] EricGao888 opened a new pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-14 Thread GitBox
EricGao888 opened a new pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134 ### What is this PR for? * fix ZEPPELIN-5398, make corrupted notes deletable ### What type of PR is it? * Bug Fix ### Todos * None ### What is the Jira issue? * http

[GitHub] [zeppelin] EricGao888 commented on pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-14 Thread GitBox
EricGao888 commented on pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#issuecomment-859420632 > It would be nice to add a unit test about it. Sure, will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] zjffdu commented on pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-14 Thread GitBox
zjffdu commented on pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-859326448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-14 Thread GitBox
zjffdu commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-859235027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-14 Thread GitBox
PrarthiJain commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-859394558 @zjffdu Those were succeeded after re-triggering on my forked repo. However, I think I don't have permission to re-trigger and check the failed tests here. Do I need to upl

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-14 Thread GitBox
cuspymd commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r650643037 ## File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java ## @@ -319,4 +319,22 @@ public Map extractTableConfigOpti

[GitHub] [zeppelin] zjffdu opened a new pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-14 Thread GitBox
zjffdu opened a new pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137 ### What is this PR for? Add timezone support for flink interpreter, It is only available for flink 1.13, previous version are not supported. ### What type of PR is it? [ Impro

[GitHub] [zeppelin] zjffdu opened a new pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-14 Thread GitBox
zjffdu opened a new pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135 ### What is this PR for? Simple PR to address NPE on empty dynamic form input. Instead of throwing NPE, just make the form value as empty string. ### What type of PR is it? [Improveme

[GitHub] [zeppelin] zjffdu opened a new pull request #4136: [ZEPPELIN-5409] Zeppelin server fails to start due to java.lang.ClassNotFoundException: org.apache.commons.vfs2.provider.webdav.WebdavFilePr

2021-06-14 Thread GitBox
zjffdu opened a new pull request #4136: URL: https://github.com/apache/zeppelin/pull/4136 ### What is this PR for? This is a regression issue caused by ZEPPELIN-5303, we should upgrade `commons-vfs2-jackrabbit1` as well ### What type of PR is it? [Bug Fix ] ### T

[GitHub] [zeppelin] chillinger commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive

2021-06-14 Thread GitBox
chillinger commented on pull request #4113: URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-860400795 @zjffdu I can verify that the proposed Fix completely eliminated the deadlocks of zeppelin experienced before. We built a patched version of Zeppelin 0.9 with the chan

[GitHub] [zeppelin] asfgit closed pull request #4131: [ZEPPELIN-5404] Remove joda-time

2021-06-14 Thread GitBox
asfgit closed pull request #4131: URL: https://github.com/apache/zeppelin/pull/4131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] asfgit closed pull request #4121: [ZEPPELIN-5376] Polish server and service package codes of zeppelin-server

2021-06-14 Thread GitBox
asfgit closed pull request #4121: URL: https://github.com/apache/zeppelin/pull/4121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu commented on pull request #4113: [ZEPPELIN-5343] Zeppelin Interface becomes unresponsive

2021-06-14 Thread GitBox
zjffdu commented on pull request #4113: URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-861123437 Thanks @chillinger for the verification, will merge it soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu opened a new pull request #4138: [ZEPPELIN-5193]. Describe table using full table name in FlinkSQL can not work

2021-06-14 Thread GitBox
zjffdu opened a new pull request #4138: URL: https://github.com/apache/zeppelin/pull/4138 ### What is this PR for? Simple PR to make describing table via full table name in flink sql work. Just split full table name via `dot` separator. So that flink api can recognize it correct

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-14 Thread GitBox
zjffdu commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r651419884 ## File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java ## @@ -319,4 +319,22 @@ public Map extractTableConfigOptio

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-14 Thread GitBox
cuspymd commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r651431593 ## File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java ## @@ -197,6 +201,18 @@ protected void proc

[GitHub] [zeppelin] EricGao888 commented on pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-15 Thread GitBox
EricGao888 commented on pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#issuecomment-861331556 > It would be nice to add a unit test about it. unit test added : ) -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [zeppelin] Reamer commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-15 Thread GitBox
Reamer commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r651845240 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java ## @@ -263,6 +264,26 @@ public void testNoteOperations()

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-15 Thread GitBox
zjffdu commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r651857706 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java ## @@ -1012,7 +1012,28 @@ public void updatePersonalizedMode

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-06-15 Thread GitBox
zjffdu commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r651858033 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java ## @@ -1012,7 +1012,28 @@ public void updatePersonalizedMode

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-15 Thread GitBox
zjffdu commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r651932441 ## File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java ## @@ -197,6 +201,18 @@ protected void proce

[GitHub] [zeppelin] asfgit closed pull request #4130: [ZEPPELIN-5266]: Enable extension of flexmark in markdown interpreter

2021-06-15 Thread GitBox
asfgit closed pull request #4130: URL: https://github.com/apache/zeppelin/pull/4130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu opened a new pull request #4139: [ZEPPELIN-5412] Unable to cancel flink job due to fail to take savepoint

2021-06-15 Thread GitBox
zjffdu opened a new pull request #4139: URL: https://github.com/apache/zeppelin/pull/4139 ### What is this PR for? Sometimes flink job is unable to be cancelled when savepoint is enabled. This PR would fall back to cancel job without savepoint if cancelling with savepoint is failed.

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4078: [ZEPPELIN-5286]. Unable to run some tutorial notes in zeppelin docker container

2021-06-15 Thread GitBox
zjffdu commented on a change in pull request #4078: URL: https://github.com/apache/zeppelin/pull/4078#discussion_r652259791 ## File path: scripts/docker/zeppelin/bin/env_python_3_with_R.yml ## @@ -17,7 +17,7 @@ dependencies: - jupyter_client=5 - bokeh=1.3.4 - panel -

[GitHub] [zeppelin] zjffdu commented on pull request #4126: [ZEPPELIN-5393] Polish rest, socket package of zeppelin-server

2021-06-15 Thread GitBox
zjffdu commented on pull request #4126: URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-861920716 @Reamer #4129 is merged, could you rebase this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] Reamer commented on pull request #4126: [ZEPPELIN-5393] Polish rest, socket package of zeppelin-server

2021-06-15 Thread GitBox
Reamer commented on pull request #4126: URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-862068327 > @Reamer #4129 is merged, could you rebase this PR ? This PR is from @cuspymd :smile: @cuspymd please rebase. -- This is an automated message from the Apache Git Se

[GitHub] [zeppelin] zjffdu opened a new pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

2021-06-16 Thread GitBox
zjffdu opened a new pull request #4140: URL: https://github.com/apache/zeppelin/pull/4140 ### What is this PR for? `execution.runtime-mode` is available in flink sql-client, but it is not available in zeppelin flink interpreter. So we need to throw proper error message when user

[GitHub] [zeppelin] zjffdu commented on pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
zjffdu commented on pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#issuecomment-862112387 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652425047 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu opened a new pull request #4141: [ZEPPELIN-5405] ClassNotFoundException in YarnAppMonitor when hadoop client is not installed

2021-06-16 Thread GitBox
zjffdu opened a new pull request #4141: URL: https://github.com/apache/zeppelin/pull/4141 ### What is this PR for? Minor PR to only use YarnAppMonitor when hadoop client is installed, otherwise ClassNotFoundException will be thrown ### What type of PR is it? [ Improvement ]

[GitHub] [zeppelin] Reamer commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652425047 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
zjffdu commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652428776 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-16 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r652430602 ## File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnLauncherUtil.java ## @@ -0,0 +1,49 @@ +/* + * Lic

[GitHub] [zeppelin] Reamer commented on pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#issuecomment-862130900 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-16 Thread GitBox
zjffdu commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-862140754 @PrarthiJain AlluxioInterpreterTest is failed https://github.com/apache/zeppelin/pull/4089/checks?check_run_id=2801927837 -- This is an automated message from the Apache Git S

[GitHub] [zeppelin] asfgit closed pull request #4138: [ZEPPELIN-5193] Describe table using full table name in FlinkSQL can not work

2021-06-18 Thread GitBox
asfgit closed pull request #4138: URL: https://github.com/apache/zeppelin/pull/4138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] Jiabao-Sun commented on a change in pull request #4142: [ZEPPELIN-5415] Fix flink.webui.yarn.useProxy not working on yarn-application mode

2021-06-18 Thread GitBox
Jiabao-Sun commented on a change in pull request #4142: URL: https://github.com/apache/zeppelin/pull/4142#discussion_r654321909 ## File path: flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala ## @@ -318,6 +318,12 @@ abstract class Fl

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

2021-06-18 Thread GitBox
zjffdu commented on a change in pull request #4140: URL: https://github.com/apache/zeppelin/pull/4140#discussion_r654116082 ## File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/FlinkSqlInterrpeter.java ## @@ -502,11 +502,17 @@ public void callSelect(S

[GitHub] [zeppelin] zjffdu commented on pull request #4118: [ZEPPELIN-5370] Polish pom.xml files

2021-06-18 Thread GitBox
zjffdu commented on pull request #4118: URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-863723489 ping @cuspymd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [zeppelin] asfgit closed pull request #4139: [ZEPPELIN-5412] Unable to cancel flink job due to fail to take savepoint

2021-06-18 Thread GitBox
asfgit closed pull request #4139: URL: https://github.com/apache/zeppelin/pull/4139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4142: [ZEPPELIN-5415] Fix flink.webui.yarn.useProxy not working on yarn-application mode

2021-06-18 Thread GitBox
zjffdu commented on a change in pull request #4142: URL: https://github.com/apache/zeppelin/pull/4142#discussion_r654169553 ## File path: flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala ## @@ -318,6 +318,12 @@ abstract class FlinkS

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-18 Thread GitBox
zjffdu commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r654284105 ## File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java ## @@ -99,7 +104,7 @@ private static TableSc

[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-18 Thread GitBox
Reamer commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-863830861 Thrift 0.14.2 has been released. This version also fixed a [regression in the Java library](https://github.com/apache/thrift/commit/d604602064e9218cc1f0153a4f83dff22fa1b44e).

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4137: [ZEPPELIN-5392] Timezone is not applied in the timestamp field in flink interpreter

2021-06-18 Thread GitBox
cuspymd commented on a change in pull request #4137: URL: https://github.com/apache/zeppelin/pull/4137#discussion_r654276703 ## File path: flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/sql/AbstractStreamSqlJob.java ## @@ -99,7 +104,7 @@ private static TableS

[GitHub] [zeppelin] zjffdu commented on pull request #4078: [ZEPPELIN-5286]. Unable to run some tutorial notes in zeppelin docker container

2021-06-18 Thread GitBox
zjffdu commented on pull request #4078: URL: https://github.com/apache/zeppelin/pull/4078#issuecomment-863893978 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] asfgit closed pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-18 Thread GitBox
asfgit closed pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu opened a new pull request #4143: [ZEPPELIN-5311] Unable to run list & add hive statement

2021-06-18 Thread GitBox
zjffdu opened a new pull request #4143: URL: https://github.com/apache/zeppelin/pull/4143 ### What is this PR for? Trivial PR to support list & add hive statement as well, just trim the whitespace otherwise hive will throw syntax error exception. ### What type of PR is it?

[GitHub] [zeppelin] zjffdu commented on pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-20 Thread GitBox
zjffdu commented on pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-864567409 @Reamer Do you have any more comment ? Otherwise I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [zeppelin] Jiabao-Sun commented on a change in pull request #4142: [ZEPPELIN-5415] Fix flink.webui.yarn.useProxy not working on yarn-application mode

2021-06-20 Thread GitBox
Jiabao-Sun commented on a change in pull request #4142: URL: https://github.com/apache/zeppelin/pull/4142#discussion_r655040694 ## File path: flink/flink-scala-parent/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala ## @@ -843,6 +843,18 @@ abstract class Fl

[GitHub] [zeppelin] Reamer commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-20 Thread GitBox
Reamer commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r655079099 ## File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java ## @@ -259,13 +266,

[GitHub] [zeppelin] Reamer commented on a change in pull request #4078: [ZEPPELIN-5286]. Unable to run some tutorial notes in zeppelin docker container

2021-06-20 Thread GitBox
Reamer commented on a change in pull request #4078: URL: https://github.com/apache/zeppelin/pull/4078#discussion_r655090863 ## File path: scripts/docker/zeppelin/bin/env_python_3_with_R.yml ## @@ -1,33 +1,29 @@ -name: base +name: python_3_with_R channels: - conda-forge -

[GitHub] [zeppelin] Reamer commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-06-21 Thread GitBox
Reamer commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-864825992 @nilroy I tried around a bit and found this [great explanation on Stackoverflow](https://stackoverflow.com/a/45201229) I think the following solution can be used in our ca

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r655220571 ## File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java ## @@ -259,13 +266,

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r655220707 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookSocket.java ## @@ -67,7 +67,7 @@ public String getProtocol() { } p

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r655222659 ## File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java ## @@ -259,13 +266,

[GitHub] [zeppelin] Reamer commented on pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
Reamer commented on pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-864889515 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] Reamer removed a comment on pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
Reamer removed a comment on pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-864889515 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4143: [ZEPPELIN-5311] Unable to run list & add hive statement

2021-06-21 Thread GitBox
cuspymd commented on a change in pull request #4143: URL: https://github.com/apache/zeppelin/pull/4143#discussion_r655416528 ## File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java ## @@ -727,12 +727,14 @@ private InterpreterResult executeSql(String dbPre

[GitHub] [zeppelin] asfgit closed pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-21 Thread GitBox
asfgit closed pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] Reamer removed a comment on pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-22 Thread GitBox
Reamer removed a comment on pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-864889515 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [zeppelin] Reamer commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-06-22 Thread GitBox
Reamer commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-864825992 @nilroy I tried around a bit and found this [great explanation on Stackoverflow](https://stackoverflow.com/a/45201229) I think the following solution can be used in our ca

[GitHub] [zeppelin] asfgit closed pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-22 Thread GitBox
asfgit closed pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4143: [ZEPPELIN-5311] Unable to run list & add hive statement

2021-06-22 Thread GitBox
cuspymd commented on a change in pull request #4143: URL: https://github.com/apache/zeppelin/pull/4143#discussion_r655416528 ## File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java ## @@ -727,12 +727,14 @@ private InterpreterResult executeSql(String dbPre

<    1   2   3   4   5   6   7   8   9   10   >