dependabot[bot] commented on PR #4471:
URL: https://github.com/apache/zeppelin/pull/4471#issuecomment-1592067020
Superseded by #4614.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] closed pull request #4471: Bump guava from 24.1.1-jre to
29.0-jre in /bigquery
URL: https://github.com/apache/zeppelin/pull/4471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jongyoul opened a new pull request, #4617:
URL: https://github.com/apache/zeppelin/pull/4617
### What is this PR for?
Fixing errors for integration test. The file was being served as s3 endpoint
but it's not accessible for now
### What type of PR is it?
Hot Fix
###
jongyoul merged PR #4133:
URL: https://github.com/apache/zeppelin/pull/4133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #4616:
URL: https://github.com/apache/zeppelin/pull/4616
Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 32.0.0-jre.
Release notes
Sourced from https://github.com/google/guava/releases;>guava's releases.
32.0.0
shefali163 commented on PR #4481:
URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1592384540
Are the CI failures related to this change? If not, can this be reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhugezifang commented on PR #4606:
URL: https://github.com/apache/zeppelin/pull/4606#issuecomment-1563853718
> You should move this logic into the JDBC interpreter.
hi , i am very sorry ,could you help to review this pr again,
https://github.com/apache/zeppelin/pull/4598
--
This
Reamer commented on PR #4605:
URL: https://github.com/apache/zeppelin/pull/4605#issuecomment-1563857187
All tests except the selenium test pass successfully. In my eyes Ready to
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Reamer commented on PR #4604:
URL: https://github.com/apache/zeppelin/pull/4604#issuecomment-1563857421
All tests except the selenium test pass successfully. In my eyes Ready to
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Reamer merged PR #4602:
URL: https://github.com/apache/zeppelin/pull/4602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568088732
Do you think it would be smart to ignore all the warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jongyoul merged PR #4604:
URL: https://github.com/apache/zeppelin/pull/4604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ntheanh201 opened a new pull request, #4608:
URL: https://github.com/apache/zeppelin/pull/4608
### What is this PR for?
Fix broken url of conjars repository.
The old link: https://conjars.org/repo is deprecated, changed to
https://conjars.wensel.net/repo
### What type of PR
matthias-koch opened a new pull request, #4610:
URL: https://github.com/apache/zeppelin/pull/4610
### What is this PR for?
If you use the plugin GithubNotebookRepo to sync the notes with a remote git
repository, moved and deleted notes are not synced.
This issue has been fixed.
matthias-koch commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568120874
I could limit it to DeprecationWarnings.
Another option would be to check the type of index. However to do this I
would have to import numpy in zeppelin_context.py, which I
matthias-koch commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568393762
Let's do it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Reamer commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568373139
It seems that the data types are different. What do you think about simply
counting down?
```
rowNumber = min(len(rows), len(df.index.values))
for idx, row in zip(index, rows):
jongyoul merged PR #4605:
URL: https://github.com/apache/zeppelin/pull/4605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
matthias-koch opened a new pull request, #4609:
URL: https://github.com/apache/zeppelin/pull/4609
### What is this PR for?
If z.show is used with a Panda DataFrame that has a timestamp as index, then
a DeprecationWarning appears for every row in the data frame.
This issue was fixed.
Reamer commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568471013
Let's wait for the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Reamer merged PR #4608:
URL: https://github.com/apache/zeppelin/pull/4608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4610:
URL: https://github.com/apache/zeppelin/pull/4610#issuecomment-1569717750
Will merge this PR on Friday as long as no other comments are received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zhugezifang commented on PR #4606:
URL: https://github.com/apache/zeppelin/pull/4606#issuecomment-1569408191
hi @Reamer @jongyoul @huage1994 ,could you help me to review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhugezifang opened a new pull request, #4611:
URL: https://github.com/apache/zeppelin/pull/4611
### What is this PR for?
improve query efficiency
Design Document:
https://docs.google.com/document/d/1wruK0ZZ0XiriYOraFa5WYSz531pcsCpJeIBmne57fJY/edit?usp=sharing
### What
Reamer merged PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer merged PR #4607:
URL: https://github.com/apache/zeppelin/pull/4607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ebongzzang commented on PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1570008374
I've encountered below exception setup flink 1.16.0 with zeppelin
interpreter. (mode = remote)
`NoClassDefFoundError:
Reamer merged PR #4610:
URL: https://github.com/apache/zeppelin/pull/4610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhugezifang commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1573214026
hi @Reamer @jongyoul @huage1994 ,could you help me to review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Reamer opened a new pull request, #4604:
URL: https://github.com/apache/zeppelin/pull/4604
### What is this PR for?
Spark 2.4 does not support JDK 11, so we should test with a newer Spark
version here.
### What type of PR is it?
Refactoring
### What is the Jira
zhugezifang opened a new pull request, #4606:
URL: https://github.com/apache/zeppelin/pull/4606
### What is this PR for?
improve query efficiency
https://docs.google.com/document/d/1wruK0ZZ0XiriYOraFa5WYSz531pcsCpJeIBmne57fJY/edit?usp=sharing
### What type of PR is it?
Reamer commented on PR #4497:
URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1562440111
Finally the CI runs successfully with JDK 11. The only exception is the
Selenium test, which did not work before.
I'm going to clean up the PR now and create some PullRequest which
zhugezifang commented on code in PR #4612:
URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1222353767
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java:
##
@@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {
zhugezifang commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582091105
> A few thoughts about your work:
>
> * All functionality is located in the JDBC interpreter. All new
dependencies and classes should also be located there.
> * It seems
Reamer commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582193016
I don't think so, because this function is used by all save operations. e.g.
when note files are created. These would then block each other.
--
This is an automated message from the
Reamer commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581919786
A `synchronized` at the `saveNoteAuth` method should fix the problem. What
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581997675
Yes, i also think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Reamer commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582001696
Feel free to prepare a PullRequest with JIRA ticket. Your StackTrace should
be included in the JIRA ticket.
--
This is an automated message from the Apache Git Service.
To respond to
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581779073
Thanks for your reply.
This pull request migrates solve the concurrency problem caused by multiple
concurrent calls to
zhugezifang commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582065412
@Reamer hi，firstly thanks for your advice
"All functionality is located in the JDBC interpreter. All new dependencies
and classes should also be located there" it
zhugezifang commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582067198
> A few thoughts about your work:
>
> * All functionality is located in the JDBC interpreter. All new
dependencies and classes should also be located there.
> * It seems
Reamer commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-158298
A few thoughts about your work:
- All functionality is located in the JDBC interpreter. All new
dependencies and classes should also be located there.
- It seems that in case of a
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582052448
Mybe a synchronized at the
`org.apache.zeppelin.util.FileUtils#atomicWriteToFile(java.lang.String,
java.io.File, java.util.Set)` is
a better option.
--
This is an automated
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582337500
Thanks for your reply. I understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jongyoul commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582561003
Sorry for the late and short comment but how about making debug paragraph as
a new interpreter? I mean, for instance, `%jdbc.debug`. Debugging jdbc
paragraph itself is reasonable but
jongyoul commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1582577943
> and the data cache is really for hive like this large data database (not
for mysql), as we know , hive sql will tranlate to mapreduce job， complex hive
sql have shuffle and reducer
zhugezifang commented on PR #4611:
URL: https://github.com/apache/zeppelin/pull/4611#issuecomment-1584017096
> > and the data cache is really for hive like this large data database (not
for mysql), as we know , hive sql will tranlate to mapreduce job， complex hive
sql have shuffle and
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078089
hi~, I tried to use the above modifications, but now occasionally throw
java.nio.file.NoSuchFileException
```
Caused by: java.nio.file.NoSuchFileException:
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078356
hi~, I tried to use the above modifications, but now occasionally throw
java.nio.file.NoSuchFileException
```
Caused by: java.nio.file.NoSuchFileException:
youshaojun commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580071482
hi~, I tried to use the above modifications, but now occasionally throw
java.nio.file.NoSuchFileException
```
Caused by: java.nio.file.NoSuchFileException:
Reamer commented on PR #4563:
URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580598263
Are you sure it is because of this change?
I think you have another concurrency problem.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jongyoul commented on code in PR #4612:
URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221525956
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java:
##
@@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {
Reamer commented on code in PR #4612:
URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221819108
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java:
##
@@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {
jongyoul commented on code in PR #4612:
URL: https://github.com/apache/zeppelin/pull/4612#discussion_r1221824271
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java:
##
@@ -124,11 +122,33 @@ public void removeNoteConnection(String noteId) {
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1558675843
> > Thank you for your contribution. I already saw some comments by @Reamer
but I also could see some style issue. (Yes, Zeppelin doesn't have very-very
strict rules for styling but
realknorke commented on PR #4586:
URL: https://github.com/apache/zeppelin/pull/4586#issuecomment-1586909509
This seems like a reasonable change request and easy to fix. @zjffdu is it
possible for you to fix that? Thanks a lot! :)
--
This is an automated message from the Apache Git
Reamer merged PR #4612:
URL: https://github.com/apache/zeppelin/pull/4612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jongyoul merged PR #4613:
URL: https://github.com/apache/zeppelin/pull/4613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jongyoul commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235968470
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
LeapYear closed pull request #3947: [ZEPPELIN-5066] Notebook creation fails in
Zeppelin 0.9 with namespace collision
URL: https://github.com/apache/zeppelin/pull/3947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jongyoul commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Reamer commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236422121
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jongyoul commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236475777
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jongyoul commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1236471742
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jongyoul opened a new pull request, #4623:
URL: https://github.com/apache/zeppelin/pull/4623
### What is this PR for?
Changing the location of `bank.csv` which is being used in integration tests
### What type of PR is it?
Hot Fix
### Todos
* [x] - Change the
Reamer commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r123709
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jongyoul commented on PR #4497:
URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1600948242
I like it. I totally believe that we should support JDK 11 even though we
lose some old versioned compatibility. Let me try to see it eagerly.
--
This is an automated message from
idzikovsky opened a new pull request, #4624:
URL: https://github.com/apache/zeppelin/pull/4624
### What is this PR for?
Users who are able to see notes in some directory can rename, move to trash
and remove from trash that directory without being owner or having write
permissions for
shefali163 opened a new pull request, #4625:
URL: https://github.com/apache/zeppelin/pull/4625
### What is this PR for?
Bump jsoup version for fixing CVE-2021-37714
### What type of PR is it?
Improvement
### What is the Jira issue?
jongyoul merged PR #4623:
URL: https://github.com/apache/zeppelin/pull/4623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jongyoul commented on PR #4615:
URL: https://github.com/apache/zeppelin/pull/4615#issuecomment-1612550228
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jongyoul commented on PR #4619:
URL: https://github.com/apache/zeppelin/pull/4619#issuecomment-1612549882
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jongyoul commented on PR #4625:
URL: https://github.com/apache/zeppelin/pull/4625#issuecomment-1612606501
BTW, why don't we update the latest version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jongyoul commented on PR #4626:
URL: https://github.com/apache/zeppelin/pull/4626#issuecomment-1612729433
@zjffdu @Reamer @huage1994 Could you please review this PR? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jongyoul merged PR #4626:
URL: https://github.com/apache/zeppelin/pull/4626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596181619
I think it would be good if with this fix the checkstyle plugin is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187009
I see. Which Maven command did you run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zinal commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187342
> I see. Which Maven command did you run?
mvn clean package -DskipTests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596241260
Thank you, I can reproduce the issue.
Can you change the Goal `package` to `verify` in the following line? Then
the CI system should run checkstyle. Unfortunately the phase `package`
Reamer merged PR #4617:
URL: https://github.com/apache/zeppelin/pull/4617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4481:
URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1596530412
> Are the CI failures related to this change? If not, can this be reviewed?
I do not think so.
--
This is an automated message from the Apache Git Service.
To respond to the
Reamer commented on PR #4508:
URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1596526453
@zjffdu Do you know why ivy is included here as a dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jongyoul commented on PR #4617:
URL: https://github.com/apache/zeppelin/pull/4617#issuecomment-1596371748
@Reamer @zjffdu @huage1994 Could you please approve this PR? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zinal opened a new pull request, #4620:
URL: https://github.com/apache/zeppelin/pull/4620
### What is this PR for?
Fixed minor issues in Java files formatting to make maven-checkstyle-plugin
happy
### What type of PR is it?
Improvement
### Todos
### What is
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596191919
I am surprised that there are no errors in the CI.
Do you see errors in the CI system? Maybe we should adjust the default build.
--
This is an automated message from the Apache Git
jongyoul merged PR #4618:
URL: https://github.com/apache/zeppelin/pull/4618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zinal commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596182691
> I think it would be good if with this fix the checkstyle plugin is enabled.
It seems to be enabled, at least it was complaining without the fixes when I
followed the general build
zjffdu commented on PR #4508:
URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598025256
I think it is not used any more, can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Reamer opened a new pull request, #4622:
URL: https://github.com/apache/zeppelin/pull/4622
### What is this PR for?
Currently no longer in use, so the dependency is removed.
See: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598025256
### What type of PR is it?
jongyoul commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235074369
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jongyoul merged PR #4622:
URL: https://github.com/apache/zeppelin/pull/4622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#issuecomment-1597553878
Hi @joakime
I hope you are still active in the Jetty project and wanted to take this
opportunity to thank you for your detailed
Reamer opened a new pull request, #4621:
URL: https://github.com/apache/zeppelin/pull/4621
### What is this PR for?
This PR addresses all comments from the following comment.
https://github.com/eclipse/jetty.project/issues/6592#issuecomment-897877018
The comments were very helpful
jongyoul commented on code in PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244500227
##
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##
@@ -1497,4 +1530,78 @@ private boolean checkPermission(String noteId,
jongyoul commented on code in PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244498036
##
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java:
##
@@ -1192,24 +1203,38 @@ public void moveFolderToTrash(String folderPath,
jongyoul commented on PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1610385548
BTW, there are no tests for the features. Could you please add tests for
your feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Reamer commented on PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#issuecomment-1608925309
> is `web.xml` needed?
I think so.
I don't think the context is currently being used anywhere.
```
configuration
deployment
```
but the
Reamer merged PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
idzikovsky commented on PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1609093390
Issues in my last comment were resolved in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Reamer commented on code in PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244808864
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java:
##
@@ -376,7 +381,7 @@ private NoteNode getNoteNode(String notePath) throws
201 - 300 of 394 matches
Mail list logo
