Reamer commented on PR #4625:
URL: https://github.com/apache/zeppelin/pull/4625#issuecomment-1610990075
Based on https://mvnrepository.com/artifact/org.jsoup/jsoup do you see a way
to patch in the other vulnerability as well?
--
This is an automated message from the Apache Git Service.
dependabot[bot] opened a new pull request, #4619:
URL: https://github.com/apache/zeppelin/pull/4619
Bumps [snappy-java](https://github.com/xerial/snappy-java) from 1.1.8.4 to
1.1.10.1.
Release notes
Sourced from https://github.com/xerial/snappy-java/releases;>snappy-java's
jongyoul commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1590269638
@zhugezifang Hello, sorry for the late reply. I glance at your PR and
suggest you make a child interpreter like `jdbc.debug` instead of adding a
menu. The debug paragraph is currently
shefali163 commented on PR #4508:
URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1590585554
Hi, Can this PR be reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shefali163 commented on PR #4481:
URL: https://github.com/apache/zeppelin/pull/4481#issuecomment-1590584477
Hi, Can this PR be reviewed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Reamer commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Reamer commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Reamer commented on code in PR #4621:
URL: https://github.com/apache/zeppelin/pull/4621#discussion_r1235380362
##
zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Reamer commented on PR #4508:
URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598894158
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] closed pull request #4508: Bump ivy from 2.4.0 to 2.5.1 in
/flink/flink-scala-parent
URL: https://github.com/apache/zeppelin/pull/4508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #4508:
URL: https://github.com/apache/zeppelin/pull/4508#issuecomment-1598894737
Looks like org.apache.ivy:ivy is no longer a dependency, so this is no
longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
idzikovsky commented on PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#issuecomment-1605038003
Sorry, I made this PR on top of 0.10.1 version, and it seems like something
has been changed in this filed in master branch since then.
Now I have local fix of this issue for
jongyoul merged PR #4592:
URL: https://github.com/apache/zeppelin/pull/4592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zjffdu commented on PR #4594:
URL: https://github.com/apache/zeppelin/pull/4594#issuecomment-1536147257
@zhugezifang Could you make a screenshot of what this feature looks like?
And it's better to add doc in `jdbc.md`
--
This is an automated message from the Apache Git Service.
To
zhugezifang commented on PR #4594:
URL: https://github.com/apache/zeppelin/pull/4594#issuecomment-1536158697
> @zhugezifang Could you make a screenshot of what this feature looks like?
And it's better to add doc in `jdbc.md`
ok，i add a doc in jdbc.md
--
This is an automated
zhugezifang commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-153779
> I see code a lot, one file even has over 28000 lines of new code. Was this
code generated or did you write it yourself?
>
> I don't see myself being able to do a review here
zhugezifang commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1538192630
> I see code a lot, one file even has over 28000 lines of new code. Was this
code generated or did you write it yourself?
>
> I don't see myself being able to do a review here
Reamer commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1537870669
I see code a lot, one file even has over 28000 lines of new code. Was this
code generated or did you write it yourself?
I don't see myself being able to do a review here as there
xieyi888 opened a new pull request, #4597:
URL: https://github.com/apache/zeppelin/pull/4597
### What is this PR for?
for jdbc interpreter. in some situation, 'zeppelin.jdbc.auth.type'=
'KERBEROS', such as hive
if interprete open for long time(more than 12h), and execyte sql,
huage1994 commented on code in PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1189389993
##
zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java:
##
@@ -20,21 +20,22 @@
import
huage1994 commented on code in PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1189389993
##
zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java:
##
@@ -20,21 +20,22 @@
import
Reamer merged PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer opened a new pull request, #4600:
URL: https://github.com/apache/zeppelin/pull/4600
### What is this PR for?
This PR migrates the Zeppelin-server module from JUnit4 to JUnit 5.
### What type of PR is it?
Improvement
Test
### What is the Jira issue?
*
Reamer opened a new pull request, #4601:
URL: https://github.com/apache/zeppelin/pull/4601
### What is this PR for?
This PR is minimally invasive. This PR updates atomix from 3.0.0-rc4 to
3.0.0-rc5m which removes hamcrest-all as compile dependency from
zeppelin-interpreter.
xieyi888 commented on PR #4597:
URL: https://github.com/apache/zeppelin/pull/4597#issuecomment-1541506278
> LGTM Unfortunately, I cannot verify the change, but they look plausible. I
will merge the change on Friday as long as no further comments are received.
thanks for your review
dependabot[bot] opened a new pull request, #4599:
URL: https://github.com/apache/zeppelin/pull/4599
Bumps spark-core_2.12 from 3.1.1 to 3.4.0.
[
the older version
Reamer commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543457201
> hi @Reamer is this pr has other problems？ i really want to add this
feature to zeppelin， could you help me complete it？
Don't you see the review comments from me?
--
This is
Reamer commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543535531
I do not see your changes.
--
This is an automated message from the Apache Git
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543339056
hi @Reamer is this pr has other problems？ i really want to add this feature
to zeppelin， could you help me complete it？
--
This is an automated message from the Apache Git
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543519064
> > hi @Reamer is this pr has other problems？ i really want to add this
feature to zeppelin， could you help me complete it？
>
> Don't you see the review comments from me?
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543701096
> I have created
[zhugezifang#1](https://github.com/zhugezifang/zeppelin/pull/1) for you. Please
look over it. The compilation works. I can't make any statement about the
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1190893807
##
zeppelin-interpreter/pom.xml:
##
@@ -218,6 +219,12 @@
mockito-core
test
+
+
+ org.antlr
+ antlr4
Review Comment:
I think that
Reamer commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1543645830
I have created https://github.com/zhugezifang/zeppelin/pull/1 for you.
Please look over it. The compilation works. I can't make any statement about
the functionality.
--
This is an
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1190893807
##
zeppelin-interpreter/pom.xml:
##
@@ -218,6 +219,12 @@
mockito-core
test
+
+
+ org.antlr
+ antlr4
Review Comment:
I think that
jongyoul commented on PR #4601:
URL: https://github.com/apache/zeppelin/pull/4601#issuecomment-1546544979
I approved it. BTW, you can feel free to ping me or assign me as a reviewer
to send me a notification :-) I'm willing to help to review if needed.
--
This is an automated message
jongyoul merged PR #4601:
URL: https://github.com/apache/zeppelin/pull/4601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1547221612
> > I found two minor improvements. Can you correct your formatter. For
example, Zeppelin uses an indentation of two spaces. Furthermore, the use of
antlr4 must be included in the
jongyoul commented on PR #4602:
URL: https://github.com/apache/zeppelin/pull/4602#issuecomment-1548999719
BTW,
https://github.com/apache/zeppelin/assets/3612566/85d61cfd-8695-4b6c-add6-de72a88f4b9b;>
Keep failing again?
--
This is an automated message from the Apache Git
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1549018532
> I found two minor improvements. Can you correct your formatter. For
example, Zeppelin uses an indentation of two spaces. Furthermore, the use of
antlr4 must be included in the
Reamer commented on PR #4602:
URL: https://github.com/apache/zeppelin/pull/4602#issuecomment-1549326243
> Keep failing again?
Yes the selenium test is very unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1194952676
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jongyoul commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1549881081
Thank you for your contribution. I already saw some comments by @Reamer but
I also could see some style issue. (Yes, Zeppelin doesn't have very-very strict
rules for styling but I
jongyoul commented on PR #4602:
URL: https://github.com/apache/zeppelin/pull/4602#issuecomment-1549883637
> >Keep failing again?
>
> Yes the selenium test is very unstable.
Let me check it sooner than later
--
This is an automated message from the Apache Git Service.
To
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1550574022
> I have added a few comments. Please remember to include images of both
front ends in the PullRequest description.
hi @Reamer ，i not do the new ui ，You see, okay？ i am really
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1550569502
> Thank you for your contribution. I already saw some comments by @Reamer
but I also could see some style issue. (Yes, Zeppelin doesn't have very-very
strict rules for styling but I
Reamer merged PR #4600:
URL: https://github.com/apache/zeppelin/pull/4600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Reamer commented on PR #4602:
URL: https://github.com/apache/zeppelin/pull/4602#issuecomment-1550934923
I will observe this feature a bit more in my productive environment. So far,
everything looks very good.
--
This is an automated message from the Apache Git Service.
To respond to the
zhugezifang commented on code in PR #4594:
URL: https://github.com/apache/zeppelin/pull/4594#discussion_r1186640864
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##
@@ -28,14 +28,7 @@
import java.net.SocketTimeoutException;
import
zhugezifang opened a new pull request, #4596:
URL: https://github.com/apache/zeppelin/pull/4596
### What is this PR for?
This pull request add sql debug feat into zeppelin
### What type of PR is it?
Feature
### Todos
* [ ] - Task
### What is the Jira issue?
zhugezifang closed pull request #4594: [ZEPPELIN-5896]feat:add sql debug feat
URL: https://github.com/apache/zeppelin/pull/4594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
huage1994 commented on code in PR #4594:
URL: https://github.com/apache/zeppelin/pull/4594#discussion_r1186601161
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##
@@ -28,14 +28,7 @@
import java.net.SocketTimeoutException;
import
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1191227143
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1192046617
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1192064601
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/antlr/SqlSplitVisitor.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1545324330
> > We need also an integration in the new UI `zeppelin-web-angular`.
>
> hi @Reamer i am not familiar with the new ui of angular , is there a
developer familiar with angular
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1545030591
> We need also an integration in the new UI `zeppelin-web-angular`.
hi @Reamer i am not familiar with the new ui of angular , is there a
developer familiar with angular in
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1544991828
> We need also an integration in the new UI `zeppelin-web-angular`.
yes，it also need
--
This is an automated message from the Apache Git Service.
To respond to the message,
Reamer commented on PR #4601:
URL: https://github.com/apache/zeppelin/pull/4601#issuecomment-1545796787
I need a review here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1545545539
> I found two minor improvements. Can you correct your formatter. For
example, Zeppelin uses an indentation of two spaces. Furthermore, the use of
antlr4 must be included in the
Reamer merged PR #4597:
URL: https://github.com/apache/zeppelin/pull/4597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhugezifang opened a new pull request, #4594:
URL: https://github.com/apache/zeppelin/pull/4594
### What is this PR for?
This pull request add sql debug feat into zeppelin
### What type of PR is it?
Feature
### Todos
* [ ] - Task
### What is the Jira issue?
Reamer commented on PR #4592:
URL: https://github.com/apache/zeppelin/pull/4592#issuecomment-1535779121
Additional Review needed after I have rebased the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
huage1994 commented on code in PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185841009
##
zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java:
##
@@ -20,21 +20,22 @@
import
huage1994 commented on PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595#issuecomment-1535934652
LGTM except for some minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Reamer commented on code in PR #4595:
URL: https://github.com/apache/zeppelin/pull/4595#discussion_r1185898124
##
zeppelin-interpreter/src/test/java/org/apache/zeppelin/cluster/ClusterSingleNodeTest.java:
##
@@ -20,21 +20,22 @@
import
Reamer opened a new pull request, #4595:
URL: https://github.com/apache/zeppelin/pull/4595
### What is this PR for?
This PR is to migrate the tests in zeppelin-interpreter module from JUnit 4
to JUnit 5, which is a part of [JUnit 5 Migration
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1552299344
> I am very unhappy with the code quality and therefore will not pursue this
feature. Another reviewer is welcome to ask my opinion once the code is clean.
In my opinion, most of
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1552873939
> I am very unhappy with the code quality and therefore will not pursue this
feature. Another reviewer is welcome to ask my opinion once the code is clean.
In my opinion, most of
kp-incelligent closed pull request #4603: fix maven dependency convergence
errors
URL: https://github.com/apache/zeppelin/pull/4603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kp-incelligent commented on PR #4603:
URL: https://github.com/apache/zeppelin/pull/4603#issuecomment-1552738528
My bad, I was running it with
` mvn clean package -DskipTests`
which uses the system's Maven
```
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1553035671
> Thank you for your contribution. I already saw some comments by @Reamer
but I also could see some style issue. (Yes, Zeppelin doesn't have very-very
strict rules for styling but I
zhugezifang closed pull request #4596: [ZEPPELIN-5896]feat:add sql debug feature
URL: https://github.com/apache/zeppelin/pull/4596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zhugezifang opened a new pull request, #4598:
URL: https://github.com/apache/zeppelin/pull/4598
### What is this PR for?
This pull request add sql debug feat into zeppelin
### What type of PR is it?
Feature
### Todos
* [ ] - Task
### What is the Jira issue?
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1188549738
##
zeppelin-interpreter/pom.xml:
##
@@ -242,6 +249,29 @@
-MM-dd HH:mm:ss
+
+org.antlr
+antlr4-maven-plugin
+
zhugezifang commented on PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1540103956
> Is there a reason why you open so many pull requests with the same
subject? You can always change the existing pull request. If everything works
with the Maven plugin, the pull
zhugezifang commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1188592534
##
zeppelin-interpreter/src/main/antrl4/Sql.g4:
##
@@ -0,0 +1,1976 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
zhugezifang commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1537654029
@Reamer hi,i haved developed the feature of sql debug and add a pull
request, could you help me to review it？
--
This is an automated message from the Apache Git Service.
To
zjffdu commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1537664033
@zhugezifang Is this feature only apply to any specific database? Because I
see you have a sql parser. And is it only for jdbc interpreter? Can it been
applied to spark sql?
--
This
zhugezifang commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1537697429
> @zhugezifang Is this feature only apply to any specific database? Because
I see you have a sql parser. And is it only for jdbc interpreter? Can it been
applied to spark sql?
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1188820387
##
zeppelin-interpreter/src/main/antrl4/Sql.g4:
##
@@ -0,0 +1,1976 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
Reamer commented on PR #4603:
URL: https://github.com/apache/zeppelin/pull/4603#issuecomment-1551529562
What is your Maven call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kp-incelligent opened a new pull request, #4603:
URL: https://github.com/apache/zeppelin/pull/4603
Hello.
I got the following Maven errors when trying to build from source (current
master branch):
```
[INFO] --< org.apache.zeppelin:zeppelin-interpreter
>--
Reamer commented on PR #4581:
URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1551599673
I created https://github.com/grizzly-monkey/zeppelin/pull/1 to fix this
feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Reamer commented on code in PR #4598:
URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1196585537
##
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:
##
@@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext
context)
301 - 394 of 394 matches
Mail list logo
