Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@Leemoonsoo, @felixcheung, @zjffdu I think it's good to go.
Any concerns about backend code like persistency, ...?
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2616
@gef756 Could u make CI green?
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2585
Hi, Thanks for rebasing and testing. But this recent PR passed the CI.
If you don't mind please re-run few times until successful and check the
failure reasons?
If we can verify
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2585
The 3/4 jobs failed. Please rebase this PR based on master. And Could you
resolve them?
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2573
- https://travis-ci.org/1ambda/zeppelin/jobs/286465199
-
https://s3.amazonaws.com/archive.travis-ci.org/jobs/286465199/log.txt?X-Amz-Expires=30=20171011T113958Z=AWS4-HMAC-SHA256
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2573
rebased since it's quite old
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2616
Nowadays many browser support password auto-completion. (e.g Chrome, ...)
So +1 for this feature.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2585
I wanted to merge now. But cound't find the build history.
- https://builds.apache.org/job/zeppelin-pull-request/2960/
@yu74n if you don't mind close and reopen this issue
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2617
I tried to search other typo but couldn't find (for viable text, not for
css class things). LGTM.
### What is this PR for?
Can't build docker image for bin due to missing wget cmd
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2585
Thanks for the contribution @yu74n
Looks Good to Me. Let me test more cases and then left feedback soon.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@Madhuka Happy to see the icon.
I just searched the license but couldn't find the license. It only says
"free for commercial usage". Could you check it can be used even in
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2580
[ZEPPELIN-2924] Fix broken javascript source map
### What is this PR for?
Fixed broken javascript source map. The coverage loader should be used only
for test env.
**that's
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2580
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@malayhm it's nice if we can remove `More` text and there is no license
problem ð
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
@malayhm What about this icon?
- http://fontawesome.io/icon/bars
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2580
---
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2580
[ZEPPELIN-2924] Fix broken javascript source map
### What is this PR for?
Fixed broken javascript source map. The coverage loader should be used only
for test env.
**that's
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2558
@ruseel Thanks for the update. Could you resolve zjffdu's last comment?
---
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2580
[ZEPPELIN-2924] Fix broken javascript source map
### What is this PR for?
Fixed broken javascript source map. The coverage loader should be used only
for test env.
**that's
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu I created one. Thanks.
- https://issues.apache.org/jira/browse/ZEPPELIN-2923
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Checked that `conda list` works beautifully. But I am getting this ipython
related message when activate a new env. Can we remove this message which is
not related to conda at all
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2579
@malayhm Hi, Thanks for the contribution.
I just read the JIRA issue and have a question. Could you elaborate the
situation when
> sometimes user want to delete the last em
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Tested locally and works well. @cloverhearts Can we fix `conda list`
command as well? it will need exactly the same code with `conda install`.
LGTM except for it.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Merge if no more discussion.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts There is no problem about python lib paths.
`%python.conda install` and `%python conda list` commands are the problem.
They don't aware activated env by Zeppelin
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2574
@cloverhearts There is no problem about python lib paths.
`%python.conda install` command is the problem.
So you don't need to write code for python path.
### What is this PR for?
Sometimes I can see manually written error handler and it's repeated again
and again.
Even
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2572
CI failed, but irrelevant.
-
https://s3.amazonaws.com/archive.travis-ci.org/jobs/273164416/log.txt?X-Amz-Expires=30=20170908T065857Z=AWS4-HMAC-SHA256=AKIAJRYRXRSVGNKPKO5A/20170908/us-east
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2572
---
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2572
[ZEPPELIN-2919] fix: Fallback to table when vis is not available
### What is this PR for?
fallback to table when vis is not available.
The erroneous situation can happen when
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2572
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2525
@yu74n Thanks for the update. Could u restart / check the failed job?
https://travis-ci.org/yu74n/zeppelin/jobs/273160145
---
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2572
[ZEPPELIN-2919] fix: Fallback to table when vis is not available
### What is this PR for?
fallback to table when vis is not available.
The erroneous situation can happen when
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Personally, I like this change.
But just to make sure It would be nice to wait few days since this affects
on user experiences.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Looks good to me
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2568
I agree to extract remove icon outside of the setting dropdown.
- Can we use the thinner icon for remove?
- Not sure new setting icon is good or not.
* you might propose more
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2569
Cool!
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2559
CI is green, merge if no more discussion.
- https://travis-ci.org/janusd/zeppelin/builds/270815865
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2559
Read the description and LGTM.
> ZEPPELIN-2769 introduced a mechanism to prevent SQL injection, but
unfortunately table names can not be parameterised in PreparedStatements. A
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2492
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2492
@krishna-pandey Hi, I just built master execute zeppelin.
-
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2548
Hi, @kepricon Could you resolve the conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2558
Hi, @ruseel! Thanks for the contribution.
Could u setup travis CI your forked zeppelin repositiory?
Please setup by swich on 'zeppelin' repository at
https://travis-ci.org
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2557
Could u restart https://travis-ci.org/minahlee/zeppelin/jobs/270775840
I am not sure this one is due to flaky or not.
---
If your project is set up for it, you can reply to this email
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2557
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
The one of famous product what does the same thing with this PR is Source
Tree as u know. And it has this kind of UI. I think @tinkoff-dwh you can get
ideas from this UI
 only.
```js
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2510
Verified that this PR works on master with ipython interpreter. (See the
timestamp in the paragraph)
Merge if no more discussion.
you said that
> I confirm the code I wrote for Zeppelin 0.6.0 solved the dead l
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2525
@yu74n Could you solve the conflict and reply @felixcheung's last comment?
> but seems like this isn't just default owner/admin for private mode
only, but in all cases?
---
If y
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2525
I think this feature is useful. That's because admin can't see all notes
currently
- since they not owner even if admin has `admin` role.
- so admin needs to ask all notebook
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2526
IMO introducing `EXECUTE` permission makes sense. For instance.
1. A shared notebook (dashboard) contains important indices and it requires
large query executions. Thus I don't want
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2547
LGTM merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2533
Hi, ping @SDRLurker
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2543
LGTM merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2541
LGTM. Merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2543
Checked that CI is green. Merge if no more discussion.
https://travis-ci.org/byung-u/zeppelin/builds/265423161
---
If your project is set up for it, you can reply to this email and have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2543
I think now CI works properly.
Please restart the failed test since it looks like the flaky test
- https://travis-ci.org/byung-u/zeppelin/jobs/265423163
---
If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2445
LGTM, merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1151
Closed. Thanks for the reporting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2538
LGTM. Merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2527
LGTM. merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2540
Some PRs made yesterday passed CI. Could you rebase using current master? I
am not sure what base branch you are using.
