[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @RoxanaTapia Could you file a Jira issue here https://issues.apache.org/jira/projects/ZEPPELIN so that it can be tracked & handled separately ? Once a patch is merged, can't be opened again or tracked anymore. ---
[GitHub] zeppelin issue #2660: Change Spell url to snapshot-8
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2660 Merge to gh-pages branch if there is no more discussions ---
[GitHub] zeppelin issue #2660: Change Spell url to snapshot-8
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2660 LGTM ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2394 Yeah second option is better for me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Thanks for the great work @soralee! And also thanks for detailed review
@1ambda.
Tested and looks nice!
I really like the most of parts. Some minor suggestion is
Technologies
- how about using same border color with "Deployment" box `#999` instead
of `#4881B3`?
https://user-images.githubusercontent.com/10060731/26859880-7f3df818-4aef-11e7-9364-a0274c2642bf.png;>
Deployment
- how about putting "LEARN MORE" buttons in each deployment section box
in the middle instead of right side?
- and also we can remove the single & multi user font awesome icons since
the text ("single" and "multi") itself already explain what "single-user" and
"multi-user" are meaning for.
How about this? It's just my opinion. Please have a look and feel free to
share your thought :)
https://user-images.githubusercontent.com/10060731/26859800-0d9d5cf8-4aef-11e7-804c-3f93a1ae035d.png;>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2381 Thank you for great work! Especially big +1 for adding this section https://cloud.githubusercontent.com/assets/10060731/26764287/e5b90aa2-4918-11e7-908c-1fdfd4870037.png;> I've always thought we need this kind of guide in first page of website. I quickly look through the change and here are some thought in my head. ### 1. Navbar - before https://cloud.githubusercontent.com/assets/10060731/26764234/1be270e2-4918-11e7-976c-ed07289479b2.png;> - after https://cloud.githubusercontent.com/assets/10060731/26764235/1ec0bd82-4918-11e7-981c-4ba4f3c119b8.png;> Adding "Quick Start" menu and switching menu order are really good idea I think. But not sure about making the font size bigger and adding too much shadow. So in my opinion, just below work will be enough. - Adding "Quick Start" menu - Switching menu order ### 2. Main I also agree this part doesn't have really good looking. https://cloud.githubusercontent.com/assets/10060731/26764349/4a00b96e-491a-11e7-9f06-6841bff11b50.png;> But not sure the new change is definitely better than current one. https://cloud.githubusercontent.com/assets/10060731/26764350/55ed2a46-491a-11e7-8f14-12cd3ff2385b.png;> I think it'll be better to update other parts expect "Technologies" & "Deployments" that you newly added in another PR step by step. That would be easier to get review/ consensus from other ppl and also easier to make it merged. I mean we can separate the work like below. ``` 1. update navbar 2. update main section 3. adding "Technologies" & "Deployment" section 4. minor styling ``` What do you think? Thanks again for staring this work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2371 Cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2346 `gh-pages` doesn't have CI check. So the red light is irrelevant with this change. Ready to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2346: [gh-pages] Hide pagination btn if there is only...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2346 [gh-pages] Hide pagination btn if there is only 1 page ### What is this PR for? Same work with #2345 but for `gh-pages` ### What type of PR is it? Improvement ### What is the Jira issue? N/A ### Screenshots (if appropriate) - Before https://cloud.githubusercontent.com/assets/10060731/26078695/55cba402-398e-11e7-9f12-f9748480db38.png;> - After https://cloud.githubusercontent.com/assets/10060731/26078697/58981a6c-398e-11e7-9921-22b9219f0f79.png;> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin hide-only-one-pagination-btn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2346 commit a98ed668a2c86a603c0de32e9fe2ec2c7e38e6da Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-05-15T20:46:36Z gh-pages: Hide pagination btn if there is only 1 page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2345: [MINOR] Hide pagination button if there is only 1 page...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2345 @1ambda If you don't mind, could you help me to review this? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2345: [MINOR] Hide pagination button if there is only...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2345 [MINOR] Hide pagination button if there is only 1 page in Helium menu ### What is this PR for? It'll be better to hide the pagination button if there is only one page. ([`only-of-type` CSS type selector](https://www.w3schools.com/cssref/sel_only-of-type.asp) can be used for this.) Please see the attached screenshot img. ### What type of PR is it? Improvement ### What is the Jira issue? N/A ### How should this be tested? ### Screenshots (if appropriate) - Before  - After https://cloud.githubusercontent.com/assets/10060731/26078167/a28f36fc-398c-11e7-8151-46ca79161010.png;> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin hide/only-one-pagination-btn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2345 commit 452f01dad0c3c316e558b8dafd7325eb0a322cc1 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-05-15T20:35:05Z Hide pagination btn if there is only 1 page --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2340: [ZEPPELIN-2426] Improve graph setting DOMs
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2340 Tested and it looks good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 Tested and it looks great! +1 for this change  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@1ambda Yeah right right I misapprehended actually. It was my bad.
Btw I wanted to test this locally but failed when I run `yarn install` and
got this below 404 error.
```
[{
"code": "EHTTP",
"data": {
"endpoint": {
"name": "headroom.js",
"source": "https://unpkg.com/headroom.js/bower.zip;,
"target": "*"
},
"resolver": {
"name": "headroom.js",
"source": "https://unpkg.com/headroom.js/bower.zip;,
"target": "*"
}
},
"id": "EHTTP",
"level": "error",
"message": "Status code of 404",
"stacktrace": "Error: Status code of 404\nat createError
(/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/util/createError.js:4:15)\n
at Request.
(/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/util/download.js:91:36)\n
at emitOne (events.js:101:20)\nat Request.emit (events.js:188:7)\n
at Request.onRequestResponse
(/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/node_modules/request/request.js:951:10)\n
at emitOne (events.js:96:13)\nat ClientRequest.emit (events.js:188:7)\n
at HTTPParser.parserOnIncomingClient [as onIncoming]
(_http_client.js:474:21)\nat HTTPParser.parserOnHeadersComplete
(_http_common.js:99:23)\nat TLSSocket.socketOnData (_http_client.js:363:20)"
}]
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about
this command.
```
Could you point me how can I install `headroom.js`? Did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 Cool! Then to reach to the menu, some users who have lots of paragraphs have to spend much time to scroll up. Then how about sticky "go to top" like button at bottom-right side instead? I mean in another PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda CI checks has been failed sadly. Can you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 Oh.. Will merge into master right after CI turns into green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2255: [HOTFIX] Invalid method signature in GroovyInterpreter
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2255 Merge into master as a hotfix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2244: [MINOR] fix typo from 'interpeter' to 'interpreter'
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2244 Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Yeah makes sense. Looks GOOD to me ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Great work! Quickly looked through the most of file changes and it looks good. Zeppelin web is getting bigger, everyone will feel the necessity of this kind of lint rule. btw I saw the below some warning msgs when I ran `npm run lint:once`, ``` $ npm run lint:once > zeppelin-web@0.0.0 lint:once /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web > eslint src /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/notebook/notebook.controller.js 52:34 warning Unnecessary escape character: \/ no-useless-escape 52:44 warning Unnecessary escape character: \/ no-useless-escape 52:59 warning Unnecessary escape character: \/ no-useless-escape 52:69 warning Unnecessary escape character: \/ no-useless-escape /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js 131:37 warning Unexpected mix of '&&' and '||' no-mixed-operators 131:54 warning Unexpected mix of '&&' and '||' no-mixed-operators /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.js 38:40 warning Unnecessary escape character: \/ no-useless-escape 38:45 warning Unnecessary escape character: \/ no-useless-escape â 8 problems (0 errors, 8 warnings) ``` Is there any particular reason for not fixing them? If you just worried about the side effect, I think it's okay with as is :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 @tae-jun Looks GOOD to merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 @tae-jun Thanks for the improvement. >You can add any dependencies in package.json, but you must include two dependencies: zeppelin-vis and zeppelin-tabledata. Yeah I think you're right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2232: [ZEPPELIN-2373] Remove -Pyarn build profile
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2232 @felixcheung Thanks! Merge into master if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2124: [ZEPPELIN-2154] Support zeppelin.server.port in dev mo...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2124 @soralee I just merged this PR into branch-0.7 but it's not closed automatically. Could you close it in your side? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ @wary Thanks! Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2232: [ZEPPELIN-2373] Remove -Pyarn build profile
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2232 CI is green now. @jongyoul Could you help me to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2232: [ZEPPELIN-2373] Remove -Pyarn build profile
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2232
[ZEPPELIN-2373] Remove -Pyarn build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Pyarn`
build profile to enable Yarn for embedded local Spark. This PR is to remove
`-Pyarn` and make Yarn related libraries can be automatically downloaded
without the profile during build time.
### What type of PR is it?
just removed Yarn build profile in `spark-dependencies/pom.xml`
### What is the Jira issue?
[ZEPPELIN-2373](https://issues.apache.org/jira/browse/ZEPPELIN-2373)
### How should this be tested?
1. apply this patch and build Zeppelin with below command
```
mvn clean package -DskipTests -pl 'zeppelin-server, spark-dependencies,
spark' --am
```
2. check `spark-yarn_${scala.binary.version}.jar` is downloaded(or
included) during build time
```
[INFO] Including org.apache.spark:spark-yarn_2.10:jar:2.1.0 in the shaded
jar.
```
In current master, the above line won't be shown if you don't use `-Pyarn`
build profile. But with this patch, it will be shown without the profile.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
ZEPPELIN-2373/includeYarnByDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2232
commit 59eb2b505ff1ca70ff31cd3aaf1a7b3b5998e09a
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-07T10:44:26Z
Remove -Pyarn build profile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2220: [Minor] Fix wrong Python lib path in Matplotlib tutori...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2220 Merge into master and branch-0.7 if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2212 @1ambda Thanks. CI failure is irrelevant with gh-pages change. Merge into gh-pages if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 @1ambda I just merged this into branch-0.7 but it's not closed automatically. Could you close in your side? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2225 @1ambda Yeah I also knew it when I was adding the pagination to Helium menu for both zeppelin.apache.org and Zeppelin :) Tested again and it works well. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2225 @1ambda If we update angular-bootstrap version, the pagination in Helium page won't work since they change the pagination lib name (`pagination` ->`ul uib-pagination`) So you might need to change [this part](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/helium/helium.html#L189) from ``` ``` to ``` ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 LGTM Merge into branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2215: [ZEPPELIN-2341] Remove -Psparkr build profile
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2215 @Leemoonsoo Thanks! Merge into master if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 CI failure is irrelevant with this change. Looks good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Looks great! So sorry I forgot to mention that there is another place to be updated regarding [this change](https://github.com/apache/zeppelin/pull/2098#issuecomment-291390619). https://cloud.githubusercontent.com/assets/10060731/24690393/7e4612ec-1a07-11e7-8d70-34554826a27a.png; width="600px"> Could you update [`docs/index.html`](https://github.com/apache/zeppelin/blob/master/docs/index.md#more) as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ Thanks! Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ @wary Thanks for your contribution. Could you add `zeppelin.jdbc.auth.kerberos.proxy.enable` info to [this table](https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#more-properties) as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2220: [Minor] Fix wrong Python lib path in Matplotlib...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2220 [Minor] Fix wrong Python lib path in Matplotlib tutorial note ### What is this PR for? There is a wrong information about Zeppelinâs matplotlib backend files. It actually located under `ZEPPELIN_HOME/interpreter/lib/python/*` but tutorial note says it as `ZEPPELIN_HOME/lib/python/*`. So I corrected it. ### What type of PR is it? kind a typo fix ### What is the Jira issue? N/A ### Screenshots (if appropriate) - Before  - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin fix/wrongPythonLibPathInTutorialNote Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2220 commit b43dc44ddd3e61e1291997fb50d38cdf50908396 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-04-04T06:47:21Z Fix wrong Python lib path in tutorial note --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2212 @1ambda Can you help review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2210 yeah I got same error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2213 Merge into master if there are no more comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' next to ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2211 @felixcheung @Leemoonsoo Thanks. Merge into master if there are no further comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2213 @jongyoul Yup, will open a PR for that soon. @Leemoonsoo Thanks. Updated again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2213
[ZEPPELIN-2298] Remove -Ppyspark build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Ppyspark`
to use `%pyspark` with embedded local Spark. But it's quite inconvenient to
write this build profile every time we build i think. So I removed `-Ppyspark`
and make pyspark related libraries automatically downloaded when we build
Zeppelin.
### What type of PR is it?
Improvement
### Todos
* [x] - remove the rest of `-Ppyspark` build profile in
`dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md`
after getting feedback
### What is the Jira issue?
[ZEPPELIN-2298](https://issues.apache.org/jira/browse/ZEPPELIN-2298)
### How should this be tested?
1. Apply this patch
2. Build source with below command
```
mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine,
zeppelin-server, zeppelin-display, spark, spark-dependencies'
```
Aftr this step, there will be `pyspark` dir under
`ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and
`zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Ppyspark` build
profile.
4. Restart Zeppelin. To make sure, run any python code e.g.
```
%pyspark
print("Hello "+z.input("name"))
```
It should be run successfully without any error
### Screenshots (if appropriate)
tl;dr Without `-Ppyspark` profile
- Before
https://cloud.githubusercontent.com/assets/10060731/24584778/0e8ec6b0-17b4-11e7-9f0d-f2599fd7bd63.png;>
- After
https://cloud.githubusercontent.com/assets/10060731/24584779/10b7ed68-17b4-11e7-90d4-aa95eb9bba2d.png;>
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
I want to include `SparkR` by default(= remove `-PsparkR` build profile)
like this as a next step. I want to ask how Zeppelin community think about this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
ZEPPELIN-2298/includePysparkByDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2213
commit 30aac819644b8a3109e9f39ab12f4778f2875614
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-02T05:10:59Z
Remove -Ppyspark build flag
commit fa4fb3679681eefad8c836aaf08063caf315160b
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-03T02:29:27Z
Remove the rest of -Ppyspark
commit ce431584dc77408104b01d0fb46db324021298f4
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-03T02:30:21Z
Change py4j.version -> spark.py4j.version
commit cee1e874973f625211c6da5f4c643bca74ba48fb
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-03T02:30:34Z
Change py4j.version -> python.py4j.version
commit 458ac02a23065b1e76604a790a97e421689c4ca4
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-03T03:59:22Z
Remove the rest of -Ppyspark in blind side of Zeppelin :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 Thanks. I'm merging into master now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2213
[ZEPPELIN-2298] Remove -Ppyspark build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Ppyspark`
to use `%pyspark` with embedded local Spark. But it's quite inconvenient to
write this build profile every time we build i think. So I removed `-Ppyspark`
and make pyspark related libraries automatically downloaded when we build
Zeppelin.
### What type of PR is it?
Improvement
### Todos
* [ ] - remove the rest of `-Ppyspark` build profile in
`dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md`
after getting feedback
### What is the Jira issue?
[ZEPPELIN-2298](https://issues.apache.org/jira/browse/ZEPPELIN-2298)
### How should this be tested?
1. Apply this patch
2. Build source with below command
```
mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine,
zeppelin-server, zeppelin-display, spark, spark-dependencies'
```
Aftr this step, there will be `pyspark` dir under
`ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and
`zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Ppyspark` build
profile.
4. Restart Zeppelin. To make sure, run any python code e.g.
```
%pyspark
print("Hello "+z.input("name"))
```
It should be run successfully without any error
### Screenshots (if appropriate)
tl;dr Without `-Ppyspark` profile
- Before
https://cloud.githubusercontent.com/assets/10060731/24584778/0e8ec6b0-17b4-11e7-9f0d-f2599fd7bd63.png;>
- After
https://cloud.githubusercontent.com/assets/10060731/24584779/10b7ed68-17b4-11e7-90d4-aa95eb9bba2d.png;>
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
I want to include `SparkR` by default(= remove `-PsparkR` build profile)
like this as a next step. I want to ask how Zeppelin community think about this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
ZEPPELIN-2298/includePysparkByDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2213
commit 30aac819644b8a3109e9f39ab12f4778f2875614
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-02T05:10:59Z
Remove -Ppyspark build flag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 CI is green now. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of
interpreter type pkg
### What is this PR for?
Currently "see more" is placed next to the older version of INTERPRETER
type of Helium pkg. But other type of Helium pkg(e.g. SPELL or VISUALIZATION)
has "enable". And if we click "enable", can see the dialog for asking if you
want to enable the package or not. So I changed INTERPRETER type pkg's "see
more" to "enable" for the consistency in this patch.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2339](https://issues.apache.org/jira/browse/ZEPPELIN-2339)
### How should this be tested?
1. Run Zeppelin web under `zeppelin-web` with
```
$ yarn run dev
```
2. Go to Helium menu and click any interpreter type of package
3. Click `versions`
4. there should be "enable" not "see more"
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2211
commit 64597eca559b0a2a7b470e2525ea1311e53c47d5
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-01T09:47:42Z
Change 'see more' -> 'enable' next to the older ver of intp type pkg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2212: [gh-pages] set max size for pagination btn & hi...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2212 [gh-pages] set max size for pagination btn & hide arrows when current page is first/last ### What is this PR for? As the number of Helium packages is increasing, more pagination buttons will be generated accordingly. If we don't set `maxSize`, pagination layout will be broken when screen size is small. So I set max size to 5 for it. And also hide unnecessary arrows when current page is on first & last. (related feedback is https://github.com/apache/zeppelin/pull/2174#issuecomment-289776096 suggested by @1ambda) ### What type of PR is it? Improvement | gh-pages ### What is the Jira issue? N/A ### How should this be tested? Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and click pagination button ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin improve/pagination Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2212 commit 599e06369cd648def8c7e60ec839a2e7d630432a Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-04-01T13:20:55Z Set maxSize for pagination commit 3c7cba30d7c0afc5f45a6ebcbce72b4658bdb442 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-04-01T13:21:53Z Hide unnecessary first & last button --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of
interpreter type pkg
### What is this PR for?
Currently "see more" is placed next to the older version of INTERPRETER
type of Helium pkg. But other type of Helium pkg(e.g. SPELL or VISUALIZATION)
has "enable". And if we click "enable", can see the dialog for asking if you
want to enable the package or not. So I changed INTERPRETER type pkg's "see
more" to "enable" for the consistency in this patch.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2339](https://issues.apache.org/jira/browse/ZEPPELIN-2339)
### How should this be tested?
1. Run Zeppelin web under `zeppelin-web` with
```
$ yarn run dev
```
2. Go to Helium menu and click any interpreter type of package
3. Click `versions`
4. there should be "enable" not "see more"
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2211
commit 64597eca559b0a2a7b470e2525ea1311e53c47d5
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date: 2017-04-01T09:47:42Z
Change 'see more' -> 'enable' next to the older ver of intp type pkg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2195: [ZEPPELIN-2319] new methods for ZeppelinContext
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2195 @meniluca Great initiative! Thanks for detailed explanation and it makes sense to me as well. That would be helpful to any other reviewers. But before you go further, need to setup travis account for Zeppelin first. - Please take a look https://zeppelin.apache.org/contribution/contributions.html#continuous-integration - The repository name must be Zeppelin (not incubator-zeppelin, ...) - It's not mandatory to pass all tests to be reviewed. But some reviewers might select passed PRs first Trigger travis CI by pushing new commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Looks good to me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2208: [HOTFIX][gh-pages] Fix Maven web link for INTERPRETER ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2208 @felixcheung Thanks! CI failure is irrelevant with `gh-pages` change. Merge into gh-pages as a hotfix if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 @1ambda Yup thanks for letting me know --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts Great! Tested this patch and it works well as you described. - Before  - After  If @astroshim feedback can also be addressed, looks GOOD to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2177 Sure. I'll test it and get back you soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 I already merged into `branch-0.7` but not closed yet. So closing this manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2208: [HOTFIX][gh-pages] Fix Maven web link for INTER...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2208 [HOTFIX][gh-pages] Fix Maven web link for INTERPRETER type pkg ### What is this PR for? In current https://zeppelin.apache.org/helium_packages.html page, `INTERPRETER` type package web link is wrong. It should point Maven web link not npm. So I fixed it. ### What type of PR is it? Hot Fix ### What is the Jira issue? N/A ### How should this be tested? Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and click any `INTERPRETER` type of package name. ### Screenshots (if appropriate) - Before  - After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin fix/mavenLink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2208 commit 9fdb50b5506b3a9b90690ed08a5e17b25b0490b8 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-03-31T02:37:11Z Fix maven serach link for INTERPRETER type pkg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2202: [Minor][ZEPPELIN-2328] Separate Helium related docs fr...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2202 Thanks @1ambda for the confirmation! Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Appreciate for such detailed explanation! Regarding `no-group`, I can assume the other ppl can be confused like me. So it'll be better to add some description for that to the documentation. (you already wrote all needed contents in your comments :D) FYI I suggested to separate Helium related docs page from "Contribute" section in the dropdown menu and create new section "Helium Framework" in #2202(Helium is worth to have its own kk). So your new docs page "Writing Zeppelin Visualization: Transformation(or another name?)" can be put under this section. And maybe more self-descriptive name would be better instead of just `Transformation`(hard to recognize at a glance what kind of transformation is). Something like `Writing Zeppelin Visualization: Advanced Chart Configuration`.. But I don't wanna hang this PR because of docs. Surely you can handle it in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks! Will merge into master if there are no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Tested and it works well now. Thanks for fixing it. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2151 @Remilito Tested and it works as expected. Regarding docs, how about adding new section for this feature instead of `subsequent parameter (optional)` as a subsection under "Run a paragraph synchronously" & "Run a paragraph asynchronously" ? I saw many ppl have wanted this feature, so it'll be better to create new section for it. Below each "Run a paragraph synchronously" & "Run a paragraph asynchronously" section would be good place i think. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Yeah I saw this as well. Let me take a look :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Thanks for addressing my comments! I left some minor comments again about "author name" in the source code and removing unnecessary `log.info`. Except these two things, LGTM ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 @felixcheung Thanks! Merge into branch-0.7 if there are no further comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda I updated the pagination as you said and this is the current status. Will be appreciated if you can take a look again.  @felixcheung I set the maximum pagination size as "5" and tested in the smallest mobile device size that Chrome dev tool provides (`320 x 568`) like below.  The pagination is not broken when the screen is small. But `enable` btn and package type selection btn are broken instead ð Let me handle them in another PR. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 @felixcheung Is this good to go now? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2202: [Minor][ZEPPELIN-2328] Separate Helium related ...
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2202 [Minor][ZEPPELIN-2328] Separate Helium related docs from 'Contribution' section ### What is this PR for? Actually writing "Visualization", "Spell" or "Application" type of Helium package is not a direct contribution to Zeppelin. So i created "Helium Framework" section and moved "Writing Zeppelin Visualization", "Writing Zeppelin Spell", and "Writing Zeppelin Application" under "Helium Framework" from "Contribution". ### What type of PR is it? Documentation ### What is the Jira issue? [ZEPPELIN-2328](https://issues.apache.org/jira/browse/ZEPPELIN-2328) ### Screenshots (if appropriate) - Before https://cloud.githubusercontent.com/assets/10060731/2171/743d8c7e-14a0-11e7-8a10-ec02596d2a19.png; width="300px"> - After https://cloud.githubusercontent.com/assets/10060731/2245/aecfe274-14a0-11e7-8488-99086b1db415.png; width="300px"> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2328 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2202 commit 6185fcd45c47ade3f0f36fd7918a56c80bd774eb Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-03-29T07:50:32Z Separate Helium related docs from 'Contribution' section --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 Hi @markito Thanks for your contribution and taking care of Geode interpreter. - Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin. - Please take a look https://zeppelin.apache.org/contribution/contributions.html#continuous-integration - The repository name must be Zeppelin (not incubator-zeppelin, ...) - It's not mandatory to pass all tests to be reviewed. But some reviewers might select passed PRs first Trigger travis CI by pushing new commits or amend your last commit (git commit --amend and git push your-remote HEAD --force) after setup your travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda I feel so sorry for my late response. Tested this patch \w your Helium package: zeppelin-ultimate-line-chart. Here are some thought and question(?) in my head. 1. "Save" & "Delete" button on top of the setting table - It'll be better there are some feedback after clicking these buttons like "Changes are successfully saved" or "Changes will be discarded". How about small `ngtoast` or bootstrap dialog?  Probably ppl can click the trash can button by mistake. Then they'll lose the setting. To prevent this, we can provide some alert for this. - I think we can hide "Save" & "Delete" button when the setting table is folded. A good example is in our interpreter setting page. As you know, users only can save/remove the setting when they click "edit" button. So how about activating those disket & trash btns only when the setting table is expanded? 2. no-group field - What is difference between `no-group` and just letting `group` field as blank? Is there special reason for creating `no-group` field? (It's question actually :D) - `xAxis` and `yAxis` field size are different in `no-group` section. https://cloud.githubusercontent.com/assets/10060731/24440240/0ae00fc0-148e-11e7-999b-554af8d39f72.png;> And again, this is really cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2200: [HOTFIX] Remove unintended characters from r tutorial
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2200 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks for the detailed explanation.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda No worries :) Then how about 1 page ? I mean if there is only 1 page, we can hide `<<` & `>>`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 @1ambda I couldn't auto merge this PR into branch-0.7 since there are some conflicts. If you don't mind, can you create separate PR for branch-0.7? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 Thanks. Merging into master and branch-0.7 now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Let me check again for that part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda It's wired. This is what I can see when I build my branch.  There are two `ng-repeat` like below. And [the pagination DOM](https://github.com/AhyoungRyu/zeppelin/blob/7150e7cb596c2bbe9148ea2a09009c6fb273a20e/zeppelin-web/src/app/helium/helium.html#L195) is placed inside of the first `ng-repeat`(for pkg type checking loop) and outside of the second one(each type of package listing). https://cloud.githubusercontent.com/assets/10060731/24363549/26531e08-134b-11e7-8f05-4b71bf1b277b.png;> FYI, the data is like this. https://cloud.githubusercontent.com/assets/10060731/24363853/ff811018-134b-11e7-84a3-867ec956539e.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Thanks! Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2189 [branch-0.7] Minor styling for Helium menu ### What is this PR for? Since Helium online registry is available in develop version(0.8.0-SNAPSHOT) for now, people only can use their local registry(e.g. `ZEPPELIN_HOME/helium`) in 0.7.X. So they will see below empty screen when open Helium menu at the first time. https://cloud.githubusercontent.com/assets/10060731/24322858/4f9c21c6-11af-11e7-93fc-8975dbfcaddf.png;> It's hard to recognize what Helium is and not that attractive actually. So I added - initial sentence "Currently there is no available package to be listed" when there is no package under local registry - question icon to header -> link to https://zeppelin.apache.org/helium_packages.html to give some hint(?) about Helium :) And also fixed `VISUALIZATION` button group as I did in #2185. Please see below screenshot images for the details. ### What type of PR is it? Improvement ### What is the Jira issue? N/A ### How should this be tested? 1. Run ``` $ yarn run dev ``` under `zeppelin-web/` 2. Go to Helium menu ### Screenshots (if appropriate) - when the package size is 0 & question mark icon (link to  - fixed viz type icon ordering button group - before https://cloud.githubusercontent.com/assets/10060731/24322931/6dd2e728-11b0-11e7-9b7b-111b751c1dfb.png;> - after (round border in rightmost icon) https://cloud.githubusercontent.com/assets/10060731/24322932/6f8c3538-11b0-11e7-8198-a221376f9f44.png;> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin add/initialMsgToHeliumMenu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2189.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2189 commit 39a0775a9e85ad1d4375286d9795dc6745584bb6 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-03-25T09:50:44Z Minor styling for Heliu menu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee And as you can see in the above gif image that i took, the tooltip in scatter chart is shown like "(age, value)". But before #2042 it looks like below.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Right it should be passed without refreshing. So I removed that part and added `waitForParagraph(1, "FINISHED");` before every selections for the stability. Now CI is green now. Will be appreciated if you can check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2174 [ZEPELIN-2209] Add pagination to Helium menu ### What is this PR for? Like I did in #2126, added pagination to Helium menu in Zeppelin. 10 pkgs will be shown per 1 page. ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209) ### How should this be tested? 1. Replace temporarily [ZeppelinConfiguration.java#L46](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L46) with [this url](https://raw.githubusercontent.com/AhyoungRyu/spark-notebook-example/master/helium.json) 2. Build \w below command and restart Zeppelin server ``` $ mvn clean package -DskipTests -pl 'zeppelin-zengine, zeppelin-server, zeppelin-interpreter' ``` 3. Start web dev server under `ZEPPELIN_HOME/zeppelin-web` and browse `localhost:9000` ``` $ yarn run dev ``` 4. Go to Helium menu -> Click `INTERPRETER` btn (Currently the other types of pkg are registered in online registry less than 10. That's why I request to change online registry URI in step 1) 5. Check the pagination works well or not ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/AhyoungRyu/zeppelin add/paginationToHeliumMenu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2174 commit 050b1dc8d32b2248f285c14e80d23061d2ae5419 Author: RyuAhyoung <ahyoungryu@macbook-pro-5.local> Date: 2017-03-22T04:35:41Z Add pagination to Helium menu commit e0bb52a53b0012cab9c866fc72e7aec7a6506cb4 Author: RyuAhyoung <ahyoungryu@macbook-pro-5.local> Date: 2017-03-23T06:50:57Z Fix pkg orderBy published commit af3f797919cc4b8383dd9bd55dce2f3ce4585d6e Author: RyuAhyoung <ahyoungryu@macbook-pro-5.local> Date: 2017-03-25T04:03:33Z Resolve confilct manually --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee Thanks for the explanation. I tested this branch to make sure it works well or not, but when I select "Line chart" below error msg shows up. ``` vendor.bcb986b75e1664c0.js:64 Error: attribute transform: Trailing garbage, "translate(813,NaN)". ```  I checked multiple times, but I could see this every time. Could you check this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2180 CI failure is not related with this change since it's based on `gh-pages` branch. Merge into `gh-pages` if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1976 @del680202 Thanks for your time and effort to test it out. >But I seem when I edit interpreter config then the zombie process will be occurred I checked it with current `branch-0.7` and I could see the interpreter process was killed. Actually just tested in basic case (anonymous / global mode) with Spark interpreter. 1. Run some paragraphs \w Spark intp 2. Edit `zeppelin.spark.maxResult` from 1000 to 20 in the interpreter setting page -> save 3. The remote interpreter process was killed Was your case different with mine? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
