[GitHub] zeppelin issue #2586: [ZEPPELIN-2930] Releasing session of JDBC interpreter ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2586 @felixcheung yeah.. it's similar but the differentiation is that the previous one couldn't solve the releasing connection issue perfectly. ---
[GitHub] zeppelin issue #2586: [ZEPPELIN-2930] Releasing session of JDBC interpreter ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2586 @felixcheung This is not a subset of the other PR. ---
[GitHub] zeppelin pull request #2586: [ZEPPELIN-2930] Releasing session of JDBC inter...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2586 [ZEPPELIN-2930] Releasing session of JDBC interpreter close(). ### What is this PR for? This PR fixes that the session release issue of close() of JDBC interpreter. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2930 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2930 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2586.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2586 commit 08224c3741ff1ee0971f08b969606a09cbf0ae6d Author: Shim <yooji...@gmail.com> Date: 2017-09-13T13:07:28Z fixed release session. ---
[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2582 ---
[GitHub] zeppelin issue #2582: fixed jdbc connection issue.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2582 CI fails seems not related to this PR ---
[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2582 fixed jdbc connection issue. ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following ![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png) new JDBC connection is made like following. ``` $ netstat -an |grep EST |grep 3306 |wc -l 1 $ netstat -an |grep EST |grep 3306 |wc -l 2 $ netstat -an |grep EST |grep 3306 |wc -l 3 ``` ### What type of PR is it? Bug Fix ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin feat/fixJdbcIssue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2582.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2582 commit 9b99d21e9d2e637c34351ff3fdd54dc8748fe962 Author: Shim <yooji...@gmail.com> Date: 2017-09-12T05:22:59Z fixed jdbc connection issue. ---
[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2581 ---
[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2581 Fix/jdbc connection release 0.7 ### What is this PR for? This PR fixes JDBC connection release problem. for example whenever i run not executable command like following ![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png) new JDBC connection is made like following. ``` $ netstat -an |grep EST |grep 3306 |wc -l 1 $ netstat -an |grep EST |grep 3306 |wc -l 2 $ netstat -an |grep EST |grep 3306 |wc -l 3 ``` ### What type of PR is it? Bug Fix ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin fix/jdbcConnectionRelease-0.7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2581.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2581 commit b62e2e01bbdca87ab68a68ffae5e228217da5679 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-04-04T06:33:39Z [ZEPPELIN-2341] Remove -Psparkr build profile ### What is this PR for? Currently users who build Zeppelin from source need to include `-Psparkr` to use `%r` with embedded local Spark. But it's quite inconvenient to write this build profile every time we build i think. So I removed `-Psparkr` and make `r` related libraries automatically downloaded when we build Zeppelin like I did #2213 ### What type of PR is it? Improvement ### Todos * [x] - remove the rest of `-Psparkr` build profile in `dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md` after #2213 merged ### What is the Jira issue? [ZEPPELIN-2341](https://issues.apache.org/jira/browse/ZEPPELIN-2341) ### How should this be tested? 1. Apply this patch 2. Build source with below command ``` mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine, zeppelin-server, zeppelin-display, spark, spark-dependencies' ``` Aftr this step, there will be `R` dir under `ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and `zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Psparkr` build profile. 4. Restart Zeppelin. To make sure, run R tutorial note under `Zeppelin Tutorial` folder It should be run successfully without any error ### Screenshots (if appropriate) If we build without `-Psparkr` - before : R related properties are not activated by default in Spark interpreter ![screen shot 2017-04-03 at 4 31 49 pm](https://cloud.githubusercontent.com/assets/10060731/24599560/b952e414-188b-11e7-80db-ac649c869c02.png) - after ![after](https://cloud.githubusercontent.com/assets/10060731/24599567/bc513a94-188b-11e7-9e93-7abca3428279.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdu...@hanmail.net> Author: Ahyoung Ryu <ahyoung...@apache.org> Closes #2215 from AhyoungRyu/ZEPPELIN-2341/includeSparkRByDefault and squashes the following commits: 8db18cc [AhyoungRyu] Remove the rest of '-Psparkr' in docs & sh files f891fd4 [Ahyoung Ryu] Merge branch 'master' into ZEPPELIN-2341/includeSparkRByDefault 445be3e [AhyoungRyu] Add SPARKR env to check each test case need to download r dep or not 67af02a [AhyoungRyu] Remove -PsparkR in travis file a00466c [AhyoungRyu] Remove sparkr build profile in pom files commit 32e86d02d8ea8fdc66a2c1a39bf5cc2317922556 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2017-04-04T06:47:21Z [Minor] Fix wrong Python lib path in Matplotlib tutorial note ### What is this PR for? There is a wrong information about Zeppelinâs matplotlib backend files. It actually located under `ZEPPELIN_HOME/interpreter/lib/python/*` but tutorial note says it as `ZEPPELIN_HOME/lib/python/*`. So I corrected it. ### What type of PR is it? kind a typo fix ### What is the Jira issue? N/A ### Screenshots (if appropriate) - Before ![screen shot 2017-04-04 at 3 50 06 pm](https://cloud.githubusercontent.com/assets/10060731/24644505/e573d3a0-194e-11e7-826f-4022bc5e1572.png) - After ![screen shot 2017-04-04 at 3 50 56 pm](https://cloud.githubusercontent.com/assets/10060731/24644507/e6ae25c2-194e-11e7-91d7-f42b327d820e.png) ### Questions: *
[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2576 [hotfix] JDBC connection does not release when got exception. ### What is this PR for? This PR fixes JDBC connection release problem. for example when i run not executable command like following. ![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png) new JDBC connection is made like following. ``` $ netstat -an |grep EST |grep 3306 |wc -l 1 $ netstat -an |grep EST |grep 3306 |wc -l 2 $ netstat -an |grep EST |grep 3306 |wc -l 3 ``` ### What type of PR is it? Bug Fix ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin fix/jdbcConnectionRelease Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2576.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2576 commit 88d3edb980e508e72d4cdde8e75c1005efcadda8 Author: Shim <yooji...@gmail.com> Date: 2017-09-08T09:55:24Z fix jdbc connection relase issue. commit 3ae59e9f0285d011f682393bf359cb0a6f89 Author: Shim <yooji...@gmail.com> Date: 2017-09-08T10:20:25Z fixed exception codes ---
[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2428 LGTM~ I think this PR can be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @cloverhearts Did you test this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @tinkoff-dwh Sorry it was my problem. Tested and working good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 I think this feature is really cool. BTW I got following exception whenever i try to run sql completion. ``` ==> logs/zeppelin-interpreter-jdbc-jdbc.log <== ERROR [2017-05-25 01:29:57,441] ({pool-1-thread-5} TThreadPoolServer.java[run]:296) - Error occurred during processing of message. java.lang.NullPointerException at org.apache.zeppelin.jdbc.SqlCompleter.completeKeyword(SqlCompleter.java:407) at org.apache.zeppelin.jdbc.SqlCompleter.completeName(SqlCompleter.java:469) at org.apache.zeppelin.jdbc.SqlCompleter.complete(SqlCompleter.java:105) at org.apache.zeppelin.jdbc.JDBCInterpreter.completion(JDBCInterpreter.java:844) at org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.completion(RemoteInterpreterServer.java:573) at org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1940) at org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1925) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) ==> logs/zeppelin-.local.log <== ERROR [2017-05-25 01:29:57,443] ({qtp517210187-14} NotebookServer.java[onMessage]:383) - Can't handle message org.apache.zeppelin.interpreter.InterpreterException: org.apache.thrift.transport.TTransportException at org.apache.zeppelin.interpreter.remote.RemoteInterpreter.completion(RemoteInterpreter.java:493) at org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136) at org.apache.zeppelin.notebook.Paragraph.completion(Paragraph.java:304) at org.apache.zeppelin.notebook.Note.completion(Note.java:664) at org.apache.zeppelin.socket.NotebookServer.completion(NotebookServer.java:1345) at org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:330) at org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128) at org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65) at org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122) at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161) at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309) at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214) at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220) at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632) at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480) at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.thrift.transport.TTransportException at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86) at org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429) at org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318) at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69) at org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_completion(RemoteInterpreterServ
[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 @Remilito Could you make this PR based on branch-0.7 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 @Remilito Could you make this PR based on `branch-0.7` branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2192 LGTM.. Sorry for late catch.. Merge if there is no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts It looks also great! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 Looks great. one thing i worrying about is that the `_zc` can be possibly used by user easily? how about assigning more unique key word like `__zc__` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2106: [WIP] Rewrite PythonInterpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @Leemoonsoo fixed the issues you commented and added PandasSql. and also added `conda`, `pandasql` interpreter test on PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2106: [WIP] Rewrite PythonInterpreter.
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2106: [WIP] Rewrite PythonInterpreter.
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/2106 [WIP] Rewrite PythonInterpreter. ### What is this PR for? I've been testing the python interpreter and I found at least 4 major issues in the current python interpreter. 1. not working streaming output. - https://issues.apache.org/jira/browse/ZEPPELIN-2225 2. printed "..." when there is indent in the python code. - https://issues.apache.org/jira/browse/ZEPPELIN-1929 3. very slow output of matplotlib - https://issues.apache.org/jira/browse/ZEPPELIN-1894 - https://issues.apache.org/jira/browse/ZEPPELIN-1360 4. Unexpected output of matplotlib. - https://issues.apache.org/jira/browse/ZEPPELIN-2107 so I changed python interpreter to use py4j based on pyspark interpreter and would be fixed above issues. and I am going to recreate conda, docker for python interpreter ASAP. ### What type of PR is it? Bug Fix | Hot Fix | Refactoring ### How should this be tested? 1. not working streaming output. ``` import time for x in range(0, 5): print x time.sleep(1) ``` 2. printed "..." when there is indent in the python code. ``` def fn(): print("hi") fn() ``` 3. very slow output of matplotlib. ``` import matplotlib import sys import matplotlib.pyplot as plt plt.plot([1,2,3]) ``` 4. Unexpected output of matplotlib. ``` import matplotlib.pyplot as plt import matplotlib as mpl # Make a figure and axes with dimensions as desired. fig = plt.figure(figsize=(8, 3)) ax1 = fig.add_axes([0.05, 0.80, 0.9, 0.15]) ax2 = fig.add_axes([0.05, 0.475, 0.9, 0.15]) ax3 = fig.add_axes([0.05, 0.15, 0.9, 0.15]) # Set the colormap and norm to correspond to the data for which # the colorbar will be used. cmap = mpl.cm.cool norm = mpl.colors.Normalize(vmin=5, vmax=10) # ColorbarBase derives from ScalarMappable and puts a colorbar # in a specified axes, so it has everything needed for a # standalone colorbar. There are many more kwargs, but the # following gives a basic continuous colorbar with ticks # and labels. cb1 = mpl.colorbar.ColorbarBase(ax1, cmap=cmap, norm=norm, orientation='horizontal') cb1.set_label('Some Units') # The second example illustrates the use of a ListedColormap, a # BoundaryNorm, and extended ends to show the "over" and "under" # value colors. cmap = mpl.colors.ListedColormap(['r', 'g', 'b', 'c']) cmap.set_over('0.25') cmap.set_under('0.75') # If a ListedColormap is used, the length of the bounds array must be # one greater than the length of the color list. The bounds must be # monotonically increasing. bounds = [1, 2, 4, 7, 8] norm = mpl.colors.BoundaryNorm(bounds, cmap.N) cb2 = mpl.colorbar.ColorbarBase(ax2, cmap=cmap, norm=norm, # to use 'extend', you must # specify two extra boundaries: boundaries=[0] + bounds + [13], extend='both', ticks=bounds, # optional spacing='proportional', orientation='horizontal') cb2.set_label('Discrete intervals, some other units') # The third example illustrates the use of custom length colorbar # extensions, used on a colorbar with discrete intervals. cmap = mpl.colors.ListedColormap([[0., .4, 1.], [0., .8, 1.], [1., .8, 0.], [1., .4, 0.]]) cmap.set_over((1., 0., 0.)) cmap.set_under((0., 0., 1.)) bounds = [-1., -.5, 0., .5, 1.] norm = mpl.colors.BoundaryNorm(bounds, cmap.N) cb3 = mpl.colorbar.ColorbarBase(ax3, cmap=cmap, norm=norm, boundaries=[-10] + bounds + [10], extend='both', # Make the length of each extension # the same as the length of the # interior colors: extendfrac='auto', ticks=bounds, spacing='uniform', orientation='horizontal') cb3.set_label('Custom extension lengths, some other units') plt.show() ``` ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no *
[GitHub] zeppelin issue #2106: [WIP] Rewrite PythonInterpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @Leemoonsoo thanks for reviewing.. Let me fix the issues you commented and add PandasSql. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2106: Rewrite PythonInterpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 I just added conda interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2106: Rewrite PythonInterpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2106 @zjffdu Thank you for your opinion! Of course i checked #1495 and I totally agree of extensibility for python interpreter. but As you can see, current python interpreter has lots of issues and i think these issues are really serious so I wanted it to fix them on current python interpreter but I couldn't. It would be better if #1495 is done ASAP but I thought we also need to think about zeppelin users while implementing #1495. Actually i think it would be better to rewrite python interpreter as python codes for simplicity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2106: Py4j python interpreter
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2106 Py4j python interpreter ### What is this PR for? I've been testing the python interpreter and I found at least 4 major issues in the current python interpreter. 1. not working streaming output. - https://issues.apache.org/jira/browse/ZEPPELIN-2225 2. printed "..." when there is indent in the python code. - https://issues.apache.org/jira/browse/ZEPPELIN-1929 3. very slow output of matplotlib - https://issues.apache.org/jira/browse/ZEPPELIN-1894 - https://issues.apache.org/jira/browse/ZEPPELIN-1360 4. Unexpected output of matplotlib. - https://issues.apache.org/jira/browse/ZEPPELIN-2107 so I changed python interpreter to use py4j based on pyspark interpreter and would be fixed above issues. and I am going to recreate conda, docker for python interpreter ASAP. ### What type of PR is it? Bug Fix | Hot Fix | Refactoring ### How should this be tested? 1. not working streaming output. ``` import time for x in range(0, 5): print x time.sleep(1) ``` 2. printed "..." when there is indent in the python code. ``` def fn(): print("hi") fn() ``` 3. very slow output of matplotlib. ``` import matplotlib import sys import matplotlib.pyplot as plt plt.plot([1,2,3]) ``` 4. Unexpected output of matplotlib. ``` import matplotlib.pyplot as plt import matplotlib as mpl # Make a figure and axes with dimensions as desired. fig = plt.figure(figsize=(8, 3)) ax1 = fig.add_axes([0.05, 0.80, 0.9, 0.15]) ax2 = fig.add_axes([0.05, 0.475, 0.9, 0.15]) ax3 = fig.add_axes([0.05, 0.15, 0.9, 0.15]) # Set the colormap and norm to correspond to the data for which # the colorbar will be used. cmap = mpl.cm.cool norm = mpl.colors.Normalize(vmin=5, vmax=10) # ColorbarBase derives from ScalarMappable and puts a colorbar # in a specified axes, so it has everything needed for a # standalone colorbar. There are many more kwargs, but the # following gives a basic continuous colorbar with ticks # and labels. cb1 = mpl.colorbar.ColorbarBase(ax1, cmap=cmap, norm=norm, orientation='horizontal') cb1.set_label('Some Units') # The second example illustrates the use of a ListedColormap, a # BoundaryNorm, and extended ends to show the "over" and "under" # value colors. cmap = mpl.colors.ListedColormap(['r', 'g', 'b', 'c']) cmap.set_over('0.25') cmap.set_under('0.75') # If a ListedColormap is used, the length of the bounds array must be # one greater than the length of the color list. The bounds must be # monotonically increasing. bounds = [1, 2, 4, 7, 8] norm = mpl.colors.BoundaryNorm(bounds, cmap.N) cb2 = mpl.colorbar.ColorbarBase(ax2, cmap=cmap, norm=norm, # to use 'extend', you must # specify two extra boundaries: boundaries=[0] + bounds + [13], extend='both', ticks=bounds, # optional spacing='proportional', orientation='horizontal') cb2.set_label('Discrete intervals, some other units') # The third example illustrates the use of custom length colorbar # extensions, used on a colorbar with discrete intervals. cmap = mpl.colors.ListedColormap([[0., .4, 1.], [0., .8, 1.], [1., .8, 0.], [1., .4, 0.]]) cmap.set_over((1., 0., 0.)) cmap.set_under((0., 0., 1.)) bounds = [-1., -.5, 0., .5, 1.] norm = mpl.colors.BoundaryNorm(bounds, cmap.N) cb3 = mpl.colorbar.ColorbarBase(ax3, cmap=cmap, norm=norm, boundaries=[-10] + bounds + [10], extend='both', # Make the length of each extension # the same as the length of the # interior colors: extendfrac='auto', ticks=bounds, spacing='uniform', orientation='horizontal') cb3.set_label('Custom extension lengths, some other units') plt.show() ``` ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs d
[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2080 @Leemoonsoo I did. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2080: [ZEPPELIN-1964] Layout info is lost after refre...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2080 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow Thank you for confirm your idea and thank @zjffdu help to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2080: [ZEPPELIN-1964] Layout info is lost after refre...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2080 [ZEPPELIN-1964] Layout info is lost after refresh ### What is this PR for? This PR is for `branch-0.7` of https://github.com/apache/zeppelin/pull/2053. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1964 ### How should this be tested? Please do resize paragraph and then refresh browser. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin fix/layoutbroken Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2080.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2080 commit b7c939de01c229df01faf32636586a4d458d Author: hyungsung <astros...@gmail.com> Date: 2017-02-28T18:51:11Z fix layout broken issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2080 @AhyoungRyu Could you help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @zjffdu I tested impersonation mode followed http://zeppelin.apache.org/docs/0.7.0/manual/userimpersonation.html and worked well. BTW for now anybody can interrupt to interpreter process. and that is @FireArrow's worrying. Am i right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @Leemoonsoo @zjffdu @felixcheung @karuppayya Could you guys help to review about the impersonation mode? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow I think it seems not can be possible to know if impersonation mode or not in Interpreter side(I couldn't find it) and checking `cancel` paragraph for impersonation is also not good idea (Interpreter sever can be launched itself not the same system with ZeppelinServer) So I think that the canceling job can run only by user who launched interpreter process can be one option. and In this way, the other user can't stop the job in shared mode. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow Yea, right. I understood. Let me fix it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow Note has permission in the zeppelin so if user doesn't have `write` permission on that note, user can't cancel job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2053: [ZEPPELIN-1964] Layout info is lost after refre...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2053 [ZEPPELIN-1964] Layout info is lost after refresh ### What is this PR for? This PR fixes layout info is lost after refreshing issue. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1964 ### How should this be tested? Please do resize paragraph and then refresh browser. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2053.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2053 commit 474bdf52f40a9f3e5ec9b7746fd91178b8fb9e39 Author: astroshim <hss...@zepl.com> Date: 2017-02-22T02:34:50Z fix layout lost problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2052: [ZEPPELIN-2048] Can't run first paragraph when persona...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2052 CI has passed. Thank you @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2052: [ZEPPELIN-2048] Can't run first paragraph when ...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/2052 [ZEPPELIN-2048] Can't run first paragraph when personalize mode on. ### What is this PR for? Problem of ZEPPELIN-2048 was because not set the user id when inserting new paragraph. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2048 ### How should this be tested? please refer to the screenshot of jira. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2048 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2052.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2052 commit 77bd2ac3774a62fa78db277555d31cdce880a9fa Author: astroshim <hss...@zepl.com> Date: 2017-02-21T16:11:44Z add user when inserting paragraph. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2052: [ZEPPELIN-2048] Can't run first paragraph when ...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/2052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2052: [ZEPPELIN-2048] Can't run first paragraph when ...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/2052 [ZEPPELIN-2048] Can't run first paragraph when personalize mode on. ### What is this PR for? Problem of ZEPPELIN-2048 was because not set the user id when inserting new paragraph. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2048 ### How should this be tested? please refer to the screenshot of jira. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2048 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2052.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2052 commit 77bd2ac3774a62fa78db277555d31cdce880a9fa Author: astroshim <hss...@zepl.com> Date: 2017-02-21T16:11:44Z add user when inserting paragraph. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1985 [ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter. ### What is this PR for? If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart. ``` %spark.pyspark import time while True: time.sleep(1) print("running..") ``` ### What type of PR is it? Bug Fix | Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2075 ### How should this be tested? Run above code with Pyspark Interpreter and try to cancel. ### Screenshots (if appropriate) - before ![pyspark before](https://cloud.githubusercontent.com/assets/3348133/22696141/615c1206-ed90-11e6-9bbb-339ecdec73fc.gif) - after ![pyspark after](https://cloud.githubusercontent.com/assets/3348133/22696168/70899172-ed90-11e6-99e1-342eb4094b2c.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1985.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1985 commit 6731e5628c5c139bd9f7189416a0312313cfda7a Author: astroshim <hss...@zepl.com> Date: 2017-02-07T14:47:45Z add signal to cancel job commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb Author: astroshim <hss...@zepl.com> Date: 2017-02-07T14:54:23Z init python pid variable commit 678c183000ce194cfd17c8a6979ccedf6611a83f Author: astroshim <hss...@zepl.com> Date: 2017-02-08T04:23:58Z remove signal handler commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1 Author: astroshim <hss...@zepl.com> Date: 2017-02-08T04:36:03Z fix logging commit f26eacf5041eb266d04c237df50be42fdd86f87b Author: astroshim <hss...@zepl.com> Date: 2017-02-12T03:30:22Z add test-case for canceling. commit b60d89a5ba4aae0fb983dcfea2bed1b03e1349b6 Author: astroshim <hss...@zepl.com> Date: 2017-02-15T06:06:57Z Merge branch 'master' into ZEPPELIN-2075 commit bc12eaaec6dcfe06911359ed5cae7f9d663d66e0 Author: astroshim <hss...@zepl.com> Date: 2017-02-15T08:11:14Z pass pid to java commit 84bf09ae2eec0efefaa4c0a34fda21345ccbf06c Author: astroshim <hss...@zepl.com> Date: 2017-02-18T15:36:45Z fix testcase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @zjffdu yes, this PR is not kill the python process. Thank you for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1985 [ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter. ### What is this PR for? If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart. ``` %spark.pyspark import time while True: time.sleep(1) print("running..") ``` ### What type of PR is it? Bug Fix | Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2075 ### How should this be tested? Run above code with Pyspark Interpreter and try to cancel. ### Screenshots (if appropriate) - before ![pyspark before](https://cloud.githubusercontent.com/assets/3348133/22696141/615c1206-ed90-11e6-9bbb-339ecdec73fc.gif) - after ![pyspark after](https://cloud.githubusercontent.com/assets/3348133/22696168/70899172-ed90-11e6-99e1-342eb4094b2c.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1985.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1985 commit 6731e5628c5c139bd9f7189416a0312313cfda7a Author: astroshim <hss...@zepl.com> Date: 2017-02-07T14:47:45Z add signal to cancel job commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb Author: astroshim <hss...@zepl.com> Date: 2017-02-07T14:54:23Z init python pid variable commit 678c183000ce194cfd17c8a6979ccedf6611a83f Author: astroshim <hss...@zepl.com> Date: 2017-02-08T04:23:58Z remove signal handler commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1 Author: astroshim <hss...@zepl.com> Date: 2017-02-08T04:36:03Z fix logging commit f26eacf5041eb266d04c237df50be42fdd86f87b Author: astroshim <hss...@zepl.com> Date: 2017-02-12T03:30:22Z add test-case for canceling. commit b60d89a5ba4aae0fb983dcfea2bed1b03e1349b6 Author: astroshim <hss...@zepl.com> Date: 2017-02-15T06:06:57Z Merge branch 'master' into ZEPPELIN-2075 commit bc12eaaec6dcfe06911359ed5cae7f9d663d66e0 Author: astroshim <hss...@zepl.com> Date: 2017-02-15T08:11:14Z pass pid to java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 Hello. Sorry for late response. @Leemoonsoo Let me fix CI error. @karuppayya Let me fix `scala` too in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1985 [ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter. ### What is this PR for? If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart. ``` %spark.pyspark import time while True: time.sleep(1) print("running..") ``` ### What type of PR is it? Bug Fix | Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2075 ### How should this be tested? Run above code with Pyspark Interpreter and try to cancel. ### Screenshots (if appropriate) - before ![pyspark before](https://cloud.githubusercontent.com/assets/3348133/22696141/615c1206-ed90-11e6-9bbb-339ecdec73fc.gif) - after ![pyspark after](https://cloud.githubusercontent.com/assets/3348133/22696168/70899172-ed90-11e6-99e1-342eb4094b2c.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1985.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Great Job! but still doesn't work with `mysql`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1962: [ZEPPELIN-2014] Jetty Directory Listing on app, assets...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1962 Tested and working expectably. Thank you for contributing but Could you make the CI as green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Thank you for great improvement. I tested `mysql` and `postgresql` and only `postgresql` is working expectedly like @cloverhearts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1953: User Impersonation fails on setting hive_conf_list in ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1953 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1924 @Leemoonsoo I just create JIRA issue that is https://issues.apache.org/jira/browse/ZEPPELIN-2024. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1833 LGTM it's working well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1924 CI has passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1924 Thank you @felixcheung and @Leemoonsoo for reviewing this. Let me check the CI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1927: [ZEPPELIN-1994] bugfix of streaming output.
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1927 [ZEPPELIN-1994] bugfix of streaming output. ### What is this PR for? If you run the following code, then streaming output doesn't work properly from the second run. ``` %spark.pyspark import time print("1") time.sleep(2) print("2") time.sleep(2) print("3") time.sleep(2) print("4") ``` This problem comes from the order of `paragraph update` event timing and `paragraph update-append` event timing is incorrect. and This PR will fix also https://github.com/apache/zeppelin/pull/1833 too. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1994 ### How should this be tested? - run several times pyspark interpreter with above code. ### Screenshots (if appropriate) - before ![2017-01-21 00_55_25](https://cloud.githubusercontent.com/assets/3348133/22173437/bfa48e64-df77-11e6-9625-ab44dedee395.gif) - after ![2017-01-21 00_59_12](https://cloud.githubusercontent.com/assets/3348133/22173438/c21820ac-df77-11e6-87dc-07970fca13ca.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions?no * Does this needs documentation?no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1994 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1927.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1927 commit c7baa59b32da6f7dceeb0c611a5b74eb1162df12 Author: astroshim <hss...@zepl.com> Date: 2017-01-21T09:06:52Z fix streaming output problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1922: [ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1922 [ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_OUTPUT from the Interpreter. ### What is this PR for? This PR fixes the problem of streaming events(PARAGRAPH_APPEND_OUTPUT). It's because of the queue was not thread safe. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1991 ### How should this be tested? 1. make a spark paragraph 2. run following code on spark paragraph. ``` %spark (1 to 5).foreach{ i=> Thread.sleep(1000) println("Hello " + i) } ``` 3. make a python paragraph 4. run following code on python paragraph. ``` %python.python print("hi1") ``` 5. retry run step 2, and check if streaming working. ### Screenshots (if appropriate) - before ![2017-01-20 13_36_02](https://cloud.githubusercontent.com/assets/3348133/22166640/edb9f610-df16-11e6-926c-c781f618e6cf.gif) - after ![2017-01-20 13_52_53](https://cloud.githubusercontent.com/assets/3348133/22166840/efd855e4-df17-11e6-816c-17e069cd6a04.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1991 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1922 commit 66d3d2fef536f27d6e21bf74f901618c021c0aa7 Author: astroshim <hss...@zepl.com> Date: 2017-01-20T21:41:01Z fix to thread safe commit e99358541c23bd0cefe5e3dbd2eb7d96890a0ab0 Author: astroshim <hss...@zepl.com> Date: 2017-01-21T00:18:40Z make scheduler not static --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1922: [ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1924: [Pyspark] checking nhooks count.
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1924 [Pyspark] checking nhooks count. ### What is this PR for? if the `nhooks` value is `0` in this(https://github.com/apache/zeppelin/blob/master/spark/src/main/resources/python/zeppelin_pyspark.py#L324) line, python code will run twice. ### What type of PR is it? Bug Fix | Improvement ### How should this be tested? - comment https://github.com/apache/zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/PySparkInterpreter.java#L114 line and build. - run pyspark code(eg, `print("hi")`), then you can see it run twice. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin fix/pythoncode Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1924.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1924 commit 1c50c6d367e5db935c6b3ae2b06af242c30b91f4 Author: astroshim <hss...@zepl.com> Date: 2017-01-20T23:21:45Z add checking nhooks count --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1845: [ZEPPELIN-1906] Use multiple InterpreterResult for dis...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1845 @prabhjyotsingh Yea I know you didn't change it. That's because it doesn't have state before. I agree that we can take care/discuss it in a different PR. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1845: [ZEPPELIN-1906] Use multiple InterpreterResult for dis...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1845 Sorry for late response @prabhjyotsingh, @jongyoul . Let me review soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1858 @corneadoug please help to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1877 [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error. ### What is this PR for? This PR fixes syntax error of PythonInterpreter. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1930 ### How should this be tested? Please run following code on the paragraph of PythonInterpreter. ``` for x in range(0,3): print ("hi") ``` ### Screenshots (if appropriate) - before ![image](https://cloud.githubusercontent.com/assets/3348133/21763102/fdf3fada-d610-11e6-8e92-310aec1968ad.png) - after ![image](https://cloud.githubusercontent.com/assets/3348133/21763159/4a0aec26-d611-11e6-955b-be0b86455a34.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1930 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1877.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1877 commit 5a7e1b3cbaf2d98f1b38fa6c3449b2aa73ff9e65 Author: astroshim <hss...@zepl.com> Date: 2017-01-09T10:08:48Z fix syntax error. commit 573140fe3ccecd7331e71ece53202d51ca2c2ab3 Author: astroshim <hss...@zepl.com> Date: 2017-01-09T14:49:27Z add test-case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1877 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1877 @agoodm pyspark interpreter is working well. ![image](https://cloud.githubusercontent.com/assets/3348133/21768320/e79bebe0-d62d-11e6-8878-3c837fb7938f.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1877 [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error. ### What is this PR for? This PR fixes syntax error of PythonInterpreter. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1930 ### How should this be tested? Please run following code on the paragraph of PythonInterpreter. ``` for x in range(0,3): print ("hi") ``` ### Screenshots (if appropriate) - before ![image](https://cloud.githubusercontent.com/assets/3348133/21763102/fdf3fada-d610-11e6-8e92-310aec1968ad.png) - after ![image](https://cloud.githubusercontent.com/assets/3348133/21763159/4a0aec26-d611-11e6-955b-be0b86455a34.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1930 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1877.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1877 commit 5a7e1b3cbaf2d98f1b38fa6c3449b2aa73ff9e65 Author: astroshim <hss...@zepl.com> Date: 2017-01-09T10:08:48Z fix syntax error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1858 @corneadoug Let me find different of more efficient way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1867: [MINOR][ZEPPELIN-1919] Reduce markdown intp's plain te...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1867 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1862 Tested and LGTM! Thanks @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1853: [ZEPPELIN-1911] Adding how to install evaluate package...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1853 @felixcheung You're right! `evaluate` is dependency package of `knitr`. Thanks for pointing out. It's my misunderstood. Let me close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1853 [ZEPPELIN-1911] Adding how to install evaluate package to build R. ### What is this PR for? This PR inform how to avoid build failing with R. ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1911 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1853 commit 2ca82573e497ebcdca373c2be1048b1b7a1b4afa Author: astroshim <hss...@zepl.com> Date: 2017-01-06T01:56:16Z add doc how to install evaluate package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1858 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1858 [ZEPPELIN-1229] Clear browser cache with version hashtag. ### What is this PR for? This PR avoids browser cache. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1229 ### How should this be tested? 1. Run old version of zeppelin(I was using 0.6.1) and show main page up in your browser. 2. Stop zeppelin. 3. Run this PR of Zeppelin and show page up on the same browser of 1. 4. check main page changed. - before (Job menu doesn't show) ![2017-01-06 01_50_29](https://cloud.githubusercontent.com/assets/3348133/21728478/43aec6d0-d3fb-11e6-84ce-9e1b18853611.gif) - after (Job menu show) ![2017-01-06 01_55_10](https://cloud.githubusercontent.com/assets/3348133/21728482/4a794e72-d3fb-11e6-8934-d6f92d65889b.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1229 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1858.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1858 commit 9d9f76f415e5b29c35b387cf1dcac889272b7503 Author: astroshim <hss...@zepl.com> Date: 2017-01-06T08:14:35Z fix ZEPPELIN-1229 commit c94de90832645da674bd2f1df2d4f7ddea1e14bf Author: astroshim <hss...@zepl.com> Date: 2017-01-06T08:15:53Z delete unnecessary codes commit 655dc3d67e587e6b46c4b147f28325d32d8cc746 Author: astroshim <hss...@zepl.com> Date: 2017-01-06T09:38:17Z tag all html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1858 @corneadoug I updated screenshot and codes. Could you help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1858 [ZEPPELIN-1229] Clear browser cache with version hashtag. ### What is this PR for? This PR avoids browser cache. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1229 ### How should this be tested? 1. Run old version of zeppelin and show main page up in your browser. 2. Stop zeppelin. 3. Run this PR and show page up on the same browser with 1. 4. check main page changed. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1229 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1858.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1858 commit 9d9f76f415e5b29c35b387cf1dcac889272b7503 Author: astroshim <hss...@zepl.com> Date: 2017-01-06T08:14:35Z fix ZEPPELIN-1229 commit c94de90832645da674bd2f1df2d4f7ddea1e14bf Author: astroshim <hss...@zepl.com> Date: 2017-01-06T08:15:53Z delete unnecessary codes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1853 [ZEPPELIN-1911] Adding how to install evaluate package to build R. ### What is this PR for? This PR inform how to avoid build failing with R. ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1911 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1853 commit 2ca82573e497ebcdca373c2be1048b1b7a1b4afa Author: astroshim <hss...@zepl.com> Date: 2017-01-06T01:56:16Z add doc how to install evaluate package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1848: [ZEPPELIN-1812] Ace editor show/hide problem.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1848 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1832: [ZEPPELIN-1884] Prevent NullPointerException when JDBC...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1832 @felixcheung Thank you for review! Currently only `COMMON_KEY` uses for max line count in JDBC interpreter but as like you mentioned it seems more make sense to move the code to `open()` method. Let me fix then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1832 [ZEPPELIN-1884] Prevent NullPointerException when JDBC query. ### What is this PR for? Sometimes users don't want to set the properties which they don't want to care about and `common.max_count` of JDBC interpreter is one of that property. If it does not set the `common.max_count`, NullPointerException will occur. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1884 ### How should this be tested? - Set properties like as following image and run select query. ![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1832 commit f1efda772d70d9f0247d07195ab8913050e2339d Author: astroshim <hss...@zepl.com> Date: 2017-01-02T06:22:49Z add checking commonkey exists --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1833 Hi. In my case it seems doesn`t work properly.. What am i missing? ![test1](https://cloud.githubusercontent.com/assets/3348133/21593751/75fa43be-d0cf-11e6-8f83-aa102458dc29.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1831: [ZEPPELIN-1883] Can't import spark submitted packages ...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1831 In my test, I got a ` INFO [2017-01-02 09:08:12,358] ({Exec Default Executor} RemoteInterpreterManagedProcess.java[onProcessComplete]:164) - Interpreter process exited 0` error when i try to run the paragraph. Maybe this error occurs when couldn't download libraries of `SPARK_SUBMIT_OPTIONS` option. Is this normal behavior? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...
GitHub user astroshim reopened a pull request: https://github.com/apache/zeppelin/pull/1832 [ZEPPELIN-1884] Prevent NullPointerException when JDBC query. ### What is this PR for? Sometimes users don't want to set the properties which they don't want to care about and `common.max_count` of JDBC interpreter is one of that property. If it does not set the `common.max_count`, NullPointerException will occur. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1884 ### How should this be tested? - Set properties like as following image and run select query. ![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1832 commit f1efda772d70d9f0247d07195ab8913050e2339d Author: astroshim <hss...@zepl.com> Date: 2017-01-02T06:22:49Z add checking commonkey exists --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1813 @soralee Thank you for reviewing and commenting!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1832 [ZEPPELIN-1884] Prevent NullPointerException when JDBC query. ### What is this PR for? Sometimes users don't want to set the properties which they don't want to care about and `common.max_count` of JDBC interpreter is one of that property. If it does not set the `common.max_count`, NullPointerException will occur. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1884 ### How should this be tested? - Set properties like as following image and run select query. ![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1832.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1832 commit f1efda772d70d9f0247d07195ab8913050e2339d Author: astroshim <hss...@zepl.com> Date: 2017-01-02T06:22:49Z add checking commonkey exists --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1813: [ZEPPELIN-1868]fix to not shows up the login bu...
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1813 [ZEPPELIN-1868]fix to not shows up the login button on Anonymous mode. ### What is this PR for? This PR fixs to not shows up the login button on Anonymous mode. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1868 ### How should this be tested? 1. Give permission on note. 2. Turn off the shiro. 3. Delete note that you made on 1. 4. Then you can see the `login button` like as screen shot. ### Screenshots (if appropriate) ![image](https://cloud.githubusercontent.com/assets/3348133/21537257/89d15862-cd43-11e6-8129-0e25348537ae.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin feat/skipLogin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1813.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1813 commit ba7218872f75a8341ae2dd24d32b6544c40f35c1 Author: astroshim <hss...@zepl.com> Date: 2016-12-29T05:12:43Z fix to not shows up the login button on Anonymous mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @AhyoungRyu Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 CI has passed after rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @bzz I agree with you and I will follow your word! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 In my case, It's normal output of results. @AhyoungRyu Did you build this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @AhyoungRyu Thank you for review and let me check that problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1777 Thanks for contribution! Looks great to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1780: [BugFix] Tutorial note json format.
GitHub user astroshim opened a pull request: https://github.com/apache/zeppelin/pull/1780 [BugFix] Tutorial note json format. ### What is this PR for? Since https://github.com/apache/zeppelin/pull/1658, the output format had changed but note.json of Tutorials didn't changed. ### What type of PR is it? Bug Fix ### How should this be tested? Please make sure there is no `result` field in note.json file. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/astroshim/zeppelin fix/tutorialNote Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1780.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1780 commit a957baaab0659c5e06beff4c4a222ef8ae59440e Author: Hyungsung Shim <shim@hyungsungui-macbook-pro.local> Date: 2016-12-17T07:01:07Z fix tutorial note json format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1735: [ZEPPELIN-1767] Blank paragraph should not be run.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1735 CI is green now. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1752: [HOT FIX] Fix broken display_formula.png by using rela...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1752 LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1735: [ZEPPELIN-1767] Blank paragraph should not be r...
Github user astroshim closed the pull request at: https://github.com/apache/zeppelin/pull/1735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---