[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1600 Thank you @aspen01, @placeybordeaux In order to be merged, this branch have to be rebased on top of the master, which itself already includes CI fixes, i.e 1c7d8fb. This branch must not include any other commits, except for ones that implement "HDFS to backup and restore notebook" - edae7bc, d94eb16 need to be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov Is it WIP? Then please feel free to add WIP in PR title and ping back, when it's ready for reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1767 Great improvement, thank you @vinayshukla ! But indeed, it would be really nice to have documentation available on the website as well, as @Leemoonsoo suggests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1776 Thank you @pmccaffrey6 , it looks great to me, modulo few things noted above. Could you just double check that all feedback from reviews was addressed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1779: [ZEPPELIN-1835] Upgrade ElasticSearch to version 2.4.3
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1779 Looks good to me. Just FYI - there already is #1598 from @1ambda but AFAIK it is stuck and need a hand. That would be awesome, if we could come up with a plan to merge that one as well.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1780 Looks great to me. CI fails here though. I know it's annoying but @astroshim, as PR author, could you please post failure build logs here, so we can see if it is something that already have a JIRA issue, or a new one should be created? Again, sorry for bothering, but this helps improving CI stability a lot and sets a good example of NOT ignoring the CI failures for other contributors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1758 Is there any other feedback, or was everything addressed and we shall merge it now? Saw @zjffdu 's > How about refer this note in flink.md ? @AlexanderShoshin do you think it's worth to update the interpreter documentation as well under `./docs`, to mention this example? Other than that, looks great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Only the last CI profile fails on very strange curcumstances: ``` 16/12/19 04:54:08 INFO ApplicationMaster: Deleting staging directory .sparkStaging/application_1482123134765_0003 16/12/19 04:54:08 ERROR ApplicationMaster: Failed to cleanup staging dir .sparkStaging/application_1482123134765_0003 java.net.ConnectException: Call From testing-docker-7a57c244-e7fb-44fb-9664-5856f0534506/172.17.0.5 to localhost:39393 failed on connection exception: java.net.ConnectException: Connection refused; For more details see: http://wiki.apache.org/hadoop/ConnectionRefused at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 Thank you very much @cuspymd for fix and @zjffdu for double-checking! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1600 I see! This looks like something failing on the TravisCI side though. Could you please rebase this branch on latest master and force-push it here again? This will trigger CI \w latest code\fixes from master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 @cuspymd please let me know you ASF JIRA user or email and I'll be happy to assign [ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) so attribution is keept for release notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 Looks great to me. Merging to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1774: [HOTFIX] CAN'T install cran packages using apt in Trav...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1774 merging as HOTFIX as CI is green now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1774: [HOTFIX] CAN'T install cran packages using apt in Trav...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1774 Merging as a HOTFIX, as CI passes \wo packaeg installation error, as per https://travis-ci.org/1ambda/zeppelin/builds/184455104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1716 @cloverhearts can you please rebase it on latest master - `git rebase master` and force push it? This will trigger CI with latest fixes and help to see if there are any relevant failures here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 \cc @corneadoug @felizbear for reivew --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1477 Thank you @yiming187 ! CI failures looks not relevant to the changes ``` Results : Failed tests: HeliumApplicationFactoryTest.testLoadRunUnloadApplication:160 expected: but was: Tests run: 122, Failures: 1, Errors: 0, Skipped: 0 ``` and ``` Results : Tests in error: ParagraphActionsIT.testRemoveButton:155->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisible ParagraphActionsIT.testMoveUpAndDown:200->AbstractZeppelinIT.clickAndWait:131 » ElementNotVisible ParagraphActionsIT.testCreateNewButton:85 » ElementNotVisible Element is not c... Tests run: 18, Failures: 0, Errors: 3, Skipped: 0 ``` Merging to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Thanks for explanation, makes sense to me On CI failures - from my experience, if the reason of failure is posted here - there speeds up the merge dramatically. I have update [ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797) \w Scala 2.10 profile failure on DependencyInterpreter, that is a first failng profile here. And the last one loooks like something new, possibly [related to Livy](https://api.travis-ci.org/jobs/183791719/log.txt?deansi=true), do we have a JIRA issue for that? Other that that - current master build time is `Elapsed time 32 min 6 sec`, this branch `Elapsed time 34 min 4 sec`... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1603 2 weeks ping @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 First and second failing CI profile hit [ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797) Spark 1.5 had another troubles \w `DepInterpreterTest` ``` 16/12/13 10:47:22 INFO RemoteActorRefProvider$RemotingTerminator: Remote daemon shut down; proceeding with flushing remote transports. Results : Tests in error: DepInterpreterTest.testDefault:96 » NullPointer Tests run: 24, Failures: 0, Errors: 1, Skipped: 0 ``` And Selenium profiles also fails on test, related to `DepInterpreter` ``` ailed tests: SparkParagraphIT.testDep:234 First paragraph from SparkParagraphIT of testDep status: Expected: "FINISHED" but: was "ERROR" Tests in error: ZeppelinIT.testSparkInterpreterDependencyLoading:234->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 » Timeout Tests run: 18, Failures: 1, Errors: 1, Skipped: 0 ``` Though I belive none of these have to do anything with the changed introduced in this PR, so merging it to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 Looks great to me, thank you @1ambda @mfelgamal Let's wait for CI results and merge to master, if nothing comes up and there is no further discussion! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Iâm a bit confused though - this PR seems not to have separate checkstyle CI profile, right? Didnât we want to have `CHECKSTLYLE=1 â¦` profile for all projects, and then skip checkstyle (I assume that is what `loose checkstyle` option is for) on all other profiles? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1734 Guys, if I may, I would suggest keep the discussion in PR focused on the subject of the PR and move general topics of project's CI stability to the public dev@ mailing list and appropriate JIRA issues. Main reason beeing that people in community, who are interested in the subject of CI stability have hirer chanced on collaborating and fixing it together that way. Here is JIRA for the CI failing on `spark-csv` - [ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797), \w some logs and failure examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 I'm sorry for a confusion - as soon as this issue is not about CI, but about `Update checkstyle rule file, plugin`. Let's move the CI discussion to the dev@ mailing list so all people in the community will be included, I have created [ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797) Merging this to master as CI failure is not relevant to the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1689
Interesting, that is the first time I see it! AFAIK `spark-csv` has been
included in Spark since 2.0
The failing profile is Spark 1.6 with **Scala 2.11**, but it fails on
fetching `spark-csv_2.10` which seems to me as almost the right thing to happen
(to avoid runtime errors)...
This artefact seems to be fine, published on central and sonatype
https://mvnrepository.com/artifact/com.databricks/spark-csv_2.10/1.3.0
May be we need to update `./dev/change_scala_version.sh` to take care of
the version literal here as well and see if that helps?
Another way is to let maven `resource-plugin` replace it with actual
version on build time, and use smth like `${scala.version}` in the Java code.
Default property value can be set to 2.10 and override it though SCALA_VERSION
env var, but this is not very IDE-friendly as they tend to do custom builds for
you, skipping lifecycle definition from time to time, but the default value in
the code like `${scala.version}` would not be very useful. So resource-plugin
way actually seems to me to complicated and we usually try to avoid it.
What do you think, @1ambda ?
Or another, simplest, way could be - create a separate JIRA issue for Scala
version mismatch in tests(if that is the case here), move the
feedback\discussion there and handle it in subsequent PRs. But just re-trigger
CI here, to see if it is reproducible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1744 Looks great to me, modulo minor issue above. Also, in my experience if CI failure reason is summarised and posted here by PR author - it makes merging/reviewing process much faster. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1714 Thank you @felizbear ! Merging to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal could you please explain, why do you think one more script is needed - `start-zeppelin.sh` and why `CMD["/bin/zeppelin.sh"]` can not be used as entrypoint for the image? @1ambda has the point, and we should try to reduce the number of shell scripts that need to be supported later on, as well as possible issues with setting up classpath, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1716 @cloverhearts thank you for contribution! In my experience, if PR author or one of reviewers post the reason for CI failure - that speeds up the review\merge process dramatically. CI is failing with flaky pySpark tests, not relevant to the PR ``` Results : Failed tests: ZeppelinSparkClusterTest.pySparkDepLoaderTest:430 expected: but was: ZeppelinSparkClusterTest.pySparkAutoConvertOptionTest:312 expected: but was: Tests run: 82, Failures: 2, Errors: 0, Skipped: 1 ``` It will be handled under [ZEPPELIN-1761](https://issues.apache.org/jira/browse/ZEPPELIN-1761). \cc @felizbear to review the frontend part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 ð Idea sounds great to me. It looks like https://github.com/optimalisatie/grunt-goog-webfont-dl is not maintained but https://github.com/Mika-/grunt-google-fonts had changes this year. I tried locally in dev mode (\wo maven) `npm i; npm run start` and the fonts were not loaded - could you fix that please?  Same on current master works as expected (fonts are loaded). CI is failing on single profile \w flaky test `ZeppelinSparkClusterTest.pySparkDepLoaderTest` It will be handled separatly under [ZEPPELIN-1761](https://issues.apache.org/jira/browse/ZEPPELIN-1761). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1727 Looks great to me, thank you @1ambda for valuable build improvements! Merging to master if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal that sounds awesome job, thank you very much. Please let me test it tomorrow and get back to you here, but otherwise I think it's ready to be merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1561 @meenakshisekar thank you for contribution! Could you rebase on the latest master please? Also, please do not hesitate to let us know in case you need any help with this one, in order to get it merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1477 @yiming187 thank you for improvement, looks good to me, ð for having tests! Could you please rebase it on the latest master, before merging it in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1661: [ZEPPELIN-1605] zeppelin-interpreter: don't publish sh...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1661 Sounds awesome, thank you! Let's merge then, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1714 Looks great to me! @felizbear In my experience, if the contribution author followup on CI failure - that speeds up the merge time tremendously. It looks like at least CI is failing on `npm run test` (which fails on the `grunt test`? ), could you please double-check\digg into it? ``` ERROR] [ERROR] npm ERR! Linux 4.8.7-040807-generic [ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "run" "test" [ERROR] npm ERR! node v6.9.1 [ERROR] npm ERR! npm v3.10.8 [ERROR] npm ERR! code ELIFECYCLE [ERROR] npm ERR! zeppelin-web@0.0.0 test: `grunt test` [ERROR] npm ERR! Exit status 3 [ERROR] npm ERR! [ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 test script 'grunt test'. [ERROR] npm ERR! Make sure you have the latest version of node.js and npm installed. [ERROR] npm ERR! If you do, this is most likely a problem with the zeppelin-web package, [ERROR] npm ERR! not with npm itself. [ERROR] npm ERR! Tell the author that this fails on your system: [ERROR] npm ERR! grunt test [ERROR] npm ERR! You can get information on how to open an issue for this project with: [ERROR] npm ERR! npm bugs zeppelin-web [ERROR] npm ERR! Or if that isn't available, you can get their info via: [ERROR] npm ERR! npm owner ls zeppelin-web [ERROR] npm ERR! There is likely additional logging output above. [ERROR] [ERROR] npm ERR! Please include the following file with any support request: [ERROR] npm ERR! /home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm test) on project zeppelin-web: Failed to run task: 'npm run test' failed. (error code 1) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1718: [HOTFIX] Restore uninteded change of exit code in test...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1718 Looks great to me, thank you @minahlee ! Merging as a hotfix, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1714: Use explicit arguments in functions in paragraph.contr...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1714 Looks great to me, thank you @felizbear for frontend code improvements! Let's wait for CI, meanwhile, would you mind creating a JIRA issue please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 I see what you mean, for profile not included in build roster by default we would need to update the CI profile. Well, it's 12s * 10 (number of profile we have no), which looks like 2min time, but we can always optimize that later. Could you please elaborate on CI failures here? In my experience, that helps to merge things faster. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Sounds great! What is rationale for having checkstyle running everywhere + a separate profile? Would it make sense to measure the CI build time with\without separate profile and see if there is a net gain in time, having it separately (and skipping it everywhere else)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 With number of PRs we have I'm a bit lost, which one will introduce a separate checkstyle CI profile and skip it in all the rest? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1661: [ZEPPELIN-1605] zeppelin-interpreter: don't publish sh...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1661 @minahlee Looks great to me! Could you please rebase on latest master? I assume that for testing, it should be enough to build `mvn clean package -Pbuild-distr -DskipTests` and make sure Zeppelin run from `zeppelin-distribution/target` is able to execute a paragraph, or is there a better way? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1695: Zeppelin 1283
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1695 @PetroKostyuk thank you for improvement! It looks like your work need to be rebased on the latest master in order to resolve conflicts, before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 2 Scala 2.11 profiles failed on IgniteSQL tests - a flaky test tracked under [ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738l) ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.116 sec <<< FAILURE! - in org.apache.zeppelin.ignite.IgniteSqlInterpreterTest testSql(org.apache.zeppelin.ignite.IgniteSqlInterpreterTest) Time elapsed: 0.909 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.zeppelin.ignite.IgniteSqlInterpreterTest.testSql(IgniteSqlInterpreterTest.java:95) Results : Failed tests: IgniteSqlInterpreterTest.testSql:95 expected: but was: Tests run: 4, Failures: 1, Errors: 0, Skipped: 0 ``` which is not relevant to the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Waiting for CI to finish on https://travis-ci.org/1ambda/zeppelin/ Will merge to master right after that, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 Looks great to me, thank you @felixcheung let's merge if there is no further discussion! CI failure of tests in `zeppelin-zengine` on 1 profile looks not relevant and will be taken care under [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) ``` Failed tests: NotebookTest.testAbortParagraphStatusOnInterpreterRestart:746 expected: but was: Tests run: 122, Failures: 1, Errors: 0, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Go it, that sounds great. Then shall we finish and merge this guy first, and then get back to #1668 merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1500 Looks great to me and CI is green. Thank you @Peilin-Yang for prompt responce and @felizbear for reviews! Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Looks like it need a final re-base here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1709: [HOTFIX] Make Spark download stable on CI
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1709 CI is green, merging to master as a HOTFIX --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1696: CI test for 1689
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1696 rebasing on #1709 should solve the CI issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 @1ambda I have created a HOTFIX for CI Spark download in #1709 so after merging it, let's rebase and see if that fixed the issue. I'm a bit confused, do you want to continue working here or in #1696 though? Or they can be rebased one after another --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 @felixcheung I think after #1709 there might be no need for `mvn -q` option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1709: [HOTFIX] Make Spark download stable on CI
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1709
[HOTFIX] Make Spark download stable on CI
### What is this PR for?
There has been issues with downloading\caching Spark, esp in #1689 #1696
This is hotfix for Spark download on CI.
### What type of PR is it?
Hot Fix
### Todos
*[x] do not use distrs.apache.org
*[x] levirage `download-maven-plugin` cache for Spark download
*[x] set timeout 1min and 5 re-tries on download
*[x] un-pack them under `/target/` so `mvn clean` works as expected
*[x] mute logs for `./testing/install_external_dependencies.sh`
### How should this be tested?
In CI logs, Spark should be downloaded by `spark-dependencies` and cached
under `${HOME}/.m2/repository/.cache/maven-download-plugin`
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin make-ci-stabel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1709.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1709
commit 9ee9c045c21648752791c5692e410df6a6a72349
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T01:55:07Z
Direct Spark download url for CI as INFRA-12996
commit 605dea9bcb11f90954065f66dd06ee03656fd65a
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T06:38:58Z
Spark 2.0.1 on CI, same as in pom.xml
commit 7a64690ba60634352a25acff91158e3e4f4c7d81
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T08:55:03Z
Bump download-maven-plugin version to lastes 1.3.0
commit 78109af26db877fd20b10589351c6975fdc61a73
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T10:04:56Z
Set readTimeOut for download-maven-plugin
commit 1d85b5c162e2ea25f5dedd099e0df9fa079a0f46
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T10:31:57Z
Mute dependency install logs
commit 7040b092fd3ea4876a8bfd627ca70070ff4f9ccc
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T13:09:23Z
Switch Spark download dir
commit 702dcdd112e4501cd4c94b9e4240437ef5f4f745
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T14:03:34Z
Spark download\cached, using download-maven-plugin
commit 06c031c757a89eda6614949c35b12c7b25855b77
Author: Alexander Bezzubov <b...@apache.org>
Date: 2016-11-30T14:04:50Z
Move logging config to MAVEN_OPTS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Will you also add `plugin.download.version` to [spark-dependencies/pom.xml](https://github.com/apache/zeppelin/pull/1668/files#diff-457fb4186c9640eac4e0808bbd0d849e) ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 There is really strange test failure in `markdown` tests on first CI profile (flaky-test?) ``` Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 101.166 sec <<< FAILURE! - in org.apache.zeppelin.markdown.PegdownParserTest testWebsequencePlugin(org.apache.zeppelin.markdown.PegdownParserTest) Time elapsed: 99.979 sec <<< FAILURE! java.lang.AssertionError: Expected: a string containing "http://www.websequencediagrams.com/?png=; but: was "Error while parsing action 'Root/Sequence/ZeroOrMore/Sequence/Block/FirstOf/Table/Sequence/Optional/Sequence/NodeSequence/Sequence/TableRow/Sequence/OneOrMore/Sequence/TableCell/NodeSequence/Sequence/OneOrMore/Sequence/Inline/Inline_Action1' at input position (line 10, pos 1): ^ org.pegdown.ParsingTimeoutException" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.Assert.assertThat(Assert.java:832) at org.apache.zeppelin.markdown.PegdownParserTest.testWebsequencePlugin(PegdownParserTest.java:320) Results : Failed tests: PegdownParserTest.testWebsequencePlugin:320 Expected: a string containing "http://www.websequencediagrams.com/?png=; but: was "Error while parsing action 'Root/Sequence/ZeroOrMore/Sequence/Block/FirstOf/Table/Sequence/Optional/Sequence/NodeSequence/Sequence/TableRow/Sequence/OneOrMore/Sequence/TableCell/NodeSequence/Sequence/OneOrMore/Sequence/Inline/Inline_Action1' at input position (line 10, pos 1): ^ org.pegdown.ParsingTimeoutException" ``` @1ambda have you seen that before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 That makes sense, let's try! @1ambda and me are already working on downoad Spark src stability if not cached and going to nail it in #1696 and #1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1682: Update to Spark 1.6.3 and 2.0.2
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1682 Great update @felixcheung ! On the `--quite` switch - before fixing the symptoms I would rather prefer fixing the reason, if possible. Do you have any idea why does it start to bite us only recently? I.e one thing is - our tests produce A LOT of garbage output.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1168: [MINOR] Add formatter
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1168 I think we are already on the path of multiple PRs, wich sounds great to me! @jongyoul shall we close this guy then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1391 Having a `PortProvider` as injectable dependency, that incapsulates all the logic about picking the port numbers sounds great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal yes, exactly. Do you think this is possible? I wonder if the image size would go down, if we remove those guys after getting `knitr`. The goal would be to have a _minimal_ image that includes all necessary dependencies only to run Zeppelin. I'm not very familiar with R ecosystem, but isn't there some way of installing packages that comes with everything compiled, like [.whl](https://pypi.python.org/pypi/wheel) in [Python](http://pythonwheels.com/)? Then we could skip building layers of image \w gcc all together... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1603 ping @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Thank you @1ambda ! Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1674: [ZEPPELIN-1695] Apply regular maven indent
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1674 Sounds good, let's take care of small parts first, and then rebase and merge this guys in a bulk! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1696: CI test for 1689
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1696 I have asked ASF on another side as well [INFRA-12996](https://issues.apache.org/jira/browse/INFRA-12996) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Here are more detailed logs ``` [WARNING] Retrying (4 more) Downloading: http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz org.apache.maven.wagon.TransferFailedException: Failed to transfer file: http://archive.apache.org/dist/spark/spark-2.0.1/spark-2.0.1.tgz. Return code is: 503 , ReasonPhrase:Service Unavailable. at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:1039) at org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:977) at org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:116) at org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:88) at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:61) at com.googlecode.WGet.doGet(WGet.java:293) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1701: remove usage of non-standard string method
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1701 Looks good to me. Usually, it's better to have JIRA issue to keep author\attribution information for the release. Merging to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Prev plugin version seems to have same behavior ``` [ERROR] Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.2.1:wget (download-pyspark-files) on project zeppelin-spark-dependencies_2.10: IO Error: Could not get content -> [Help 1] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1698 CI failure seems like a candidate for JIRA issue with `flaky-test` label ``` Failed tests: ZeppelinSparkClusterTest.zRunTest:346 expected: but was: ``` Seems un-related to the changes. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 thanks a lot, @1ambda ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Sounds reasonable. CI is green, merging to master then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1700: [DOCS] Update Shiro configuration file with new packag...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1700 Looks good to me, merging to master as a hotfix based on user feedback in [this thread](http://markmail.org/message/4z6hxxf3eem2wgp2), if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1696: CI test for 1689
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1696 Spark 2.0 profile fails with very stragne ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) on project zeppelin: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream - Element type "html" must be declared.:6:26 -> [Help 1] [ERROR] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1679 Looks good to me. CI is green now, so will merge it to master if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to verify ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1693 Looks great to me, thank you @1ambda Merging to master if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Looks great to me, thank you @1ambda ! May be, as soon as CI is green let's try to squash some commits, before merging it in - 37 may be a bit too much to be useful in merge commit message summary. Going to merge to master, if there is no further discussion, right after that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1632 I think it is mostly the test output that pollutes the CI logs... So, if I read TravisCI logs right - with 2 new profiles `Elapsed time 31 min`, and on `master` i.e [yesterday](https://travis-ci.org/apache/zeppelin/builds/179087724) `Elapsed time 31 min 14 sec` Looks great to me, merging to master if there is no further discussion! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1689 Thank you @1ambda ! I think it's a great idea to have checkstyle off the most of profiles, but add a new one with just checkstyle. After CI finishes, let's post the CI time statistics in PR description, in order to verify the hypothesis that this change actually does speed up the CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1690: [ZEPPELIN-1709] docs: Describe how to use checkstyle p...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1690 Looks great to me, thank you for taking care of both, Eclipse and IDEA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1673 Thank you @Leemoonsoo ! Merging to master, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1632 Thank you for CI failure assessment @agoodm ! How do you think, how crucial are those tests? May be just documenting on how to run them manually could be an option? Generally, we tried to avoid exploding number of CI profiles to keep the CI build time minimum, but if more profiles is not going cost substantial build time that defility could be an option. In that case any of the suggested solutions sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1673 Thank you for review @felizbear ! > it increases npm test time since it tries to install phantom every time but it reduces `npm install` time, and as soon as on CI we only do install\test once - total time should be the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 to recap - theare are two final things, that would be very nice to have in this image: - find a way to reduce base image size from ~500mb i.e by installing R without `build-base make gcc g++` - re-use `./testing/install_external_dependencies.sh` as soon as #1632 is merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 > if we want to make dockerfile to the latest version from zeppelin which haven't a binary version This better be handled under a separate JIRA issue as this one is about `[ZEPPELIN-1386] Docker images for running Apache Zeppelin releases `. It can be done later i.e by setting up CI automation that runs nightly build \w something similar to `create_release.sh`. Important thing there would be to make sure that's clearly marked as non-release, but just as a developer's artefact. So all that sounds great, and image looks good (except for fat R dependencies, but I'm not sure if we can do something about it).. How do you guys think, is there anything that's left here? Or shall we merge this, run `docker build` for old binary releases using this image? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1632 @agoodm as CI is failing - could you please rebase on latest master, it has some CI improvements and then open\close the PR to trigger a new CI here again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1673 Thanks for review @1ambda ! Not sure about version number, so kept it blank for now.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 @1ambda it looks like rebase is needed after few other `pom.xml` modifications got merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Looks great to me and CI is green now. Merging to master, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1638 Great, CI is green now! Merging to master, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1673 \cc @afsanjar @felizbaer for reivew --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1638 Awesome, ð for tests and a great commit\history structure that allows just to skip one and preserve all the work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1662: [ZEPPELIN-1695] Enforce pom.xml style while removing u...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1662 Thanks! Looks great to me, will merge to master as soon as CI is green, if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1668 Thank you for double-checking and explanations. Looks like CI is failing right now though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1441 @cloverhearts looks like CI is failing. Do you know the reason? If you try open\close the PR, can it be reproduced? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 Great job @mfelgamal ! The idea was to try to avoid building separate artefacts for Docker and use official convenience binaries from Apache release. Am I mimssing something, or what is the reason such images can not be published under https://hub.docker.com/r/apache/zeppelin automatically as a part of release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1339 Thank you @AhyoungRyu for great job and taking care in addressing the [user experience concerns](https://github.com/apache/zeppelin/pull/1339#issuecomment-259683752)! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1639: [ZEPPELIN-1667] add support for es6
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1639 CI is green now. Looks great to me, merging to master if there is no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1662: [ZEPPELIN-1695] Enforce pom.xml style while removing u...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1662 @1ambda thank you for great effort! It's a bit hard to review as re-formatting is mixed with pom.xml modifications. How hard would be to have 2 separate PRs - one with improvements, and another one, with re-formatting? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1600 @aspen01 thank you for contribution! Could you please double-check that all new files, as any other file in Apache Zeppelin, have [ASF's Apache 2.0 license header](http://www.apache.org/legal/src-headers.html)? As for copyright notices, could you please help to understand if your contribution contains any [third-party works](http://www.apache.org/legal/src-headers.html#3party) or is that all code, [developed for the ASF](http://www.apache.org/legal/src-headers.html#headers)? That would determine, if the existing copyright notice from the files should be moved to root NOTICE file or not. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
