Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/3084
@Tagar thanks for suggestion, but I think it's better not to include this
check for tornado in this function since it's not really pre-requisite check.
if we add it, then we need to keep
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/3073
@jongyoul thanks, will close then
---
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/3073
---
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/3084
[zeppelin-3639] Add Ipython interpreter prerequisite check for protobuf
### What is this PR for?
This is to protobuf prerequisite check when starting ipython kernel. This
is required
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/3073
@zjffdu just enabled them. similar profiles as in master with unrelated
errors failing here as well, will restart them
---
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/3071
i've just restarted failing profiles 4, 6, 7 and here's results for them:
4 is failing with
```
Results :
Failed tests:
PersonalizeActionsIT.testSimpleAction:168
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/3073
[zeppelin-3625] [branch-0.8] Pandasql interpreter fails to query over
python dataframe
### What is this PR for?
fix pandasql query over dataframe for `branch-0.8`. the reason
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/3071
yeah i was wondering as well, and actually they were failing and capturing
it. just checked and seems they're disabled
https://github.com/apache/zeppelin/blob
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/3071
[zeppelin-3625] Pandasql interpreter fails to query over python interpreter
dataframe
### What is this PR for?
fix pandasql query over dataframe for `master`. the reason
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/3046
Minor fix "ipykernel" package name shown in logs when ipython prerequisite
isn't met
### What is this PR for?
minor fix to show correct package name `ipykernel` in
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2658
thanks for contribution. I think need to configure travis with your account
for builds
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
, otherwise
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
thanks for the ping, i'll check the state and update the branch by end of
the week
---
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2621
LGTM
---
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2523
[ZEPPELIN-2764] update packages and documentation for ZeppelinHubRepo
storage
### What is this PR for?
update the packages/documentation/links due to migration of domain and
renaming
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2499
thanks for checking, added verification step as well and tested with most
of notes in https://github.com/jakevdp/PythonDataScienceHandbook. will be
merging if no more discussion
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin
note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin
note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2499
/cc @jongyoul to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2499
[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin
note converter
### What is this PR for?
Fixes the issue of having doubled new lines between lines when
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@felixcheung actually that means to persist in default way, since Zeppelin
persists on most of user activities so it seems to be "continuously". another
way would be to call it &
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@1ambda actually it would rename on first save, it can be run, edit
paragraph, or rename. Regarding renaming for all notes in the beginning it was
discussed actually above and I think we
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@1ambda
1. separate tab with `Global Settings` contains the settings which are
applied to all storages, so that we don't duplicate in each storage setting.
2. note persisted when
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@zjffdu @1ambda addressed the feedback to convert in save, w/o additional
interface. probably will need to separate base class with each storage after
this pr to handle more logic
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2439
thanks for the improvement, this scenario needs to be fixed indeed. after
trying the pr, i noticed couple of things
* when following scenario and going into note as user2, my browser
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@zjffdu yeah, the renaming would be done probably on saving which would
apply if user enters note, and does some action so that save->conversion
(rename) is initiated. This would w
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@Leemoonsoo @1ambda @zjffdu I wanted to have opinion on the note conversion
strategy. lazy strategy - converting when note is renamed, vs aggressive -
converting all notes when starting
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on run and commit
### What is this PR for?
adding settings to storage layer to let user choose to persist continuously
or only
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@1ambda @zjffdu addressed the feedback and added persist on `run` as well.
Also moved the logic out of storage classes. Please help further review and
test this one to move
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@1ambda on 1. yes, we would need to implement renaming for other repos and
i was planning to do it for S3, Azure right after this PR. As an alternative to
adding this method to interface
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@1ambda good point, we can make both possible. i'll modify it to support
both config then through dropdown
---
If your project is set up for it, you can reply to this email and have your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
rebased from master, /cc @1ambda @Leemoonsoo please help review and test as
well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2448
[ZEPPELIN-2702] save notes in reader-friendly format with zpln extension
for VFS and Git repo
### What is this PR for?
first task in converting note files into human readable
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2448
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2448
@zjffdu addressed the feedback on adding new `rename` method and having
only one fileInfo, please help review
---
If your project is set up for it, you can reply to this email and have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
this is ready for more review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on commit
### What is this PR for?
adding settings to storage layer to let user choose to persist continuously
or only on commits
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@zjffdu the persistence policy is saving on run and almost on any note
action. originally i introduced this feature globally on base class, however
after some discussion above, introducing
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2448
[ZEPPELIN-2702] save notes in reader-friendly format with zpln extension
for VFS and Git repo
### What is this PR for?
first task in converting note files into human readable
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on commit
### What is this PR for?
adding settings to storage layer to let user choose to persist continuously
or only on commits
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Merging into master if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2371
@1ambda thanks, will merge into master then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2371
@1ambda could you plz resolved conflicts here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2371
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2391
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
yes that's true, i'll look into saving when stopping zeppelin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
@1ambda thanks for testing. yes that's the purpose of `save & commit`, the
changes are applied in memory only unless it's explicitly saved and commit
(persisted into file)
---
If
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2391
@1ambda thanks for contribution, tested and looks much better! When
searching for note and clicking on it (e.g. redirect to /#/notebook/2CBFCSS6X)
i can see below stacktrace in console
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2374
this is ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2383
will be merging into master if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on commit
### What is this PR for?
adding settings to storage layer to let user choose to persist continuously
or only on commits
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2354
@sohaibiftikhar i guess we can rebase it from master now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2373
i've just tried to login using the config info from online demo for
oidc-client in https://demo.c2id.com/oidc-client using modified config below
```
oidcConfig
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2354
Hi @FRosner, I think best way would be to help review and test #932 first.
i was going to do it as well, but didn't get much time recently. thanks for
help, and i'll check it this week too
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on commit
### What is this PR for?
adding settings to storage layer to let user choose to persist continuously
or only on commits
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2354
thanks for clarification, then i may look into #932 as well, and after
finalising that we can rebase this one
---
If your project is set up for it, you can reply to this email and have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2354
@sohaibiftikhar thanks for adding option for authentication with role
check, I was wondering if these changes are related to the issue in #932, from
first look seems a bit unrelated and i
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2321
[ZEPPELIN-2498] add more info and config for Ldap authentication
### What is this PR for?
This is to add some necessary configs for ldap authentication.
### What type
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2288
I think this and #2289 are required in `branch-0.7` as well, isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2321
[ZEPPELIN-2498] add more info and config for Ldap authentication
### What is this PR for?
This is to add some necessary configs for ldap authentication.
### What type
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2306
[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu
### What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2306
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2306
@1ambda yeah that's better idea, I just pushed the changes and updated image
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2306
[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu
### What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2289
i'm getting below error in web part during build here as well
```
[INFO]
/Users../zeppelin/zeppelin-myrepo/incubator-zeppelin/zeppelin-web/src/app/notebook/paragraph
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@soralee it's disappearance is based on multi-user logic and it's correct
since if note have `owners`, `readers`, `writers` as `user1` it doesn't have
anything to do in `admin`'s list
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@soralee yeah the steps are correct. so if you follow those steps and click
`Save`, say for `Note A`, then `Note A` will disappear from the list of your
notes, and then you will not have
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2274
very nice! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2278
Thanks for looking into this, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2247
will be merging into `branch-0.7` if no comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2247
@felixcheung please help to quickly go over this, since already the
original PR for master was reviewed in #2198 and this is mostly cherry-picked
and resolved conflict in pom.xml
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2247
[ZEPPELIN-2318][branch-0.7] Fix proxy configuration for http client of
zeppelinhub storage layer
### What is this PR for?
this is to resolve this issue for `branch-0.7` since original
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2198
merge into master and branch-0.7 if no further comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2243
Closing for now since can be solved by changing security policy without
changing headers
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
CI is green. i linked some of related issue in
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
---
If your project is set up for it, you can reply to this email
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is
created
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
@Leemoonsoo i found some js tests failing in second profile, let me take a
look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
@Leemoonsoo actually I couldn't reproduce ZEPPELIN-1145, but we can reopen
it to make sure. maybe also /cc @r-kamath as original author
---
If your project is set up for it, you can reply
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is
created
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
second profile keeps failing
[here](https://travis-ci.org/khalidhuseynov/zeppelin/jobs/217983115). as i
tried locally, getting following error
```
[ERROR] Failed to execute goal
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2198
@felixcheung right `warning` level makes more sense in those cases,
addressed in 8ea7d5d9652fa00d00cb6d749f0e1e718beb8c95
---
If your project is set up for it, you can reply to this email
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2198
[ZEPPELIN-2318] Fix proxy configuration for http client of zeppelinhub
storage layer
### What is this PR for?
it fixes proxy configuration for http client of zeppelinhub storage layer
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2187
/cc @anthonycorbacho @cloverhearts @Leemoonsoo plz help review this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2187
[ZEPPELIN-2314] Fix watcher websocket origin header
### What is this PR for?
this is to add `Origin` header to ws client, and fix ws connection error
after merging ZEPPELIN-2288
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2161
@anthonycorbacho thanks for the feedback, addressed them above. Let me know
if there's something else and if it works fine for you.
Also would be nice if other members could
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2161
/cc @anthonycorbacho @Leemoonsoo @AhyoungRyu plz help to review and test
this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2161
yes, i think my fork was integrated with travis since i have the build here
https://travis-ci.org/khalidhuseynov/incubator-zeppelin/builds/212981024 . also
the branch was rebased today
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2161
[ZEPPELIN-1697] Fix multiuser ws connection for secondary ZeppelinHubRepo
storage
### What is this PR for?
This is to fix problem with ws connection that was introduced in 0.7.0
1 - 100 of 371 matches
Mail list logo
