[GitHub] zeppelin issue #1556: [MINOR] remove comments in NotebookRestApi.java
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1556 @minahlee @jongyoul Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1556: [MINOR] remove comments in NotebookRestApi.java
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1556 [MINOR] remove comments in NotebookRestApi.java ### What is this PR for? Since ZEPPELIN-1162 (PR #1341) has been solved, we should remove TODO comments correspondingly. ### What type of PR is it? Minor ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/vectorijk/zeppelin minor-remove-comments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1556 commit 1e8ce8acf236a6d8bc30cfc83f7bd184b8ae65f7 Author: Kai Jiang <jiang...@gmail.com> Date: 2016-10-24T03:23:01Z remove TODO comments since 1162 has been solved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @Leemoonsoo @bzz Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1550: [ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpre...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1550 @jongyoul Thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1550: [ZEPPELIN-912] Apply new mechanism to GeodeOqlI...
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1550 [ZEPPELIN-912] Apply new mechanism to GeodeOqlInterpreter ### What is this PR for? This PR applies the new interpreter registration mechanism to Geode Oql interpreter. ### What type of PR is it? Improvement ### Todos Added `interpreter-setting.json` ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-912 ### How should this be tested? Test locally. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/vectorijk/zeppelin zeppelin-912 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1550.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1550 commit 5dfad61a788af3d386c83f1516768edf0534dd93 Author: Kai Jiang <jiang...@gmail.com> Date: 2016-10-22T13:13:11Z Apply new mechanism to GeodeOqlInterpreter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 cc @Leemoonsoo @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @bzz I have updated and added unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 @bzz Thanks for the quick response! I will write and update some tests for this to make sure the changes doesn't break things before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1530: [Zeppelin-1555] Eliminate prefix in PythonInterpreter ...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1530 cc @zjffdu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1530: [Zeppelin-1555] Eliminate prefix in PythonInter...
GitHub user vectorijk opened a pull request: https://github.com/apache/zeppelin/pull/1530 [Zeppelin-1555] Eliminate prefix in PythonInterpreter exception ### What is this PR for? Solve bug metioned [here](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L139) Since we launch python interpreter as a process and redirect stdin and stdout, only exception occurred (like syntax error or indentation error, etc) could give string like `...`. Thus, we don't need to determine whether syntax error happened in [`PythonProcess.sendAndGetResult`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonProcess.java#L86) because we have detected error in [`PythonInterpreter.pythonErrorIn`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L152) ### What type of PR is it? Bug Fix ### What is the Jira issue? Jira: https://issues.apache.org/jira/browse/ZEPPELIN-1555 ### How should this be tested? Test locally. ### Screenshots https://cloud.githubusercontent.com/assets/3419881/19422552/192a8b3a-93cb-11e6-89e8-63f2652a7f85.png;> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/vectorijk/zeppelin zeppelin-1555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1530 commit d7a2ef4003c717141003aa94f7c28a529a1db390 Author: Kai Jiang <jiang...@gmail.com> Date: 2016-10-17T00:54:11Z [zeppelin-1555] Eliminate prefix in PythonInterpreter exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1496 @jongyoul Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...
Github user vectorijk commented on the issue: https://github.com/apache/zeppelin/pull/1496 @anthonycorbacho Thanks for your quick response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
