[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user volumeint commented on the issue: https://github.com/apache/zeppelin/pull/1210 Just closing the loop. Pull Request #2313 contained the webpack.config.js change. It has been merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1210 @volumeint cool! Do you mind make a pullrequest with modification `test: /\.png(\?\S*)?$/, loader: 'url-loader'` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user volumeint commented on the issue:
https://github.com/apache/zeppelin/pull/1210
I just published a helium visualization that uses Leaflet. You can find it
at (https://github.com/volumeint/helium-volume-leaflet). To get it working, I
first had to patch
[webpack.config.js](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/resources/helium/webpack.config.js)
in zengine 0.8.0-SNAPSHOT to add a test for png files. Leaflet has two png
files referenced in their CSS.
test: /\.svg(\?\S*)?$/, loader: 'url-loader', }, {
test: /\.png(\?\S*)?$/, loader: 'url-loader', }, { <-- add
this line
test: /\.json$/, loader: 'json-loader' }, ],
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1210 Visualizations have incompatible license can be packaged as a [Helium application](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/helium/Application.java) and loaded dynamically. Soon, there will be [highlevel api](https://issues.apache.org/jira/browse/ZEPPELIN-1003) to make visualization easier based on helium. In the future, we'll have online registry for applications. So, please consider [use helium framework](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1210 Dear @mwpenny and Zeppelin PMC. I have reviewed the license of ArcGIS Online https://developers.arcgis.com/terms/ and and http://www.esri.com/legal/software-license. Although it's client javascript library is Apache 2, client does not functioning without ArcGIS online service, so the ArcGIS Online license does matter. However, the license does not look like type of license we can use. For example > Generally, if you are not planning to monetize your app, say by charging a fee or by embedding revenue generating advertising in your app, you can make your app available to just about anyone. and > If you want to charge for access to apps you build using ArcGIS Online you have to have a paid subscription. Apache 2 License allow monetize Apache Zeppelin. However ArcGIS Online license has incompatible restriction. Also the client is loading arbitrary code (javascript) dynamically from their server on runtime and we can not guarantee what kind of code will be executed on our user's machine. see https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L1392 Therefore, unfortunately, we might need to remove this changes from our source tree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user tabraiz12 commented on the issue:
https://github.com/apache/zeppelin/pull/1210
adding the following css fixed the issue for safari and chrome
```
.esri-bitmap {
max-width: none;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug When I test it without the CSS, the tiles still load but they're not positioned properly (they extend outside of the paragraph). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @karup1990 This is very strange. I cannot reproduce the issue using the same browser version and your network doesn't seem to be the problem since it is working for you in Safari. The only other thing I can think of is a browser setting or extension interfering somehow. Try running Chrome with the `--disable-extensions` argument. If that doesn't work, try creating a new Chrome user profile and using that temporarily. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @karup1990 Can you send a screenshot of the map? If you look at the network requests in your browser's developer tools, are the requests to the ArcGIS servers successful (i.e., retrieval of the map JavaScript and CSS)? Here's a screenshot of what happens when I load the map (I'm using Firefox):  Also check to make sure the map tile requests are succeeding. Screenshot from my browser:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user karup1990 commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny Thanks for the awesome work. I was trying out the visualizations. I can see only the pins, the maps seems to not load. Any idea what could be wrong? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny CSS loading late I guess, but there is also a possibility that the resource is not available for whatever reason. It is not critical for now, but since there is a risk of map not showing for some users without any error message (creating more traffic in the mailing list), it would be nice to try to address it in a different PR maybe. Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug The CSS and JavaScript come from the same server. The CSS is timing out for you but not the JS? Or is the CSS just loading late? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny With the way we include the css, there is still a risk of not being able to get the css, but having the JS file just fine. Which end up in the map not showing, and no error message like the one we added in case there is no internet connection. I actually got that a few times with slow internet. Except for that, LGTM, awesome work! if anybody wants to try it, I use the test case of #765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug I'm all to familiar with that magic when trying to reproduce bugs ;) I've made the changes. * __Small popup:__ The side and bottom margins of the popup are present due to yesterday's changes (differentiating the white of the popup from the white of the paragraph) and the extra-large top margin is from Esri's CSS. After decreasing the top margin the popup is still very cluttered but a bit more usable.  Even with some extra CSS styling, I just don't think there's enough space to display the popup nicely in a paragraph that small. Other graph modes have a similar problem which users are likely already accustomed to:  * __Internet error message:__ I went with a look similar to the other graph modes:  * __Lazy loading:__ Similar to the way esriLoader loads the map JavaScript, the CSS is now lazy loaded the first time it is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny latest changes I promise haha If you resize the paragraph to the smallest height allowed, the popup is crushed and unusable, however there is plenty of space on top and bottom of the popup, maybe we could try to reduce it. We can't support every width and height, but lets see if we can do something for that case  If you don't have internet, it would be nice to show a small error message instead of the map  Also without internet, the app takes a good 20-30seconds to load/show (even home page). It is due to the page try to load the esri CSS from online. I think this [plugin](https://github.com/GabrielDelepine/angular-css-injector) could help with that problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug Good to hear! The padding makes bottom-docked popups look a lot more clean.  Good catch on the hidden popup header (before/after).  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny I tested it again, its so much better now. You will need to rebase your branch (conflicts, always conflicts) We could probably improve the marker's popup by adding a bit of padding so that its not too white? https://cloud.githubusercontent.com/assets/710411/17542670/df5ddb9a-5f05-11e6-863b-4e2b61e770d1.png;> Also depending on the paragraph height and the number of infos to show, it seems the popup header is hidden https://cloud.githubusercontent.com/assets/710411/17542786/c2a9d002-5f06-11e6-83ef-7c5734202125.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 I have made the changes/fixes you mentioned and rebased with master. I can create the PR for the documentation after this is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny Sorry for the delay, I got a bit busy. I will take a look this week-end. What you can do until then is to rebase with master since there is some conflicts right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 I've added basemap selection (see screenshot)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user ErikApption commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug This is a great feature! ESRI is by far the most complete mapping component and the base maps are totally free (unlike gg or bing), plus their API is open source. What would be the next step to get this PR accepted? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user mwpenny commented on the issue: https://github.com/apache/zeppelin/pull/1210 @corneadoug, The Esri angular module is used to download and lazy load the JS API and require its various classes. These classes are then used to display the dynamically downloaded map tiles and render the different map layers (i.e., basemap + pin layer). The angular module was developed by Esri and released under the Apache 2.0 license. They state on their website that ["The JavaScript API [downloaded by the angular module] is hosted by Esri and is available for free use"](https://developers.arcgis.com/javascript/3/jshelp/intro_accessapi.html). Esri also has a public Apache 2.0-licensed repo of samples ([Esri/quickstart-map-js](https://github.com/Esri/quickstart-map-js)) which use the API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1210 @mwpenny Thanks for the PR There was already some attempts to include Leaflet before, however I think it is not yet to be finished. (No pivot to choose columns at least) I think the community should be able to decide which map they prefer. However, in term of license, I'm still not sure if this could be included or not. Can you provide more infos on how the Javascript API is needed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
