[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user darionyaphet commented on the issue: https://github.com/apache/zeppelin/pull/1497 Add a Screenshot  --- If your project is se

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user HeartSaVioR commented on the issue: https://github.com/apache/zeppelin/pull/1497 Follow this: 1. create a new branch which is based on current master 2. cherry-pick your commits (write down your last commit id) 3. change branch to PR's branch 4. git reset --h

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user darionyaphet commented on the issue: https://github.com/apache/zeppelin/pull/1497 Aha. A lot of files conflict and I can't resolve that . Maybe I will close this one and reopen another . --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @HeartSaVioR yeah i would love to have a class that manipulate redis cmd and handle null, ussually i am not a huge fan of returning `null`, i would prefer to return an `EMPTY` type instead

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user darionyaphet commented on the issue: https://github.com/apache/zeppelin/pull/1497 Hi @anthonycorbacho @HeartSaVioR I have update `RedisInterpreter` with some redis commands (include APPEND ,BITCOUNT ,BITFIELD ,BITOP, BITPOS, DECR) . Please help review this one

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @HeartSaVioR thank you for pointing that out, you are right we better handle the potential `JedisException` exception to avoid leak. --- If your project is set up for it, you can reply t

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user HeartSaVioR commented on the issue: https://github.com/apache/zeppelin/pull/1497 Every command methods have a chance to leak Jedis instance when command is failing and throwing a kind of JedisException. You need to replace your borrow-call-return pattern with `try-with

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user kavinkumarks commented on the issue: https://github.com/apache/zeppelin/pull/1497 I too checked the changes and they look good.The comment from @anthonycorbacho about usage of "Strategy pattern" for selecting the relevant redis command instance and executing them is the be

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user darionyaphet commented on the issue: https://github.com/apache/zeppelin/pull/1497 Hi @anthonycorbacho thank you for you great help and I'm still working on it . I have implement a lot of command include `GEO` ,`HASH`, `HYPERLOGLOG`, `LIST`, `KEYS`, `Sets` ,`SORT

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @darionyaphet do you need some help for the change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1497 Hi - thank you for your contribution. Could you see the list of steps here: https://zeppelin.apache.org/docs/0.6.1/development/writingzeppelininterpreter.html#contributing-a-new-interpreter