Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
Thanks for review @prabhjyotsingh @hayssams , will merge it if no more
comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hayssams commented on the issue:
https://github.com/apache/zeppelin/pull/2455
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2455
Tested on local, works as expected, have tried on both environments, with
and without Kerberos.
LGTM, except a minor comment.
---
If your project is set up for it, you can reply to
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
I also verified the kerberized hdfs manually in my local box. @jongyoul
@Leemoonsoo @felixcheung @prabhjyotsingh @hayssams Please help review it, Thanks
---
If your project is set up for it, you
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
Also add HADOOP_CONF_DIR in zeppelin.sh, but it looks like there's some
code duplication between `zeppelin.sh` and `zeppelin-daemon.sh`, we need a
followup PR to remove these duplication.
---
Github user hayssams commented on the issue:
https://github.com/apache/zeppelin/pull/2455
@zjffdu Yes when you want to start zeppelin not as a daemon.
Please also note the docker image rely on zeppelin.sh
---
If your project is set up for it, you can reply to this email and
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
@hayssams Any reason why `zeppelin-daemon.sh` doesn't fit for you ? Because
zeppelin does not guarantee `zeppelin.sh` can launch zeppelin server properly.
`zeppelin-daemon.sh` not only add
Github user hayssams commented on the issue:
https://github.com/apache/zeppelin/pull/2455
Yes but sometimes we need to launch zeppelin through zeppelin.sh equally in
Mesos by Marathon
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
Thanks for review. @hayssams I did that in zeppelin-daemon.sh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hayssams commented on the issue:
https://github.com/apache/zeppelin/pull/2455
@zjffdu I think that the zeppelin.sh file should be updated with the
HADOOP_CONF_DIR in the classpath
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2455
@jongyoul Yeah, since your PR is also using the hadoop jar. I think we need
to do 2 things:
* Use the same hadoop jar version
* Decide whether include it in distribution or not. For this, I
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2455
@zjffdu Almost conflicts will be removed by extracting jars but how we
guarantee those libraries are not related my features? I'm just curious.
---
If your project is set up for it, you can
12 matches
Mail list logo
