Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2903
merged this to master & 0.8
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2903
I think so, @zjffdu what do you think about this in 0.8?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Hi @felixcheung is it possible to release this into 0.8.0?
Thanks
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2903
looks good!
merging if no more comment
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Hi @felixcheung please let me know if any additional changes or adjustments
are needed.
The two failing tests are unrelated to the code in in this PR
Thanks.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Closing and reopening to trigger tests.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
ping @felixcheung
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Oops! I must have messed up somewhere!
I've corrected the style issues now @felixcheung, and the one remaining
failure appears to be a build script problem unrelated to my code.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2903
still have errors on this link
https://travis-ci.org/sanjaydasgupta/zeppelin/builds/363808230?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Hi @felixcheung, can these changes be merged now?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
Apologies for missing the check style errors @felixcheung
The style issues in _JDBCInterpreterInterpolationTest.java_ have been
removed, and all the tests now pass. The other failu
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
@felixcheung I've fixed the 4 issues in the documentation file jdbc.md,
thanks for the very careful review.
I have also added a unit test
[JDBCInterpreterInterpolationTest.java](ht
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2903
@felixcheung Please note [my
response](https://github.com/apache/zeppelin/pull/2903#discussion_r178733031)
to your earlier question about the unrelated documentation change.
Pleas
13 matches
Mail list logo